Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64523/#review193590 --- @ReviewBot retry - Stephan Erb On Dec. 12, 2017, 3:29 a.m

Re: Review Request 64523: Attempt #2 to fix flaky Webhook test

()` to say > why it differs, but it does pass consistently for me. Jordan, will you update your PR? Or do you plan to file one, Bill? - Stephan ------- This is an automatically generated e-mail. To reply, visit: https://review

Re: Review Request 64534: Reproduce Kerberos Python Build Issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64534/#review193530 --- @ReviewBot retry - Stephan Erb On Dec. 12, 2017, 12:38 p.m

Re: Review Request 64508: Convert carriage returns to newlines in reviews

for being sloppy here. I have pushed https://github.com/apache/aurora/commit/301f066369a9ef7262c1702c77004d12bc8eac00 unbreak the build. - Stephan Erb On Dec. 12, 2017, 10:05 a.m., Stephan Erb wrote: > > --- > This is an auto

Re: Review Request 64534: Reproduce Kerberos Python Build Issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64534/#review193527 --- @ReviewBot retry - Stephan Erb On Dec. 12, 2017, 12:38 p.m

Review Request 64534: Reproduce Kerberos Python Build Issues

0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/thermos/core/test_process.py 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 Diff: https://reviews.apache.org/r/64534/diff/1/ Testing --- Thanks, Stephan Erb

Re: Review Request 64508: Convert carriage returns to newlines in reviews

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64508/#review193522 --- @ReviewBot retry - Stephan Erb On Dec. 12, 2017, 10:05 a.m

Re: Review Request 64508: Convert carriage returns to newlines in reviews

quot;\r" "\n" | tee build_outpu Thanks, Stephan Erb

Re: Review Request 64508: Convert carriage returns to newlines in reviews

t: https://reviews.apache.org/r/64508/#review193477 ----------- On Dec. 12, 2017, 10:05 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e

Re: Review Request 64508: Convert carriage returns to newlines in reviews

. - Stephan Erb On Dec. 11, 2017, 9:47 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 64508: Convert carriage returns to newlines in reviews

://reviews.apache.org/r/64508/diff/1/ Testing --- ./gradlew --console=plain -Pq build 2>&1 | tr -u "\r" "\n" | tee build_outpu Thanks, Stephan Erb

Re: Review Request 64341: Add metadata field to Job object in DSL

address the flaky build. - Stephan Erb On Dec. 11, 2017, 12:13 p.m., Jing Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 64290: Update to Thrift 0.10.0

address the flaky build. - Stephan Erb On Dec. 9, 2017, 5:32 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 64482: Fix flaky WebhookTest

``` org.apache.aurora.scheduler.events.WebhookTest > testTaskChangedWithOldStateError FAILED java.lang.AssertionError at WebhookTest.java:193 I1210 11:12:13.954 [ShutdownHook, SchedulerMain] Stopping scheduler services. ``` - Stephan Erb On Dec. 10, 2017, 1:08 a.m., Stephan Erb wr

Re: Review Request 64290: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193348 --- @ReviewBot retry - Stephan Erb On Dec. 9, 2017, 5:32 p.m

Re: Review Request 64482: Fix flaky WebhookTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64482/#review193337 --- @ReviewBot retry - Stephan Erb On Dec. 9, 2017, 11:13 p.m

Review Request 64482: Fix flaky WebhookTest

/WebhookTest.java adeff8939a4c4a225444dc5ca2575f9eb705a92b Diff: https://reviews.apache.org/r/64482/diff/1/ Testing --- Multiple runs of ./gradlew test Thanks, Stephan Erb

Re: Review Request 64290: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193334 --- - Stephan Erb On Dec. 9, 2017, 5:32 p.m., John Sirois wrote

Re: Review Request 63750: pants for high-sierra

bit more complicated than anticipated, but John managed to resolve the problems in https://reviews.apache.org/r/64290/. I am therefore closing this patch. - Stephan Erb On Nov. 15, 2017, 12:51 a.m., se choi wrote: > > --- > T

Re: Review Request 64290: Update to Thrift 0.10.0

cleanly after the merge of https://reviews.apache.org/r/64382/. The merge conflict is trivial to resolve though. I have re-run the end-to-end tests with both patches applied and all looks good. - Stephan Erb On Dec. 9, 2017, 6:16 a.m., John Sirois wrote

Re: Review Request 64426: Remove hack for guice error logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64426/#review193144 --- @ReviewBot retry - Stephan Erb On Dec. 7, 2017, 6:53 p.m

Re: Review Request 64426: Remove hack for guice error logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64426/#review193143 --- Ship it! Ship It! - Stephan Erb On Dec. 7, 2017, 6:53 p.m

Review Request 64382: Update Python deps incl requests and pex

/apache/aurora/common/BUILD 0e4c51020946dc21953493bd43b944177c444c28 Diff: https://reviews.apache.org/r/64382/diff/1/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Stephan Erb

Re: Review Request 64377: Remove H2-related end-to-end test case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64377/#review192992 --- Ship it! Ship It! - Stephan Erb On Dec. 6, 2017, 3:42 p.m

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

> > (Updated Dec. 4, 2017, 4:23 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included

Re: Review Request 64362: Update to guice 4.1.0, switch from jersey to resteasy

current.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) ``` - Stephan Erb On

Re: Review Request 64287: Clean up some lint rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64287/#review192668 --- Ship it! Ship It! - Stephan Erb On Dez. 4, 2017, 12:39 vorm

Re: Review Request 63750: pants for high-sierra

> On Nov. 15, 2017, 1:13 a.m., Aurora ReviewBot wrote: > > Master (4fecf1f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > WARN] > > /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.4.0.dev20/local/lib/python2.7/site-packa

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

> On Sept. 27, 2017, 1:53 a.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > >

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

Thanks, Stephan Erb

Re: Review Request 64284: Expose thrift workload stats on pruneTasks() invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64284/#review192645 --- Ship it! Ship It! - Stephan Erb On Dez. 3, 2017, 2:20 nachm

Re: Review Request 64283: Remove redundant transaction recorder

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64283/#review192643 --- Ship it! Ship It! - Stephan Erb On Dez. 3, 2017, 6:53 vorm

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192636 --- Ship it! Ship It! - Stephan Erb On Dez. 1, 2017, 1:32 vorm

Re: Review Request 64234: Extract a storage Persistence layer

stence` (that implements `DistributedSnapshotStore`) will actually write a snapshot to the replicated log. The comment makes this look differently. - Stephan Erb On Dec. 1, 2017, 1:32 a.m., Bill Farner wrote: > > --- > This is a

Re: Review Request 64126: Add a key-value backed StreamManager implementation

-- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64126/ > --- > > (Updated Nov. 29, 2017, 2:40 a.m.) > > > Review request for Aurora, David McLa

Re: Review Request 64190: Moved `HostOffer` to `offers` package

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64190/#review192383 --- Ship it! Ship It! - Stephan Erb On Nov. 30, 2017, 1:59 a.m

Re: Review Request 63884: Add RemoveJobUpdates log Op, slim JobUpdateStore API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63884/#review192075 --- Ship it! Ship It! - Stephan Erb On Nov. 22, 2017, 12:44 a.m

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

good to me :) RELEASE-NOTES.md Lines 57 (patched) <https://reviews.apache.org/r/60942/#comment269736> You will need to move this to 0.20.0. Also please state that you removed it. The fields have been deprecated before. - Stephan Erb On Nov. 23, 2017, 9:35 p.m., Nicolás Donatucci

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

-13 (patched) <https://reviews.apache.org/r/63536/#comment269507> Should we prevent that users submit a non-default reschedule policy if the scheduler feature toggle is disabled? (I am fine either way but just want to point it out) - Stephan Erb On Nov. 21, 2017, 7:42 p.m.,

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

> On Nov. 21, 2017, 6:54 p.m., David McLaughlin wrote: > > The outstanding feedback is: > > > > * Discussion on using a mock with capture (my preference) vs using a fake > > implementation. > > * Concern over how to handle a partition during a transient state. My > > preference is to move imm

Re: Review Request 63884: Idempotent Ops and slimmed API for JobUpdateStore

his also coalesce completely unrelated job updates of different jobs? - Stephan Erb On Nov. 16, 2017, 7:20 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 63750: pants for high-sierra

> On Nov. 13, 2017, 5:05 p.m., Bill Farner wrote: > > Stephan - FYI, i reproduce the build error: > > ``` > > Exception message: Could not satisfy all requirements for > > mesos.executor==1.4.0: > > mesos.executor==1.4.0 > > ``` > > Stephan

Re: Review Request 63750: pants for high-sierra

> On Nov. 13, 2017, 5:05 p.m., Bill Farner wrote: > > Stephan - FYI, i reproduce the build error: > > ``` > > Exception message: Could not satisfy all requirements for > > mesos.executor==1.4.0: > > mesos.executor==1.4.0 > > ``` Interesting. Does it go away after a `./pants clean-all`? -

Re: Review Request 63750: pants for high-sierra

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63750/#review190812 --- @ReviewBot retry - Stephan Erb On Nov. 13, 2017, 11:35 a.m

Re: Review Request 63746: Add a workaround for test_du_diskcollector failing on macOS

... - Stephan Erb On Nov. 12, 2017, 9:14 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63531: Update to Mesos 1.4

(against Mesos 1.4) * master (Mesos 1.2) in the new vagrant box (against Mesos 1.4) Thanks, Stephan Erb

Re: Review Request 63744: Remove LockStore

is green. - Stephan Erb On Nov. 11, 2017, 2:42 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63743: Remove the internal SQL database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63743/#review190778 --- Ship it! Ship It! - Stephan Erb On Nov. 11, 2017, 5:53 vorm

Re: Review Request 63743: Remove the internal SQL database

dependencies in build.gradle. Beyond that this looks good to me. - Stephan Erb On Nov. 11, 2017, 5:53 vorm., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 63685: RFC: Use new scheduler UI as landing page

-d3d1fc057a59__Screen_Shot_2017-11-08_at_23.18.20.png Thanks, Stephan Erb

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

wonder why the task does not end up as LOST. - Stephan Erb On Nov. 7, 2017, 8:28 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 63564: Migrate from findbugs to spotbugs

26051ac9267060606a5a4e05a1ac432c1ff4c79b config/findbugs/excludeFilter.xml 4d5b36f0c9ae9312ba6afdc6f0b4a42ab0c2dc2b src/main/java/org/apache/aurora/scheduler/offers/OfferOrderBuilder.java 2676da0a4aba3ff4afc7801dfd8f9d16918d87ff Diff: https://reviews.apache.org/r/63564/diff/1/ Testing --- Thanks, Stephan Erb

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

s an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57524/ > --- > > (Updated March 13, 2017, 5:36 p.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb

Review Request 63531: Update to Mesos 1.4

following end to end test scenarios and they worked: * this patch (Mesos 1.4) in the old vagrant box (against Mesos 1.2) * this patch (Mesos 1.4) in the new vagrant box (against Mesos 1.4) * master (Mesos 1.2) in the new vagrant box (against Mesos 1.4) Thanks, Stephan Erb

Re: Review Request 63435: Remove inaccurate "Initializing sandbox" message

revisit for an improvement. - Stephan Erb On Oct. 31, 2017, 12:43 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 63443: Terminate the executor on unhandled errors

status 130 I1031 15:59:54.692834 1956 slave.cpp:4869] Cleaning up executor 'thermos-www-data-prod-hello-0-d8d50c2f-e79b-467d-8c65-cca3cb44cf9c' of framework 7b202c2e-8796-4f27-afeb-8b76ba4b3037- at executor(1)@192.168.33.7:48931 I1031 15:59:54.692996 1956 slave.cpp:4957] Cleaning up framework 7b202c2e-8796-4f27-afeb-8b76ba4b3037- ``` Thanks, Stephan Erb

Review Request 63435: Remove inaccurate "Initializing sandbox" message

/diff/1/ Testing --- ./pants test.pytest src/test/python:: File Attachments Screen Shot 2017-10-31 at 00.16.56.png https://reviews.apache.org/media/uploaded/files/2017/10/30/685d76fe-3db2-4761-80c1-f0af83642d0e__Screen_Shot_2017-10-31_at_00.16.56.png Thanks, Stephan

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

> On Oct. 30, 2017, 7:09 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceInstance.java > > Lines 45 (patched) > > <https://reviews.apache.org/r/63418/diff/1/?file=1872715#file1872715line45> > > > > Should we

Re: Review Request 63406: Condense whitespace of navigation and breadcrumb, reduce impact of quota widget

(orthogonal) question though: Have you considered listing all tiers here, rather than 'Quota used' and 'Non-production'? At least the latter is always confusing and somewhat deprecated together with the production flag. - Stephan Erb On Oct. 30, 2017, 4:32 p.m., Da

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

We could also add comments to the enum that all other state are deprecated and not used. - Stephan Erb On Oct. 30, 2017, 5:36 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 63401: Add support for generating patch RCs from non-master branches

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63401/#review189585 --- Ship it! Ship It! - Stephan Erb On Oct. 30, 2017, 12:18 a.m

Re: Review Request 63383: Suppress multiline logging from mesos callbacks

/commit/fb64e3a9ffac224fc008298a30b6f1213edce525 Closing - Stephan Erb On Oct. 28, 2017, 1:46 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63306: Add release notes for new UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63306/#review189245 --- Ship it! Thanks :) - Stephan Erb On Oct. 25, 2017, 10:25

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

> On Sept. 27, 2017, 1:53 a.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > >

Re: Review Request 63282: Remove the old UI and serve the new UI instead

notes entry in this or one of your upcoming patches. - Stephan Erb On Oct. 25, 2017, 2:21 a.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

ll Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62869/ > --- > > (Updated Okt. 18, 2017, 8:11 nachm.) > > > Rev

Re: Review Request 62692: Move job environment validation to the scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review188982 --- Ship it! Ship It! - Stephan Erb On Oct. 23, 2017, 4:14 p.m

Re: Review Request 63217: Update to shiro 1.2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63217/#review188944 --- Ship it! Ship It! - Stephan Erb On Okt. 23, 2017, 4:36

Re: Review Request 63204: Update to guava 23.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63204/#review188912 --- Ship it! Ship It! - Stephan Erb On Oct. 22, 2017, 7:43 p.m

Re: Review Request 63130: Use LockStore only for backwards compatibility

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63130/#review188669 --- Ship it! Ship It! - Stephan Erb On Oct. 19, 2017, 1:18 a.m

Re: Review Request 63121: Remove static bans for task groups that are no longer pending

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63121/#review188665 --- Ship it! Ship It! - Stephan Erb On Oct. 19, 2017, 2:04 a.m

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

ts below, write this in form of an `if` with a `continue` statement? (I don't feel strongly about this though. It just feels a little bit weird that this is handled differently here) - Stephan Erb On Oct. 18, 2017, 1

Re: Review Request 62956: When scheduling, skip offers with no CPU and no mem

> On Oct. 13, 2017, 10:12 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 220-224 (patched) > > <https://reviews.apache.org/r/62956/diff/2/?file=1854107#file1854107line220> > > > > This won'

Re: Review Request 63121: Remove static bans for task groups that are no longer pending

memory increase within these 5 minutes? Or have you increased the offer hold time significantly? - Stephan Erb On Oct. 18, 2017, 9:40 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

latest additional patch looks good to me as well! Ship it! (once review bot agrees as well :) - Stephan Erb On Oct. 18, 2017, 8:11 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 63083: Add diff viewer to Update Page

> On Oct. 17, 2017, 11:03 p.m., Stephan Erb wrote: > > Should we consider pretty printing the executor configuration (when > > assembling the thrift struct in the client)? Hopefully this would yield > > diffs that are a bit easier to read. > > David McLaughlin

Re: Review Request 63083: Add diff viewer to Update Page

> On Oct. 17, 2017, 11:03 p.m., Stephan Erb wrote: > > Should we consider pretty printing the executor configuration (when > > assembling the thrift struct in the client)? Hopefully this would yield > > diffs that are a bit easier to read. > > David McLaughlin

Re: Review Request 63083: Add diff viewer to Update Page

> On Oct. 17, 2017, 11:03 p.m., Stephan Erb wrote: > > Should we consider pretty printing the executor configuration (when > > assembling the thrift struct in the client)? Hopefully this would yield > > diffs that are a bit easier to read. > > David McLaughlin

Re: Review Request 63083: Add diff viewer to Update Page

(when assembling the thrift struct in the client)? Hopefully this would yield diffs that are a bit easier to read. - Stephan Erb On Oct. 17, 2017, 10:11 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e

Re: Review Request 62956: Immediately reject offers lacking necessary resources

> On Oct. 17, 2017, 8:26 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 67-68 (patched) > > > > > > Since the Scheduler fails over every 24 hour

Re: Review Request 63038: Protect against null value in RoleQuota

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63038/#review188180 --- Ship it! Ship It! - Stephan Erb On Okt. 16, 2017, 7:52

Re: Review Request 62835: Use compatible Curator session and connection timeouts

ault is probably what they really want. Done - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/#review187383 -----------

Re: Review Request 62835: Use compatible Curator session and connection timeouts

--- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 62956: Immediately reject offers lacking necessary resources

mem <= mem_threshold || cpu <= cpu_threshold return no_revocable and no_non_revocable ``` Would that still work for you? (As a minor improvement of the heuristic we could use the minimal executor resources as thresholds rather than 0) - Stephan Erb On Oct. 13, 2

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

This relies on the assumption that all `UpdateEvent`s and `InstanceUpdateEvent`s are sorted chronologically. I think we should enforce this invariant in `saveJobUpdateEvent` and `saveJobInstanceUpdateEvent` to prevent surprises. - Stephan Erb On Oct. 10, 2017, 9:35

Re: Review Request 62692: Move job environment validation to the scheduler.

am ok with this, but I am calling this out so that everyone is aware: With this change a new client will be able to create arbitrary environments on old scheduler instances. - Stephan Erb On Oct. 12, 2017, 8:20 p.m., Mau

Re: Review Request 62652: Remove legacy commons ZK code

(limited) perspectice Curator is ready. - Stephan Erb On Oct. 8, 2017, 7:29 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

> On Oct. 10, 2017, 11:23 p.m., Stephan Erb wrote: > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > > Line 149 (original) > > <https://reviews.apache.org/r/62869/diff/1/?file=1851255#file1851255line149> > > > > Can we remove that already?

Re: Review Request 62692: Move job environment validation to the scheduler.

g behavior by > default? > > Bill Farner wrote: > My mistake! I believed the scheduler was already restricting this, but i > stand corrected. I support your suggestion for `".*"` as the default. > > Stephan Erb wrote: > I am not convinced we would n

Re: Review Request 62873: Stream backup file from disk

maller while providing similar performance. So, it might be worth a try for our IO bound operations. - Stephan Erb On Oct. 10, 2017, 10:35 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 62873: Stream backup file from disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62873/#review187595 --- @ReviewBot retry - Stephan Erb On Oct. 10, 2017, 10:35 p.m

Re: Review Request 62873: Stream backup file from disk

> On Oct. 10, 2017, 10:53 p.m., Jordan Ly wrote: > > Change LGTM, but is build failing due to this change or being flaky? Not enough memory on Jenkins :/ INFO: os::commit_memory(0x0007b110, 248512512, 0) failed; error='Cannot allocate memory' (errno=12) # There is insufficient

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

e if we want them everywhere. If not, we should drop them. - Stephan Erb On Oct. 10, 2017, 9:35 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 62857: Fix broken end-to-end tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62857/#review187542 --- Ship it! Ship It! - Stephan Erb On Oct. 10, 2017, 8:21 a.m

Re: Review Request 62857: Fix broken end-to-end tests

> On Oct. 10, 2017, 4:59 p.m., Stephan Erb wrote: > > I have been running the end-to-end tests from time to time and have not > > seen this problem, yet. > > > > Code wide, I also don't think this should be necessary. We are defaulting > > to json if

Re: Review Request 62857: Fix broken end-to-end tests

08 [2] https://github.com/apache/aurora/commit/0105a15#diff-8c860297930ef9ce9d2e9885f577b2b8R115 - Stephan Erb On Oct. 10, 2017, 8:21 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 62835: Use compatible Curator session and connection timeouts

/AbstractDiscoveryModuleTest.java 0f2121ef1453b41286f9713d5ce89a26d1cb1b4f src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java a065505134c1ad30ba9f4d4cd829355b2acc9a13 Diff: https://reviews.apache.org/r/62835/diff/1/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Review Request 62832: Run Jenkins tests without the Gradle daemon

://docs.gradle.org/current/userguide/gradle_daemon.html#when_should_i_not_use_the_gradle_daemon Diffs - build-support/jenkins/build.sh e54bd2a8a45a8ff5b973d38b4a14ab0343851c16 Diff: https://reviews.apache.org/r/62832/diff/1/ Testing --- ./build-support/jenkins/build.sh Thanks, Stephan Erb

Re: Review Request 62623: Use a simpler command line argument system

flag and I am wondering if I should sit out until this one is merged :) - Stephan Erb On Sept. 30, 2017, 4:07 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 62831: Switch packaging release checksum to sha512

che.org/dev/release-distribution [2] http://www.apache.org/dev/release-distribution#sigs-and-sums ``` Diffs - build-support/release/release-candidate c5aad693b00ad8fd84c4121e51bd6adba90f4cec Diff: https://reviews.apache.org/r/62831/diff/1/ Testing --- Thanks, Stephan Erb

<    1   2   3   4   5   6   7   8   9   10   >