Re: Review Request 58609: Switch Thermos runner to simple disk log layout

e.org/r/58609/#review172657 --- On April 21, 2017, 11:35 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 58605: Default watch_secs to 0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/#review172658 --- @ReviewBot retry - Stephan Erb On April 21, 2017, 9:58 a.m

Re: Review Request 58605: Default watch_secs to 0.

mail. To reply, visit: https://reviews.apache.org/r/58605/#review172642 --- On April 21, 2017, 9:58 a.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automaticall

Re: Review Request 58611: Bump initial_task_kill_retry_interval to 15s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58611/#review172641 --- @ReviewBot retry - Stephan Erb On April 21, 2017, 12:36 p.m

Review Request 58612: Improve cleanup hints in release and release-candidate scripts

next release. Thanks, Stephan Erb

Review Request 58611: Bump initial_task_kill_retry_interval to 15s.

https://reviews.apache.org/r/58611/diff/1/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 58605: Default watch_secs to 0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/#review172620 --- Please mention this in the changelog. - Stephan Erb On April

Review Request 58609: Switch Thermos runner to simple disk log layout

-f964b97b7b40__before.png Thanks, Stephan Erb

Re: Review Request 58524: Allow task to be in STARTING state during watch_secs.

> On April 19, 2017, 6:32 p.m., Stephan Erb wrote: > > I am not sure I understand your description. If you want faster updates, > > why don't you just reduce `watch_secs`? > > > > I understand `watch_secs` as the the time that we always wait _after_ we > &

Re: Review Request 58524: Allow task to be in STARTING state during watch_secs.

n automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58524/ > --- > > (Updated April 19, 2017, 6:18 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > &g

Re: Review Request 58524: Allow task to be in STARTING state during watch_secs.

must remain in ```RUNNING``` state before considered a success (Default: 45)`. (I haven't looked into the code yet, but maybe you can clarify before I do). - Stephan Erb On April 19, 2017, 6:18 p.m., Santhosh Kumar Shanmu

Re: Review Request 58259: Add update affinity to Scheduler

> On April 17, 2017, 10:27 p.m., Stephan Erb wrote: > > The code change looks decent to me. > > > > However, I am unsure about two things: > > > > * For us it is common to have jobs with #instance in the ballpark of > > #agents. The proposed code

Re: Review Request 58462: Fix bug. Do not increase current_consecutive_successes if .healthchecksnooze present

> On April 14, 2017, 11:26 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/aurora/executor/common/health_checker.py > > Lines 163-166 (patched) > > > > > > This will cause a task to get stuck in `ST

Re: Review Request 58366: Allow resource monitors to be disabled.

. If this is not the case, I would love if we just drop the accounting within Thermos completely. We also have https://issues.apache.org/jira/browse/AURORA-1033 to track this. - Stephan Erb On April 12, 2017, 10:08 p.m., David Robinson wrote

Re: Review Request 57433: AURORA-1895 Expose stats on ZooKeeperClient connection state

implementation? Is the curator implementation good enough so that this ticket can be discarded and the legacy ZK implementation be dropped? - Stephan Erb On March 8, 2017, 10:55 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an auto

Re: Review Request 37855: Rename slave to agent in scheduler src/main/java.

the renaming. Closing. - Stephan Erb On Aug. 27, 2015, 11:12 p.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 38210: [aurora-packaging] Adds Monit supervisor support for EL6

on systemd and thus would not require monit. Please feel free to re-open if you disagree. - Stephan Erb On Sept. 9, 2015, 8:56 a.m., Steve Salevan wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 32114: Fix building on Windows

around any longer. Please feel free to re-open and re-base if you see the need :-) - Stephan Erb On March 16, 2015, 6:25 p.m., Matias Lahti wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 56935: Fix for unnecessary object serializations

:-) - Stephan Erb On Feb. 22, 2017, 8:34 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 58259: Add update affinity to Scheduler

heduler/updater/UpdaterModule.java Lines 52-55 (patched) <https://reviews.apache.org/r/58259/#comment245215> I am trying to understand if this is a good default for this best-effort feature. What is your cluster-wide MTTA? It should give us a decent hint for a suitable default.

Re: Review Request 52669: Move the H2 database off heap.

only offered marginal improvements. I suppse I can therefore discard this patch? - Stephan Erb On Oct. 11, 2016, 8:17 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://review

Review Request 58467: Update to Mesos 1.2.0

548cf37e097c6ed56fc6cc718a642b105afb9331 build.gradle bca669881e95e1415f5848f298dc4bab4fb65ba0 Diff: https://reviews.apache.org/r/58467/diff/1/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ./gradlew -Pq build ./pants test.pytest src/{main,test}/python:: -- -v Thanks, Stephan Erb

Re: Review Request 58066: Fix schema to allow multiple task volumes per task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58066/#review171202 --- Ship it! Ship It! - Stephan Erb On April 6, 2017, 3:29 p.m

Re: Review Request 58167: Fix Thermos Health Check for MesosContainerizer with `--nosetuid-health-checks`

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58167/#review171105 --- Ship it! Ship It! - Stephan Erb On April 4, 2017, 9:11 p.m

Re: Review Request 58167: Fix Thermos Health Check for MesosContainerizer with `--nosetuid-health-checks`

t243803> The way the health checker is currently called there can be no reasonable case where the command is ever None (this used to be different IIRC). You could therefore drop the `if other is not None` guard here. - Stephan Erb On April 4, 2017, 7:47 a.m.

Re: Review Request 57881: Remove use of deprecated fields in tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57881/#review170934 --- Ship it! Ship It! - Stephan Erb On March 31, 2017, 8:01 p.m

Re: Review Request 58066: Fix schema to allow multiple task volumes per task.

> On March 30, 2017, 4:49 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java > > Lines 89-93 (patched) > > <https://reviews.apache.org/r/58066/diff/1/?file=1680699#file1680699line89> > > > > It fe

Re: Review Request 58053: Reliably subscribe to Mesos in the HTTP Driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58053/#review170932 --- Ship it! Ship It! - Stephan Erb On March 31, 2017, 2:45 a.m

Re: Review Request 58053: Reliably subscribe to Mesos in the HTTP Driver.

CIND`, `INVERSE_OFFERS`, etc. - Stephan Erb On March 30, 2017, 1:52 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58053/ > -

Re: Review Request 58066: Fix schema to allow multiple task volumes per task.

checkin for `image` when deciding if we should fill the (from a datastructure perspective) unrelated field `volumes`. Would it be incorrect that we always populate the volumes? - Stephan Erb On March 30, 2017, 5:26 a.m.,

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58036/#review170578 --- Ship it! Ship It! - Stephan Erb On March 30, 2017, 1:42 a.m

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

Line 324 (original), 324 (patched) <https://reviews.apache.org/r/54957/#comment243023> Could you please elaborate why TransportException and TransientError require special retry handling, whereas a TimeoutError can always be retried? Sorry if I have missed some previous discussion. - S

Re: Review Request 57881: Remove use of deprecated fields in tests

a/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java Lines 573-576 (patched) <https://reviews.apache.org/r/57881/#comment242721> Use `ImmutableSet.of` for consistency as in the other places. - Stephan Erb On March 23, 2017,

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

> On March 11, 2017, 1:28 p.m., Stephan Erb wrote: > > I need a little bit more context to understand what is going on here: > > > > * Do you plan to use this with Thermos or an alternative executor? Or both? > > * It seems like we don't need this

Re: Review Request 57757: Make Thermos observer resource collection intervals configurable

://reviews.apache.org/r/57757/diff/3-4/ Testing --- ./pants test.pytest src/{test,main}/python:: -- -v Thanks, Stephan Erb

Re: Review Request 57757: Make Thermos observer resource collection intervals configurable

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57757/#review169462 --- On March 19, 2017, 11:50 p.m., Stephan Erb wrote: > > ---

Re: Review Request 57757: Make Thermos observer resource collection intervals configurable

--- ./pants test.pytest src/{test,main}/python:: -- -v Thanks, Stephan Erb

Re: Review Request 57757: Make Thermos observer resource collection intervals configurable

://reviews.apache.org/r/57757/diff/2/ Testing --- ./pants test.pytest src/{test,main}/python:: -- -v Thanks, Stephan Erb

Re: Review Request 57757: Make Thermos resource collection intervals configurable

/57757/diff/1-2/ Testing --- ./pants test.pytest src/{test,main}/python:: -- -v Thanks, Stephan Erb

Review Request 57757: Make Thermos resource collection intervals configurable

--- ./pants test.pytest src/{test,main}/python:: -- -v Thanks, Stephan Erb

Re: Review Request 57732: Use Process.oneshot() in latest psutils for faster stats retrieval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57732/#review169362 --- @ReviewBot retry - Stephan Erb On March 17, 2017, 5:38 p.m

Re: Review Request 57717: Support Mesos Maintenance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57717/#review169331 --- Ship it! Ship It! - Stephan Erb On March 17, 2017, 11:05

Re: Review Request 57732: Use Process.oneshot() in latest psutils for faster stats retrieval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57732/#review169326 --- @ReviewBot retry - Stephan Erb On March 17, 2017, 5:38 p.m

Review Request 57732: Use Process.oneshot() in latest psutils for faster stats retrieval.

/monitoring/process_collector_psutil.py 3000e95e2930a01f57ac855960b5db7aabbfc0ca Diff: https://reviews.apache.org/r/57732/diff/1/ Testing --- ./pants test.pytest src/{test,main}/python:: -- Thanks, Stephan Erb

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

this could break assumptions, as `serverset_endpoint_name` indicates I can put everything in there. - Stephan Erb On March 16, 2017, 11:42 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 57717: Support Mesos Maintenance

s` to gain some performance and robustness. For an example, see `test_observer_ui`. - Stephan Erb On March 17, 2017, 2:25 a.m., Zameer Manji wrote: > > --- > This is an automaticall

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56395/#review168828 --- Ship it! Ship It! - Stephan Erb On March 13, 2017, 5:46 p.m

Re: Review Request 56575: AURORA-1837 Improve task history pruning

--- On Feb. 15, 2017, 6:07 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56575/ > ----------

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

failing test (should be trivial) and add a sentance to the release notes that one needs to upgrade to Aurora 0.18 before Mesos can be udpated to 1.2. - Stephan Erb On Feb. 15, 2017, 6:40 a.m., Santhosh Kumar Shanmugham wrote

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

> > FAILURE > > > > > > 08:14:12 06:56 [complete] > >FAILURE > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" this looks like a legit test failure.

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

aurora/blob/master/docs/features/containers.md#mesos-containerizer or https://github.com/apache/aurora/blob/master/docs/features/custom-executors.md - Stephan Erb On March 11, 2017, 1:27 a.m., Zameer Manji wrote: > > --- > This

Re: Review Request 57404: Reduce log output in `VersionedSchedulerDriverService`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57404/#review168329 --- Ship it! Ship It! - Stephan Erb On März 8, 2017, 3:05 vorm

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

> On March 1, 2017, 11:50 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 179-192 (original), 196-209 (patched) > > <https://reviews.apache.org/r/56690/diff/5/?file=1652041#file1652041line198> > > >

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

and was only caring about the high-level Veto concepts. Now it has to deal with details. I don't have a better solution yet, but I will think about it. - Stephan Erb On Feb. 28, 2017, 10:25 p.m., Dmitriy Shirchenko wrote: > > -

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

> On Feb. 23, 2017, 12:31 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > > Lines 210-228 (patched) > > <https://reviews.apache.org/r/56690/diff/2/?file=1634094#file1634094line213> > > > > This reads lik

Re: Review Request 57061: Enable Mesos HTTP API.

/mesos/VersionedSchedulerDriverService.java Lines 171-178 (patched) <https://reviews.apache.org/r/57061/#comment239416> Do you have an idea where those updates without UUID are comming from? - Stephan Erb On March 1, 2017, 9:20 a.m., Zameer

Re: Review Request 57061: Enable Mesos HTTP API.

> On Feb. 28, 2017, 12:22 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, > > lines 470-471 > > <https://reviews.apache.org/r/57061/diff/4/?file=1650744#file1650744line470> > > > > Should we add

Re: Review Request 57061: Enable Mesos HTTP API.

hat inconsistent with how you format log messages. src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java (lines 91 - 94) <https://reviews.apache.org/r/57061/#comment239060> The log messages are duplicated (see V1 scheduler methods). Can we drop them in

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

ra/scheduler/tiers.json (lines 29 - 33) <https://reviews.apache.org/r/56690/#comment238373> Shoudn't reservations be always backed by quota to prevent abuse? - Stephan Erb On Feb. 15, 2017, 2:44 a.m., Dmitriy Shirchenko wrote: > > ---

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review166427 --- Ship it! LGTM. - Stephan Erb On Jan. 28, 2017, 10:15 p.m

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

My recommendation would be: * leave `getResource` in the `ThriftBackFill` class. It is scrape code that we will remove soon anyway. * Leverage the already existing `ResourceManager` methods here instead: `quantityOf(getTaskResources(config, CPUS))` - Stephan Erb On Feb. 7, 2017, 6:

Re: Review Request 56577: Add basic test scripts for RPM and DEB packages

-aurora.sh PRE-CREATION Diff: https://reviews.apache.org/r/56577/diff/ Testing --- See the distribution specific README.md. Thanks, Stephan Erb

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review165579 --- Ship it! Ship It! - Stephan Erb On Feb. 14, 2017, 3:26 a.m

Re: Review Request 56575: AURORA-1837 Improve task history pruning

ed if those 10ms are sufficient and/or needed at all? How did you came up with this number? - Stephan Erb On Feb. 13, 2017, 6:30 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 56575: AURORA-1837 Improve task history pruning

gt; > Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and > Stephan Erb. > > > Bugs: AURORA-1837 > https://issues.apache.org/jira/browse/AURORA-1837 > > > Repository: aurora > > > Description > --- > > This patch address

Re: Review Request 56575: AURORA-1837 Improve task history pruning

<https://reviews.apache.org/r/56575/#comment237157> Shouldn't all this be done on the `expiredTasks` rather than the `inactiveTasks`? Otherwise we risk deleting tasks which have not been around for the minimal retention period. - Stephan Erb On Feb. 12, 2017, 11:49 p.m., Mehrdad

Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56523/#review165280 --- Ship it! Ship It! - Stephan Erb On Feb. 10, 2017, 8:24 p.m

Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed

s a Jenkins problem. One more try... - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56523/#review165275 --- On Feb. 10, 2017, 8:

Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56523/#review165279 --- @ReviewBot retry - Stephan Erb On Feb. 10, 2017, 8:24 p.m

Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56523/#review165274 --- @ReviewBot retry - Stephan Erb On Feb. 10, 2017, 8:24 p.m

Re: Review Request 56575: AURORA-1837 Improve task history pruning

., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56575/ > --- > > (Updated Feb. 12, 20

Re: Review Request 56575: AURORA-1837 Improve task history pruning

t; (Updated Feb. 12, 2017, 12:12 a.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and > Stephan Erb. > > > Bugs: AURORA-1837 > https://issues.apache.org/jira/browse/AURORA-1837 > > > Repository: aurora &

Review Request 56577: Add basic test scripts for RPM and DEB packages

--- See the distribution specific README.md. Thanks, Stephan Erb

Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed

che.org/r/56523/#comment236947> Indentation is off - here and in some other places below. I am wondering how this came past our checkstyle rules :-) - Stephan Erb On Feb. 10, 2017, 2:12 a.m., Abhishek Jain wrote: > > --

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56395/#review164679 --- @ReviewBot retry - Stephan Erb On Feb. 7, 2017, 6:02 p.m

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review164643 --- Ship it! Ship It! - Stephan Erb On Feb. 8, 2017, 1:48 a.m

Review Request 56404: Update PMD to 5.5.3

--- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

> On Feb. 6, 2017, 10:01 p.m., Stephan Erb wrote: > > specs/debian/aurora-executor.thermos.service, lines 22-23 > > <https://reviews.apache.org/r/52437/diff/4/?file=1621617#file1621617line22> > > > > Can the corresponding init scripts be dropped? >

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

ws.apache.org/r/52437/#comment236098> Can the corresponding init scripts be dropped? specs/debian/aurora-scheduler.service <https://reviews.apache.org/r/52437/#comment236097> Same here, can the corresponding init scripts be dropped? - Stephan Erb On Feb. 1, 2017, 9

Re: Review Request 56265: Move Aurora to v1 Protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56265/#review164363 --- Ship it! Ship It! - Stephan Erb On Feb. 3, 2017, 8:38 p.m

Re: Review Request 56138: Prepare release notes for 0.17.0

--- Thanks, Stephan Erb

Review Request 56138: Prepare release notes for 0.17.0

merge this shortly before tagging the RC. Diffs - RELEASE-NOTES.md 9e6d122f10121265b74c93c80715b310d26d1cc8 docs/operations/installation.md 8599d5388be0f0e70526a12e221e5a8a186314b9 Diff: https://reviews.apache.org/r/56138/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56131/#review163717 --- @ReviewBot retry - Stephan Erb On Jan. 31, 2017, 7:41 p.m

Re: Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56131/#review163698 --- Ship it! Ship It! - Stephan Erb On Jan. 31, 2017, 7:41

Re: Review Request 54459: Add message parameter to killTasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54459/#review163678 --- What is the status of this? - Stephan Erb On Dec. 9, 2016, 8

Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/#review163504 --- @ReviewBot retry - Stephan Erb On Jan. 30, 2017, 1:55 p.m

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

> On Jan. 28, 2017, 12:37 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor.java, > > lines 65-72 > > <https://reviews.apache.org/r/55089/diff/3/?file=1616764#file1616764line65> > > > >

Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

://reviews.apache.org/r/56058/diff/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Review Request 56062: Fix flapping TestRunnerKillProcessGroup test

Diff: https://reviews.apache.org/r/56062/diff/ Testing --- ./pants test.pytest src/test/python/apache/thermos:: -- -v Thanks, Stephan Erb

Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

, Stephan Erb

Re: Review Request 56048: Preemption performance improvement and new metrics release notes entry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56048/#review163395 --- Ship it! Thanks! - Stephan Erb On Jan. 28, 2017, 12:50 a.m

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

then we could move the new counter code from the `finally` to the `try` block and eliminate the `response != null` guard. L - Stephan Erb On Jan. 26, 2017, 11:07 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automat

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

/configuration/ConfigurationManager.java (line 297) <https://reviews.apache.org/r/55982/#comment234754> This message is now outdated and can be dropped. - Stephan Erb On Jan. 26, 2017, 4:16 p.m., Nicolás Donatucci wrote: > > -

Re: Review Request 54883: Move snapshots into a separate log

t others running Aurora in production think about > putting this behind a flag. This feels like a big change to force on people > and I think if this came from someone outside of our org we'd like the > flexibility to enable this on our own timeframe rather than being blocked >

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163335 --- @ReviewBot retry - Stephan Erb On Jan. 26, 2017, 4:16 p.m

Re: Review Request 54754: Fixed starting cron jobs when using default_docker_parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54754/#review163332 --- Ship it! Ship It! - Stephan Erb On Dec. 15, 2016, 6:48 p.m

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

write something like the following? ``` @ThriftWorkload(result -> result.getJobSummaryResult().getSummariesSize()) ``` - Stephan Erb On Dec. 30, 2016, 6:58 a.m., Mehrdad Nurolahzade wrote: > > --- > This i

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

Mesos people if they are willing to re-establish compatibility for one version. - Stephan Erb On Jan. 25, 2017, 8:02 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate limiter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55471/#review162656 --- Ship it! Ship It! - Stephan Erb On Jan. 23, 2017, 6 p.m

Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate limiter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55471/#review162657 --- @ReviewBot retry - Stephan Erb On Jan. 23, 2017, 6 p.m

<    1   2   3   4   5   6   7   8   9   10   >