Re: Review Request 57061: Enable Mesos HTTP API.

/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57061/#review166919 --- @ReviewBot retry - Zameer Manji On Feb. 24, 2017, 7:16 p.m

Re: Review Request 57074: Fix scheduler_framework_disconnects stats

. - Zameer Manji On Feb. 26, 2017, 11:05 a.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57074/ > --

Re: Review Request 57074: Fix scheduler_framework_disconnects stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57074/#review166910 --- Ship it! Ship It! - Zameer Manji On Feb. 26, 2017, 11:05

Re: Review Request 57061: Enable Mesos HTTP API.

f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Review Request 57061: Enable Mesos HTTP API.

/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56691/ > --- > > (Updated Feb. 24, 2017, 3:02 p.m.) > > > Review re

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

in/java/org/apache/aurora/scheduler/offers/OfferReconciler.java (line 86) <https://reviews.apache.org/r/56691/#comment238819> We prefer `ImmutableList.of()` for lists of one item. - Zameer Manji On Feb. 22, 2017, 2:35 p.m.,

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

imeout we can reserve it. src/test/java/org/apache/aurora/scheduler/TierManagerTest.java (line 27) <https://reviews.apache.org/r/56690/#comment238816> Can you revert the import glob here? - Zameer Manji On Feb. 23, 2017,

Re: Review Request 56797: Move task conversion during reconciliation into the delayed closure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56797/#review166007 --- Ship it! Ship It! - Zameer Manji On Feb. 17, 2017, 4:13 p.m

Re: Review Request 56723: Add best effort pulse timestamp recovery.

ps://reviews.apache.org/r/56723/#review165801 ------- On Feb. 15, 2017, 6:24 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 56723: Add best effort pulse timestamp recovery.

che/aurora/scheduler/updater/JobUpdaterIT.java ea0b89a232c2fc10f2183218b750bb0478d51a58 Diff: https://reviews.apache.org/r/56723/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56723: Add best effort pulse timestamp recovery.

apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 729c1234a2e27f1e756ddfd6a4e5a04fa20bbd7f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java ea0b89a232c2fc10f2183218b750bb0478d51a58 Diff: https://reviews.apache.org/r/56723/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56723: Add best effort pulse timestamp recovery.

va/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 729c1234a2e27f1e756ddfd6a4e5a04fa20bbd7f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java ea0b89a232c2fc10f2183218b750bb0478d51a58 Diff: https://reviews.apache.org/r/56723/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56723: Add best effort pulse timestamp recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56723/#review165775 ------- On Feb. 15, 2017, 2:09 p.m., Zameer Manji wrote: > > -

Review Request 56723: Add best effort pulse timestamp recovery.

llerImpl.java 729c1234a2e27f1e756ddfd6a4e5a04fa20bbd7f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java ea0b89a232c2fc10f2183218b750bb0478d51a58 Diff: https://reviews.apache.org/r/56723/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

://reviews.apache.org/r/5/diff/ Testing --- sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

To reply, visit: https://reviews.apache.org/r/5/#review165452 ------- On Feb. 13, 2017, 6:26 p.m., Zameer Manji wrote: > > --- > This is an automatica

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

d e-mail. To reply, visit: https://reviews.apache.org/r/5/#review165597 ------- On Feb. 13, 2017, 6:26 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/533

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

5> > > > > Can you fix spacing so the columns line up? ;) Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review165512 -------

Re: Review Request 56575: AURORA-1837 Improve task history pruning

> On Feb. 14, 2017, 4:02 p.m., Mehrdad Nurolahzade wrote: > > Looking at it as is, I'm not sure if there is much value to be gained from > > pushing this down to `TaskStore`. > > Do you see any value in pursuing this idea any further? Or shall I restore > > it to previous state? I think there

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

tps://reviews.apache.org/r/56629/#comment237421> Could you refer to AURORA-1892? - Zameer Manji On Feb. 13, 2017, 9:41 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

1fe09090bfa3eeb0f6897e8c895782fb1ff949a1 Diff: https://reviews.apache.org/r/5/diff/ Testing --- sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

. Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review154365 --- On Oct. 31, 2016, 6:48 p.m., Zameer Manji wrote: &g

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

eference) Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review154573 --- On Oct. 31, 2016, 6:48 p.m., Zameer Manji wrote: > > -

Re: Review Request 56577: Add basic test scripts for RPM and DEB packages

, but apparently not. Thanks for doing this. - Zameer Manji On Feb. 12, 2017, 5:12 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56523/#review165387 --- This is now on master. - Zameer Manji On Feb. 13, 2017, 12:09

Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56523/#review165385 --- Ship it! LGTM, thanks for your contribution. - Zameer Manji

Re: Review Request 52669: Move the H2 database off heap.

ated e-mail. To reply, visit: > https://reviews.apache.org/r/52669/ > --- > > (Updated Oct. 11, 2016, 11:17 a.m.) > > > Review request for Aurora, David McLaughlin, John Sirois, and Zameer Manji. > > > Repository: au

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

of the deprecated fields. - Zameer Manji On Feb. 7, 2017, 9:02 a.m., Nicolás Donatucci wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56404: Update PMD to 5.5.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56404/#review164568 --- Ship it! Ship It! - Zameer Manji On Feb. 7, 2017, 1:32 p.m

Re: Review Request 56361: Add additional tests for the conversion of TaskStatus.

/ProtosConversionTest.java 86e065c62cf2bc7ee173a377efa7b57b41918e40 Diff: https://reviews.apache.org/r/56361/diff/ Testing --- Thanks, Zameer Manji

Review Request 56361: Add additional tests for the conversion of TaskStatus.

://reviews.apache.org/r/56361/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56265: Move Aurora to v1 Protobufs.

86861e1bd4ca5b920808abf419bc13f83961b836 Diff: https://reviews.apache.org/r/56265/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 54459: Add message parameter to killTasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54459/#review164384 --- This change is now on master. - Zameer Manji On Feb. 6, 2017

Re: Review Request 54459: Add message parameter to killTasks

and I'll land this. - Zameer Manji On Feb. 1, 2017, 4:57 p.m., Cody Gibb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56265: Move Aurora to v1 Protobufs.

/scheduler/thrift/ThriftIT.java 86861e1bd4ca5b920808abf419bc13f83961b836 Diff: https://reviews.apache.org/r/56265/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56265: Move Aurora to v1 Protobufs.

/scheduler/thrift/ThriftIT.java 86861e1bd4ca5b920808abf419bc13f83961b836 Diff: https://reviews.apache.org/r/56265/diff/ Testing --- Thanks, Zameer Manji

Review Request 56265: Move Aurora to v1 Protobufs.

75bac6f238a619c41903007babd4a6e20aaeaa1e src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 86861e1bd4ca5b920808abf419bc13f83961b836 Diff: https://reviews.apache.org/r/56265/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 54459: Add message parameter to killTasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54459/#review163922 --- @ReviewBot retry - Zameer Manji On Feb. 1, 2017, 4:57 p.m

Re: Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.

/mesos/CommandLineDriverSettingsModule.java (line 155) <https://reviews.apache.org/r/56131/#comment235171> Can you link to the commit that did this or something? It would make it much easier to determine later if we can remove it. - Zameer Manji On Jan. 31, 2017, 10:41 a.m.,

Re: Review Request 56062: Fix flapping TestRunnerKillProcessGroup test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56062/#review163564 --- Ship it! Ship It! - Zameer Manji On Jan. 29, 2017, 9:53 a.m

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163551 --- This is on master now. - Zameer Manji On Jan. 30, 2017, 10:23

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163550 --- Ship it! Ship It! - Zameer Manji On Jan. 30, 2017, 10:23

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review163020 --- Ship it! Ship It! - Zameer Manji On Jan. 25, 2017, 10:47

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162721 --- Ship it! Ship It! - Zameer Manji On Jan. 23, 2017, 12:21

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a Diff: https://reviews.apache.org/r/54288/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate limiter

. - Zameer Manji On Jan. 23, 2017, 9 a.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 55684: Fix command escaping when using the Mesos containerizer

, but the addition to the e2e test makes me confident. - Zameer Manji On Jan. 18, 2017, 12:54 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 55071: Disable H2 logging via SLF4J.

is an operational change (by default everything went to stderr) and plus it is nice to use the logback.xml configuration. Have we considered filing a ticket upstream? H2 can fix this integration bug. - Zameer Manji On Dec. 28, 2016, 3:28 a.m., Stephan Erb wrote

Re: Review Request 55578: Log process sampling failures with debug severity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55578/#review161913 --- Ship it! Ship It! - Zameer Manji On Jan. 16, 2017, 6:44 a.m

Re: Review Request 55536: Improve `thriftw` robustness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55536/#review161655 --- Ship it! Ship It! - Zameer Manji On Jan. 14, 2017, 10:19

Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review161591 --- Ship it! Ship It! - Zameer Manji On Jan. 13, 2017, 12:23

Re: Review Request 55357: AURORA-1867 Consider reserving for multiple tasks per preemption round

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55357/#review161590 --- Ship it! Ship It! - Zameer Manji On Jan. 11, 2017, 8:48 a.m

Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate limiter blocking time

> On Jan. 13, 2017, 11:47 a.m., Mehrdad Nurolahzade wrote: > > Thinking about it, maybe we should expose this metric as a counter rather > > than time. Thoughts? > > Zameer Manji wrote: > What would it be counting exactly? > > Mehrdad Nurolahzade wrote: &g

Re: Review Request 55477: AURORA-1874 Expose stats on SlotSizeCounter runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55477/#review161575 --- Ship it! Ship It! - Zameer Manji On Jan. 12, 2017, 3:07 p.m

Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate limiter blocking time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55471/#review161573 --- Ship it! Ship It! - Zameer Manji On Jan. 12, 2017, 2:46 p.m

Re: Review Request 55056: AURORA-1834 Expose stats on undelivered event bus events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55056/#review160197 --- Ship it! Ship It! - Zameer Manji On Dec. 27, 2016, 1:36 p.m

Re: Review Request 55019: AURORA-1851 Expose stats on JobUpdateAction transitions

think all you have to do is iterate of the `.values()` method of the enum and prime the cache. That would create the counters. - Zameer Manji On Dec. 23, 2016, 12:24 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an auto

Re: Review Request 55003: AURORA-1848 Expose ResponseCode stats on Thrift server calls

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55003/#review160033 --- Ship it! Ship It! - Zameer Manji On Dec. 22, 2016, 4:06 p.m

Re: Review Request 54990: AURORA-1855 Expose stats on deleted tasks in TaskHistoryPruner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54990/#review160003 --- Ship it! Ship It! - Zameer Manji On Dec. 22, 2016, 11:27

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

nstead adding `StatsProvider` to your constructor and using that instance to create the metrics? - Zameer Manji On Dec. 21, 2016, 4:30 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 54255: Update to Mesos 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/#review159660 --- Ship it! Ship It! - Zameer Manji On Dec. 18, 2016, 4:09 a.m

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158812 --- @ReviewBot retry - Zameer Manji On Dec. 11, 2016, 4:43 p.m

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

an idea of what's going on? - Zameer Manji On Dec. 8, 2016, 3:28 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

/r/54288/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

://reviews.apache.org/r/54288/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

to review this. I support this metric and look forward to using it once it is landed. +1 to Serb's comment about adding a chnagelog entry bonus points for updating the metrics docs. - Zameer Manji On Dec. 7, 2016, 9:50 a.m., Joshua Cohen wrote

Re: Review Request 54459: Add message parameter to killTasks

-- On Dec. 6, 2016, 6:20 p.m., Cody Gibb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54459/ > --- > > (Updated Dec. 6, 2016, 6:20 p.m.) > > > Revie

Re: Review Request 54255: Update to Mesos 1.1.0.

I think the mesos make files have recursive make invocations in them, so this is more desirable. src/main/java/org/apache/aurora/scheduler/base/Conversions.java (line 67) <https://reviews.apache.org/r/54255/#comment229137> Can you reference AURORA-1814 in this comment please

Re: Review Request 54255: Update to Mesos 1.1.0.

ttps://reviews.apache.org/r/54255/ > --- > > (Updated Dec. 7, 2016, 3:04 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1813 > https://issues.apache.org/jira/browse/AURORA-1813 > &

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

can't reproduce the jenkins failure. - Zameer Manji On Dec. 1, 2016, 7:19 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review157840 --- @ReviewBot retry - Zameer Manji On Dec. 1, 2016, 7:19 p.m

Re: Review Request 54269: Improve scheduling throughput via logging changes.

g builtin formatting rather than doing the string > > concatenate all the time. Good catch, done! On Dec. 1, 2016, 5:41 p.m., Zameer Manji wrote: > > Please mention the logger config change in the release notes. Done. - Zameer --

Re: Review Request 54269: Improve scheduling throughput via logging changes.

ps://reviews.apache.org/r/54269/#review157799 ------- On Dec. 1, 2016, 3:13 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 54269: Improve scheduling throughput via logging changes.

aurora/scheduler/state/TaskStateMachine.java 23f256a7d467c79dcd5d906f76af4f0261dfd81d src/main/resources/logback.xml 84c175cec811fd95db44fd8dfcd514385606042d Diff: https://reviews.apache.org/r/54269/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

staring at the tests, but I think this is correct. This is unfortunately a little complex to understand. For bonus points, would it be possible to encode some of this information in a diagram? The tests are thourough, which makes me comfortable in shipping this change. - Zameer Manji On Dec. 2

Review Request 54288: Make leader elections resilient to ZK disconnections.

/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a Diff: https://reviews.apache.org/r/54288/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 54269: Improve scheduling throughput via logging changes.

e.java 23f256a7d467c79dcd5d906f76af4f0261dfd81d src/main/resources/logback.xml 84c175cec811fd95db44fd8dfcd514385606042d Diff: https://reviews.apache.org/r/54269/diff/ Testing --- Thanks, Zameer Manji

Review Request 54269: Improve scheduling throughput via logging changes.

ources/logback.xml 84c175cec811fd95db44fd8dfcd514385606042d Diff: https://reviews.apache.org/r/54269/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 54176: Update PMD and checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54176/#review157337 --- Ship it! Ship It! - Zameer Manji On Nov. 29, 2016, 1:56 p.m

Re: Review Request 54107: changes to intercept and time mybatis invocations

/InstrumentingInterceptor.java (line 81) <https://reviews.apache.org/r/54107/#comment227868> Instead of having a hard dependency on `SlidingStats` constructor here. Could we use `StatsProvider` to get the sliding stats for us? - Zameer Manji On Nov. 28, 2016, 6:36 p.m., Reza Motamedi

Re: Review Request 53519: Tear down the observer in case of on unhandled errors

use it in AURORA-1799. - Zameer Manji On Nov. 23, 2016, 2:25 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

://reviews.apache.org/r/54011/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54011/#review156727 --- On Nov. 22, 2016, 6:47 p.m., Zameer Manji wrote: > > --

Review Request 54011: Add benchmarks for `StateManagerImpl`.

StateManagerBenchmarks.InsertPendingTasksBenchmark.run 5 N/A thrpt 10 0.041 ± 0.006 ops/s Diffs - src/jmh/java/org/apache/aurora/benchmark/StateManagerBenchmarks.java PRE-CREATION Diff: https://reviews.apache.org/r/54011/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing

future changes? - Zameer Manji On Nov. 18, 2016, 6:45 p.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53836: Get pants using the same thrift binary as gradle.

> On Nov. 17, 2016, 1:48 p.m., Zameer Manji wrote: > > Seems like a lot of patches to enable this behaviour. I'm not opposed but > > it seems risky. > > John Sirois wrote: > You find everything risky! I'm just afraid that the more patches we have, the hard

Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53831/#review156227 --- Ship it! Ship It! - Zameer Manji On Nov. 17, 2016, 8:43 a.m

Re: Review Request 53829: Make scheduling benchmarks more realistic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53829/#review156157 --- Ship it! Ship It! - Zameer Manji On Nov. 16, 2016, 4:19 p.m

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

> On Nov. 16, 2016, 2:44 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/executor/aurora_executor.py, line 118 > > <https://reviews.apache.org/r/53590/diff/5/?file=1565457#file1565457line118> > > > > The only objection I have to this code is

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

> On Nov. 16, 2016, 2:44 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/executor/aurora_executor.py, line 118 > > <https://reviews.apache.org/r/53590/diff/5/?file=1565457#file1565457line118> > > > > The only objection I have to this code is

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

> On Nov. 16, 2016, 2:44 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/executor/aurora_executor.py, line 118 > > <https://reviews.apache.org/r/53590/diff/5/?file=1565457#file1565457line118> > > > > The only objection I have to this code is

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

return RUNNING and the rest return `None` we go to RUNNING. If one returns STARTING we poll until we reach the previous states. What do you think about that? - Zameer Manji On Nov. 16, 2016, 1:38 p.m., Santhosh Kumar Shanmugham

Re: Review Request 53796: Bump guava dependency to 20.

/apache/aurora/scheduler/storage/log/LogManagerTest.java 73440517cddda643c0b84cc04cb8463cdea2da28 Diff: https://reviews.apache.org/r/53796/diff/ Testing --- Thanks, Zameer Manji

Review Request 53796: Bump guava dependency to 20.

73440517cddda643c0b84cc04cb8463cdea2da28 Diff: https://reviews.apache.org/r/53796/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 53794: Update Curator to 2.11.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53794/#review155979 --- Ship it! Ship It! - Zameer Manji On Nov. 15, 2016, 1:22 p.m

<    1   2   3   4   5   6   7   8   >