Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

ine 69) <https://reviews.apache.org/r/51759/#comment216480> Just curious, is this default arbitrary or something that was derrived from your deployment in production? - Zameer Manji On Sept. 14, 2016, 10:25 a.m., Maxim Khuto

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

> On Sept. 13, 2016, 6:29 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/BatchWorker.java, line 110 > > <https://reviews.apache.org/r/51759/diff/4/?file=1498117#file1498117line110> > > > > The documentation implies we are returning a

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

d have that extra code add more work. - Zameer Manji On Sept. 13, 2016, 5:16 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

> On Sept. 13, 2016, 5:11 p.m., Zameer Manji wrote: > > I support this change as a developer. > > > > As an operator I am scared. > > > > What happens to an existing cluster if we don't set `framework_name`? Will > > it register another frameowor

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

/CommandLineDriverSettingsModule.java (line 83) <https://reviews.apache.org/r/51874/#comment216322> I like the idea of making the framework name `Aurora`. - Zameer Manji On Sept. 13, 2016, 5:05 p.m., Santhosh Kumar Shanmugham

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

this review to the ticket. Chnage the title to "Aurora admin commands for reconcilation" Please update the description to explain what commands you added. - Zameer Manji On Sept. 12, 2016, 2:29 p.m., Karthik Anantha Padmana

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

7a0797d5402e931006d4f215e2d9c0dbbd113257 src/test/python/apache/aurora/client/cli/test_supdate.py 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

7a0797d5402e931006d4f215e2d9c0dbbd113257 src/test/python/apache/aurora/client/cli/test_supdate.py 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148643 --- On Sept. 12, 2016, 3:26 p.m., Zameer Manji wrote: > >

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

ng that here for consistency? - Zameer Manji On Sept. 12, 2016, 3:51 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148628 --- @ReviewBot retry - Zameer Manji On Sept. 12, 2016, 3:26 p.m

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

7a0797d5402e931006d4f215e2d9c0dbbd113257 src/test/python/apache/aurora/client/cli/test_supdate.py 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51826: Implement `toString` on lazy modules.

org.apache.aurora.scheduler.http.api.security.IniShiroRealmModule])` Diffs - src/main/java/org/apache/aurora/scheduler/app/MoreModules.java d5f96543d1068bf30b9d173a247c2806faf35578 Diff: https://reviews.apache.org/r/51826/diff/ Testing --- Thanks, Zameer Manji

Review Request 51826: Implement `toString` on lazy modules.

/scheduler/app/MoreModules.java d5f96543d1068bf30b9d173a247c2806faf35578 Diff: https://reviews.apache.org/r/51826/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

ent command and initializing both > > values in this changelist? Otherwise, there is a risk of cutting a release > > in between and delaying removal by extra release (until both client and > > scheduler are dual writing/reading). > > Zameer Manji wrote: > We ca

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

/test_api.py 7a0797d5402e931006d4f215e2d9c0dbbd113257 Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

ent command and initializing both > > values in this changelist? Otherwise, there is a risk of cutting a release > > in between and delaying removal by extra release (until both client and > > scheduler are dual writing/reading). > > Zameer Manji wrote: > We ca

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

t: https://reviews.apache.org/r/51712/#review148565 ------- On Sept. 12, 2016, 12:39 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

there are outstanding feedback items. Once those are complete, please ask a comitter to land this patch for you. Thanks for your contribution! - Zameer Manji On Sept. 12, 2016, 10:49 a.m., Karthik Anantha Padmanabhan wrote

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- Thanks, Zameer Manji

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

> On Sept. 12, 2016, 11:06 a.m., Zameer Manji wrote: > > docs/reference/scheduler-configuration.md, line 205 > > <https://reviews.apache.org/r/51807/diff/1/?file=1496736#file1496736line205> > > > > As an aside, could you file a ticket to clean up the def

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

tps://reviews.apache.org/r/51807/#comment215987> As an aside, could you file a ticket to clean up the default here? Seems useless ATM. - Zameer Manji On Sept. 12, 2016, 6:38 a.m., Stephan Erb wrote: > > --- > This is a

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148539 --- Bumping this for visability. - Zameer Manji On Sept. 8, 2016

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- Thanks, Zameer Manji

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

est/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java (line 1258) <https://reviews.apache.org/r/51662/#comment215776> Please add tests for cases where batch size is unset and when it is 0 and when it is negative. - Zameer Manji On Sept. 8, 2016, 5:01 p.m

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java a7d1f74acdfe5f58eb822a4d826e920cad53dced src/test/python/apache/aurora/client/api/test_api.py 7a0797d5402e931006d4f215e2d9c0dbbd113257 Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

out in the release notes > > ad well? Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148158 --- On

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

ng issues. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148208 --- On Sept. 7, 2016, 5:03 p.m

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148120 --- @ReviewBot retry - Zameer Manji On Sept. 7, 2016, 5:03 p.m

Re: Review Request 51536: Modify the watch_secs assertion on scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148118 --- Ship it! Ship It! - Zameer Manji On Sept. 7, 2016, 4:10 p.m

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

deprecation, please pay careful attention to ensure nothing is broken for 0.16.0. - Zameer Manji On Sept. 7, 2016, 5:03 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

929d021a336c6a3438613c9340c84a1096dc9069 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java a7d1f74acdfe5f58eb822a4d826e920cad53dced Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Review Request 51667: Remove HttpServletRequestParams

/HttpServletRequestParamsTest.java f1479bfea90bd78cd07d451fc62ca2b4d341d654 Diff: https://reviews.apache.org/r/51667/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

at `0c90c862a14c3a5efe0fdf0f30ee41c01b96b434`. - Zameer Manji On Sept. 5, 2016, 11:56 a.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147899 --- Ship it! Ship It! - Zameer Manji On Sept. 5, 2016, 11:56

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Sept. 1, 2016, 12:51 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 467 > > <https://reviews.apache.org/r/51536/diff/3/?file=1489406#file1489406line467> > > > > This is not sufficent to determine if healthcheckin

Re: Review Request 51595: Add Job Store and Dynamic Reservations design docs

shouldn't link to it until someone works on it. - Zameer Manji On Sept. 2, 2016, 2:14 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51602: Extend the resource isolation and oversubscription documentation

of the Mesos docs or just the latest version we support at time of writing? - Zameer Manji On Sept. 2, 2016, 7:55 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

we know that this patch is blocked on that review landing first? - Zameer Manji On Sept. 1, 2016, 12:37 p.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

abling of this feature be a property of the Job or Update? - Zameer Manji On Aug. 31, 2016, 3:08 p.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

> On Aug. 31, 2016, 2:47 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 795-796 > > <https://reviews.apache.org/r/51384/diff/4/?file=1487500#file1487500line795> > > > > +100 > > > > I don't th

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

- 796) <https://reviews.apache.org/r/51384/#comment214669> +100 I don't think a client could fetch the entire JobUpdate to get the metadata it attached to the request. - Zameer Manji On Aug. 27, 2016, 8:58 p.m., Santhosh Kumar Shanmugham

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

> On Aug. 29, 2016, 9:57 a.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 795-796 > > > > > > How about moving this into `JobUpdateSummary` instead? As it stands > >

Re: Review Request 51469: Remove static Stats method `exportSize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51469/#review147493 --- Bumping for Josh. - Zameer Manji On Aug. 26, 2016, 3:11 p.m

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147490 --- Ship it! Ship It! - Zameer Manji On Aug. 31, 2016, 1:56 p.m

Re: Review Request 51513: Add support for ETags in the Aurora API.

pect that we > > get a different hash each time, even though the content itself has not > > changed. > > > > Considering it is working in some cases, do we have to do something to get > > some speedups for the Aurora UI as well? > > Zameer Manji wrote: > C

Re: Review Request 51513: Add support for ETags in the Aurora API.

pect that we > > get a different hash each time, even though the content itself has not > > changed. > > > > Considering it is working in some cases, do we have to do something to get > > some speedups for the Aurora UI as well? > > Zameer Manji wrote: > C

Re: Review Request 51513: Add support for ETags in the Aurora API.

enough that > > sending them on the wire and processing them on the client side is causing > > a perf problem)? > > > > At the very least, perhaps we should only buffer the response if the > > `If-None-Match` header is set? > > Zameer Manji w

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> On Aug. 30, 2016, 10:56 a.m., Zameer Manji wrote: > > LGTM modulo updating the docs about restarting all instances at the same > > time. > > > > Could you also file a ticket to track the removal of the `zk_use_curator` > > flag in 0.17? I did not see on

Re: Review Request 51499: Update 3dparty Python dependencies

nothing that conerns me. Just saying that if the executor/observer behavious abnormally after this change, it's likely because of that. - Zameer Manji On Aug. 30, 2016, 12:40 a.m., Stephan Erb wrote: > > --- > This is an auto

Re: Review Request 51513: Add support for ETags in the Aurora API.

-------- On Aug. 29, 2016, 6:12 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51513/ > ---

Re: Review Request 51513: Add support for ETags in the Aurora API.

I could wrap the outputstream of the response and have that compute the hash as bytes are given. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51513/#review147255 ----

Re: Review Request 51531: Minor improvements to the custom executor docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51531/#review147324 --- Ship it! Ship It! - Zameer Manji On Aug. 30, 2016, 10:45

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

instances at the same time. Could you also file a ticket to track the removal of the `zk_use_curator` flag in 0.17? I did not see one on JIRA. - Zameer Manji On Aug. 29, 2016, 4:37 p.m., John Sirois wrote: > > --- > This is an auto

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- > > (Updated Aug. 29, 2016, 4:37 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: auror

Re: Review Request 51513: Add support for ETags in the Aurora API.

well. I'm willing to add e2e tests and other changes to validate this works via curl if required. Feel free to comment on the idea in the associated ticket. - Zameer Manji On Aug. 29, 2016, 6:12 p.m., Zameer Manji wrote

Review Request 51513: Add support for ETags in the Aurora API.

/ApiIT.java 0a3ff05586c87e0ab2cc20470e99b5dd609f7039 Diff: https://reviews.apache.org/r/51513/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51469: Remove static Stats method `exportSize`.

> On Aug. 29, 2016, 9:33 a.m., Maxim Khutornenko wrote: > > Not against this change but rather curious what your thoughts are wrt the > > larger picture here. Are you intending to get rid of all static helps in > > `Stats` in favor of the `StatsProvider`? > > Zamee

Re: Review Request 51469: Remove static Stats method `exportSize`.

r/51469/#review147138 --- On Aug. 26, 2016, 3:11 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

s it's own discussion. I believe we configured pants to style checking already. It shouldn't be necessary to do this here. - Zameer Manji On Aug. 27, 2016, 3:33 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatica

Re: Review Request 51469: Remove static Stats method `exportSize`.

://reviews.apache.org/r/51469/diff/ Testing --- Thanks, Zameer Manji

Review Request 51469: Remote static stats method `exportSize`.

6d4934b6b6de5273687041174315c4e3d151ac11 src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java e7534c4325afa29b580d890cffdc26bdec7ef938 Diff: https://reviews.apache.org/r/51469/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

lly generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146574 ------- On Aug. 23, 2016, 1:45 p.m., Zameer Manji wrote: > > --- >

Re: Review Request 51306: Only warn about terminated executors if their exit code is not 0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51306/#review146452 --- Ship it! Ship It! - Zameer Manji On Aug. 22, 2016, 3:48 p.m

Review Request 51264: Reduce static method exposure for Stats.

bb0af69a89e8f8905e7fd01183d0ac7fe2a49db2 Diff: https://reviews.apache.org/r/51264/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51045: Remove unnecessary guice container parameters.

": "*", "scalar": { "value": 3.0 }, "type": "SCALAR" } ], "slave_id": { "value": "d7716da3-790d-4297-877b-93f724e91335-S0" }, "url": { "add

Review Request 51045: Remove unnecessary guice container parameters.

/aurora/scheduler/http/api/ApiModule.java e46820952fb6028911bca924169ceade6a134bfc Diff: https://reviews.apache.org/r/51045/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50168: Add rollback functionality to the scheduler

into the code before I had a chance. - Zameer Manji On Aug. 11, 2016, 11:07 a.m., Igor Morozov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 50937: Bump jetty dependency to the latest release.

iff: https://reviews.apache.org/r/50937/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50931: Remove unnecessary guice container parameters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50931/#review145258 --- @ReviewBot retry - Zameer Manji On Aug. 9, 2016, 12:53 p.m

Review Request 50931: Remove unnecessary guice container parameters.

.v20151106) Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

//github.com/apache/aurora/commit/581262ccfb3191083b42e40588dbb5471d52e3c4 - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144797 --- On Aug.

Re: Review Request 50826: Populate the source field of ExecutorInfo.

/MesosTaskFactoryImplTest.java 7484e8b159eb65634f7bd8f0aae61b2e1227e662 Diff: https://reviews.apache.org/r/50826/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50826: Populate the source field of ExecutorInfo.

: https://reviews.apache.org/r/50826/diff/ Testing --- Thanks, Zameer Manji

Review Request 50826: Populate the source field of ExecutorInfo.

/aurora/scheduler/mesos/MesosTaskFactory.java 34134430063b2d24a4e20d3f91ab899604edaf89 Diff: https://reviews.apache.org/r/50826/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

7dbe48b433262a5b9f7b369d69a0d41e2472b054 src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 31f5cb3bed48eef60c3b2becb2ed285e93f2bd5a Diff: https://reviews.apache.org/r/50685/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

know > > if the use case exists to send json yet want to receive binary, but it's > > more idiomatic HTTP to support that possibility. > > Stephan Erb wrote: > +1 for the accept header > > Zameer Manji wrote: > I tried and wasn't able to make progress. The pro

Re: Review Request 50685: Support TBinaryProtocol over HTTP

------ On Aug. 2, 2016, 5:10 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50685/ > ---

Re: Review Request 50685: Support TBinaryProtocol over HTTP

/TContentAwareServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50685/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

/TContentAwareServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50685/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

-CREATION Diff: https://reviews.apache.org/r/50685/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

e.org/r/50685/#review144485 --- On Aug. 1, 2016, 6:29 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 50685: Support TBinaryProtocol over HTTP

.apache.org/r/50685/#review144439 --- On Aug. 1, 2016, 6:29 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 50685: Support TBinaryProtocol over HTTP

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144450 --- On Aug. 1, 2016, 6:29 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-m

Re: Review Request 50685: Support TBinaryProtocol over HTTP

/ApiModule.java (line 11) <https://reviews.apache.org/r/50685/#comment210451> Reviwers: please note that this is a little light on tests because I want to ensure the approach is acceptable first. - Zameer Manji On Aug. 1, 2016, 6:29 p.m., Zameer Manji

Review Request 50685: Support TBinaryProtocol over HTTP

/apache/aurora/scheduler/http/api/TContentAwareServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50685/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50168: Add rollback functionality to the scheduler

s here and include a brief statement in `RELEASE-NOTES.md`. - Zameer Manji On July 28, 2016, 12:06 p.m., Igor Morozov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 50168: Add rollback functionality to the scheduler

s://reviews.apache.org/r/50168/ > --- > > (Updated July 20, 2016, 8:37 p.m.) > > > Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Bill Farner, and > Zameer Manji. > > > Bugs: AURORA-1721

Re: Review Request 47076: Changing ResourceMapper interface arg type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47076/#review132091 --- Ship it! Ship It! - Zameer Manji On May 6, 2016, 11:10 a.m

Re: Review Request 46948: Adding mesos resource converter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46948/#review131735 --- Ship it! Ship It! - Zameer Manji On May 3, 2016, 2:11 p.m

Re: Review Request 46810: Generalizing port resource management.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46810/#review131155 --- Ship it! Ship It! - Zameer Manji On April 29, 2016, 9:43

Re: Review Request 46716: ResourceAggregate schema changes for resource refactoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46716/#review130812 --- Ship it! Ship It! - Zameer Manji On April 26, 2016, 5:31

Re: Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/#review130510 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 2:54

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130506 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 5:16

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130468 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 5:38

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

-- > > (Updated April 22, 2016, 5:38 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-945 > https://issues.apache.org/jira/browse/AURORA-945 > > > Repository: aurora >

Re: Review Request 46459: Schema changes for resource management refactoring

/46459/#comment193835> Perhaps to reduce duplication we could use `ResourceType..getAuroraName()` here instead of hard coding in CPUS, RAM_MB, etc? - Zameer Manji On April 22, 2016, 9:45 a.m., Maxim Khutornenko wrote: > >

Re: Review Request 46361: deleting --setuid-health-checks and switching to --nosetuid-health-checks flag to to control whether the executor runs health checks as the job role's user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46361/#review129600 --- Ship it! Ship It! - Zameer Manji On April 18, 2016, 7:31

Review Request 46346: Add @Timed annotations to cron stores.

6a9c73e8e6dd92e9e6361baa0e02ccaf89fce5d7 src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 365494c0bfca7b633c57bf97762473df458ef1aa Diff: https://reviews.apache.org/r/46346/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 46286: Plumb Curator discovery as an option.

? - Zameer Manji On April 16, 2016, 9:10 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

<    1   2   3   4   5   6   7   8   >