Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52776/#review152371 --- Ship it! Ship It! - Zameer Manji On Oct. 12, 2016, 1:46 a.m

Re: Review Request 52790: Upgrade pystachio to 0.8.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/#review152361 --- Ship it! This is now on master. - Zameer Manji On Oct. 12

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

but can you peel off this authentication thing to a seperate diff or drop it? I don't think it's required for this change to work, I am not aware of people even run private docker registries with authenication enabled for reads. - Zameer Manji On Oct. 10, 2016, 9:0

Re: Review Request 52739: Update mybatis, h2, and jmh to their latest versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52739/#review152169 --- Ship it! Ship It! - Zameer Manji On Oct. 11, 2016, 8:11 a.m

Re: Review Request 52640: Upgrade to pants 1.2.0rc0.

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52640/ > --- > > (Updated Oct. 7, 2016, 9:34 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. &g

Re: Review Request 52640: Upgrade to pants 1.2.0rc0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52640/#review152078 --- Ship it! Ship It! - Zameer Manji On Oct. 7, 2016, 9:34 p.m

Re: Review Request 52588: Enable per task volume mounts via scheduler API

schema.sql with the migrations, but I believe there is some nuance there that is hard to capture. I will also defer to Josh here. One is not generated from the other sadly. - Zameer --- This is an automatically generated e-mail. T

Re: Review Request 52665: Populate curator latches with scheduler information

172.17.0.1: 172.17.0.1 > > Enumerating addresses of interface wlp3s0: > > fe80:0:0:0:183:9e44:9c10:%wlp3s0: > > fe80:0:0:0:183:9e44:9c10:%wlp3s0 > > 10.0.3.132: 10.0.3.132 > > ``` > > > > I'm not sure

Re: Review Request 52665: Populate curator latches with scheduler information

just had the ServerSet information. If we did that, we would avoid these issues. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52665/#review151949 --- On Oct. 9, 2016, 1:43 a.m., Jing C

Re: Review Request 52669: Move the H2 database off heap.

. build.gradle (line 94) <https://reviews.apache.org/r/52669/#comment220728> Can you please peel off the rev bumps on to their own patch? We should land them anyways. - Zameer Manji On Oct. 10, 2016, 8:14 a.m., Stephan Erb wrote: > > --

Re: Review Request 52588: Enable per task volume mounts via scheduler API

/java/org/apache/aurora/scheduler/thrift/Fixtures.java 95b371627d23f7ed3472561f17880bf3c4259b96 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java e578f5a3076b8f1aad86247b815d05c8244dddc8 Diff: https://reviews.apache.org/r/52588/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 52588: Enable per task volume mounts via scheduler API

.java 95b371627d23f7ed3472561f17880bf3c4259b96 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java e578f5a3076b8f1aad86247b815d05c8244dddc8 Diff: https://reviews.apache.org/r/52588/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 52588: Enable per task volume mounts via scheduler API

eviews.apache.org/r/52588/diff/1/?file=1524200#file1524200line137> > > > > nit: indentation should be the same here as we do for other sources > > (i.e. 4 space indents for continuations, one attribute per line). Done. - Zameer

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

ton.edu> wrote: >>>>> >>>>>> Zameer, >>>>>> >>>>>> Alright. I will start making changes to incorporate Stephan's idea. >>>>>> Also, I didn't seem to find an existing test for PendingTasks. Please >&

Re: Review Request 52610: Use the Thrift binary protocol in the Aurora client.

at my change has enabled the client to be much faster with large jobs. - Zameer Manji On Oct. 6, 2016, 11:14 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

/ZooKeeperUtils.java (line 29) <https://reviews.apache.org/r/52594/#comment220066> Maybe we can remove the 'Twitter' reference here? - Zameer Manji On Oct. 5, 2016, 8:29 p.m., John Sirois wrote: > > --- >

Re: Review Request 52591: Remove untested classes that no longer exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52591/#review151625 --- Ship it! How did you determine this? - Zameer Manji On Oct

Re: Review Request 52588: Enable per task volume mounts via scheduler API

/ThriftIT.java 3caad32a30a02a1dd33893266c0dc817633a0f37 Diff: https://reviews.apache.org/r/52588/diff/ Testing --- Thanks, Zameer Manji

Review Request 52588: Enable per task volume mounts via scheduler API

://reviews.apache.org/r/52588/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 52581: Reduce offer_filter_duration to 0secs in Vagrant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52581/#review151608 --- Ship it! Ship It! - Zameer Manji On Oct. 5, 2016, 4:23 p.m

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

ave no idea what's causing these. - Zameer ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151573 ---

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151582 --- @ReviewBot retry - Zameer Manji On Oct. 5, 2016, 3:01 p.m

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

first remove the depends on review from here (so the robot doesn't apply it) and two rebase your changes? I'll land it once the robot gives it a shipit. - Zameer Manji On Oct. 4, 2016, 11:09 p.m., Kai Huang wrote: > > ---

Re: Review Request 52531: Build Debian Jessie and Ubuntu Xenial specific mesos eggs

the title and metadata. - Zameer Manji On Oct. 5, 2016, 12:55 p.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151539 --- Ship it! Ship It! - Zameer Manji On Oct. 4, 2016, 11:09 p.m

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

gt; or should I hold it for now until the idea is a little more clear? > > On Tue, Oct 4, 2016 at 5:18 PM, Zameer Manji wrote: > >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/51993/ >> >> On October 4th, 2016, 2:10 p

Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52527/#review151402 --- Ship it! Ship It! - Zameer Manji On Oct. 4, 2016, 2:08 p.m

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

> On Oct. 4, 2016, 2:10 p.m., Stephan Erb wrote: > > This change will be backwards incompatible. For example, it will break the > > Prometheus Aurora exporter: > > https://github.com/tommyulfsparre/aurora_exporter/blob/master/main.go#L101 > > > > So the question: Do we consider this endpoint t

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

update configuration.md and I think `features/job-updates.md` needs to be updated as well. - Zameer Manji On Oct. 3, 2016, 5:42 p.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Review Request 52521: Replace wfarner with zmanji as default reviewer.

--- Replace wfarner with zmanji as default reviewer. Diffs - CONTRIBUTING.md 1d6baa40c1ed7806677e84e1b57eaaa820aaefa4 Diff: https://reviews.apache.org/r/52521/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

acters using the only > special character that is allowed '-'. Hence the mapping would look like, > \ => -pys-slash- > . => -pys-dot- > and so on. > > I vote for expanding the character limit for Ref. > > Zameer Manji wrote: >

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

tps://reviews.apache.org/r/52479/#comment219629> Why did you add support for creds? Is it not possible to have a registry with unauthenticated reads? - Zameer Manji On Oct. 3, 2016, 6:22 p.m., Santhosh Kumar Shanmugham wrote: > > ---

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

> On Oct. 3, 2016, 11:22 a.m., Joshua Cohen wrote: > > I don't think that the registry to resolve against should be an argument to > > the docker helper, as this should likely be controlled by Aurora operators, > > not by Aurora users. When we originally discussed this, we talked about > > hav

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

ply, visit: > https://reviews.apache.org/r/52437/ > --- > > (Updated Sept. 30, 2016, 12:23 p.m.) > > > Review request for Aurora, Dmitriy Shirchenko and Zameer Manji. > > > Repository: aurora-packaging > > &

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review151078 --- Ship it! Ship It! - Zameer Manji On Sept. 29, 2016, 4:43

Re: Review Request 52428: Add missing libffi build dep to support pants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151053 --- Ship it! Ship It! - Zameer Manji On Sept. 30, 2016, 11:17

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

/python/apache/aurora/client/config.py (line 112) <https://reviews.apache.org/r/52094/#comment219030> We should validate that this number is positive and non-zero. - Zameer Manji On Sept. 28, 2016, 10 a.m., Kai Huang wrote: > > --

Re: Review Request 52367: Upgrade to latest pants 1.2.0 pre-release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52367/#review150783 --- Ship it! Ship It! - Zameer Manji On Sept. 28, 2016, 3:51

Re: Review Request 52343: Add Criteo to Aurora user list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52343/#review150752 --- Ship it! Ship It! - Zameer Manji On Sept. 28, 2016, 4:46

Re: Review Request 52312: Remove `-zk_use_curator` and unused code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52312/#review150601 --- Ship it! +100 - Zameer Manji On Sept. 27, 2016, 12:43 p.m

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52276/#review150463 --- Ship it! Ship It! - Zameer Manji On Sept. 26, 2016, 2:16

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

apache.org/r/52276/ > --- > > (Updated Sept. 26, 2016, 2:08 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Bugs: AURORA-1783 > https://issues.apache.org/jira/browse/AURORA-1783 > > > Repository: aurora > > > Description > --- > >

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

> On Sept. 23, 2016, 3:18 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/executor/aurora_executor.py, line 120 > > <https://reviews.apache.org/r/51876/diff/5/?file=1509363#file1509363line120> > > > > This check is brittle to determine if health

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51876/#review150427 --- Ship it! Ship It! - Zameer Manji On Sept. 23, 2016, 11:58

Re: Review Request 51876: Modify executor state transition logic to rely on health checks (if enabled)

method `mesos_task_instance_from_assigned_task` will give you an instance of the executor config. You can then check the `health_check_config()` property of the result to see if health checking is enabled for the task. - Zameer Manji On Sept. 23, 2016, 11:58 a.m., Kai Huang

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review150106 --- Ship it! Ship It! - Zameer Manji On Sept. 20, 2016, 3:02

Re: Review Request 51929: Scheduling multiple tasks per round.

is null later, so why not just make it an empty `ImmutableSet` to start? - Zameer Manji On Sept. 20, 2016, 3:02 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 51929: Scheduling multiple tasks per round.

- > > (Updated Sept. 20, 2016, 3:02 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This is phase 2 of scheduling perf improvement

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

wn requests. - Zameer Manji On Sept. 22, 2016, 8:20 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

Worker services so I'm not sure why this helps at all. - Zameer Manji On Sept. 21, 2016, 10:38 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 52074: switching from launchTask to acceptOffers

TODOs are marked as `TODO(zmanji)`. Please mark your TODO here. - Zameer Manji On Sept. 20, 2016, 11:08 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

f the review to link to the JIRA ticket. I greatly appreciate the addition to the e2e test. - Zameer Manji On Sept. 20, 2016, 10:32 a.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 51980: Refactor of Webhook and no longer posting entire task state via webhook on scheduler restart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51980/#review149547 --- Ship it! Ship It! - Zameer Manji On Sept. 19, 2016, 11:28

Re: Review Request 52051: Add a release note about full task filesystem isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52051/#review149526 --- Ship it! Ship It! - Zameer Manji On Sept. 19, 2016, 12:04

Re: Review Request 52049: Clarifying documentation for new contributors by adding a step for them to ask for their JIRA id to get whitelisted

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52049/#review149515 --- Ship it! Ship It! - Zameer Manji On Sept. 19, 2016, 11:38

Re: Review Request 51980: Refactor of Webhook and no longer posting entire task state via webhook on scheduler restart

(line 71) <https://reviews.apache.org/r/51980/#comment217158> Please leave a comment here that if the old state is not present it's because the scheduler just started up and we don't want to resend those event . - Zameer Manji On Sept. 16, 2016, 6:40 p.m., Dmitriy

Re: Review Request 51987: Enable the `project_info` plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51987/#review149337 --- Ship it! Ship It! - Zameer Manji On Sept. 17, 2016, 10:50

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51759/#review149256 --- Ship it! Ship It! - Zameer Manji On Sept. 16, 2016, 1:03

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

/scheduling/SchedulingModule.java (line 91) <https://reviews.apache.org/r/51765/#comment216793> Curious, arbitrary or derrived? - Zameer Manji On Sept. 14, 2016, 4:18 p.m., Maxim Khutornenko wrote: > > --- > This is a

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

urrent/CompletableFuture.html#completeExceptionally-java.lang.Throwable- here and set the exception into the future. Then the exception will propagate to the caller (like `TaskGroupBatchWorker`). Then the user of the batch worker can handle the exception. - Zameer Manji On Sept. 14, 2016

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

> On Sept. 14, 2016, 3:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 82 > > > > > > Did you try to rollback to pre 0.15 scheduler

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

che.org/r/51763/#comment216615> For integration tests I was under the impression we used `org.apache.aurora.scheduler.testing.FakeStatsProvider` - Zameer Manji On Sept. 14, 2016, 4:12 p.m., Maxim Khutornenko wrote: > > --- >

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

> On Sept. 14, 2016, 11:36 a.m., Zameer Manji wrote: > > This patch LGTM. Just a single concern here and some questions. I will be > > moving on to the subsequent patches shortly. > > Please do not commit this until all parts are shipped. Also, please don't &

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

> On Sept. 14, 2016, 11:36 a.m., Zameer Manji wrote: > > This patch LGTM. Just a single concern here and some questions. I will be > > moving on to the subsequent patches shortly. > > Please do not commit this until all parts are shipped. Also, please don't &

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'Aurora'

we can rename from `TwitterScheduler` to `Aurora` without any risk whatever. - Zameer Manji On Sept. 14, 2016, 1:58 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

le.java (line 69) <https://reviews.apache.org/r/51759/#comment216480> Just curious, is this default arbitrary or something that was derrived from your deployment in production? - Zameer Manji On Sept. 14, 2016, 10:25 a.m., M

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

> On Sept. 13, 2016, 6:29 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/BatchWorker.java, line 110 > > <https://reviews.apache.org/r/51759/diff/4/?file=1498117#file1498117line110> > > > > The documentation implies we are returning a

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

is complete and have that extra code add more work. - Zameer Manji On Sept. 13, 2016, 5:16 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

> On Sept. 13, 2016, 5:11 p.m., Zameer Manji wrote: > > I support this change as a developer. > > > > As an operator I am scared. > > > > What happens to an existing cluster if we don't set `framework_name`? Will > > it register another fram

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

/CommandLineDriverSettingsModule.java (line 83) <https://reviews.apache.org/r/51874/#comment216322> I like the idea of making the framework name `Aurora`. - Zameer Manji On Sept. 13, 2016, 5:05 p.m., Santhosh Kumar Shanmugham wrote: > > -

Re: Review Request 51874: Change framework_name default value from 'TwitterScheduler' to 'aurora'

. What happens to an existing cluster if we don't set `framework_name`? Will it register another frameowork_id? (bad) or will it fail to register? (better). - Zameer Manji On Sept. 13, 2016, 5:05 p.m., Santhosh Kumar Shanmugham

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

review to the ticket. Chnage the title to "Aurora admin commands for reconcilation" Please update the description to explain what commands you added. - Zameer Manji On Sept. 12, 2016, 2:29 p.m., Karthik Anantha Padmana

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

7a0797d5402e931006d4f215e2d9c0dbbd113257 src/test/python/apache/aurora/client/cli/test_supdate.py 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

pi.py 7a0797d5402e931006d4f215e2d9c0dbbd113257 src/test/python/apache/aurora/client/cli/test_supdate.py 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148643 --- On Sept. 12, 2016, 3:26 p.m., Zameer Manji wrote: > > ---

Re: Review Request 51759: Batching writes - Part 1 (of 3): Introducing BatchWorker and task event batching.

instead of 'ns'. Mind using that here for consistency? - Zameer Manji On Sept. 12, 2016, 3:51 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148628 --- @ReviewBot retry - Zameer Manji On Sept. 12, 2016, 3:26 p.m

Re: Review Request 51826: Implement `toString` on lazy modules.

b2fb3c9dcba64f69a05894f506ba43766f74ddaa Diff: https://reviews.apache.org/r/51826/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

7a0797d5402e931006d4f215e2d9c0dbbd113257 src/test/python/apache/aurora/client/cli/test_supdate.py 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51826: Implement `toString` on lazy modules.

org.apache.aurora.scheduler.http.api.security.IniShiroRealmModule])` Diffs - src/main/java/org/apache/aurora/scheduler/app/MoreModules.java d5f96543d1068bf30b9d173a247c2806faf35578 Diff: https://reviews.apache.org/r/51826/diff/ Testing --- Thanks, Zameer Manji

Review Request 51826: Implement `toString` on lazy modules.

/scheduler/app/MoreModules.java d5f96543d1068bf30b9d173a247c2806faf35578 Diff: https://reviews.apache.org/r/51826/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

ent command and initializing both > > values in this changelist? Otherwise, there is a risk of cutting a release > > in between and delaying removal by extra release (until both client and > > scheduler are dual writing/reading). > > Zameer Manji wrote: > We can&#x

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

/test_api.py 7a0797d5402e931006d4f215e2d9c0dbbd113257 Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

ent command and initializing both > > values in this changelist? Otherwise, there is a risk of cutting a release > > in between and delaying removal by extra release (until both client and > > scheduler are dual writing/reading). > > Zameer Manji wrote: > We can&#x

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

eply, visit: https://reviews.apache.org/r/51712/#review148565 ------- On Sept. 12, 2016, 12:39 p.m., Zameer Manji wrote: > > --- > This is an automatically g

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

outstanding feedback items. Once those are complete, please ask a comitter to land this patch for you. Thanks for your contribution! - Zameer Manji On Sept. 12, 2016, 10:49 a.m., Karthik Anantha Padmanabhan wrote: > > --- > T

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

sting --- Thanks, Zameer Manji

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

> On Sept. 12, 2016, 11:06 a.m., Zameer Manji wrote: > > docs/reference/scheduler-configuration.md, line 205 > > <https://reviews.apache.org/r/51807/diff/1/?file=1496736#file1496736line205> > > > > As an aside, could you file a ticket to clean up the def

Re: Review Request 51807: Introduce a flag to treat RAM as a revocable resources

tps://reviews.apache.org/r/51807/#comment215987> As an aside, could you file a ticket to clean up the default here? Seems useless ATM. - Zameer Manji On Sept. 12, 2016, 6:38 a.m., Stephan Erb wrote: > > --- > This is a

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148539 --- Bumping this for visability. - Zameer Manji On Sept. 8, 2016

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- Thanks, Zameer Manji

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java (line 1258) <https://reviews.apache.org/r/51662/#comment215776> Please add tests for cases where batch size is unset and when it is 0 and when it is negative. - Zameer Manji On Sept. 8, 2016, 5:0

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java a7d1f74acdfe5f58eb822a4d826e920cad53dced src/test/python/apache/aurora/client/api/test_api.py 7a0797d5402e931006d4f215e2d9c0dbbd113257 Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

this out in the release notes > > ad well? Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148158 -------

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

ng issues. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148208 --- On Sept. 7, 2016, 5:03 p.m., Zameer Manji wrote: > > -

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148120 --- @ReviewBot retry - Zameer Manji On Sept. 7, 2016, 5:03 p.m

Re: Review Request 51536: Modify the watch_secs assertion on scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148118 --- Ship it! Ship It! - Zameer Manji On Sept. 7, 2016, 4:10 p.m

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

deprecation, please pay careful attention to ensure nothing is broken for 0.16.0. - Zameer Manji On Sept. 7, 2016, 5:03 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

929d021a336c6a3438613c9340c84a1096dc9069 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java a7d1f74acdfe5f58eb822a4d826e920cad53dced Diff: https://reviews.apache.org/r/51712/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

reflect the changes here? This has diverged from the initial review. I need the title and message to be updated so I can commit this. - Zameer Manji On Sept. 7, 2016, 3:06 p.m., Kai Huang wrote: > > --- > This is an auto

<    1   2   3   4   5   6   7   8   9   10   >