---
On June 29, 2015, 1:59 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35954
2a2b499905a788eb59f5824bc66b487f91e838f1
Diff: https://reviews.apache.org/r/35954/diff/
Testing
---
./rbt post -o
Thanks,
Zameer Manji
/
Testing
---
./rbt post -o
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35886/#review89411
---
Ship it!
Ship It!
- Zameer Manji
On June 25, 2015, 11:50 a.m
., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/
---
(Updated June 25, 2015, 5:07 p.m.)
Review
---
On June 25, 2015, 5:07 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/
---
(Updated June 25
71b09b1fddc5faa7960ade43929cb57eec3243dd
Diff: https://reviews.apache.org/r/35812/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
38ef412a6d29dfef7b305e00cf44522818303965
Diff: https://reviews.apache.org/r/35812/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
line of the
review?
Also, would you mind adding the testcase you described to the test? This way
regressions can be caught.
- Zameer Manji
On June 22, 2015, 2:39 p.m., Michael Leinartas wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35483/#review88010
---
Ship it!
Ship It!
- Zameer Manji
On June 15, 2015, 5:27 p.m
/UserTaskLauncherTest.java
fe2fc954350b42487151fc820ebad22a41aeb039
Diff: https://reviews.apache.org/r/34967/diff/
Testing
---
./gradlew test -Pq
Thanks,
Zameer Manji
---
On June 2, 2015, 6:11 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34967
/UserTaskLauncherTest.java
fe2fc954350b42487151fc820ebad22a41aeb039
Diff: https://reviews.apache.org/r/34967/diff/
Testing
---
./gradlew test -Pq
Thanks,
Zameer Manji
://reviews.apache.org/r/34967/diff/
Testing
---
./gradlew test -Pq
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34827/#review85789
---
Ship it!
Ship It!
- Zameer Manji
On May 29, 2015, 12:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34733/#review85441
---
Ship it!
Ship It!
- Zameer Manji
On May 27, 2015, 1:52 p.m
things:
1. Remove wfarner from this review as currently he is on vacation. I suggest
adding kevints or jcohen.
2. Assign the ticket linked to this review to yourself and link to this review
in the comments of the ticket.
3. Confirm the e2e tests work with this change.
- Zameer Manji
On May 21
/#comment135666
perhaps we should call `executor.shutdownNow` here?
src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
https://reviews.apache.org/r/34440/#comment135670
How is this related to this diff?
- Zameer Manji
On May 19, 2015, 3:50 p.m., Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34449/#review84428
---
Ship it!
Ship It!
- Zameer Manji
On May 19, 2015, 5:27 p.m
On May 19, 2015, 4:48 p.m., Zameer Manji wrote:
Does it make sense for the reconciler to run in parallel with the GC
executor mechanism? It seems fine to me, but I would like some re-assurance
here.
Maxim Khutornenko wrote:
GC executor is not adding anything when task
/python::
Thanks,
Zameer Manji
On May 10, 2015, 7:53 p.m., Joe Smith wrote:
packaging/rpm/Makefile, line 15
https://reviews.apache.org/r/33778/diff/3/?file=952806#file952806line15
My hunch is we should grab this from either the requirements.txt or the
java dep, vs. specifying it here
+1. We don't need more
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33924/#review83072
---
Ship it!
Ship It!
- Zameer Manji
On May 6, 2015, 6:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review83089
---
Ship it!
Ship It!
- Zameer Manji
On May 8, 2015, 1:57 p.m
May 7, 2015, 4:58 p.m.)
Review request for Aurora, Kevin Sweeney and Zameer Manji.
Bugs: AURORA-1239
https://issues.apache.org/jira/browse/AURORA-1239
Repository: aurora
Description
---
Add update watch and update start --watch flag.
Diffs
-
src/main
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33967/#review82965
---
Ship it!
Ship It!
- Zameer Manji
On May 7, 2015, 7:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33920/#review82765
---
Ship it!
Ship It!
- Zameer Manji
On May 6, 2015, 4:06 p.m
/test_file_browser.py
https://reviews.apache.org/r/33366/#comment131262
Please remove `int(x)` and replace it with `x` everywhere in this file.
- Zameer Manji
On April 21, 2015, 11:53 a.m., Bhuvan Arumugam wrote:
---
This is an automatically
TestTaskUtil replaces a lot of
the custom fixtures used in different test cases. I think it counts for a non
trival portion of the diff.
- Zameer Manji
On April 14, 2015, 5:04 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail
/preemptor/PendingTaskProcessor.java
https://reviews.apache.org/r/32597/#comment130285
Don't we want `pendingGroups.remove(group)`?
- Zameer Manji
On April 15, 2015, 6:39 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated
78bae5bb6d254d014e35be0b828497f1509d80bd
Diff: https://reviews.apache.org/r/32993/diff/
Testing
---
./pants --print-exception-stacktrace test.pytest --no-fast src/test/python/::
Thanks,
Zameer Manji
701 - 731 of 731 matches
Mail list logo
