[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7388 ) Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7388 ) Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7388 ) Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-03 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 3: (2 comments) The build has run

[Impala-ASF-CR] IMPALA-6355: fix overflow DCHECK in decimal mod

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8929 ) Change subject: IMPALA-6355: fix overflow DCHECK in decimal mod .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-01-03 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8936 Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. IMPALA-3833: Fix invalid data handling in

[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 ) Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8854 ) Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' .. IMPALA-6295: Fix mix/max handling of 'nan' and

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-03 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 1: (1 comment) fix looks good to me. just a small

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 2: (1 comment) I didn't take a close look at the code

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 1: Code-Review+1 Fix makes sense to me. Not sure if there

[Impala-ASF-CR] IMPALA-6348: Redact only sensitive fields in runtime profiles

2018-01-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8934 Change subject: IMPALA-6348: Redact only sensitive fields in runtime profiles .. IMPALA-6348: Redact only sensitive fields in

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 1: Yeah that would help. Bikram and I thought about

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 1: Meta comment: if we have lock ranking to enforce lock

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8933 Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. IMPALA-6362: avoid Reservation/MemTracker deadlock Avoid the

[Impala-ASF-CR] IMPALA-6355: fix overflow DCHECK in decimal mod

2018-01-03 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8929 ) Change subject: IMPALA-6355: fix overflow DCHECK in decimal mod .. Patch Set 1: Code-Review+2 I feel comfortable giving +2 here

[Impala-ASF-CR] IMPALA-6355: fix overflow DCHECK in decimal mod

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8929 ) Change subject: IMPALA-6355: fix overflow DCHECK in decimal mod .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6355: fix overflow DCHECK in decimal mod

2018-01-03 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8929 ) Change subject: IMPALA-6355: fix overflow DCHECK in decimal mod .. Patch Set 1: Code-Review+1 (1 comment)

[native-toolchain-CR] Bump LLVM to 5.0.0

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8932 ) Change subject: Bump LLVM to 5.0.0 .. Patch Set 1: Code-Review+2 Looks good, I think we can wait until the Impala change is ready to

[native-toolchain-CR] Bump LLVM to 5.0.0

2018-01-03 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8932 Change subject: Bump LLVM to 5.0.0 .. Bump LLVM to 5.0.0 Testing: Was able to build on all supported OSes. Also got Impala to build

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 19: Build failed due to failed test: 21:45:15 ] FAIL

[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 ) Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 19: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8852 ) Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. IMPALA-6318: Adjustment for hanging

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 ) Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6355: fix overflow DCHECK in decimal mod

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8929 ) Change subject: IMPALA-6355: fix overflow DCHECK in decimal mod .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-03 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. IMPALA-4323: "SET ROW FORMAT" option added to

[Impala-ASF-CR] IMPALA-6355: fix overflow DCHECK in decimal mod

2018-01-03 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8929 ) Change subject: IMPALA-6355: fix overflow DCHECK in decimal mod .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-01-03 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#16). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

[Impala-ASF-CR] IMPALA-5052: Read and write signed integer logical types in Parquet

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8548 ) Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet .. Patch Set 1: Ping? -- To view, visit

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: The backport for KUDU-2228 is merged now. -- To

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 19: Build started:

[Impala-ASF-CR] IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8861 ) Change subject: IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be a

[Impala-ASF-CR] IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8861 ) Change subject: IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be a

[Impala-ASF-CR] IMPALA-3651: Adds murmur hash() built-in function

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8893 ) Change subject: IMPALA-3651: Adds murmur_hash() built-in function .. Patch Set 2: (3 comments) Looks good, just a few minor requests.

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 ) Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 ) Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 ) Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. Patch Set 5: Code-Review+1 Thank Mansi. I'll

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-03 Thread Manaswini Maharana (Code Review)
Manaswini Maharana has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. IMPALA-6296: Avoid crash caused by DCHECK in

[Impala-ASF-CR] Added the "SET ROW FORMAT" option to the "ALTER TABLE" command.

2018-01-03 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: Added the "SET ROW FORMAT" option to the "ALTER TABLE" command. .. Patch Set 1: (11 comments)

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. KUDU-2228: Make Messenger options configurable

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2018-01-03 Thread Zoltan Borok-Nagy (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8490 to look at the new patch set (#19). Change subject: IMPALA-2248: Make

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2018-01-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 18: (3 comments) Thanks!

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2018-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 3: Build started: