[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 7: Code-Review+2 Carrying +2. -- To view, visit

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 7: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 4: Build Succes

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-25 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. Patch Set 2: Code-Review+

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-25 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. IMPALA-7710: test_owner_privileges_wit

[Impala-ASF-CR] IMPALA-7662: fix error race when scanner open fails

2018-10-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11596 ) Change subject: IMPALA-7662: fix error race when scanner open fails .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-7662: fix error race when scanner open fails

2018-10-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11596 ) Change subject: IMPALA-7662: fix error race when scanner open fails .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] [DOCS] 2 Typos fixed in NVL2 examples

2018-10-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11795 ) Change subject: [DOCS] 2 Typos fixed in NVL2 examples .. [DOCS] 2 Typos fixed in NVL2 examples Change-Id: Ib3ac978398eb3de1877e3

[Impala-ASF-CR] [DOCS] 2 Typos fixed in NVL2 examples

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11795 ) Change subject: [DOCS] 2 Typos fixed in NVL2 examples .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] [DOCS] 2 Typos fixed in NVL2 examples

2018-10-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11795 ) Change subject: [DOCS] 2 Typos fixed in NVL2 examples .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1

[Impala-ASF-CR] [DOCS] 2 Typos fixed in NVL2 examples

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11795 ) Change subject: [DOCS] 2 Typos fixed in NVL2 examples .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-

[Impala-ASF-CR] [DOCS] 2 Typos fixed in NVL2 examples

2018-10-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11795 Change subject: [DOCS] 2 Typos fixed in NVL2 examples .. [DOCS] 2 Typos fixed in NVL2 examples Change-Id: Ib3ac978398eb3de1877e3cd26f662a

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. IMPALA-7714: remove unsafe code from signal handlers I

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache

2018-10-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11688 ) Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache .. Patch Set 1: (1 comment) http://g

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 6: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 6: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 6: Should there also be an end-to-end test for this

[Impala-ASF-CR] test-with-docker: add --env option to pass through env variables

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11730 ) Change subject: test-with-docker: add --env option to pass through env variables .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] test-with-docker: add --env option to pass through env variables

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11730 ) Change subject: test-with-docker: add --env option to pass through env variables .. test-with-docker: add --env option

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache

2018-10-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11688 ) Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache .. Patch Set 1: (2 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 ) Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache

2018-10-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11688 ) Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache .. Patch Set 1: Hey Todd, you asked for this f

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. Patch Set 2: B

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-25 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 6: Code-Review+2 (2 comments) http

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. IMPALA-7760: Privilege ver

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. Patch Set 1: B

[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 ) Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function .. Patch Set 1: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11794 Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. IMPALA-7760: Privilege ve

[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function

2018-10-25 Thread Greg Rahn (Code Review)
Greg Rahn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11793 Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function .. IMPALA-7759: Add Levenshtein edit distance built-in function

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: Hit IMPALA-7523 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 6: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. IMPALA-7351: Add estimates to Exchange node Added rough

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 3: (1 comment) http://

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 6: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: Verified-1 Build failed: https://jenkins.

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 3: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 6: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 6: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Philip Zeyliger (Code Review)
Hello Quanlong Huang, Laszlo Gaal, Jim Apple, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11731 to look at the new patch set (#6). Change subject: IMPALA-7698: Add centos support to bootstrap_system

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 5: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] test-with-docker: add --env option to pass through env variables

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11730 ) Change subject: test-with-docker: add --env option to pass through env variables .. Patch Set 4: Build started: https://jenkin

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 3: Build Succes

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Code-Review+1 Thanks! I've found a few more additions, many around the use of Eclipse.

[Impala-ASF-CR] IMPALA-7758: Fix LOCATION clause when creating chars formats *

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11789 ) Change subject: IMPALA-7758: Fix LOCATION clause when creating chars_formats_* .. Patch Set 1: Build Successful https://jenki

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 6: https://jenkins.impala.io/job/ubuntu-16.04-fro

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 4: (12 comments) Thanks everyone for the comments.

[Impala-ASF-CR] IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11790 ) Change subject: IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog .. Patch Set 1: Verified+1 Build

[Impala-ASF-CR] IMPALA-7758: Fix LOCATION clause when creating chars formats *

2018-10-25 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11789 ) Change subject: IMPALA-7758: Fix LOCATION clause when creating chars_formats_* .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] test-with-docker: allow built images to be used with "docker run" easily.

2018-10-25 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/11781 ) Change subject: test-with-docker: allow built images to be used with "docker run" easily. .. Patch Set 1: Code-Review+1 -- To view, vi

[Impala-ASF-CR] IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11790 ) Change subject: IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog .. Patch Set 1: Build Started ht

[Impala-ASF-CR] IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog

2018-10-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11790 Change subject: IMPALA-7743: [DOCS] A new option to load incremental statistics from catalog .. IMPALA-7743: [DOCS] A new option to load

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-25 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. IMPALA-7710: test_owner_privileges_wit

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-25 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 6: > Patch Set 6: > > The test failures look l

[Impala-ASF-CR] IMPALA-7758: Fix LOCATION clause when creating chars formats *

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11789 ) Change subject: IMPALA-7758: Fix LOCATION clause when creating chars_formats_* .. Patch Set 1: Code-Review+1 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7758: Fix LOCATION clause when creating chars formats *

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11789 ) Change subject: IMPALA-7758: Fix LOCATION clause when creating chars_formats_* .. Patch Set 1: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Code-Review+1 Thanks for doing this! LGTM. -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Tim Armstrong (Code Review)
Hello Fredy Wijaya, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11787 to look at the new patch set (#3). Change subject: Update .gitignore .. Update .gitignore A few unversioned artifa

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 2: I think I addressed the ones you mentioned. I don't use some of those IDEs - intell

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Tim Armstrong (Code Review)
Hello Fredy Wijaya, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11787 to look at the new patch set (#2). Change subject: Update .gitignore .. Update .gitignore A few unversioned artifa

[Impala-ASF-CR] IMPALA-7758: Fix LOCATION clause when creating chars formats *

2018-10-25 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11789 Change subject: IMPALA-7758: Fix LOCATION clause when creating chars_formats_* .. IMPALA-7758: Fix LOCATION clause when creating chars_for

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] test-with-docker: allow built images to be used with "docker run" easily.

2018-10-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11781 ) Change subject: test-with-docker: allow built images to be used with "docker run" easily. .. Patch Set 1: Code-Review+1 LGTM. -- To

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 1: We need to ignore more. These are files that I think should also be ignored. $IMPALA

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 5: Verified-1 Build failed: https://jenkins.

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 2: Code-Review+1 Vuk, ca

[Impala-ASF-CR] test-with-docker: add --env option to pass through env variables

2018-10-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11730 ) Change subject: test-with-docker: add --env option to pass through env variables .. Patch Set 4: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11787 Change subject: Update .gitignore .. Update .gitignore A few unversioned artifacts crept in over time without corresponding .gitignore

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 6: Build Successful https://jenkins.impala.io/job/ge

[Impala-ASF-CR] test-with-docker: add --env option to pass through env variables

2018-10-25 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/11730 ) Change subject: test-with-docker: add --env option to pass through env variables .. Patch Set 4: Code-Review+1 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-25 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. IMPALA-7710: test_owner_privileges_wit

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-25 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 2: (1 comment) http://ge

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 4: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 6: Code-Review+2 > Looks like test_explain_level* needs to b

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-25 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11692 to look at the new patch set (#6). Change subject: IMPALA-7351: Add estimates to Exchange node ..

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 5: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: (3 comments) Looks good overall http://ge

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Philip Zeyliger, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11777 to look at the new patch set (#4). Change subject: IMPALA-7714: remove unsafe code from signal handlers

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 5: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 3: Code-Review+2 (1 comment) Just a nit http://gerri

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 5: Looks like test_explain_level* needs to be updated. Maybe

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 3: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 3: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 2: Build Successful https://jenkins.impala.

  1   2   >