[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. IMPALA-7864: Deflake test_replan_limit - Doubles the number

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5200: Count child time for parent's total time

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11791 ) Change subject: IMPALA-5200: Count child time for parent's total time .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 2: Ran into IMPALA-7245. Retrying -- To view, visit

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. IMPALA-7844: HAVING clause cannot support

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 7: Verified+1 -- To view, visit

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 8: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 8: Build Successful

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 8: Build Failed

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2018-12-18 Thread Lars Volker (Code Review)
Hello Michael Ho, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12069 to look at the new patch set (#8). Change subject: IMPALA-7694: Add host resource usage metrics to profile

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2018-12-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 7: (24 comments) Thanks for the reviews, please

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 8: (11 comments)

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 7: (10 comments)

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-18 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12079 to look at the new patch set (#5). Change subject: IMPALA-7968, Part 1: JSON serialization framework

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 8: I fixed the logging and manually tested by setting

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12082 to look at the new patch set (#8). Change subject: IMPALA-7931: fix executor shutdown races

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12102 ) Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. Patch Set 3: Verified+1 -- To

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12102 ) Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. IMPALA-7183: Include

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-5200: Count child time for parent's total time

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11791 ) Change subject: IMPALA-5200: Count child time for parent's total time .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 2: Code-Review+2 Removed debug logging. Carrying +2. --

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Bharath Vissapragada (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12105 to look at the new patch set (#2). Change subject: IMPALA-7864: Deflake test_replan_limit ..

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12108 Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. IMPALA-6521: Patch gflags to

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7931: fix executor shutdown races

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 ) Change subject: IMPALA-7931: fix executor shutdown races .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12102 ) Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 1: Build Successful

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12102 ) Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. Patch Set 3: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12102 ) Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-18 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12102 ) Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7963: Don't underflow uint64 t when time goes backwards

2018-12-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12091 ) Change subject: IMPALA-7963: Don't underflow uint64_t when time goes backwards .. Patch Set 2: Code-Review+2 Carrying +2 -- To

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12102 ) Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. IMPALA-7183: Include remote host when

[Impala-ASF-CR] IMPALA-5200: Count child time for parent's total time

2018-12-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11791 ) Change subject: IMPALA-5200: Count child time for parent's total time .. Patch Set 4: Code-Review+2 Can't reproduce the UBSAN

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Adar Dembo from this change. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Removed reviewer Adar Dembo. -- To view, visit

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-18 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12106 to review the following change. Change subject: Add "network_plane" as part of ConnectionId .. Add

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12107 Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. IMPALA-7213: Use separate network plane

[Impala-ASF-CR] IMPALA-7963: Don't underflow uint64 t when time goes backwards

2018-12-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12091 ) Change subject: IMPALA-7963: Don't underflow uint64_t when time goes backwards .. IMPALA-7963: Don't underflow uint64_t when

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and