[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part of

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/1268

[Impala-ASF-CR] IMPALA-8284. KuduTableSink spends too much CPU in KuduSchema::Column()

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12692 ) Change subject: IMPALA-8284. KuduTableSink spends too much CPU in KuduSchema::Column() .. Patch Set 1: Verified+1 -- To view

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 7: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-6503: Support reading complex types from ORC

2019-03-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12168 ) Change subject: IMPALA-6503: Support reading complex types from ORC .. Patch Set 25: (15 comments) > Patch Set 25: > > (33 comments)

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12680 ) Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. Patch Set 3: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12680 ) Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. Patch Set 4: Code-Review+2 -- To vie

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12680 ) Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. Patch Set 4: Build started: https://j

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. Patch Set 3: (2 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRetr

[Impala-ASF-CR] IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint.

2019-03-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12702 Change subject: IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint. .. IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 7: Code-Review+1 (4 comments) I'll let Paul tak

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. IMPALA-8271: Refactor the use of Thrift enums for query

[Impala-ASF-CR] IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint.

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12702 ) Change subject: IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint. .. Patch Set 1: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. Patch Set 5: (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: (2 comments) My understanding of the math

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. Patch Set 5: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part of

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 8: Code-Review+1 (3 comments) Carry Bharath's +1. Paul,

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. Patch Set 5: Code-Review+1 (1 comment) http://ge

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. IMPALA-8271: Refactor the use of Thrift enums for query

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. Patch Set 6: Code-Review+1 (1 comment) Carry Csaba'

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 8: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. Patch Set 6: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-8014: Revise FK/PK cardinality estimation

2019-03-08 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12535 to look at the new patch set (#5). Change subject: IMPALA-8014: Revise FK/PK cardinality estimation ..

[Impala-ASF-CR] IMPALA-8014: Revise FK/PK cardinality estimation

2019-03-08 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Revise FK/PK cardinality estimation .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12535

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-03-08 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/12672/2/be/

[Impala-ASF-CR] IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint.

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12702 ) Change subject: IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint. .. Patch Set 2: Build started: https://jenkins.impa

[Impala-ASF-CR] IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint.

2019-03-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12702 ) Change subject: IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint. .. Patch Set 1: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-8283. Order of Kudu PRIMARY KEYs can be silently ignored

2019-03-08 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12694 ) Change subject: IMPALA-8283. Order of Kudu PRIMARY KEYs can be silently ignored .. Patch Set 1: Code-Review+2 (1 comment) http://ge

[Impala-ASF-CR] IMPALA-8284. KuduTableSink spends too much CPU in KuduSchema::Column()

2019-03-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12692 ) Change subject: IMPALA-8284. KuduTableSink spends too much CPU in KuduSchema::Column() .. IMPALA-8284. KuduTableSink spends too

[Impala-ASF-CR] IMPALA-8014: Revise FK/PK cardinality estimation

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Revise FK/PK cardinality estimation .. Patch Set 5: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12680 ) Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. IMPALA-8279: Revert IMPALA-665

[Impala-ASF-CR] IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression.

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12680 ) Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint.

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12702 ) Change subject: IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint. .. Patch Set 2: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] [stress] factor out MemBroker into its own file.

2019-03-08 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12687 ) Change subject: [stress] factor out MemBroker into its own file. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint.

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12702 ) Change subject: IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint. .. Patch Set 2: Verified+1 -- To view, visit http:

[Impala-ASF-CR] IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint.

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12702 ) Change subject: IMPALA-8288: avoid overflow causing DCHECK in PrettyPrint. .. IMPALA-8288: avoid overflow causing DCHEC

[Impala-ASF-CR](2.x) IMPALA-6802 (part 1): Clean up authorization tests

2019-03-08 Thread Quanlong Huang (Code Review)
Hello Alex Behm, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12708 to review the following change. Change subject: IMPALA-6802 (part 1): Clean up authorization tests ..

[Impala-ASF-CR](2.x) IMPALA-6802 (part 1): Clean up authorization tests

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12708 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR](2.x) IMPALA-6802 (part 1): Clean up authorization tests

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12708 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. Patch Set 1: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR](2.x) IMPALA-6802 (part 1): Clean up authorization tests

2019-03-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12708 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. Patch Set 1: Hi Fredy, I'm going to pick your patch of COMMENT

[Impala-ASF-CR](2.x) IMPALA-6802 (part 1): Clean up authorization tests

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12708 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. Patch Set 1: Build Successful https://jenkins.impala.io

[Impala-ASF-CR](2.x) IMPALA-6802 (part 1): Clean up authorization tests

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12708 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. Patch Set 1: Code-Review+2 > Patch Set 1: > > Hi Fredy, I'm going

[Impala-ASF-CR](2.x) IMPALA-6802 (part 1): Clean up authorization tests

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12708 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. IMPALA-6802 (part 1): Clean up authorization test

[Impala-ASF-CR](2.x) IMPALA-6802 (part 1): Clean up authorization tests

2019-03-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12708 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. Patch Set 1: Verified+1 -- To view, visit http://gerrit