[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 13: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. IMPALA-7971: Add support for insert events in e

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. Patch S

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 12: Code-Review+1 (2 comments) Than

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 11: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 12: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 11: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. IMPALA-7971: Add support for insert events in e

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. IMPALA-7971: Add support for insert events in e

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 10: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 10: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. IMPALA-7971: Add support for insert events in e

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 10: (3 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12960 ) Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 7: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 7: Build started: https://jenk

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 4: Build Successful ht

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 3: Build Successful ht

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. Patch

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. Patch

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#4). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb ..

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 3: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12960 ) Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 3: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#3). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb ..

[Impala-ASF-CR] IMPALA-8390: clean up test vectors in test cancellation.py

2019-04-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12960 ) Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py .. Patch Set 2: (1 comment) Looks good to me http://gerrit.

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 2: (4 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-11 Thread Bharath Krishna (Code Review)
Bharath Krishna has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. IMPALA-8338

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. Patch

[native-toolchain-CR] Add ORC 1.5.5 to toolchain

2019-04-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12998 Change subject: Add ORC 1.5.5 to toolchain .. Add ORC 1.5.5 to toolchain Testing: Ran the scanner tests on orc/def locally. Change-Id: I

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-11 Thread Bharath Krishna (Code Review)
Bharath Krishna has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. IMPALA-8338 :

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 4: Build Failed https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing locally .. Patch Set 3: Build Successful https://

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing locally .. Patch Set 2: Build Successful https://

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-04-11 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12297 to look at the new patch set (#4). Change subject: IMPALA-8138: Reintroduce rpc debugging options .

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

2019-04-11 Thread David Knupp (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12958 to look at the new patch set (#3). Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing locally ..

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless tetsing locally

2019-04-11 Thread David Knupp (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12958 to look at the new patch set (#2). Change subject: IMPALA-8346: Don't create FE testcase files unless tetsing locally ..

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. Patch Set 4: Verified+1

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. IMPALA-8365: Ad

[Impala-ASF-CR] IMPALA-8363: Fix E2E start with impala log dir

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: Fix E2E start with impala_log_dir .. IMPALA-8363: Fix E2E start with impala_log_dir This

[Impala-ASF-CR] IMPALA-8363: Fix E2E start with impala log dir

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: Fix E2E start with impala_log_dir .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 21: Build Successful https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-11 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 21: Fixed a couple failing e2e tests. -- To view, visit h

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-11 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#21). ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. IMPALA-7368: Add initial support for DATE type DATE values describe a

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 6: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 6: (5 comments) patch looks good to

[native-toolchain-CR] Enable reusing ccache directories.

2019-04-11 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12996 Change subject: Enable reusing ccache directories. .. Enable reusing ccache directories. Commit 2d6d6ba119e2bf303f82dbc3ce07e8120e7e391

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. Patch S

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-11 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: > (3 comments) > > > Another option would be to do a global h

[Impala-ASF-CR] [DOCS] Copy edited impala webui.xml

2019-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12994 ) Change subject: [DOCS] Copy edited impala_webui.xml .. [DOCS] Copy edited impala_webui.xml Change-Id: I076f22977c124a2998e6337e6

[Impala-ASF-CR] IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12985 ) Change subject: IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types .. Patch Set 2: Verified+1 -

[Impala-ASF-CR] [DOCS] Copy edited impala webui.xml

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12994 ) Change subject: [DOCS] Copy edited impala_webui.xml .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types

2019-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12985 ) Change subject: IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types .. Patch Set 2: Nice results! I thin

[Impala-ASF-CR] [DOCS] Copy edited impala webui.xml

2019-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12994 ) Change subject: [DOCS] Copy edited impala_webui.xml .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/129

[Impala-ASF-CR] [DOCS] Copy edited impala webui.xml

2019-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12994 Change subject: [DOCS] Copy edited impala_webui.xml .. [DOCS] Copy edited impala_webui.xml Change-Id: I076f22977c124a2998e6337e615d6b3908

[Impala-ASF-CR] [DOCS] Copy edited impala webui.xml

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12994 ) Change subject: [DOCS] Copy edited impala_webui.xml .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-au

[native-toolchain-CR] POC: IMPALA-7085: Extend CCTZ's interface with get offset()

2019-04-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12992 Change subject: POC: IMPALA-7085: Extend CCTZ's interface with get_offset() .. POC: IMPALA-7085: Extend CCTZ's interface with get_offs

[native-toolchain-CR] POC: IMPALA-7085: Extend CCTZ's interface with get offset()

2019-04-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12992 ) Change subject: POC: IMPALA-7085: Extend CCTZ's interface with get_offset() .. POC: IMPALA-7085: Extend CCTZ's interface with get_offse

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 4: Build Successful https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (3 comments) > Another option would be to do a global hashtable

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 2: (6 comments) Thanks for the patch! http://g

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. Patch Set 3: Build Suc

[Impala-ASF-CR] IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12939 ) Change subject: IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity .. Patch Set 3: Build Successful ht

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-04-11 Thread Yongzhi Chen (Code Review)
Hello Bharath Vissapragada, Anurag Mantripragada, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12940 to look at the new patch set (#4). Change subject: IMPALA-7322: Add storage wait time to profile

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: After sleeping on this patch, had a few more higher-level thoug

[Impala-ASF-CR] IMPALA-8363: Fix E2E start with impala log dir

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: Fix E2E start with impala_log_dir .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8363: Fix E2E start with impala log dir

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: Fix E2E start with impala_log_dir .. Patch Set 3: Build started: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-8363: Fix E2E start with impala log dir

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: Fix E2E start with impala_log_dir .. Patch Set 2: Thanks for the fix. -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-8363: Fix E2E start with impala log dir

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: Fix E2E start with impala_log_dir .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity

2019-04-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12939 ) Change subject: IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity .. Patch Set 3: Changes in patch set 3: * A

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. Patch Set 4: Build sta

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. Patch Set 4: Code-Revie

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. IMPALA-8365: Add test coverage for

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. Patch Set 3: Code-Review+2 Carr

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. Patch Set 3: (1 comment) http:

[Impala-ASF-CR] IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity

2019-04-11 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12939 to look at the new patch set (#3). Change subject: IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity ...

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity

2019-04-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12939 ) Change subject: IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity .. Patch Set 2: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 20: Build Successful https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types

2019-04-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12985 ) Change subject: IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types .. Patch Set 2: (3 comments) http:

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-11 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. IMPALA-7368: Add initial support for DATE type DATE values describe a

[Impala-ASF-CR] IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12985 ) Change subject: IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types .. Patch Set 2: Build Success

[Impala-ASF-CR] IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12985 ) Change subject: IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types .. Patch Set 2: Build started

[Impala-ASF-CR] IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types

2019-04-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12985 ) Change subject: IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types .. Patch Set 2: (11 comments) http:/

[Impala-ASF-CR] IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types

2019-04-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12985 Change subject: IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types .. IMPALA-8381: WIP - Optimize ParquetP

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. IMPALA-7981: Add host disk statistics to profile T

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/g

[Impala-ASF-CR] Initial support for recursive file listing within a partition

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12991 ) Change subject: Initial support for recursive file listing within a partition .. Patch Set 1: Build Successful https://jenkin

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-c

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-veri

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12950/

[Impala-ASF-CR] Initial support for recursive file listing within a partition

2019-04-11 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Anonymous Coward (486), I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12991 to review the following change. Change subject: Initial support for recursive file listing within a partition ..

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Yongzhi Chen, Vihang Karajgaonkar, Anonymous Coward (486), Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12950 to look at the new patch set (#4). Change subject: Refactor file descriptor loading code

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 3: Got a few test failures on the first dryrun due to not properly ha