[Impala-ASF-CR] IMPALA-9680 Fixed compressed inserts failing

2020-05-04 Thread Adam Tamas (Code Review)
Adam Tamas has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15816 ) Change subject: IMPALA-9680 Fixed compressed inserts failing .. IMPALA-9680 Fixed compressed inserts failing Modified the insert testfiles

[Impala-ASF-CR] IMPALA-9680 Fixed compressed inserts failing

2020-05-04 Thread Adam Tamas (Code Review)
Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/15816 ) Change subject: IMPALA-9680 Fixed compressed inserts failing .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/15816/3/te

[Impala-ASF-CR] IMPALA-9680 Fixed compressed inserts failing

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15816 ) Change subject: IMPALA-9680 Fixed compressed inserts failing .. Patch Set 4: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list

2020-05-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15818 to look at the new patch set (#2). Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list

[Impala-ASF-CR] IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 ) Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list .. Patch Set 2: (4 comments

[Impala-ASF-CR] IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list

2020-05-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 ) Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list .. Patch Set 1: (12 comments)

[Impala-ASF-CR] IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 ) Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list .. Patch Set 3: (4 comments

[Impala-ASF-CR] IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list

2020-05-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15818 to look at the new patch set (#3). Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list

[Impala-ASF-CR] IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list

2020-05-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 ) Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list .. Patch Set 3: PS3 is mostly a

[Impala-ASF-CR] IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 ) Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list .. Patch Set 2: Build Faile

[Impala-ASF-CR] IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 ) Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the valid write id list .. Patch Set 3: Build Faile

[Impala-ASF-CR] Bump Kudu to 389d4f1e1, fix toolchain Python

2020-05-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15845 ) Change subject: Bump Kudu to 389d4f1e1, fix toolchain Python .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-9699: Skip '-1' values when aggregating num null statistics

2020-05-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15835 ) Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics .. Patch Set 5: Code-Review+1 (1 comment) http:

[Impala-ASF-CR] IMPALA-9699: Skip '-1' values when aggregating num null statistics

2020-05-04 Thread Tamas Mate (Code Review)
Hello Sahil Takiar, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15835 to look at the new patch set (#6). Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics .

[Impala-ASF-CR] IMPALA-9699: Skip '-1' values when aggregating num null statistics

2020-05-04 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15835 ) Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics .. Patch Set 5: (1 comment) Thank you Csaba. Fixed.

[Impala-ASF-CR] IMPALA-9688: Support create iceberg table by impala

2020-05-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15797 ) Change subject: IMPALA-9688: Support create iceberg table by impala .. Patch Set 11: (12 comments) Thank you for working on this.

[Impala-ASF-CR] IMPALA-9597: Eliminate redundant Ranger audits when a query involves column masking

2020-05-04 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15854 Change subject: IMPALA-9597: Eliminate redundant Ranger audits when a query involves column masking .. IMPALA-9597: Eliminate redundant R

[Impala-ASF-CR] IMPALA-9699: Skip '-1' values when aggregating num null statistics

2020-05-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15835 ) Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics .. Patch Set 6: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] Bump test-with-docker test concurrency for large instances

2020-05-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15834 ) Change subject: Bump test-with-docker test concurrency for large instances .. Patch Set 1: Code-Review+2 This makes sense to me. --

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15821 to look at the new patch set (#11). Change subject: IMPALA-9380: async query unregistration

[Impala-ASF-CR] IMPALA-9597: Eliminate redundant Ranger audits when a query involves column masking

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15854 ) Change subject: IMPALA-9597: Eliminate redundant Ranger audits when a query involves column masking .. Patch Set 1: Build Suc

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/158

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 11: I rebased back onto master -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-9699: Skip '-1' values when aggregating num null statistics

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15835 ) Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics .. Patch Set 7: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9699: Skip '-1' values when aggregating num null statistics

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15835 ) Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics .. Patch Set 7: Build started: https://jen

[Impala-ASF-CR] Add link to quickstart container from README

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15847 ) Change subject: Add link to quickstart container from README .. Patch Set 1: I guess the link from the README could be construed as en

[Impala-ASF-CR] Add link to quickstart container from README

2020-05-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15847 ) Change subject: Add link to quickstart container from README .. Patch Set 1: Code-Review+1 Interesting. I had assumed there was no issue

[Impala-ASF-CR] [WIP]IMPALA-9645 Port LLVM codegen to adapt aarch64

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 ) Change subject: [WIP]IMPALA-9645 Port LLVM codegen to adapt aarch64 .. Patch Set 5: Let me know when it's a non-WIP, I can do a full r

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 ) Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64 .. Patch Set 4: (1 comment) SOrry for the slow turnarou

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 11: (8 comments) initial comments, have to go to a meeting, but w

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15821 to look at the new patch set (#12). Change subject: IMPALA-9380: async query unregistration

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 11: (12 comments) http://gerrit.cloudera.org:8080/#/c/15821/11//

[Impala-ASF-CR] IMPALA-9716: Add jitter to the exponential backoff in status reporting

2020-05-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15857 Change subject: IMPALA-9716: Add jitter to the exponential backoff in status reporting .. IMPALA-9716: Add jitter to the expon

[Impala-ASF-CR] IMPALA-9716: Add jitter to the exponential backoff in status reporting

2020-05-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/15857 ) Change subject: IMPALA-9716: Add jitter to the exponential backoff in status reporting .. Abandoned -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 11: (4 comments) few more nits, generally lgtm http://gerrit.clo

[Impala-ASF-CR] IMPALA-9716: Add jitter to the exponential backoff in status reporting

2020-05-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15860 Change subject: IMPALA-9716: Add jitter to the exponential backoff in status reporting .. IMPALA-9716: Add jitter to the expon

[Impala-ASF-CR] IMPALA-9716: Add jitter to the exponential backoff in status reporting

2020-05-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15860 ) Change subject: IMPALA-9716: Add jitter to the exponential backoff in status reporting .. Patch Set 1: (1 comment) http://g

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-04 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15859 Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 .. IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 Needed for python 3 compatibility.

[Impala-ASF-CR] IMPALA-9721: Fix minor python2/3 syntax regression

2020-05-04 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15856 Change subject: IMPALA-9721: Fix minor python2/3 syntax regression .. IMPALA-9721: Fix minor python2/3 syntax regression A minor syntax e

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources

2020-05-04 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15855 Change subject: IMPALA-9718: Delete pkg_resources .. IMPALA-9718: Delete pkg_resources This file was originally copied here in 2013 becau

[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1

2020-05-04 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15858 Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 .. IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 This is needed for python3 com

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15821 to look at the new patch set (#13). Change subject: IMPALA-9380: async query unregistration

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/15821/11/be

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15855 ) Change subject: IMPALA-9718: Delete pkg_resources .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-

[Impala-ASF-CR] IMPALA-9716: Add jitter to the exponential backoff in status reporting

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15860 ) Change subject: IMPALA-9716: Add jitter to the exponential backoff in status reporting .. Patch Set 1: Build Successful http

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-05-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 9: (17 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-8205: Support number of true and false statistics for boolean column

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14666 ) Change subject: IMPALA-8205: Support number of true and false statistics for boolean column .. Patch Set 10: Build started: h

[Impala-ASF-CR] IMPALA-8205: Support number of true and false statistics for boolean column

2020-05-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14666 ) Change subject: IMPALA-8205: Support number of true and false statistics for boolean column .. Patch Set 10: Kicked off the pre-commit

[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 ) Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15859 ) Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf

2020-05-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15822 ) Change subject: IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 13: Build Successful https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-9721: Fix minor python2/3 syntax regression

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15856 ) Change subject: IMPALA-9721: Fix minor python2/3 syntax regression .. Patch Set 1: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 13: (5 comments) With this, I think the cancel rpc from the deb

[Impala-ASF-CR] IMPALA-9716: Add jitter to the exponential backoff in status reporting

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15860 ) Change subject: IMPALA-9716: Add jitter to the exponential backoff in status reporting .. Patch Set 1: (2 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-9721: Fix minor python2/3 syntax regression

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15856 ) Change subject: IMPALA-9721: Fix minor python2/3 syntax regression .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-6984: coordinator cancels backends on EOS

2020-05-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15840 ) Change subject: IMPALA-6984: coordinator cancels backends on EOS .. Patch Set 3: (5 comments) still trying to understand the code here

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15821 to look at the new patch set (#14). Change subject: IMPALA-9380: async query unregistration

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 14: (5 comments) I missed your top-level comment, need to look a

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 14: I don't see the behaviour change - when i cancel a second tim

[Impala-ASF-CR] Ban netty

2020-05-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/15837 ) Change subject: Ban netty .. Abandoned Merged separately -- To view, visit http://gerrit.cloudera.org:8080/15837 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 14: Build Successful https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-9365: Disable acid-negative.test on non-HDFS filesystems

2020-05-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15862 Change subject: IMPALA-9365: Disable acid-negative.test on non-HDFS filesystems .. IMPALA-9365: Disable acid-negative.test on non-HDFS fi

[Impala-ASF-CR] IMPALA-6984: coordinator cancels backends on EOS

2020-05-04 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15840 to look at the new patch set (#4). Change subject: IMPALA-6984: coordinator cancels backends on EOS .

[Impala-ASF-CR] IMPALA-6984: coordinator cancels backends on EOS

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15840 ) Change subject: IMPALA-6984: coordinator cancels backends on EOS .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/158

[Impala-ASF-CR] IMPALA-9365: Disable acid-negative.test on non-HDFS filesystems

2020-05-04 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15862 ) Change subject: IMPALA-9365: Disable acid-negative.test on non-HDFS filesystems .. Patch Set 1: Code-Review+1 Thanks for the qu

[Impala-ASF-CR] IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf

2020-05-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15822 ) Change subject: IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf .. Patch Set 4: (5 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf

2020-05-04 Thread Thomas Tauber-Marshall (Code Review)
Hello Sahil Takiar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15822 to look at the new patch set (#4). Change subject: IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf .

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15855 ) Change subject: IMPALA-9718: Delete pkg_resources .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-9365: Disable acid-negative.test on non-HDFS filesystems

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15862 ) Change subject: IMPALA-9365: Disable acid-negative.test on non-HDFS filesystems .. Patch Set 1: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-9365: Disable acid-negative.test on non-HDFS filesystems

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15862 ) Change subject: IMPALA-9365: Disable acid-negative.test on non-HDFS filesystems .. Patch Set 1: Build started: https://jenkins

[Impala-ASF-CR] IMPALA-9721: Fix minor python2/3 syntax regression

2020-05-04 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15856 ) Change subject: IMPALA-9721: Fix minor python2/3 syntax regression .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-9721: Fix minor python2/3 syntax regression

2020-05-04 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15856 ) Change subject: IMPALA-9721: Fix minor python2/3 syntax regression .. IMPALA-9721: Fix minor python2/3 syntax regression A minor

[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 ) Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf

2020-05-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15822 ) Change subject: IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf .. Patch Set 4: Code-Review+2 LGTM. Since this is just re

[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1

2020-05-04 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 ) Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 .. Patch Set 1: > Patch Set 1: Verified-1 > > Build failed: https://jenkins.

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15859 ) Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-6984: coordinator cancels backends on EOS

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15840 ) Change subject: IMPALA-6984: coordinator cancels backends on EOS .. Patch Set 4: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15822 ) Change subject: IMPALA-9692 (part 1): Refactor TBackendDescriptor to protobuf .. Patch Set 4: Build Successful https://jenkin

[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1

2020-05-04 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15858 to look at the new patch set (#2). Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 .. IMPALA-9

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-04 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15859 to look at the new patch set (#3). Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 .. IMPALA-9719

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-04 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15859 to look at the new patch set (#4). Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 .. IMPALA-9719

[Impala-ASF-CR] IMPALA-8205: Support number of true and false statistics for boolean column

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14666 ) Change subject: IMPALA-8205: Support number of true and false statistics for boolean column .. Patch Set 10: Verified-1 Build

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from IMPALA HOME/shell/

2020-05-04 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15855 to look at the new patch set (#4). Change subject: IMPALA-9718: Delete pkg_resources from IMPALA_HOME/shell/ ..

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 11: Build Failed https://jenkins.impala.io/job/gerrit-co

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from IMPALA HOME/shell/

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15855 ) Change subject: IMPALA-9718: Delete pkg_resources from IMPALA_HOME/shell/ .. Patch Set 4: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-9380: async query unregistration

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15821 ) Change subject: IMPALA-9380: async query unregistration .. Patch Set 15: Build started: https://jenkins.impala.io/job/gerrit-v

[Impala-ASF-CR] IMPALA-9712: fix mem consumption of operators above selective scan

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15863 Change subject: IMPALA-9712: fix mem consumption of operators above selective scan .. IMPALA-9712: fix mem consumption of operators abo

[Impala-ASF-CR] IMPALA-9712: fix mem consumption of operators above selective scan

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/15863 ) Change subject: IMPALA-9712: fix mem consumption of operators above selective scan .. Abandoned I need to add a test for this actually.. -- To

[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 ) Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 .. Patch Set 2: Code-Review+2 Checked out the bitarray 1.2.1 release tag a

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15859 ) Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 .. Patch Set 4: (1 comment) Code change looks good to me. I checked the sour

[Impala-ASF-CR] IMPALA-9699: Skip '-1' values when aggregating num null statistics

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15835 ) Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics .. Patch Set 7: Build started: https://jen

[Impala-ASF-CR] IMPALA-9699: Skip '-1' values when aggregating num null statistics

2020-05-04 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15835 ) Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics .. Patch Set 7: Hmm, 5738 stopped without result. Sta

[Impala-ASF-CR] IMPALA-9699: Skip '-1' values when aggregating num null statistics

2020-05-04 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15835 ) Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics .. Patch Set 7: Looks like there was a Jenkins restar

[Impala-ASF-CR] IMPALA-9712: fix mem consumption of operators above selective scan

2020-05-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has restored this change. ( http://gerrit.cloudera.org:8080/15863 ) Change subject: IMPALA-9712: fix mem consumption of operators above selective scan .. Restored -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-9712: fix mem consumption of operators above selective scan

2020-05-04 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15863 to look at the new patch set (#2). Change subject: IMPALA-9712: fix mem consumption of operators above selective scan

[Impala-ASF-CR] IMPALA-9712: fix mem consumption of operators above selective scan

2020-05-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15863 ) Change subject: IMPALA-9712: fix mem consumption of operators above selective scan .. Patch Set 1: Build Successful https://

  1   2   >