[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 19: Build Successful

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. IMPALA-9636: Don't run retried query on the blacklisted

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-14 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: Code-Review+1 (2 comments) I don't feel as strongly about

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 ) Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries .. Patch Set 5: Code-Review+1 (10

[Impala-ASF-CR] IMPALA-8291: Show constraints in DESCRIBE FORMATTED

2020-09-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16428 ) Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. IMPALA-9636: Don't run retried query on the blacklisted

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 17: Code-Review+1 (1 comment) just one

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. IMPALA-9636: Don't run retried query on the blacklisted

[Impala-ASF-CR] IMPALA-8291: Show constraints in DESCRIBE FORMATTED

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16428 ) Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 16: (2 comments)

[Impala-ASF-CR] IMPALA-8291: Show constraints in DESCRIBE FORMATTED

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16428 ) Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 16: (2 comments)

[Impala-ASF-CR] IMPALA-8291: Show constraints in DESCRIBE FORMATTED

2020-09-14 Thread Shant Hovsepian (Code Review)
Hello Quanlong Huang, Vihang Karajgaonkar, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16428 to look at the new patch set (#2). Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 16: (2 comments)

[Impala-ASF-CR] [WIP] MPALA-10075: Reuse unchanged partition instances

2020-09-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16392 ) Change subject: [WIP] MPALA-10075: Reuse unchanged partition instances .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 16: (3 comments)

[Impala-ASF-CR] IMPALA-10154: Fix data race on coord backend id in TSAN build

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16437 ) Change subject: IMPALA-10154: Fix data race on coord_backend_id in TSAN build .. IMPALA-10154: Fix data race on

[Impala-ASF-CR] IMPALA-10154: Fix data race on coord backend id in TSAN build

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16437 ) Change subject: IMPALA-10154: Fix data race on coord_backend_id in TSAN build .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-14 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 4: (2 comments) Thank you both!

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 4: Build Failed

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-14 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. IMPALA-10078: Proper codegen for KuduPartitionExpr Implementing

[Impala-ASF-CR] [DOCS] Fix timezone related section in impala timestamp.xml

2020-09-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16432 ) Change subject: [DOCS] Fix timezone related section in impala_timestamp.xml .. [DOCS] Fix timezone related section in

[Impala-ASF-CR] IMPALA-10154: Fix data race on coord backend id in TSAN build

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16437 ) Change subject: IMPALA-10154: Fix data race on coord_backend_id in TSAN build .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-10154: Fix data race on coord backend id in TSAN build

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16437 ) Change subject: IMPALA-10154: Fix data race on coord_backend_id in TSAN build .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10154: Fix data race on coord backend id in TSAN build

2020-09-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16437 ) Change subject: IMPALA-10154: Fix data race on coord_backend_id in TSAN build .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] [DOCS] Fix timezone related section in impala timestamp.xml

2020-09-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16432 ) Change subject: [DOCS] Fix timezone related section in impala_timestamp.xml .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 3: (3 comments) Great to see this finally removed. I

[Impala-ASF-CR] [DOCS] Fix timezone related section in impala timestamp.xml

2020-09-14 Thread Shajini Thayasingh (Code Review)
Shajini Thayasingh has posted comments on this change. ( http://gerrit.cloudera.org:8080/16432 ) Change subject: [DOCS] Fix timezone related section in impala_timestamp.xml .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] [DOCS] Fix timezone related section in impala timestamp.xml

2020-09-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16432 ) Change subject: [DOCS] Fix timezone related section in impala_timestamp.xml .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Fix timezone related section in impala timestamp.xml

2020-09-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has removed a vote on this change. Change subject: [DOCS] Fix timezone related section in impala_timestamp.xml .. Removed Code-Review+2 by Zoltan Borok-Nagy -- To view, visit

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 1: (8 comments) Thanks for taking care of this

[Impala-ASF-CR] IMPALA-10167: Docs typo for DEFAULT TRANSACTIONAL TYPE

2020-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16447 ) Change subject: IMPALA-10167: Docs typo for DEFAULT_TRANSACTIONAL_TYPE .. IMPALA-10167: Docs typo for

[Impala-ASF-CR] IMPALA-10167: Docs typo for DEFAULT TRANSACTIONAL TYPE

2020-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16447 ) Change subject: IMPALA-10167: Docs typo for DEFAULT_TRANSACTIONAL_TYPE .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10167: Docs typo for DEFAULT TRANSACTIONAL TYPE

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16447 ) Change subject: IMPALA-10167: Docs typo for DEFAULT_TRANSACTIONAL_TYPE .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-10167: Docs typo for DEFAULT TRANSACTIONAL TYPE

2020-09-14 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16447 ) Change subject: IMPALA-10167: Docs typo for DEFAULT_TRANSACTIONAL_TYPE .. Patch Set 1: Small docs typo fix. -- To view, visit

[Impala-ASF-CR] IMPALA-10167: Docs typo for DEFAULT TRANSACTIONAL TYPE

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16447 ) Change subject: IMPALA-10167: Docs typo for DEFAULT_TRANSACTIONAL_TYPE .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-10167: Docs typo for DEFAULT TRANSACTIONAL TYPE

2020-09-14 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16447 Change subject: IMPALA-10167: Docs typo for DEFAULT_TRANSACTIONAL_TYPE .. IMPALA-10167: Docs typo for DEFAULT_TRANSACTIONAL_TYPE Fix

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. IMPALA-9636: Don't run retried query on the blacklisted

[Impala-ASF-CR] [WIP] MPALA-10075: Reuse unchanged partition instances

2020-09-14 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16392 ) Change subject: [WIP] MPALA-10075: Reuse unchanged partition instances .. Patch Set 2: (3 comments) Thanks a lot!

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-14 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 3: (5 comments) Thanks a lot for the explanation.

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-14 Thread wangsheng (Code Review)
wangsheng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16446 Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. IMPALA-10164: Supporting HadoopCatalog for Iceberg table This

[Impala-ASF-CR] [WIP] MPALA-10075: Reuse unchanged partition instances

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16392 ) Change subject: [WIP] MPALA-10075: Reuse unchanged partition instances .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8291: Show constraints in DESCRIBE FORMATTED

2020-09-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16428 ) Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED .. Patch Set 1: Code-Review+1 (1 comment) Will check with David

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. Patch Set 3: Build Failed

[Impala-ASF-CR] [WIP] MPALA-10075: Reuse unchanged partition instances

2020-09-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16392 ) Change subject: [WIP] MPALA-10075: Reuse unchanged partition instances .. Patch Set 2: (3 comments) Thank Qifan's review! Will add

[Impala-ASF-CR] [WIP] MPALA-10075: Reuse unchanged partition instances

2020-09-14 Thread Quanlong Huang (Code Review)
Hello Qifan Chen, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16392 to look at the new patch set (#2). Change subject: [WIP] MPALA-10075: Reuse unchanged partition instances

[Impala-ASF-CR] IMPALA-10078: Proper codegen for KuduPartitionExpr

2020-09-14 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16419 ) Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr .. IMPALA-10078: Proper codegen for KuduPartitionExpr Implementing