[Impala-ASF-CR] IMPALA-10368: Support required/optional property when creating Iceberg table

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16904 ) Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10368: Support required/optional property when creating Iceberg table

2021-01-06 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16904 ) Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table .. IMPALA-10368: Support required/optional prop

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 24: (39 comments) Still going through some of t

[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16926 ) Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController .. IMPALA-10424: Fix race on not_

[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16926 ) Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-10413: fix impalad crashes when canceling the retrying query

2021-01-06 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16911 ) Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query .. Patch Set 10: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-10388: [DOCS] add limitations on mask functions

2021-01-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16861 ) Change subject: IMPALA-10388: [DOCS] add limitations on mask functions .. IMPALA-10388: [DOCS] add limitations on mask functio

[Impala-ASF-CR] IMPALA-10388: [DOCS] add limitations on mask functions

2021-01-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16861 ) Change subject: IMPALA-10388: [DOCS] add limitations on mask functions .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16912 ) Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table .. IMPALA-10412: ConvertToCNFRule can be ap

[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16912 ) Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table .. Patch Set 7: Verified+1 -- To view, visit http

[Impala-ASF-CR] IMPALA-10388: [DOCS] add limitations on mask functions

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16861 ) Change subject: IMPALA-10388: [DOCS] add limitations on mask functions .. Patch Set 3: Verified+1 Build Successful https://je

[Impala-ASF-CR] IMPALA-10388: [DOCS] add limitations on mask functions

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16861 ) Change subject: IMPALA-10388: [DOCS] add limitations on mask functions .. Patch Set 3: Build Started https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-10388: [DOCS] add limitations on mask functions

2021-01-06 Thread Shajini Thayasingh (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16861 to look at the new patch set (#3). Change subject: IMPALA-10388: [DOCS] add limitations on mask functions .

[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16926 ) Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController .. Patch Set 2: Build started: https://j

[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16926 ) Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController .. Patch Set 2: Code-Review+2 -- To vie

[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16912 ) Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table .. Patch Set 7: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table

2021-01-06 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16912 ) Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table .. Patch Set 7: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-10368: Support required/optional property when creating Iceberg table

2021-01-06 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16904 ) Change subject: IMPALA-10368: Support required/optional property when creating Iceberg table .. Patch Set 3: There some problems with Ice

[Impala-ASF-CR] [WIP] IMPALA-5675: Support UTF-8 Varchar and Char

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: [WIP] IMPALA-5675: Support UTF-8 Varchar and Char .. Patch Set 6: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] [WIP] IMPALA-5675: Support UTF-8 Varchar and Char

2021-01-06 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#6). Change subject: [WIP] IMPALA-5675: Support UTF-8 Varchar and Char .. [W

[Impala-ASF-CR] IMPALA-10413: fix impalad crashes when canceling the retrying query

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16911 ) Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query .. Patch Set 10: Build Successful https:

[Impala-ASF-CR] IMPALA-10413: fix impalad crashes when canceling the retrying query

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16911 ) Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query .. Patch Set 9: Build Successful https:/

[Impala-ASF-CR] IMPALA-10413: fix impalad crashes when canceling the retrying query

2021-01-06 Thread Xianqing He (Code Review)
Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/16911 ) Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query .. Patch Set 10: (4 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-10413: fix impalad crashes when canceling the retrying query

2021-01-06 Thread Xianqing He (Code Review)
Xianqing He has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/16911 ) Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query .. IMPALA-10413: fix impalad crashes when canceling t

[Impala-ASF-CR] IMPALA-10413: fix impalad crashes when canceling the retrying query

2021-01-06 Thread Xianqing He (Code Review)
Xianqing He has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/16911 ) Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query .. IMPALA-10413: fix impalad crashes when canceling th

[Impala-ASF-CR] IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16908 ) Change subject: IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions .. Patch Set 7: Verified

[Impala-ASF-CR] [WIP] IMPALA-5675: Support UTF-8 Varchar and Char

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: [WIP] IMPALA-5675: Support UTF-8 Varchar and Char .. Patch Set 5: Build Failed https://jenkins.impala.io/job/

[Impala-ASF-CR] [WIP] IMPALA-5675: Support UTF-8 Varchar and Char

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: [WIP] IMPALA-5675: Support UTF-8 Varchar and Char .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] [WIP] IMPALA-5675: Support UTF-8 Varchar and Char

2021-01-06 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#5). Change subject: [WIP] IMPALA-5675: Support UTF-8 Varchar and Char .. [W

[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table

2021-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16912 ) Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table .. Patch Set 7: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table

2021-01-06 Thread Xiaoqing Gao (Code Review)
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16912 ) Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-10412: ConvertToCNFRule can be applied to view table

2021-01-06 Thread Xiaoqing Gao (Code Review)
Hello Aman Sinha, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16912 to look at the new patch set (#7). Change subject: IMPALA-10412: ConvertToCNFRule can be applied to view table

[Impala-ASF-CR] IMPALA-10377: Improve the accuracy of resource estimation PlanNode does not consider some factors when estimating memory, this will cause a large error rate

2021-01-06 Thread liuyao (Code Review)
liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 ) Change subject: IMPALA-10377: Improve the accuracy of resource estimation PlanNode does not consider some factors when estimating memory, this will cause a large error rate .