[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19319 ) Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest ..

[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19319 ) Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest ..

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 12: Verified-1 Build failed: https://jenkins.impa

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 12: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 12: (3 comments) Hi all, I have addressed Csab

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-06 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19194 to look at the new patch set (#12). Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF ..

[Impala-ASF-CR] IMPALA-11738: Add toolchain libstdc++ to LD LIBRARY PATH for HiveServer2

2022-12-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19276 ) Change subject: IMPALA-11738: Add toolchain libstdc++ to LD_LIBRARY_PATH for HiveServer2 .. IMPALA-11738: Add toolchain libstd

[Impala-ASF-CR] IMPALA-11738: Add toolchain libstdc++ to LD LIBRARY PATH for HiveServer2

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19276 ) Change subject: IMPALA-11738: Add toolchain libstdc++ to LD_LIBRARY_PATH for HiveServer2 .. Patch Set 2: Verified+1 -- To vi

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 6: Code-Review+2 (1 comment) This looks good to me http://g

[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest

2022-12-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19319 ) Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest .. Patch

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 12: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 12: Code-Review+2 Thanks for the fixes, this looks good t

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 12: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 11: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Michael Smith (Code Review)
Hello Yida Wu, Abhishek Rawat, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19251 to look at the new patch set (#12). Change subject: IMPALA-11730: Add support for spilling to Ozone ...

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Michael Smith (Code Review)
Hello Yida Wu, Abhishek Rawat, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19251 to look at the new patch set (#11). Change subject: IMPALA-11730: Add support for spilling to Ozone ...

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 6: Build Successful https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/192

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-06 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19262 to look at the new patch set (#6). Change subject: IMPALA-11736: Copy data between ofs buckets .

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/19262/5/

[Impala-ASF-CR] IMPALA-11584: Enable minicluster tests for Ozone

2022-12-06 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19250 ) Change subject: IMPALA-11584: Enable minicluster tests for Ozone .. IMPALA-11584: Enable minicluster tests for Ozone Enables t

[Impala-ASF-CR] IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18953 ) Change subject: IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table .. Patch Set 12: Verifie

[Impala-ASF-CR] IMPALA-11738: Add toolchain libstdc++ to LD LIBRARY PATH for HiveServer2

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19276 ) Change subject: IMPALA-11738: Add toolchain libstdc++ to LD_LIBRARY_PATH for HiveServer2 .. Patch Set 2: Build started: https

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 10: (2 comments) Overall, this makes sense, just a coupl

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 17: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-06 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 17: Rebased and added one more testcase. -- To view, visit http

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-06 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. IMPALA-11470: Add Cache For Codegen Functions The patch adds supports of the

[Impala-ASF-CR] IMPALA-11584: Enable minicluster tests for Ozone

2022-12-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19250 ) Change subject: IMPALA-11584: Enable minicluster tests for Ozone .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-12-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/19262/5/

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2022-12-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-9487: Add erasure coding policy to SHOW, DESCRIBE

2022-12-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19268 ) Change subject: IMPALA-9487: Add erasure coding policy to SHOW, DESCRIBE .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-9487: Add erasure coding policy to SHOW, DESCRIBE

2022-12-06 Thread Michael Smith (Code Review)
Hello Gergely Fürnstáhl, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19268 to look at the new patch set (#5). Change subject: IMPALA-9487: Add erasure coding policy to SHOW, DESCRIBE .

[Impala-ASF-CR] IMPALA-9487: Add erasure coding policy to SHOW, DESCRIBE

2022-12-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19268 ) Change subject: IMPALA-9487: Add erasure coding policy to SHOW, DESCRIBE .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-10871: (Addendum) use variable substitution for Hive 3 profile

2022-12-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19313 ) Change subject: IMPALA-10871: (Addendum) use variable substitution for Hive 3 profile .. Patch Set 2: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-06 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-11717: Use rapidjson for printing collections

2022-12-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 ) Change subject: IMPALA-11717: Use rapidjson for printing collections .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18953 ) Change subject: IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table .. Patch Set 12: Build

[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18987 ) Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. Patch Set 5: Verifi

[Impala-ASF-CR] IMPALA-11424: Support pushdown non-equi join predicate from OUTER/INNER JOIN to SCANNODE

2022-12-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18731 ) Change subject: IMPALA-11424: Support pushdown non-equi join predicate from OUTER/INNER JOIN to SCANNODE .. Patch Set 15: (2 commen

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. IMPALA-11758: Fixed error detection

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 7: (6 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 14: Verified+1 -- To view, visi

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 5: Code-Review+1 (3 comments) Looks good to me, just some extra clean

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 7: Build Successful htt

[Impala-ASF-CR] IMPALA-11717: Use rapidjson for printing collections

2022-12-06 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 ) Change subject: IMPALA-11717: Use rapidjson for printing collections .. Patch Set 2: Not a problem, I am just wondering. Is

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 7: (4 comments) http://gerrit

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 6: Build Successful htt

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 7: (7 comments) http://

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Csaba Ringhofer (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19304 to look at the new patch set (#7). Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 5: Build Successful htt

[Impala-ASF-CR] IMPALA-11717: Use rapidjson for printing collections

2022-12-06 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 ) Change subject: IMPALA-11717: Use rapidjson for printing collections .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 6: (8 comments) http://gerrit

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Csaba Ringhofer (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19304 to look at the new patch set (#6). Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Csaba Ringhofer (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19304 to look at the new patch set (#5). Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 6: (7 comments) http://

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 5: (7 comments) http://

[Impala-ASF-CR] IMPALA-11717: Use rapidjson for printing collections

2022-12-06 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 ) Change subject: IMPALA-11717: Use rapidjson for printing collections .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] WIP IMPALA-11718: Improve support for Hive Generic UDFs

2022-12-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19177 ) Change subject: WIP IMPALA-11718: Improve support for Hive Generic UDFs .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] WIP IMPALA-11718: Improve support for Hive Generic UDFs

2022-12-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19177 ) Change subject: WIP IMPALA-11718: Improve support for Hive Generic UDFs .. Patch Set 6: (17 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 11: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-11424: Support pushdown non-equi join predicate from OUTER/INNER JOIN to SCANNODE

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18731 ) Change subject: IMPALA-11424: Support pushdown non-equi join predicate from OUTER/INNER JOIN to SCANNODE .. Patch Set 15: Bui

[Impala-ASF-CR] IMPALA-11424: Support pushdown non-equi join predicate from OUTER/INNER JOIN to SCANNODE

2022-12-06 Thread Baike Xia (Code Review)
Baike Xia has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/18731 ) Change subject: IMPALA-11424: Support pushdown non-equi join predicate from OUTER/INNER JOIN to SCANNODE .. IMPALA-11424: Support pushdown

[Impala-ASF-CR] IMPALA-11485: Pushdown LIMIT through UNION ALL and LEFT/RIGHT OUTER JOIN

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18862 ) Change subject: IMPALA-11485: Pushdown LIMIT through UNION ALL and LEFT/RIGHT OUTER JOIN .. Patch Set 8: Build Successful ht

[Impala-ASF-CR] IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18953 ) Change subject: IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table .. Patch Set 12: Build

[Impala-ASF-CR] IMPALA-11485: Pushdown LIMIT through UNION ALL and LEFT/RIGHT OUTER JOIN

2022-12-06 Thread Baike Xia (Code Review)
Baike Xia has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/18862 ) Change subject: IMPALA-11485: Pushdown LIMIT through UNION ALL and LEFT/RIGHT OUTER JOIN .. IMPALA-11485: Pushdown LIMIT through UNION ALL a

[Impala-ASF-CR] IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18953 ) Change subject: IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table .. Patch Set 11: Build

[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18987 ) Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. Patch Set 5: Build

[Impala-ASF-CR] IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table

2022-12-06 Thread Baike Xia (Code Review)
Baike Xia has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/18953 ) Change subject: IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table .. IMPALA-11565: Support IF NOT EXIST

[Impala-ASF-CR] IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table

2022-12-06 Thread Baike Xia (Code Review)
Baike Xia has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/18953 ) Change subject: IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu/iceberg table .. IMPALA-11565: Support IF NOT EXIST

[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up

2022-12-06 Thread Baike Xia (Code Review)
Baike Xia has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18987 ) Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. IMPALA-11564: For Agg/Scan nodes,

[Impala-ASF-CR] IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18987 ) Change subject: IMPALA-11564: For Agg/Scan nodes, increase the Cache of regular expressions to speed up .. Patch Set 5: Build

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 2: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-11717: Use rapidjson for printing collections

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 ) Change subject: IMPALA-11717: Use rapidjson for printing collections .. Patch Set 2: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 2: (3 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2022-12-06 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19322 Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list Currentl

[Impala-ASF-CR] IMPALA-11717: Use rapidjson for printing collections

2022-12-06 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19309 Change subject: IMPALA-11717: Use rapidjson for printing collections .. IMPALA-11717: Use rapidjson for printing collections We have be

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 13: Code-Review+2 LGTM! -- To view

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 14: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 14: Build started: https://jenki

[Impala-ASF-CR] IMPALA-9487: Add erasure coding policy to SHOW, DESCRIBE

2022-12-06 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19268 ) Change subject: IMPALA-9487: Add erasure coding policy to SHOW, DESCRIBE .. Patch Set 4: Code-Review+1 (3 comments) I agree with

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 13: Code-Review+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-11566: Provide SQL parsing capabilities to other applications in the form of jar packages

2022-12-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19023 ) Change subject: IMPALA-11566: Provide SQL parsing capabilities to other applications in the form of jar packages .. Patch Set 4: (6

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-12-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 16: Code-Review+2 (1 comment) Looks great! I am ok with

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 11: (3 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 11: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 11: Hi all, in this patch I changed FunctionNam

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 11: Build started: https://jenkins.im

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has abandoned this change. ( http://gerrit.cloudera.org:8080/19318 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Abandoned Abandon this patch since it's no longer needed. -- To vie

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-06 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19194 to look at the new patch set (#11). Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF ..