[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: Verified-1 Build

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-25 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: > Patch Set 1: > > I'll run a perf-AB-test, as

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: I'll run a perf-AB-test, as this may have

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Patch Set 4: Code-Review-1 -- To view, visit

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Patch Set 4: I don't think this approach is safe.

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has removed Joe McDonnell from this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Removed reviewer Joe McDonnell. -- To

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has uploaded a new patch set (#4) to the change originally created by Bruno Pusztahazi. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar ..

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has uploaded a new patch set (#3) to the change originally created by Bruno Pusztahazi. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar ..

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-12076: Use ZSTD interfaces with reusable context

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19773 ) Change subject: IMPALA-12076: Use ZSTD interfaces with reusable context .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-12387: PartialUpdates is misleading for LOCAL filter

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20397 ) Change subject: IMPALA-12387: PartialUpdates is misleading for LOCAL filter .. IMPALA-12387: PartialUpdates is

[Impala-ASF-CR] IMPALA-12387: PartialUpdates is misleading for LOCAL filter

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20397 ) Change subject: IMPALA-12387: PartialUpdates is misleading for LOCAL filter .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-12076: Use ZSTD interfaces with reusable context

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19773 ) Change subject: IMPALA-12076: Use ZSTD interfaces with reusable context .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-12152: Add query option to wait for events sync up

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20131 ) Change subject: IMPALA-12152: Add query option to wait for events sync up .. Patch Set 12: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12076: Use ZSTD interfaces with reusable context

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19773 ) Change subject: IMPALA-12076: Use ZSTD interfaces with reusable context .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-25 Thread Michael Smith (Code Review)
Hello Daniel Becker, Yida Wu, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20399 to look at the new patch set (#6). Change subject: IMPALA-5081: Add codegen_opt_level query option

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 5: Build Failed

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 4: Build Failed

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-25 Thread Michael Smith (Code Review)
Hello Daniel Becker, Yida Wu, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20399 to look at the new patch set (#5). Change subject: IMPALA-5081: Add codegen_opt_level query option

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-25 Thread Michael Smith (Code Review)
Hello Daniel Becker, Yida Wu, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20399 to look at the new patch set (#4). Change subject: IMPALA-5081: Add codegen_opt_level query option

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-08-25 Thread Michael Smith (Code Review)
Hello Quanlong Huang, Qifan Chen, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20379 to look at the new patch set (#8). Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-12387: PartialUpdates is misleading for LOCAL filter

2023-08-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20397 ) Change subject: IMPALA-12387: PartialUpdates is misleading for LOCAL filter .. Patch Set 2: (1 comment) Thank you for the +2!

[Impala-ASF-CR] IMPALA-12387: PartialUpdates is misleading for LOCAL filter

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20397 ) Change subject: IMPALA-12387: PartialUpdates is misleading for LOCAL filter .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-12387: PartialUpdates is misleading for LOCAL filter

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20397 ) Change subject: IMPALA-12387: PartialUpdates is misleading for LOCAL filter .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12407: Add test table with Iceberg Equality deletes

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20422 ) Change subject: IMPALA-12407: Add test table with Iceberg Equality deletes .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12407: Add test table with Iceberg Equality deletes

2023-08-25 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20422 Change subject: IMPALA-12407: Add test table with Iceberg Equality deletes .. IMPALA-12407: Add test table with Iceberg Equality deletes

[Impala-ASF-CR] IMPALA-12089: Be able to skip pushing down a subset of the predicates

2023-08-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20133 ) Change subject: IMPALA-12089: Be able to skip pushing down a subset of the predicates .. Patch Set 8: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20421 ) Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-25 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-10086: SqlCastException when comparing char with varchar

2023-08-25 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 ) Change subject: IMPALA-10086: SqlCastException when comparing char with varchar .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-25 Thread ttttttz (Code Review)
ttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 ) Change subject: IMPALA-10856: Show client hosts and connections in the web UI .. Patch Set 7: > Patch Set 7: Code-Review+1 Hi, Quanlong!

[Impala-ASF-CR] IMPALA-10798: Initial support for reading JSON files

2023-08-25 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/19699 ) Change subject: IMPALA-10798: Initial support for reading JSON files .. Patch Set 30: Done, the startup flag enable_json_scanner has been

[Impala-ASF-CR] IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20421 ) Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

[Impala-ASF-CR] IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20421 ) Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

[Impala-ASF-CR] IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20421 ) Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

[Impala-ASF-CR] IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

2023-08-25 Thread Gergely Farkas (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20421 to look at the new patch set (#2). Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

[Impala-ASF-CR] IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

2023-08-25 Thread Gergely Farkas (Code Review)
Gergely Farkas has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20421 Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user ..

[Impala-ASF-CR] IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20421 ) Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user