[Impala-ASF-CR] IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles

2023-10-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20439 ) Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles .. Patch Set 4: Code-Review+1 (5 comments)

[Impala-ASF-CR] IMPALA-10120: Add required fields for TGetInfoResp when error.

2023-10-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20344 ) Change subject: IMPALA-10120: Add required fields for TGetInfoResp when error. .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-10120: Add required fields for TGetInfoResp when error.

2023-10-06 Thread Xiang Yang (Code Review)
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20344 ) Change subject: IMPALA-10120: Add required fields for TGetInfoResp when error. .. Patch Set 5: (2 comments) Hi quanlong, thanks for

[Impala-ASF-CR] IMPALA-10120: Add required fields for TGetInfoResp when error.

2023-10-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20344 ) Change subject: IMPALA-10120: Add required fields for TGetInfoResp when error. .. Patch Set 5: (6 comments) > Patch Set 5: > > (1

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 ) Change subject: IMPALA-12485: Remove Python 2 has_key .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] Update version to 4.4.0-SNAPSHOT

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20534 ) Change subject: Update version to 4.4.0-SNAPSHOT .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] Update version to 4.4.0-SNAPSHOT

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20534 ) Change subject: Update version to 4.4.0-SNAPSHOT .. Update version to 4.4.0-SNAPSHOT Change-Id:

[Impala-ASF-CR] IMPALA-11068: Add query option to reduce scanner thread launch.

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 ) Change subject: IMPALA-11068: Add query option to reduce scanner thread launch. .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-11068: Add query option to reduce scanner thread launch.

2023-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 ) Change subject: IMPALA-11068: Add query option to reduce scanner thread launch. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-11068: Add query option to reduce scanner thread launch.

2023-10-06 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Daniel Becker, Joe McDonnell, Csaba Ringhofer, Michael Smith, Wenzhe Zhou, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18126 to look at the new patch set (#7). Change subject: IMPALA-11068:

[Impala-ASF-CR] IMPALA-11068: Add query option to reduce scanner thread launch.

2023-10-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 ) Change subject: IMPALA-11068: Add query option to reduce scanner thread launch. .. Patch Set 6: (1 comment) Just one comment,

[Impala-ASF-CR] IMPALA-12076: Use ZSTD interfaces with reusable context

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19773 ) Change subject: IMPALA-12076: Use ZSTD interfaces with reusable context .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12076: Use ZSTD interfaces with reusable context

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19773 ) Change subject: IMPALA-12076: Use ZSTD interfaces with reusable context .. IMPALA-12076: Use ZSTD interfaces with

[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names

2023-10-06 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20539 ) Change subject: IMPALA-12354: Add architecture to S3 file names .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 ) Change subject: IMPALA-12485: Remove Python 2 has_key .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 ) Change subject: IMPALA-12485: Remove Python 2 has_key .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 ) Change subject: IMPALA-12485: Remove Python 2 has_key .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

2023-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 ) Change subject: IMPALA-12485: Remove Python 2 has_key .. Patch Set 1: Code-Review+2 This looks good to me -- To view, visit

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

2023-10-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 ) Change subject: IMPALA-12485: Remove Python 2 has_key .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Update version to 4.4.0-SNAPSHOT

2023-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20534 ) Change subject: Update version to 4.4.0-SNAPSHOT .. Patch Set 1: Code-Review+2 Looks good to me -- To view, visit

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

2023-10-06 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20541 Change subject: IMPALA-12485: Remove Python 2 has_key .. IMPALA-12485: Remove Python 2 has_key Switch calls to dict#has_key (Python

[Impala-ASF-CR] Update version to 4.4.0-SNAPSHOT

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20534 ) Change subject: Update version to 4.4.0-SNAPSHOT .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Update version to 4.4.0-SNAPSHOT

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20534 ) Change subject: Update version to 4.4.0-SNAPSHOT .. Patch Set 2: Build started:

[native-toolchain-CR] IMPALA-12354: Add architecture to S3 file names

2023-10-06 Thread Michael Smith (Code Review)
Hello Laszlo Gaal, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20539 to look at the new patch set (#3). Change subject: IMPALA-12354: Add architecture to S3 file names .. IMPALA-12354:

[Impala-ASF-CR] IMPALA-12354: Add aarch64 native-toolchain build

2023-10-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20519 ) Change subject: IMPALA-12354: Add aarch64 native-toolchain build .. Patch Set 10: > Patch Set 10: Code-Review+1 > > This is going to

[Impala-ASF-CR] IMPALA-12354: Add aarch64 native-toolchain build

2023-10-06 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20519 ) Change subject: IMPALA-12354: Add aarch64 native-toolchain build .. Patch Set 10: Code-Review+1 This is going to require a first

[Impala-ASF-CR] IMPALA-12076: Use ZSTD interfaces with reusable context

2023-10-06 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19773 ) Change subject: IMPALA-12076: Use ZSTD interfaces with reusable context .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12076: Use ZSTD interfaces with reusable context

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19773 ) Change subject: IMPALA-12076: Use ZSTD interfaces with reusable context .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-12076: Use ZSTD interfaces with reusable context

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19773 ) Change subject: IMPALA-12076: Use ZSTD interfaces with reusable context .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12354: Add aarch64 native-toolchain build

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20519 ) Change subject: IMPALA-12354: Add aarch64 native-toolchain build .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-12354: Add aarch64 native-toolchain build

2023-10-06 Thread Michael Smith (Code Review)
Hello Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20519 to look at the new patch set (#10). Change subject: IMPALA-12354: Add aarch64 native-toolchain build

[Impala-ASF-CR] IMPALA-12354: Add aarch64 native-toolchain build

2023-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20519 ) Change subject: IMPALA-12354: Add aarch64 native-toolchain build .. Patch Set 9: Build Failed

[Impala-ASF-CR] IMPALA-12354: Add aarch64 native-toolchain build

2023-10-06 Thread Michael Smith (Code Review)
Hello Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20519 to look at the new patch set (#9). Change subject: IMPALA-12354: Add aarch64 native-toolchain build

[Impala-ASF-CR] IMPALA-12354: Add aarch64 native-toolchain build

2023-10-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20519 ) Change subject: IMPALA-12354: Add aarch64 native-toolchain build .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline

2023-10-06 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 ) Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline .. Patch Set 18: We need to do

[Impala-ASF-CR] IMPALA-11996: Scanner change for Iceberg metadata querying

2023-10-06 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 ) Change subject: IMPALA-11996: Scanner change for Iceberg metadata querying .. Patch Set 9: (13 comments) Nice patch Tamas! I left