[Impala-ASF-CR] IMPALA-7131: Support external data sources in LocalCatalog mode

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20574 ) Change subject: IMPALA-7131: Support external data sources in LocalCatalog mode .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7131: Support external data sources in LocalCatalog mode

2023-10-18 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20574 ) Change subject: IMPALA-7131: Support external data sources in LocalCatalog mode .. Patch Set 4: (13 comments)

[Impala-ASF-CR] IMPALA-7131: Support external data sources in LocalCatalog mode

2023-10-18 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/20574 ) Change subject: IMPALA-7131: Support external data sources in LocalCatalog mode .. IMPALA-7131: Support external data sources in

[Impala-ASF-CR] IMPALA-12490: Fix tests on ARM

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20557 ) Change subject: IMPALA-12490: Fix tests on ARM .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12499: Deflake test hdfs scanner thread mem scaling

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20593 ) Change subject: IMPALA-12499: Deflake test_hdfs_scanner_thread_mem_scaling .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12499: Deflake test hdfs scanner thread mem scaling

2023-10-18 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20593 Change subject: IMPALA-12499: Deflake test_hdfs_scanner_thread_mem_scaling .. IMPALA-12499: Deflake test_hdfs_scanner_thread_mem_scaling

[Impala-ASF-CR] IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted domain use xff header flag is enabled and no X-Forwarded-For header is re

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20591 ) Change subject: IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted_domain_use_xff_header flag is enabled and no X-Forwarded-For header

[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore

2023-10-18 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. Patch Set 14: (15 comments) A few small things to look at but

[Impala-ASF-CR] IMPALA-12490: Fix tests on ARM

2023-10-18 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20557 ) Change subject: IMPALA-12490: Fix tests on ARM .. Patch Set 5: New ARM run at

[Impala-ASF-CR] IMPALA-12484: Update kudu and libunwind

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20566 ) Change subject: IMPALA-12484: Update kudu and libunwind .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12490: Fix tests on ARM

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20557 ) Change subject: IMPALA-12490: Fix tests on ARM .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-12490: Fix tests on ARM

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20557 ) Change subject: IMPALA-12490: Fix tests on ARM .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-12484: Update kudu and libunwind

2023-10-18 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20566 ) Change subject: IMPALA-12484: Update kudu and libunwind .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12490: Fix tests on ARM

2023-10-18 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20557 to look at the new patch set (#5). Change subject: IMPALA-12490: Fix tests on ARM ..

[Impala-ASF-CR] IMPALA-12484: Update kudu and libunwind

2023-10-18 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20566 to look at the new patch set (#2). Change subject: IMPALA-12484: Update kudu and libunwind

[Impala-ASF-CR] IMPALA-11996: Scanner change for Iceberg metadata querying

2023-10-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 ) Change subject: IMPALA-11996: Scanner change for Iceberg metadata querying .. Patch Set 13: (9 comments) Left some small

[Impala-ASF-CR] IMPALA-12308: DIRECTED distribution mode for V2 Iceberg tables

2023-10-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20548 ) Change subject: IMPALA-12308: DIRECTED distribution mode for V2 Iceberg tables .. Patch Set 4: (22 comments) I don't fully

[Impala-ASF-CR] IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted domain use xff header flag is enabled and no X-Forwarded-For header is re

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20591 ) Change subject: IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted_domain_use_xff_header flag is enabled and no X-Forwarded-For header

[Impala-ASF-CR] IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted domain use xff header flag is enabled and no X-Forwarded-For header is re

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20591 ) Change subject: IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted_domain_use_xff_header flag is enabled and no X-Forwarded-For header

[Impala-ASF-CR] IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted domain use xff header flag is enabled and no X-Forwarded-For header is re

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20591 ) Change subject: IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted_domain_use_xff_header flag is enabled and no X-Forwarded-For header

[Impala-ASF-CR] IMPALA-12478: Invalid length in StringValue::LeastSmallerString()

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20579 ) Change subject: IMPALA-12478: Invalid length in StringValue::LeastSmallerString() .. IMPALA-12478: Invalid length in

[Impala-ASF-CR] IMPALA-12478: Invalid length in StringValue::LeastSmallerString()

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20579 ) Change subject: IMPALA-12478: Invalid length in StringValue::LeastSmallerString() .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 ) Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline .. Patch Set 21: Build

[Impala-ASF-CR] IMPALA-12504: Split graphical query timeline script into es6 modules

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20588 ) Change subject: IMPALA-12504: Split graphical query timeline script into es6 modules .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted domain use xff header flag is enabled and no X-Forwarded-For header is re

2023-10-18 Thread Gergely Farkas (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20591 to look at the new patch set (#2). Change subject: IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the

[Impala-ASF-CR] IMPALA-12415: Implement tests for graphical query timeline in webUI

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20538 ) Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted domain use xff header flag is enabled and no X-Forwarded-For header is re

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20591 ) Change subject: IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted_domain_use_xff_header flag is enabled and no X-Forwarded-For header

[Impala-ASF-CR] IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted domain use xff header flag is enabled and no X-Forwarded-For header is re

2023-10-18 Thread Gergely Farkas (Code Review)
Gergely Farkas has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20591 Change subject: IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted_domain_use_xff_header flag is enabled and no X-Forwarded-For header is

[Impala-ASF-CR] IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline

2023-10-18 Thread Surya Hebbar (Code Review)
Surya Hebbar has uploaded a new patch set (#21). ( http://gerrit.cloudera.org:8080/20355 ) Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline .. IMPALA-12364: Display memory, disk

[Impala-ASF-CR] IMPALA-12504: Split graphical query timeline script into es6 modules

2023-10-18 Thread Surya Hebbar (Code Review)
Surya Hebbar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20588 Change subject: IMPALA-12504: Split graphical query timeline script into es6 modules .. IMPALA-12504: Split graphical query timeline

[Impala-ASF-CR] IMPALA-12415: Implement tests for graphical query timeline in webUI

2023-10-18 Thread Surya Hebbar (Code Review)
Surya Hebbar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20538 ) Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI .. IMPALA-12415: Implement tests for graphical query

[Impala-ASF-CR] IMPALA-12415: Implement tests for graphical query timeline in webUI

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20538 ) Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12308: DIRECTED distribution mode for V2 Iceberg tables

2023-10-18 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20548 ) Change subject: IMPALA-12308: DIRECTED distribution mode for V2 Iceberg tables .. Patch Set 4: (6 comments) Great change Gabor, I left

[Impala-ASF-CR] IMPALA-11853: Fix formatted docs query options CSS

2023-10-18 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20556 ) Change subject: IMPALA-11853: Fix formatted docs query options CSS .. Patch Set 1: Code-Review+2 Thank you for the reviews! -- To

[Impala-ASF-CR] IMPALA-11853: Fix formatted docs query options CSS

2023-10-18 Thread Tamas Mate (Code Review)
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20556 ) Change subject: IMPALA-11853: Fix formatted docs query options CSS .. IMPALA-11853: Fix formatted docs query options CSS The

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-10-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 11: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12478: Invalid length in StringValue::LeastSmallerString()

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20579 ) Change subject: IMPALA-12478: Invalid length in StringValue::LeastSmallerString() .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12478: Invalid length in StringValue::LeastSmallerString()

2023-10-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20579 ) Change subject: IMPALA-12478: Invalid length in StringValue::LeastSmallerString() .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-11853: Fix formatted docs query options CSS

2023-10-18 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20556 ) Change subject: IMPALA-11853: Fix formatted docs query options CSS .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12356: Alter partition event from hive is treated as self event

2023-10-18 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20486 ) Change subject: IMPALA-12356: Alter partition event from hive is treated as self event .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-7131: Support external data sources in LocalCatalog mode

2023-10-18 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20574 ) Change subject: IMPALA-7131: Support external data sources in LocalCatalog mode .. Patch Set 3: (12 comments)