[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-05-05 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. Patch Set 2: Code-Review+2

[Impala-ASF-CR] Add two new performance-related workloads

2020-05-05 Thread David Knupp (Code Review)
David Knupp has abandoned this change. ( http://gerrit.cloudera.org:8080/11559 ) Change subject: Add two new performance-related workloads .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/11559 To unsubscribe,

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-05 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15859 ) Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-05 Thread David Knupp (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15859 to look at the new patch set (#6). Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-05 Thread David Knupp (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15859 to look at the new patch set (#5). Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-05 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15859 ) Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 .. Patch Set 4: (1 comment) > Patch Set 4: > > (1 comment) > > Code change

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from IMPALA HOME/shell/

2020-05-05 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15855 ) Change subject: IMPALA-9718: Delete pkg_resources from IMPALA_HOME/shell/ .. IMPALA-9718: Delete pkg_resources from

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from IMPALA HOME/shell/

2020-05-05 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15855 ) Change subject: IMPALA-9718: Delete pkg_resources from IMPALA_HOME/shell/ .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from IMPALA HOME/shell/

2020-05-04 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15855 to look at the new patch set (#4). Change subject: IMPALA-9718: Delete pkg_resources from IMPALA_HOME/shell/

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-04 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15859 to look at the new patch set (#4). Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 ..

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-04 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15859 to look at the new patch set (#3). Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 ..

[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1

2020-05-04 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15858 to look at the new patch set (#2). Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 ..

[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1

2020-05-04 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 ) Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 .. Patch Set 1: > Patch Set 1: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-9721: Fix minor python2/3 syntax regression

2020-05-04 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15856 ) Change subject: IMPALA-9721: Fix minor python2/3 syntax regression .. IMPALA-9721: Fix minor python2/3 syntax regression A

[Impala-ASF-CR] IMPALA-9721: Fix minor python2/3 syntax regression

2020-05-04 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15856 ) Change subject: IMPALA-9721: Fix minor python2/3 syntax regression .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources

2020-05-04 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15855 Change subject: IMPALA-9718: Delete pkg_resources .. IMPALA-9718: Delete pkg_resources This file was originally copied here in 2013

[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1

2020-05-04 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15858 Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 .. IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1 This is needed for python3

[Impala-ASF-CR] IMPALA-9721: Fix minor python2/3 syntax regression

2020-05-04 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15856 Change subject: IMPALA-9721: Fix minor python2/3 syntax regression .. IMPALA-9721: Fix minor python2/3 syntax regression A minor syntax

[Impala-ASF-CR] IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1

2020-05-04 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15859 Change subject: IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 .. IMPALA-9719: Upgrade sasl-0.1.1 -> 0.2.1 Needed for python 3 compatibility.

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty* from mvn download

2020-05-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty* from mvn download .. Patch Set 7: > Patch Set 7: Code-Review+2 > > Looks good to me

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty* from mvn download

2020-05-01 Thread David Knupp (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15829 to look at the new patch set (#7). Change subject: IMPALA-9648: Exclude/ban netty* from mvn download

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty* from mvn download

2020-05-01 Thread David Knupp (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15829 to look at the new patch set (#6). Change subject: IMPALA-9648: Exclude/ban netty* from mvn download

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty* from mvn download

2020-05-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty* from mvn download .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-05-01 Thread David Knupp (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15829 to look at the new patch set (#5). Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download

[Impala-ASF-CR] IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

2020-05-01 Thread David Knupp (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dinesh Garg, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15796 to look at the new patch set (#8). Change subject: IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

[Impala-ASF-CR] IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

2020-05-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15796 ) Change subject: IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin .. Patch Set 7: > Patch Set 7: > > (1 comment)

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-05-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-05-01 Thread David Knupp (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15829 to look at the new patch set (#4). Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-05-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 3: > Patch Set 3: > > > > Patch Set 3: > > > > > >

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-05-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 3: > Patch Set 3: > > > Patch Set 3: > > > > # with

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 3: > Patch Set 3: > > # with USE_CDP_HIVE=false >

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 3: > Patch Set 3: > > My review bandwidth is limited.

[Impala-ASF-CR] IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

2020-04-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15796 ) Change subject: IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin .. Patch Set 7: > Patch Set 7: > > Running a

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-04-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-04-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks

2020-04-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

2020-04-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15796 ) Change subject: IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

2020-04-29 Thread David Knupp (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dinesh Garg, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15796 to look at the new patch set (#7). Change subject: IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

[Impala-ASF-CR] IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

2020-04-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15796 ) Change subject: IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

2020-04-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15796 ) Change subject: IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

2020-04-29 Thread David Knupp (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dinesh Garg, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15796 to look at the new patch set (#6). Change subject: IMPALA-9649: Exclude shiro* and add to banned dependency maven plugin

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-28 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 3: (1 comment) > Patch Set 3: > > (2 comments)

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-28 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 ) Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. Patch Set 3: (1 comment) > Patch Set 3: > > (1 comment)

[Impala-ASF-CR] IMPALA-9649: Add shiro* to the banned dependency maven plugin

2020-04-28 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15796 ) Change subject: IMPALA-9649: Add shiro* to the banned dependency maven plugin .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-9649: Add shiro* to the banned dependency maven plugin

2020-04-28 Thread David Knupp (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dinesh Garg, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15796 to look at the new patch set (#5). Change subject: IMPALA-9649: Add shiro* to the banned dependency maven plugin

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-28 Thread David Knupp (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15829 to look at the new patch set (#3). Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-28 Thread David Knupp (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15829 to look at the new patch set (#2). Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download

[Impala-ASF-CR] IMPALA-9648: Exclude/ban netty-all from mvn download

2020-04-27 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15829 Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download .. IMPALA-9648: Exclude/ban netty-all from mvn download netty-all

[Impala-ASF-CR] Don't filter maven messages about banned dependencies

2020-04-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15820 ) Change subject: Don't filter maven messages about banned dependencies .. Patch Set 1: Code-Review+2 Great, this very helpful. -- To

[Impala-ASF-CR] Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"

2020-04-27 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15825 ) Change subject: Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download" .. Revert "IMPALA-9648: Exclude

[Impala-ASF-CR] Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"

2020-04-27 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15825 Change subject: Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download" .. Revert "IMPALA-9648: Exclude netty

[Impala-ASF-CR] Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"

2020-04-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15825 ) Change subject: Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download" .. Patch Set 1: Verified+1

[Impala-ASF-CR] Revert "IMPALA-9648: Don't ban netty 3* from fe/pom.xml"

2020-04-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15824 ) Change subject: Revert "IMPALA-9648: Don't ban netty 3* from fe/pom.xml" .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-9648: Don't ban netty 3* from fe/pom.xml"

2020-04-27 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15824 ) Change subject: Revert "IMPALA-9648: Don't ban netty 3* from fe/pom.xml" .. Revert "IMPALA-9648: Don't ban netty 3* from

[Impala-ASF-CR] Revert "IMPALA-9648: Don't ban netty 3* from fe/pom.xml"

2020-04-27 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15824 Change subject: Revert "IMPALA-9648: Don't ban netty 3* from fe/pom.xml" .. Revert "IMPALA-9648: Don't ban netty 3* from fe/pom.xml"

[Impala-ASF-CR] IMPALA-9649: Add shiro* to the banned dependency maven plugin

2020-04-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15796 ) Change subject: IMPALA-9649: Add shiro* to the banned dependency maven plugin .. Patch Set 4: Patch set #4 is just a rebase. -- To

[Impala-ASF-CR] IMPALA-9649: Add shiro* to the banned dependency maven plugin

2020-04-27 Thread David Knupp (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dinesh Garg, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15796 to look at the new patch set (#4). Change subject: IMPALA-9649: Add shiro* to the banned dependency maven plugin

[Impala-ASF-CR] IMPALA-9648: Don't ban netty 3* from fe/pom.xml

2020-04-27 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15819 ) Change subject: IMPALA-9648: Don't ban netty 3* from fe/pom.xml .. IMPALA-9648: Don't ban netty 3* from fe/pom.xml netty-all <

[Impala-ASF-CR] IMPALA-9648: Don't ban netty 3* from fe/pom.xml

2020-04-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15819 ) Change subject: IMPALA-9648: Don't ban netty 3* from fe/pom.xml .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9648: Don't ban netty 3* from fe/pom.xml

2020-04-27 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15819 Change subject: IMPALA-9648: Don't ban netty 3* from fe/pom.xml .. IMPALA-9648: Don't ban netty 3* from fe/pom.xml netty-all < 4.14.46

[Impala-ASF-CR] IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download

2020-04-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15761 ) Change subject: IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download .. Patch Set 7: Code-Review+2 Rebased and

[Impala-ASF-CR] IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download

2020-04-24 Thread David Knupp (Code Review)
Hello Tamas Mate, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15761 to look at the new patch set (#7). Change subject: IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download

[Impala-ASF-CR] IMPALA-9679: Remove some jars from Docker images

2020-04-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15753 ) Change subject: IMPALA-9679: Remove some jars from Docker images .. Patch Set 5: Code-Review+1 This all looks good to me. The only

[Impala-ASF-CR] IMPALA-9648: Exclude netty from hadoop-hdfs mvn download

2020-04-24 Thread David Knupp (Code Review)
Hello Tamas Mate, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15761 to look at the new patch set (#4). Change subject: IMPALA-9648: Exclude netty from hadoop-hdfs mvn download

[Impala-ASF-CR] IMPALA-9648: Exclude netty from hadoop-hdfs mvn download

2020-04-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15761 ) Change subject: IMPALA-9648: Exclude netty from hadoop-hdfs mvn download .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9649: Add shiro* to the banned dependency maven plugin

2020-04-24 Thread David Knupp (Code Review)
Hello Tim Armstrong, Joe McDonnell, Dinesh Garg, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15796 to look at the new patch set (#3). Change subject: IMPALA-9649: Add shiro* to the banned dependency maven plugin

[Impala-ASF-CR] IMPALA-9649: Add shiro* to the banned dependency maven plugin

2020-04-24 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15796 Change subject: IMPALA-9649: Add shiro* to the banned dependency maven plugin .. IMPALA-9649: Add shiro* to the banned dependency maven

[Impala-ASF-CR] IMPALA-9648: Exclude netty from hadoop-hdfs mvn download

2020-04-23 Thread David Knupp (Code Review)
Hello Tamas Mate, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15761 to look at the new patch set (#3). Change subject: IMPALA-9648: Exclude netty from hadoop-hdfs mvn download

[Impala-ASF-CR] IMPALA-9648: Exclude netty from hadoop-hdfs mvn download

2020-04-22 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15761 to look at the new patch set (#2). Change subject: IMPALA-9648: Exclude netty from hadoop-hdfs mvn download

[Impala-ASF-CR] IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

2020-04-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15760 ) Change subject: IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

2020-04-22 Thread David Knupp (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15760 to look at the new patch set (#4). Change subject: IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks

2020-04-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. Patch Set 4: Code-Review+1 (2 comments) Sorry for

[Impala-ASF-CR] IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

2020-04-21 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15760 to look at the new patch set (#3). Change subject: IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

[Impala-ASF-CR] IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

2020-04-21 Thread David Knupp (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15760 to look at the new patch set (#2). Change subject: IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

[Impala-ASF-CR] IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

2020-04-21 Thread David Knupp (Code Review)
David Knupp has removed Joe McDonnell from this change. ( http://gerrit.cloudera.org:8080/15760 ) Change subject: IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml .. Removed reviewer Joe McDonnell. -- To view, visit

[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest

2020-04-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15777 ) Change subject: IMPALA-9681: Fix LdapImpalaShellTest .. Patch Set 1: Sorry about that. I wonder why the pre-commit tests didn't catch

[Impala-ASF-CR] IMPALA-9646: clean up README

2020-04-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15719 ) Change subject: IMPALA-9646: clean up README .. Patch Set 1: Code-Review+2 (1 comment) Thanks for doing this -- I thin this makes

[Impala-ASF-CR] IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

2020-04-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15760 ) Change subject: IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9668: Obey SKIP TOOLCHAIN BOOTSTRAP during virtualenv bootstrap

2020-04-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15759 ) Change subject: IMPALA-9668: Obey SKIP_TOOLCHAIN_BOOTSTRAP during virtualenv bootstrap .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-04-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9648: Exclude netty from hadoop-hdfs mvn download

2020-04-20 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15761 Change subject: IMPALA-9648: Exclude netty from hadoop-hdfs mvn download .. IMPALA-9648: Exclude netty from hadoop-hdfs mvn download

[Impala-ASF-CR] IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

2020-04-20 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15760 Change subject: IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml .. IMPALA-9647: Exclude fluent-hc-4.3.2.jar from fe/pom.xml

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-17 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 9: Code-Review+2 Carrying +2 from

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-17 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. IMPALA-3343, IMPALA-9489: Make impala-shell

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-17 Thread David Knupp (Code Review)
Hello Abhishek Rawat, Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15524 to look at the new patch set (#8). Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 8: Code-Review+2 Carrying +2 after clean rebase -- To

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-16 Thread David Knupp (Code Review)
Hello Abhishek Rawat, Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15524 to look at the new patch set (#7). Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 7: > Patch Set 6: > > (1 comment) >

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-9626: Use Python from the toolchain for Impala

2020-04-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: IMPALA-9626: Use Python from the toolchain for Impala .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9629: Add CentOS 8.1 support to bootstrap system.sh

2020-04-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 ) Change subject: IMPALA-9629: Add CentOS 8.1 support to bootstrap_system.sh .. Patch Set 12: (1 comment) > Patch Set 12: Code-Review+2

[Impala-ASF-CR] IMPALA-9629: Add CentOS 8.1 support to bootstrap system.sh

2020-04-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 ) Change subject: IMPALA-9629: Add CentOS 8.1 support to bootstrap_system.sh .. Patch Set 12: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download

2020-04-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 ) Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download .. Patch Set 2: > Patch Set 2:

[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download

2020-04-13 Thread David Knupp (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15720 to look at the new patch set (#2). Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download

[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download

2020-04-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 ) Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download

2020-04-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15720 ) Change subject: IMPALA-9649: Exclude shiro-core and shiro-crypto-core jars from maven download .. Patch Set 1: (1 comment) > Patch

  1   2   3   4   5   >