[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-17 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/21279 ) Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator .. Patch Set 17: (7 comments)

[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-17 Thread David Rorke (Code Review)
Hello Kurt Deschler, Riza Suminto, Abhishek Rawat, Wenzhe Zhou, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21279 to look at the new patch set (#18). Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode

[Impala-ASF-CR] IMPALA-12988: Calculate an unbounded version of CpuAsk

2024-04-17 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/21277 ) Change subject: IMPALA-12988: Calculate an unbounded version of CpuAsk .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-17 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/21279 ) Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator .. Patch Set 16: (3 comments)

[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-17 Thread David Rorke (Code Review)
Hello Kurt Deschler, Riza Suminto, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21279 to look at the new patch set (#17). Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode and

[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-17 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/21279 ) Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator .. Patch Set 13: (14 comments)

[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-17 Thread David Rorke (Code Review)
Hello Kurt Deschler, Riza Suminto, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21279 to look at the new patch set (#16). Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode and

[Impala-ASF-CR] IMPALA-12988: Calculate an unbounded version of CpuAsk

2024-04-17 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/21277 ) Change subject: IMPALA-12988: Calculate an unbounded version of CpuAsk .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-16 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/21279 ) Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator .. Patch Set 7: (5 comments)

[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-16 Thread David Rorke (Code Review)
Hello Kurt Deschler, Riza Suminto, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21279 to look at the new patch set (#13). Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode and

[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-16 Thread David Rorke (Code Review)
Hello Kurt Deschler, Riza Suminto, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21279 to look at the new patch set (#12). Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode and

[Impala-ASF-CR] IMPALA-12988: Calculate an unbounded version of CpuAsk

2024-04-16 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/21277 ) Change subject: IMPALA-12988: Calculate an unbounded version of CpuAsk .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-09 Thread David Rorke (Code Review)
David Rorke has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21279 ) Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator .. IMPALA-12657: Improve ProcessingCost of

[Impala-ASF-CR] IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator

2024-04-09 Thread David Rorke (Code Review)
David Rorke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21279 Change subject: IMPALA-12657: Improve ProcessingCost of ScanNode and NonGroupingAggregator .. IMPALA-12657: Improve ProcessingCost of

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-31 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-30 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-11904: Data cache support dumping for reloading

2023-03-20 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/19532 ) Change subject: IMPALA-11904: Data cache support dumping for reloading .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-16 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/19628 ) Change subject: IMPALA-12005: Describe executor group set selection in query profile .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-11924: Cap runtime filter NDV with build key NDV

2023-02-16 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/19506 ) Change subject: IMPALA-11924: Cap runtime filter NDV with build key NDV .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-11829 - Fix bug in cardinality estimates related to TABLE NUM ROWS hint

2023-01-14 Thread David Rorke (Code Review)
Hello Fang-Yu Rao, Qifan Chen, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19421 to look at the new patch set (#2). Change subject: IMPALA-11829 - Fix bug in cardinality estimates related to TABLE_NUM_ROWS hint

[Impala-ASF-CR] IMPALA-11829 - Fix bug in cardinality estimates related to TABLE NUM ROWS hint

2023-01-14 Thread David Rorke (Code Review)
David Rorke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19421 Change subject: IMPALA-11829 - Fix bug in cardinality estimates related to TABLE_NUM_ROWS hint .. IMPALA-11829 - Fix bug in cardinality

[Impala-ASF-CR] IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema

2021-02-24 Thread David Rorke (Code Review)
David Rorke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17117 Change subject: IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema .. IMPALA-10547: Restore TPC-DS "reason" table

[Impala-ASF-CR] IMPALA-8291: Show constraints in DESCRIBE FORMATTED

2020-09-16 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16428 ) Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED .. Patch Set 2: Code-Review+1 Checked the constraint definitions in

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-05 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-05 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-06-04 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-04-01 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 9: (2 comments)

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-31 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 8: (1 comment)

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-30 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-24 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.

2020-03-24 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-11 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: > (3 comments) > > > Another option would be to do a global

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread David Rorke (Code Review)
David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (1 comment)