[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14641/7/b

[Impala-ASF-CR] IMPALA-9181: Serialize TQueryCtx once per query

2019-11-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14777 ) Change subject: IMPALA-9181: Serialize TQueryCtx once per query .. Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist

2019-11-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist .. Patch Set 3: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-11-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14641 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/14641/5/

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2019-11-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 23: (1 comment) http://gerrit.cloudera.o

***UNCHECKED*** [Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-11-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 27: Code-Review+2 (19 comments) LGTM. Please addre

[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-11-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.

2019-10-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 2: We usually cherry-pick the K

[Impala-ASF-CR] IMPALA-9116: Work around SASL bug when FQDN is >d characters in Kudu RPC.

2019-10-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 ) Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. .. Patch Set 1: (1 comment) LGTM. Is the pl

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-10-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 25: (26 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-9026: Use resolved IP address for statestore subscriber

2019-10-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14388 ) Change subject: IMPALA-9026: Use resolved IP address for statestore subscriber .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9026: Use resolved IP address for statestore subscriber

2019-10-22 Thread Michael Ho (Code Review)
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14388 to look at the new patch set (#4). Change subject: IMPALA-9026: Use resolved IP address for statestore subscriber ...

[Impala-ASF-CR] IMPALA-9026: Use resolved IP address for statestore subscriber

2019-10-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14388 ) Change subject: IMPALA-9026: Use resolved IP address for statestore subscriber .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9026: Use resolved IP address for statestore subscriber

2019-10-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14388 ) Change subject: IMPALA-9026: Use resolved IP address for statestore subscriber .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9026: Use resolved IP address for statestore subscriber

2019-10-22 Thread Michael Ho (Code Review)
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14388 to look at the new patch set (#3). Change subject: IMPALA-9026: Use resolved IP address for statestore subscriber ...

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-10-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 24: (17 comments) Sorry for the delays in reviews

[Impala-ASF-CR] IMPALA-9026: Use resolved IP address for statestore subscriber

2019-10-08 Thread Michael Ho (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14388 to look at the new patch set (#2). Change subject: IMPALA-9026: Use resolved IP address for statestore subscriber .

[Impala-ASF-CR] IMPALA-9026: Use resolved IP address for statestore subscriber

2019-10-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14388 ) Change subject: IMPALA-9026: Use resolved IP address for statestore subscriber .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9026: Use resolved IP address for statestore subscriber

2019-10-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14388 Change subject: IMPALA-9026: Use resolved IP address for statestore subscriber .. IMPALA-9026: Use resolved IP address for statestore subsc

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3

2019-10-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 ) Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3 .. Patch Set 3: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-8960: Fix test owner privileges::test drop if exists on S3

2019-10-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14334 ) Change subject: IMPALA-8960: Fix test_owner_privileges::test_drop_if_exists on S3 .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests

2019-10-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 ) Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-09-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 24: (6 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-09-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-09-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 22: (10 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8884: track storage read statistics per queue

2019-09-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14242 ) Change subject: IMPALA-8884: track storage read statistics per queue .. Patch Set 1: Code-Review+1 (4 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI

2019-09-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 ) Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI

2019-09-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 ) Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI .. Patch Set 1: Please address the comment about thrift profile

[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI

2019-09-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 ) Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14246/4/te

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14246/1/b

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 2: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 2: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink

2019-09-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 5: Code-Review+2 (3 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 1: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink

2019-09-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/141

[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink

2019-09-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 1: May also want to rebase and address the TODO (i.e. r

[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink

2019-09-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14

[Impala-ASF-CR] IMPALA-5802: use mt scan node for all formats

2019-09-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14171 ) Change subject: IMPALA-5802: use mt scan node for all formats .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-09-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 9: Code-Review+2 (2 comments) http://g

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-09-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 7: (15 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8907: TestResultSpooling.test slow query is flaky

2019-09-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14170 ) Change subject: IMPALA-8907: TestResultSpooling.test_slow_query is flaky .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 5: Code-Review+2 Carry Thomas' +2 -- To view

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-26 Thread Michael Ho (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14101 to look at the new patch set (#5). Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS ...

[Impala-ASF-CR] IMPALA-8819: BufferedPlanRootSink should handle non-default fetch sizes

2019-08-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14129 ) Change subject: IMPALA-8819: BufferedPlanRootSink should handle non-default fetch sizes .. Patch Set 3: Code-Review+1 (3 comments) http

[Impala-ASF-CR] IMPALA-8819: BufferedPlanRootSink should handle non-default fetch sizes

2019-08-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14129 ) Change subject: IMPALA-8819: BufferedPlanRootSink should handle non-default fetch sizes .. Patch Set 2: (7 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache

2019-08-23 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14015 ) Change subject: IMPALA-8691: Query option to disable data cache .. IMPALA-8691: Query option to disable data cache This change ad

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 1: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 4: Code-Review+1 Carrying Sahil's +1 -- To v

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. IMPALA-8845: Cancel receiver's streams on exchange node's E

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS

2019-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 8: Code-Review+1 (1 comment) Not super famil

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-20 Thread Michael Ho (Code Review)
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14101 to look at the new patch set (#3). Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 1: (7 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache

2019-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14015 ) Change subject: IMPALA-8691: Query option to disable data cache .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14015/1

[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache

2019-08-20 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14015 ) Change subject: IMPALA-8691: Query option to disable data cache .. IMPALA-8691: Query option to disable data cache This change adds a query

[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS

2019-08-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 7: (7 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. IMPALA-8845: Cancel receiver's streams on exchange node's E

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14101 Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. IMPALA-8845: Cancel receiver's streams on exchange node's

[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS

2019-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 4: (10 comments) LGTM. Mostly minor comments

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 5: Code-Review+1 (1 comment) I will

[Impala-ASF-CR] IMPALA-8829: [DOCS] Document limitation of parsing "TB" string

2019-08-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14055 ) Change subject: IMPALA-8829: [DOCS] Document limitation of parsing "TB" string .. Patch Set 1: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 3: (3 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache

2019-08-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14015 ) Change subject: IMPALA-8691: Query option to disable data cache .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14015/1/

[Impala-ASF-CR] IMPALA-5149: Provide query profile in JSON format

2019-08-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 ) Change subject: IMPALA-5149: Provide query profile in JSON format .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8781: Fix TestResultSpooling::test multi batches

2019-08-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14022 ) Change subject: IMPALA-8781: Fix TestResultSpooling::test_multi_batches .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5149: Provide query profile in JSON format

2019-08-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 ) Change subject: IMPALA-5149: Provide query profile in JSON format .. Patch Set 13: (14 comments) LGTM. Some more minor nits. The patch c

[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache

2019-08-05 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14015 Change subject: IMPALA-8691: Query option to disable data cache .. IMPALA-8691: Query option to disable data cache This change adds a quer

[Impala-ASF-CR] IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC

2019-08-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC .. Patch Set 12: A quick high level reminder about using sid

[Impala-ASF-CR] IMPALA-5149: Provide query profile in JSON format

2019-08-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 ) Change subject: IMPALA-5149: Provide query profile in JSON format .. Patch Set 12: (9 comments) We don't really enforce any compatibilit

[Impala-ASF-CR] IMPALA-8781: Result spooling tests to cover edge cases and cancellation

2019-08-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13907 ) Change subject: IMPALA-8781: Result spooling tests to cover edge cases and cancellation .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC

2019-08-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC .. Patch Set 11: (6 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-8781: Result spooling tests to cover edge cases and cancellation

2019-07-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13907 ) Change subject: IMPALA-8781: Result spooling tests to cover edge cases and cancellation .. Patch Set 6: (8 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 17: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-8781: Result spooling tests to cover edge cases and cancellation

2019-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13907 ) Change subject: IMPALA-8781: Result spooling tests to cover edge cases and cancellation .. Patch Set 4: (2 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 15: Code-Review+1 (2 comments) N

[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests

2019-07-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 6: Code-Review+2 Nice. -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 11: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 11: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 11: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8339: Add local executor blacklist to coordinators

2019-07-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13868 ) Change subject: IMPALA-8339: Add local executor blacklist to coordinators .. Patch Set 6: Code-Review+1 (3 comments) Not sure if Lars wa

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 12: (2 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 11: (8 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-8339: Add local executor blacklist to coordinators

2019-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13868 ) Change subject: IMPALA-8339: Add local executor blacklist to coordinators .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-5149: Provide query profile in JSON format

2019-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 ) Change subject: IMPALA-5149: Provide query profile in JSON format .. Patch Set 9: (23 comments) http://gerrit.cloudera.org:8080/#/c/1380

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 9: (7 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8339: Add local executor blacklist to coordinators

2019-07-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13868 ) Change subject: IMPALA-8339: Add local executor blacklist to coordinators .. Patch Set 3: (19 comments) Looking good. http://gerrit.clo

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl

2019-07-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl .. Patch Set 3: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl

2019-07-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl .. Patch Set 4: (4 comments) Unifying the RowBat

[Impala-ASF-CR] IMPALA-8656: Add RowBatchQueue interface and BufferedPlanRootSink impl

2019-07-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8656: Add RowBatchQueue interface and BufferedPlanRootSink impl .. Patch Set 4: (3 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8701: [DOCS] Document --idle client poll time s flag

2019-07-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13896 ) Change subject: IMPALA-8701: [DOCS] Document --idle_client_poll_time_s flag .. Patch Set 2: Code-Review+2 -- To view, visit http://gerri

  1   2   3   4   5   6   7   8   9   10   >