[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing create event ids in reloading partitions

2023-07-03 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Sai Hemanth Gantasala, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20145 to look at the new patch set (#6). Change subject: IMPALA-12256: Fix DDLs losing create event ids in reloading partitions

[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing create event ids in reloading partitions

2023-07-03 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Sai Hemanth Gantasala, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20145 to look at the new patch set (#5). Change subject: IMPALA-12256: Fix DDLs losing create event ids in reloading partitions

[Impala-ASF-CR] IMPALA-6876: Fix possible memory leak in CatalogTableMetrics after reset metadata.

2023-07-01 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20096 ) Change subject: IMPALA-6876: Fix possible memory leak in CatalogTableMetrics after reset metadata. .. Patch Set 9: Code-Review+2

[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads

2023-06-30 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 ) Change subject: IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads .. Patch Set 3: (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads

2023-06-30 Thread Quanlong Huang (Code Review)
Hello Sai Hemanth Gantasala, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20145 to look at the new patch set (#4). Change subject: IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads

[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads

2023-06-30 Thread Quanlong Huang (Code Review)
Hello Sai Hemanth Gantasala, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20145 to look at the new patch set (#3). Change subject: IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads

[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads

2023-06-30 Thread Quanlong Huang (Code Review)
Hello Sai Hemanth Gantasala, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20145 to look at the new patch set (#2). Change subject: IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads

[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads

2023-06-30 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20145 Change subject: IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads .. IMPALA-12256: Fix DDLs losing

[Impala-ASF-CR] IMPALA-6876: Fix possible memory leak in CatalogTableMetrics after reset metadata.

2023-06-30 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20096 ) Change subject: IMPALA-6876: Fix possible memory leak in CatalogTableMetrics after reset metadata. .. Patch Set 6: Code-Review+2

[Impala-ASF-CR] IMPALA-12126: fix keywords and builtin function names conflict.

2023-06-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19866 ) Change subject: IMPALA-12126: fix keywords and builtin function names conflict. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-12131: Fix empty partition map in non-partitioned table when file metadata loading fails

2023-06-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 ) Change subject: IMPALA-12131: Fix empty partition map in non-partitioned table when file metadata loading fails .. Patch Set 31:

[Impala-ASF-CR] IMPALA-12131: Fix empty partition map in non-partitioned table when file metadata loading fails

2023-06-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 ) Change subject: IMPALA-12131: Fix empty partition map in non-partitioned table when file metadata loading fails .. Patch Set 28: (1

[Impala-ASF-CR] IMPALA-12131: Fix empty partition map in non-partitioned table when file metadata loading fails

2023-06-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 ) Change subject: IMPALA-12131: Fix empty partition map in non-partitioned table when file metadata loading fails .. Patch Set 27: (2

[Impala-ASF-CR] IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded.

2023-06-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 ) Change subject: IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded. .. Patch

[Impala-ASF-CR] IMPALA-12247: Add unimplemented methods to ModifyStmt

2023-06-27 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20127 ) Change subject: IMPALA-12247: Add unimplemented methods to ModifyStmt .. Patch Set 1: Code-Review+2 Thanks for fixing this so

[Impala-ASF-CR] IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded.

2023-06-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 ) Change subject: IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded. .. Patch

[Impala-ASF-CR] IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded.

2023-06-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 ) Change subject: IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded. .. Patch

[Impala-ASF-CR] IMPALA-12245: Move test display src socket in query cause

2023-06-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20123 ) Change subject: IMPALA-12245: Move test_display_src_socket_in_query_cause .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12245: Move test display src socket in query cause

2023-06-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20123 ) Change subject: IMPALA-12245: Move test_display_src_socket_in_query_cause .. Patch Set 1: Code-Review+2 Thanks for fixing this

[Impala-ASF-CR] IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded.

2023-06-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 ) Change subject: IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded. .. Patch

[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage

2023-06-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19706 ) Change subject: IMPALA-12048: Add query progress to queries webpage .. IMPALA-12048: Add query progress to queries webpage

[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage

2023-06-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 ) Change subject: IMPALA-12048: Add query progress to queries webpage .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12177: Add missing throw statement in unsetPartitionsColStats()

2023-06-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19964 ) Change subject: IMPALA-12177: Add missing throw statement in unsetPartitionsColStats() .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12213: Verify if the table exists in the event processor for reload event

2023-06-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20117 ) Change subject: IMPALA-12213: Verify if the table exists in the event processor for reload event .. Patch Set 1: Code-Review+2 LGTM

[Impala-ASF-CR] IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table

2023-06-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20066 ) Change subject: IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table ..

[Impala-ASF-CR] IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table

2023-06-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has removed a vote on this change. Change subject: IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table .. Removed Verified-1 by Impala Public Jenkins -- To

[Impala-ASF-CR] IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table

2023-06-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20066 ) Change subject: IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table .. Patch Set

[Impala-ASF-CR] IMPALA-11941: Support Java 17 in Impala

2023-06-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19863 ) Change subject: IMPALA-11941: Support Java 17 in Impala .. Patch Set 27: Code-Review+1 (1 comment) Thanks for working on this! Just

[Impala-ASF-CR] IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID

2023-06-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20022 ) Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID .. Patch Set 1: (7

[Impala-ASF-CR] IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table

2023-06-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20066 ) Change subject: IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table .. Patch Set

[Impala-ASF-CR] IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table

2023-06-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20066 ) Change subject: IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table .. Patch Set

[Impala-ASF-CR] IMPALA-12223: Bump thrift to 0.16.0-p5 to fix THRIFT-5716

2023-06-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20107 Change subject: IMPALA-12223: Bump thrift to 0.16.0-p5 to fix THRIFT-5716 .. IMPALA-12223: Bump thrift to 0.16.0-p5 to fix THRIFT-5716

[native-toolchain-CR] IMPALA-12223: Bump thrift to 0.16.0-p5 for THRIFT-5716

2023-06-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20106 ) Change subject: IMPALA-12223: Bump thrift to 0.16.0-p5 for THRIFT-5716 .. IMPALA-12223: Bump thrift to 0.16.0-p5 for

[native-toolchain-CR] IMPALA-12223: Bump thrift to 0.16.0-p5 for THRIFT-5716

2023-06-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20106 ) Change subject: IMPALA-12223: Bump thrift to 0.16.0-p5 for THRIFT-5716 .. Patch Set 1: Thanks for the quick review, Joe! -- To

[native-toolchain-CR] IMPALA-12223: Bump thrift to 0.16.0-p5 for THRIFT-5716

2023-06-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20106 ) Change subject: IMPALA-12223: Bump thrift to 0.16.0-p5 for THRIFT-5716 .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6665: Tag CatalogOp logs with query ids

2023-06-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19926 ) Change subject: IMPALA-6665: Tag CatalogOp logs with query ids .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6665: Tag CatalogOp logs with query ids

2023-06-21 Thread Quanlong Huang (Code Review)
Hello Kurt Deschler, Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19926 to look at the new patch set (#3). Change subject: IMPALA-6665: Tag CatalogOp logs with query ids

[native-toolchain-CR] IMPALA-12223: Bump thrift to 0.16.0-p5 for THRIFT-5716

2023-06-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20106 Change subject: IMPALA-12223: Bump thrift to 0.16.0-p5 for THRIFT-5716 .. IMPALA-12223: Bump thrift to 0.16.0-p5 for THRIFT-5716 This

[Impala-ASF-CR] IMPALA-12131: If a non-partitioned table update catalog fails, invalidate the table.

2023-06-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 ) Change subject: IMPALA-12131: If a non-partitioned table update catalog fails, invalidate the table. .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-10798: Prototype a simple JSON File reader

2023-06-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19699 ) Change subject: IMPALA-10798: Prototype a simple JSON File reader .. Patch Set 16: (5 comments) Thanks for working on this! Add

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

2023-06-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20090 ) Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10 .. Patch Set 1: Thanks for the quick review! -- To view, visit

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

2023-06-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 ) Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown .. Patch Set 17: Code-Review+2

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

2023-06-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 ) Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown .. Patch Set 17: Code-Review+1

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

2023-06-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20090 Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10 .. IMPALA-12128: Bump ORC C++ version to 1.7.9-p10 This bumps the ORC

[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage

2023-06-18 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 ) Change subject: IMPALA-12048: Add query progress to queries webpage .. Patch Set 10: LGTM but there is a weird test failure:

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

2023-06-18 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 ) Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown .. Patch Set 12: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-12171: Optimize delimited output

2023-06-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19894 ) Change subject: IMPALA-12171: Optimize delimited output .. Patch Set 9: Code-Review+1 (1 comment) LGTM. I can bump to +2 if no more

[Impala-ASF-CR] IMPALA-11534: Skip reloading file metadata for some ALTER TABLE events

2023-06-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19838 ) Change subject: IMPALA-11534: Skip reloading file metadata for some ALTER_TABLE events .. Patch Set 14: Code-Review+2 Carrying

[Impala-ASF-CR] IMPALA-11534: Skip reloading file metadata for some ALTER TABLE events

2023-06-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19838 ) Change subject: IMPALA-11534: Skip reloading file metadata for some ALTER_TABLE events .. Patch Set 13: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-11534: Skip reloading file metadata for some ALTER TABLE events

2023-06-13 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19838 ) Change subject: IMPALA-11534: Skip reloading file metadata for some ALTER_TABLE events .. Patch Set 11: (6 comments) LGTM. Just

[Impala-ASF-CR] IMPALA-12204: Fix redundant codegen info added in subplan profiles

2023-06-13 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20037 ) Change subject: IMPALA-12204: Fix redundant codegen info added in subplan profiles .. IMPALA-12204: Fix redundant codegen

[Impala-ASF-CR] IMPALA-12204: Fix redundant codegen info added in subplan profiles

2023-06-12 Thread Quanlong Huang (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20037 to look at the new patch set (#2). Change subject: IMPALA-12204: Fix redundant codegen info added in subplan profiles

[Impala-ASF-CR] IMPALA-12204: Fix redundant codegen info added in subplan profiles

2023-06-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20037 ) Change subject: IMPALA-12204: Fix redundant codegen info added in subplan profiles .. Patch Set 1: Thanks for Csaba's quick review!

[Impala-ASF-CR] IMPALA-12204: Fix redundant codegen info added in subplan profiles

2023-06-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20037 Change subject: IMPALA-12204: Fix redundant codegen info added in subplan profiles .. IMPALA-12204: Fix redundant codegen info added

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

2023-06-07 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 ) Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives .. Patch Set 1: Code-Review+2 Found snappy-devel

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20020 ) Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. Patch Set 3: (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Quanlong Huang (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20020 to look at the new patch set (#4). Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Quanlong Huang (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20020 to look at the new patch set (#3). Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-07 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20020 to look at the new patch set (#2). Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction

[Impala-ASF-CR] IMPALA-12189: updateCatalog should handle failures in createTblTransaction

2023-06-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20020 Change subject: IMPALA-12189: updateCatalog should handle failures in createTblTransaction .. IMPALA-12189: updateCatalog should

[Impala-ASF-CR] IMPALA-10262: RPM/DEB Packaging Support

2023-06-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 ) Change subject: IMPALA-10262: RPM/DEB Packaging Support .. Patch Set 8: (1 comment) Found another issue when building RPM on Redhat

[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage

2023-06-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 ) Change subject: IMPALA-12048: Add query progress to queries webpage .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView

2023-06-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19768 ) Change subject: IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView .. Patch Set 9: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-11534: Skip reloading file metadata for some ALTER TABLE events

2023-06-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19838 ) Change subject: IMPALA-11534: Skip reloading file metadata for some ALTER_TABLE events .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-6665: Tag CatalogOp logs with query ids

2023-06-06 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19926 ) Change subject: IMPALA-6665: Tag CatalogOp logs with query ids .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-12059: Deduplicate and filter warnings from Thrift compilation

2023-06-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19818 ) Change subject: IMPALA-12059: Deduplicate and filter warnings from Thrift compilation .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10262: RPM/DEB Packaging Support

2023-06-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 ) Change subject: IMPALA-10262: RPM/DEB Packaging Support .. Patch Set 8: > For ongoing development / functionality, how do we keep

[Impala-ASF-CR] IMPALA-12059: Deduplicate and filter warnings from Thrift compilation

2023-06-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19818 ) Change subject: IMPALA-12059: Deduplicate and filter warnings from Thrift compilation .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10262: RPM/DEB Packaging Support

2023-06-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 ) Change subject: IMPALA-10262: RPM/DEB Packaging Support .. Patch Set 8: (3 comments) Thank Joe's comments! I found an issue on

[Impala-ASF-CR] IMPALA-10262: RPM/DEB Packaging Support

2023-06-05 Thread Quanlong Huang (Code Review)
Hello Wenzhe Zhou, Joe McDonnell, Impala Public Jenkins, Xiang Yang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18939 to look at the new patch set (#8). Change subject: IMPALA-10262: RPM/DEB Packaging Support

[Impala-ASF-CR] IMPALA-12171: Optimize delimited output

2023-06-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19894 ) Change subject: IMPALA-12171: Optimize delimited output .. Patch Set 6: (4 comments) Thanks for doing this optimization!

[Impala-ASF-CR] IMPALA-11260: (Addendum) Restrict add-opens to Java 9+

2023-06-03 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19939 ) Change subject: IMPALA-11260: (Addendum) Restrict add-opens to Java 9+ .. IMPALA-11260: (Addendum) Restrict add-opens to Java

[Impala-ASF-CR] IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView

2023-06-03 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19768 ) Change subject: IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView .. Patch Set 8: (1 comment) > Patch

[Impala-ASF-CR] IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView

2023-06-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19768 ) Change subject: IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView .. Patch Set 7: Code-Review+2 Carrying

[Impala-ASF-CR] IMPALA-11260: (Addendum) Restrict add-opens to Java 9+

2023-06-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19939 ) Change subject: IMPALA-11260: (Addendum) Restrict add-opens to Java 9+ .. Patch Set 7: Code-Review+2 Carrying +1 from Joe and

[Impala-ASF-CR] IMPALA-11260: (Addendum) Restrict add-opens to Java 9+

2023-05-31 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19939 ) Change subject: IMPALA-11260: (Addendum) Restrict add-opens to Java 9+ .. Patch Set 4: (1 comment) Thanks for fixing this! Just

[native-toolchain-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

2023-05-31 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19934 ) Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10 .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

2023-05-31 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19934 ) Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10 .. IMPALA-12128: Bump ORC C++ version to 1.7.9-p10 This

[Impala-ASF-CR] IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView

2023-05-31 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19768 ) Change subject: IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

2023-05-31 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 ) Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-12170: Fix WebUI test failure due to the new /events page

2023-05-30 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19953 Change subject: IMPALA-12170: Fix WebUI test failure due to the new /events page .. IMPALA-12170: Fix WebUI test failure due to the

[Impala-ASF-CR] IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView

2023-05-30 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19768 ) Change subject: IMPALA-12051: Propagate analytic tuple predicates of outer-joined InlineView .. Patch Set 2: (6 comments) Thanks

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

2023-05-29 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 ) Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui

2023-05-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 ) Change subject: IMPALA-12096: Add process start time and version to backends webui .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6665: Tag CatalogOp logs with query ids

2023-05-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19926 ) Change subject: IMPALA-6665: Tag CatalogOp logs with query ids .. IMPALA-6665: Tag CatalogOp logs with query ids Adds query id in

[native-toolchain-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

2023-05-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19934 Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10 .. IMPALA-12128: Bump ORC C++ version to 1.7.9-p10 This bumps ORC C++

[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui

2023-05-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 ) Change subject: IMPALA-12096: Add process start time and version to backends webui .. Patch Set 5: Code-Review+2 Carry Wenzhe's +1.

[Impala-ASF-CR] IMPALA-11823: Add more items to Impala web UI queries page

2023-05-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19417 ) Change subject: IMPALA-11823: Add more items to Impala web UI queries page .. Patch Set 13: Code-Review+2 (1 comment) The new UI

[Impala-ASF-CR] IMPALA-12053: Expose event-processor error message in WebUI

2023-05-23 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19916 to look at the new patch set (#2). Change subject: IMPALA-12053: Expose event-processor error message in WebUI

[Impala-ASF-CR] IMPALA-12053: Expose event-processor error message in WebUI

2023-05-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19916 Change subject: IMPALA-12053: Expose event-processor error message in WebUI .. IMPALA-12053: Expose event-processor error message in

[Impala-ASF-CR] WIP IMPALA-12150: Allow executors to register to two statestores

2023-05-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19905 ) Change subject: WIP IMPALA-12150: Allow executors to register to two statestores .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui

2023-05-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 ) Change subject: IMPALA-12096: Add process start time and version to backends webui .. Patch Set 3: Code-Review+1 (1 comment) LGTM.

[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class

2023-05-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 ) Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class .. Patch Set

[Impala-ASF-CR] IMPALA-11260: Add add-opens to JAVA TOOL OPTIONS on startup

2023-05-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19845 ) Change subject: IMPALA-11260: Add add-opens to JAVA_TOOL_OPTIONS on startup .. Patch Set 8: Code-Review+2 Carrying Joe's +1. -- To

[Impala-ASF-CR] IMPALA-11253: Support testing with Java 11

2023-05-18 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19539 ) Change subject: IMPALA-11253: Support testing with Java 11 .. Patch Set 11: Code-Review+2 LGTM. Thanks for making this done! -- To

[Impala-ASF-CR] IMPALA-12059: Filter out harmless warnings from Thrift compilation

2023-05-18 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19818 ) Change subject: IMPALA-12059: Filter out harmless warnings from Thrift compilation .. Patch Set 2: Thanks for cleaning these up!

[Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64

2023-05-18 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 ) Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 .. Patch Set 21: (1 comment)

[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui

2023-05-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 ) Change subject: IMPALA-12096: Add process start time and version to backends webui .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-11260: Add add-opens to JAVA TOOL OPTIONS on startup

2023-05-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19845 ) Change subject: IMPALA-11260: Add add-opens to JAVA_TOOL_OPTIONS on startup .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11253: Support testing with Java 11

2023-05-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19539 ) Change subject: IMPALA-11253: Support testing with Java 11 .. Patch Set 9: (1 comment)

<    4   5   6   7   8   9   10   11   12   13   >