[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 4: I took a pass over this, just treating as a WIP. The overa

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16314/4/

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 ) Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images .. Patch Set 2: (2 comments) Did you think at all ab

[Impala-ASF-CR] IMPALA-10074: Set impala-shell's default protocol to hs2

2020-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16327 ) Change subject: IMPALA-10074: Set impala-shell's default protocol to hs2 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user

2020-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16252 ) Change subject: IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user .. Patch Set 4: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 15: (3 comments) This is ready for review. I still need to look a

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-08-11 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#16). Change subject: IMPALA-9979: part 2: partitioned top-n ..

[Impala-ASF-CR] WIP: IMPALA-9951: put sort before exchange in analytic plans

2020-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/16186 ) Change subject: WIP: IMPALA-9951: put sort before exchange in analytic plans .. Abandoned This does not make sense to do without reworking exch

[Impala-ASF-CR] IMPALA-9711: incrementally update aggregate profile

2020-08-10 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15931 to look at the new patch set (#7). Change subject: IMPALA-9711: incrementally update aggregate profile .

[Impala-ASF-CR] WIP - IMPALA-9979: part 2: partitioned top-n

2020-08-10 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#15). Change subject: WIP - IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9382: part 1: transposed profile prototype

2020-08-10 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15798 to look at the new patch set (#14). Change subject: IMPALA-9382: part 1: transposed profile prototype ..

[Impala-ASF-CR] IMPALA-9711: incrementally update aggregate profile

2020-08-10 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15931 to look at the new patch set (#6). Change subject: IMPALA-9711: incrementally update aggregate profile .

[Impala-ASF-CR] WIP - IMPALA-9382: part 2/2: aggregate profiles sent to coordinator

2020-08-10 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16057 to look at the new patch set (#8). Change subject: WIP - IMPALA-9382: part 2/2: aggregate profiles sent to coordinator ...

[Impala-ASF-CR] WIP - IMPALA-9979: part 2: partitioned top-n

2020-08-10 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#14). Change subject: WIP - IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9926: base64decode returns incorrect result on aarch64

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16175 ) Change subject: IMPALA-9926: base64decode returns incorrect result on aarch64 .. Patch Set 7: Code-Review+2 I updated the commit messa

[Impala-ASF-CR] IMPALA-9926: base64decode returns incorrect result on aarch64

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7) to the change originally created by zhaoren...@hotmail.com. ( http://gerrit.cloudera.org:8080/16175 ) Change subject: IMPALA-9926: base64decode returns incorrect result on aarch64 .

[Impala-ASF-CR] IMPALA-9995 Fix test alloc fail failed case on aarch64

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16307 ) Change subject: IMPALA-9995 Fix test_alloc_fail failed case on aarch64 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-9906 Fix thread-pool-test failed case on aarch64

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16173 ) Change subject: IMPALA-9906 Fix thread-pool-test failed case on aarch64 .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-9925 cast(pow(2, 31) as int) return 2147483647 on aarch64

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16174 ) Change subject: IMPALA-9925 cast(pow(2, 31) as int) return 2147483647 on aarch64 .. Patch Set 6: Code-Review+2 Ok, I think that makes

[Impala-ASF-CR] IMPALA-9904 Fix bad cipher test failed case on aarch64

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16172 ) Change subject: IMPALA-9904 Fix bad cipher test failed case on aarch64 .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 ) Change subject: IMPALA-9676 Add aarch64 compile options for clang .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-4364: Query option to refresh updated partitions

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16308 ) Change subject: IMPALA-4364: Query option to refresh updated partitions .. Patch Set 1: (1 comment) I think this makes sense at a hig

[Impala-ASF-CR] IMPALA-9741: Support querying Iceberg table by impala

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support querying Iceberg table by impala .. Patch Set 18: (10 comments) One thing I didn't understand ab

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 7: (1 comment) http:

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16314/3/b

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16306 ) Change subject: IMPALA-10061 Fix bugs of IMPALA-9645 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-9904 Fix bad cipher test failed case on aarch64

2020-08-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16172 ) Change subject: IMPALA-9904 Fix bad cipher test failed case on aarch64 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

2020-08-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 ) Change subject: IMPALA-9676 Add aarch64 compile options for clang .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-9906 Fix thread-pool-test failed case on aarch64

2020-08-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16173 ) Change subject: IMPALA-9906 Fix thread-pool-test failed case on aarch64 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16306 ) Change subject: IMPALA-10061 Fix bugs of IMPALA-9645 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16306/1/be/src/

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 6: Code-Review+2 -- To vie

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. Patch Set 4: Agree with Aman's comments about the planner t

[Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64

2020-08-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15718 ) Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 .. IMPALA-9645 Port LLVM codegen to adapt aarch64 On aarch64, t

[Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64

2020-08-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 ) Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 .. Patch Set 20: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] WIP - IMPALA-9979: part 2: partitioned top-n

2020-08-06 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#13). Change subject: WIP - IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9851: Truncate long error message.

2020-08-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64

2020-08-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 ) Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 .. Patch Set 19: Code-Review+2 Fixed the clang-tidy error. -- To view

[Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64

2020-08-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#19) to the change originally created by zhaoren...@hotmail.com. ( http://gerrit.cloudera.org:8080/15718 ) Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 .. IMPALA-9645

[Impala-ASF-CR] IMPALA-9851: Truncate long error message.

2020-08-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 1: Code-Review+2 (1 comment) One minor comment http://gerrit.

[Impala-ASF-CR] IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user

2020-08-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16252 ) Change subject: IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user .. Patch Set 2: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-9904 Fix bad cipher test failed case on aarch64

2020-08-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16172 ) Change subject: IMPALA-9904 Fix bad cipher test failed case on aarch64 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-9925 cast(pow(2, 31) as int) return 2147483647 on aarch64

2020-08-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16174 ) Change subject: IMPALA-9925 cast(pow(2, 31) as int) return 2147483647 on aarch64 .. Patch Set 4: I agree with zoltan that the results

[Impala-ASF-CR] IMPALA-9906 Fix thread-pool-test failed case on aarch64

2020-08-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16173 ) Change subject: IMPALA-9906 Fix thread-pool-test failed case on aarch64 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

2020-08-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 ) Change subject: IMPALA-9676 Add aarch64 compile options for clang .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-9926 base64decode % will not return error when in newer OS

2020-08-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16175 ) Change subject: IMPALA-9926 base64decode % will not return error when in newer OS .. Patch Set 4: I filed https://github.com/cyrusi

[Impala-ASF-CR] IMPALA-9926 base64decode % will not return error when in newer OS

2020-08-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16175 ) Change subject: IMPALA-9926 base64decode % will not return error when in newer OS .. Patch Set 4: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64

2020-08-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 ) Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 .. Patch Set 17: Code-Review+2 Sorry for the delays in reviewing these

[Impala-ASF-CR] IMPALA-9923: Load ORC serially to hack around flakiness

2020-08-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16292 ) Change subject: IMPALA-9923: Load ORC serially to hack around flakiness .. Patch Set 2: Code-Review+2 Thanks for looking into this, th

[Impala-ASF-CR] IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user

2020-08-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16252 ) Change subject: IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user .. Patch Set 2: (3 comments) The implementation lo

[Impala-ASF-CR] IMPALA-10047: Revert core piece of IMPALA-6984

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16288 ) Change subject: IMPALA-10047: Revert core piece of IMPALA-6984 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-10037: Remove flaky test mt dop scan node

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16286 ) Change subject: IMPALA-10037: Remove flaky test_mt_dop_scan_node .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] Add logging when query unregisteres

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16285 ) Change subject: Add logging when query unregisteres .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/162

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. Patch Set 2: Code-Review+1 LGTM. I can +2 but wanted to giv

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 3: Code-Review+1 (1 comment

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] WIP IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: WIP IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator .. Patch Set

[Impala-ASF-CR] IMPALA-10010: Add option to configure metrics webserver

2020-08-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16270 ) Change subject: IMPALA-10010: Add option to configure metrics webserver .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-08-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 3: I looped those end-to-end tests over the weeke

[Impala-ASF-CR] IMPALA-10036: schedule unpartitioned fragments on random executor

2020-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16272 ) Change subject: IMPALA-10036: schedule unpartitioned fragments on random executor .. IMPALA-10036: schedule unpartitioned frag

[Impala-ASF-CR] IMPALA-10036: schedule unpartitioned fragments on random executor

2020-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-10036: schedule unpartitioned fragments on random executor .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-10036: schedule unpartitioned fragments on random executor

2020-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16272 ) Change subject: IMPALA-10036: schedule unpartitioned fragments on random executor .. Patch Set 6: Verified+1 I hit https://issues.apa

[Impala-ASF-CR] IMPALA-10036: schedule unpartitioned fragments on random executor

2020-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16272 ) Change subject: IMPALA-10036: schedule unpartitioned fragments on random executor .. Patch Set 6: Code-Review+2 Carry +2 from Bikram

[Impala-ASF-CR] IMPALA-10036: schedule unpartitioned fragments on random executor

2020-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16272 ) Change subject: IMPALA-10036: schedule unpartitioned fragments on random executor .. IMPALA-10036: schedule unpartitioned fragments on r

[Impala-ASF-CR] IMPALA-10036: schedule unpartitioned fragments on random executor

2020-08-02 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16272 to look at the new patch set (#6). Change subject: IMPALA-10036: schedule unpartitioned fragments on random executor

[Impala-ASF-CR] NOT FOR REVIEW: Alternate fix for Top-N issue

2020-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/16271 ) Change subject: NOT FOR REVIEW: Alternate fix for Top-N issue .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/16271 To unsubscrib

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 15: I guess also if the single-node plan is correc

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 15: I think using the sort is correct, but it seem

[Impala-ASF-CR] NOT FOR REVIEW: Alternate fix for Top-N issue

2020-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16271 Change subject: NOT FOR REVIEW: Alternate fix for Top-N issue .. NOT FOR REVIEW: Alternate fix for Top-N issue Change-Id: I85b1ff9b69de

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

2020-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 ) Change subject: IMPALA-9903: Reduce Kudu openTable calls per query .. Patch Set 11: Agree it's unrelated - I filed IMPALA-10037 -- T

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 3: Please go ahead and fix them, it's nice to hav

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/16242/12//CO

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 ) Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 ) Change subject: IMPALA-9903: Reduce Kudu openTable calls per query .. Patch Set 9: Code-Review+2 (1 comment) Thanks for the patience

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 12: (1 comment) One more test ask related to the

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 11: I checked what patches were merged since the ver

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] I

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 3: We've been trying to reproduce the crash, and

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-07-30 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#12). Change subject: IMPALA-9979: part 2: partitioned top-n ..

[Impala-ASF-CR] IMPALA-10006: handle non-writable /opt/impala/logs

2020-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16237 ) Change subject: IMPALA-10006: handle non-writable /opt/impala/logs .. IMPALA-10006: handle non-writable /opt/impala/logs The s

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 3: I think we should make some more effort to try

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 3: TBH that was an educated guess based on the la

[Impala-ASF-CR] WIP: IMPALA-9979: part 2: partitioned top-n

2020-07-29 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#11). Change subject: WIP: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-10024: isBlackListedDb() should do a case-insensitive check

2020-07-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16254 ) Change subject: IMPALA-10024: isBlackListedDb() should do a case-insensitive check .. Patch Set 4: Code-Review+2 I think this is cont

[Impala-ASF-CR] IMPALA-8125: Add query option to limit number of hdfs writer instances

2020-07-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16204 ) Change subject: IMPALA-8125: Add query option to limit number of hdfs writer instances .. Patch Set 6: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

2020-07-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 ) Change subject: IMPALA-9903: Reduce Kudu openTable calls per query .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-07-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-07-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 3: Here's the hs_err crash dump from that job, it

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 3: Did you figure out why the first precommit fai

[Impala-ASF-CR] IMPALA-8125: Add query option to limit number of hdfs writer instances

2020-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16204 ) Change subject: IMPALA-8125: Add query option to limit number of hdfs writer instances .. Patch Set 5: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-10006: handle non-writable /opt/impala/logs

2020-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16237 Change subject: IMPALA-10006: handle non-writable /opt/impala/logs .. IMPALA-10006: handle non-writable /opt/impala/logs The shutdown s

[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16238 ) Change subject: IMPALA-10007: Impala development environment does not support Ubuntu 20.4 .. Patch Set 4: Code-Review+2 LGTM. I also

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 9: (4 comments) Had a few minor comments but I'm ne

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 ) Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. Patch Set 5: (1 comment) Did you run exhausti

[Impala-ASF-CR] IMPALA-9988: Integrate ldap filters and proxy users

2020-07-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16234 ) Change subject: IMPALA-9988: Integrate ldap filters and proxy users .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c

<    2   3   4   5   6   7   8   9   10   11   >