[native-toolchain-CR] IMPALA-8316. Update re2 to latest version

2019-03-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12771 ) Change subject: IMPALA-8316. Update re2 to latest version .. IMPALA-8316. Update re2 to latest version Change-Id:

[native-toolchain-CR] IMPALA-8316. Update re2 to latest version

2019-03-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12771 ) Change subject: IMPALA-8316. Update re2 to latest version .. Patch Set 1: Verified+1 Build ran and artifacts are now on S3 with id

[Impala-ASF-CR] IMPALA-5393. Use THREAD LOCAL state for regexp

2019-03-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12772 ) Change subject: IMPALA-5393. Use THREAD_LOCAL state for regexp .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-03-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-5393. Use THREAD LOCAL state for regexp

2019-03-16 Thread Todd Lipcon (Code Review)
Hello Lars Volker, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12772 to review the following change. Change subject: IMPALA-5393. Use THREAD_LOCAL state for regexp .. IMPALA-5393. Use

[native-toolchain-CR] IMPALA-8316. Update re2 to latest version

2019-03-16 Thread Todd Lipcon (Code Review)
Hello Lars Volker, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12771 to review the following change. Change subject: IMPALA-8316. Update re2 to latest version .. IMPALA-8316. Update re2

[native-toolchain-CR] IMPALA-8316. Update re2 to latest version

2019-03-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12771 ) Change subject: IMPALA-8316. Update re2 to latest version .. Patch Set 1: Not sure how to kick off appropriate Jenkins stuff for a

[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 ) Change subject: IMPALA-7982: Add host network usage to profile .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 ) Change subject: IMPALA-337: Add support for POST to the webserver .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 ) Change subject: IMPALA-337: Add support for POST to the webserver .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-03-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 11: (32 comments) nice work, pretty impressive test

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 9: (26 comments)

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 9: (25 comments)

[Impala-ASF-CR] IMPALA-8284. KuduTableSink spends too much CPU in KuduSchema::Column()

2019-03-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12692 ) Change subject: IMPALA-8284. KuduTableSink spends too much CPU in KuduSchema::Column() .. IMPALA-8284. KuduTableSink spends too

[Impala-ASF-CR] IMPALA-6503: Support reading complex types from ORC

2019-03-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12168 ) Change subject: IMPALA-6503: Support reading complex types from ORC .. Patch Set 25: (33 comments) Ah, I missed that this was almost

[Impala-ASF-CR] IMPALA-8283. Order of Kudu PRIMARY KEYs can be silently ignored

2019-03-07 Thread Todd Lipcon (Code Review)
Hello Thomas Marshall, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12694 to review the following change. Change subject: IMPALA-8283. Order of Kudu PRIMARY KEYs can be silently ignored

[Impala-ASF-CR] IMPALA-8284. KuduTableSink spends too much CPU in KuduSchema::Column()

2019-03-07 Thread Todd Lipcon (Code Review)
Hello Thomas Marshall, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12692 to review the following change. Change subject: IMPALA-8284. KuduTableSink spends too much CPU in KuduSchema::Column()

[Impala-ASF-CR] IMPALA-5031: `uint8 t & int` type is int

2019-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12346 ) Change subject: IMPALA-5031: `uint8_t & int` type is int .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5031: `uint8 t & int` type is int

2019-02-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12346 ) Change subject: IMPALA-5031: `uint8_t & int` type is int .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-01-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 4: Looks good to me! -- To

[Impala-ASF-CR] IMPALA-7980: Fix spinning threads because of buggy handling of num unqueued files .

2019-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning threads because of buggy handling of num_unqueued_files_. .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-7917 (Part 1): Decouple Sentry from Impala

2019-01-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Decouple Sentry from Impala .. Patch Set 6: (7 comments) I just realized I had some pending

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7980: Fix spinning threads because of buggy handling of num unqueued files .

2018-12-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning threads because of buggy handling of num_unqueued_files_. .. Patch Set 1: Would be nice to

[Impala-ASF-CR] IMPALA-7980: Fix spinning threads because of buggy handling of num unqueued files .

2018-12-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning threads because of buggy handling of num_unqueued_files_. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7870: Increase the timeout in test v1 catalog

2018-11-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11997 ) Change subject: IMPALA-7870: Increase the timeout in test_v1_catalog .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-7541. Avoid initializing Metrics for IncompleteTables

2018-11-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11393 ) Change subject: IMPALA-7541. Avoid initializing Metrics for IncompleteTables .. Patch Set 1: No problem. I bumped the priority on the

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog

2018-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11688 ) Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache

2018-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11688 ) Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache

2018-10-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11688 ) Change subject: IMPALA-7501: Slim down metastore Partition objects in LocalCatalog cache .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 18: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7597: wraps retries around Frontend metadata operations.

2018-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around Frontend metadata operations. .. Patch Set 5: Looks fine to me. Another way of doing

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs

2018-10-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11638 ) Change subject: IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs

2018-10-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11638 ) Change subject: IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs

2018-10-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11638 ) Change subject: IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs .. Patch Set 1: (1 comment) Unit test?

[Impala-ASF-CR] IMPALA-7670: Avoid getting the latest tables in bulkAlterPartitions()

2018-10-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11641 ) Change subject: IMPALA-7670: Avoid getting the latest tables in bulkAlterPartitions() .. Patch Set 1: Can we add a targeted stress

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 16: (4 comments)

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

2018-09-07 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vuk Ercegovac, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11403 to review the following change. Change subject: IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-09-07 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11227 to look at the new patch set (#3). Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 12: (7 comments)

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 3: (5 comments)

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-09-06 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11227 to look at the new patch set (#2). Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-7448: Invalidate recently unused tables from catalogd

2018-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11224 ) Change subject: IMPALA-7448: Invalidate recently unused tables from catalogd .. Patch Set 7: (8 comments) Just a few small notes

[Impala-ASF-CR] IMPALA-7203. Support UDFs in CatalogdMetaProvider

2018-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11359 ) Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider .. Patch Set 8: Looks like the compile-only job didn't trigger for

[Impala-ASF-CR] IMPALA-7203. Support UDFs in CatalogdMetaProvider

2018-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11359 ) Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider .. IMPALA-7203. Support UDFs in CatalogdMetaProvider This

[Impala-ASF-CR] IMPALA-7203. Support UDFs in CatalogdMetaProvider

2018-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11359 ) Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider .. Patch Set 8: Verified+1 Code-Review+2 Checked diff between r7 and

[Impala-ASF-CR] IMPALA-7510. Support principals/privileges with LocalCatalog

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11358 ) Change subject: IMPALA-7510. Support principals/privileges with LocalCatalog .. IMPALA-7510. Support principals/privileges with

[Impala-ASF-CR] IMPALA-7541. Avoid initializing Metrics for IncompleteTables

2018-09-05 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11393 to review the following change. Change subject: IMPALA-7541. Avoid initializing Metrics for IncompleteTables

[Impala-ASF-CR] IMPALA-7137 fixup: only recreate AuthorizationChecker on full delta updates

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11357 ) Change subject: IMPALA-7137 fixup: only recreate AuthorizationChecker on full delta updates .. IMPALA-7137 fixup: only recreate

[Impala-ASF-CR] IMPALA-7510. Support principals/privileges with LocalCatalog

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11358 ) Change subject: IMPALA-7510. Support principals/privileges with LocalCatalog .. Patch Set 9: Skipping a jenkins re-verify since it was

[Impala-ASF-CR] IMPALA-7510. Support principals/privileges with LocalCatalog

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11358 ) Change subject: IMPALA-7510. Support principals/privileges with LocalCatalog .. Patch Set 9: Verified+1 Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7510. Support principals/privileges with LocalCatalog

2018-09-05 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11358 to look at the new patch set (#9). Change subject: IMPALA-7510. Support principals/privileges with LocalCatalog

[Impala-ASF-CR] IMPALA-7510. Support principals/privileges with LocalCatalog

2018-09-05 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11358 to look at the new patch set (#8). Change subject: IMPALA-7510. Support principals/privileges with LocalCatalog

[Impala-ASF-CR] IMPALA-7137 fixup: only recreate AuthorizationChecker on full delta updates

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11357 ) Change subject: IMPALA-7137 fixup: only recreate AuthorizationChecker on full delta updates .. Patch Set 7: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2018-09-05 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11158 to look at the new patch set (#2). Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog

[Impala-ASF-CR] IMPALA-7203. Support UDFs in CatalogdMetaProvider

2018-09-05 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11359 to look at the new patch set (#7). Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-05 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11388 to look at the new patch set (#3). Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

[Impala-ASF-CR] Replace some TODOs with specific JIRA references

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11392 Change subject: Replace some TODOs with specific JIRA references .. Replace some TODOs with specific JIRA references Change-Id:

[Impala-ASF-CR] IMPALA-7510. Support principals/privileges with LocalCatalog

2018-09-05 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11358 to look at the new patch set (#7). Change subject: IMPALA-7510. Support principals/privileges with LocalCatalog

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 12: Verified+1 Code-Review+2 Going to

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. IMPALA-7469. Invalidate LocalCatalog cache

[Impala-ASF-CR] IMPALA-7510. Support principals/privileges with LocalCatalog

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11358 ) Change subject: IMPALA-7510. Support principals/privileges with LocalCatalog .. Patch Set 6: (5 comments)

[Impala-ASF-CR] WIP: IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: WIP: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: (1 comment)

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7203. Support UDFs in CatalogdMetaProvider

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11359 ) Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-09-05 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11280 to look at the new patch set (#11). Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

[Impala-ASF-CR] IMPALA-7203. Support UDFs in CatalogdMetaProvider

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11359 ) Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 10: (1 comment)

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 2: > Patch Set 2: > > Forgot to git add

[Impala-ASF-CR] IMPALA-7448: Invalidate recently unused tables from catalogd

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11224 ) Change subject: IMPALA-7448: Invalidate recently unused tables from catalogd .. Patch Set 4: (13 comments)

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-09-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 13: > Patch Set 13: > > I think adding more tests for

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-09-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 1: (2 comments)

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-04 Thread Todd Lipcon (Code Review)
Hello Vuk Ercegovac, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11388 to review the following change. Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile ..

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-09-04 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11280 to look at the new patch set (#9). Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-09-04 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11280 to look at the new patch set (#8). Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

[Impala-ASF-CR] IMPALA-7510. Support principals/privileges with LocalCatalog

2018-09-04 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11358 to look at the new patch set (#4). Change subject: IMPALA-7510. Support principals/privileges with LocalCatalog

[Impala-ASF-CR] IMPALA-7203. Support UDFs in CatalogdMetaProvider

2018-09-04 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11359 to look at the new patch set (#4). Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-09-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 11: (14 comments)

[Impala-ASF-CR] IMPALA-7203. Support UDFs in CatalogdMetaProvider

2018-09-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11359 ) Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-09-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 7: (10 comments)

[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog

2018-09-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11383 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 2: (11 comments)

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-08-31 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11280 to look at the new patch set (#7). Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

[Impala-ASF-CR] IMPALA-7510. Support principals/privileges with LocalCatalog

2018-08-31 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11358 to look at the new patch set (#3). Change subject: IMPALA-7510. Support principals/privileges with LocalCatalog

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 6: (8 comments)

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-08-31 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11280 to look at the new patch set (#6). Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 ) Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7448: Invalidate recently unused tables from catalogd

2018-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11224 ) Change subject: IMPALA-7448: Invalidate recently unused tables from catalogd .. Patch Set 3: > Patch Set 3: > > This is also an

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 ) Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats .. Patch Set 7: (1 comment)

<    1   2   3   4   5   6   7   8   9   10   >