[Impala-ASF-CR] IMPALA-10900: Add Iceberg tests that write many files

2021-09-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17831 ) Change subject: IMPALA-10900: Add Iceberg tests that write many files .. Patch Set 2: Code-Review+1 (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-10900: Add Iceberg tests that write many files

2021-09-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Riza Suminto, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17831 to look at the new patch set (#2). Change subject: IMPALA-10900: Add Iceberg tests that write many files

[Impala-ASF-CR] IMPALA-10900: Add Iceberg tests that write many files

2021-09-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17831 Change subject: IMPALA-10900: Add Iceberg tests that write many files .. IMPALA-10900: Add Iceberg tests that write many files In

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 ) Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables .. Patch

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-30 Thread Zoltan Borok-Nagy (Code Review)
Hello Qifan Chen, Amogh Margoor, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17765 to look at the new patch set (#7). Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS

[Impala-ASF-CR] IMPALA-10879: Add parquet stats to iceberg manifest

2021-08-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17806 ) Change subject: IMPALA-10879: Add parquet stats to iceberg manifest .. Patch Set 6: Code-Review+2 Great job! -- To view, visit

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 ) Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables .. Patch

[Impala-ASF-CR] IMPALA-10879: Add parquet stats to iceberg manifest

2021-08-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17806 ) Change subject: IMPALA-10879: Add parquet stats to iceberg manifest .. Patch Set 4: Code-Review+1 (2 comments) The change looks

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 9: Code-Review+1 (9 comments) Thanks

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 ) Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables .. Patch

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 ) Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables .. Patch

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 ) Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables .. Patch

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Qifan Chen, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17765 to look at the new patch set (#5). Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 ) Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables .. Patch

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17765 to look at the new patch set (#4). Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 ) Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables .. Patch

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17765 to look at the new patch set (#3). Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17765 to look at the new patch set (#2). Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables

[Impala-ASF-CR] IMPALA-10879: Add parquet stats to iceberg manifest

2021-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17806 ) Change subject: IMPALA-10879: Add parquet stats to iceberg manifest .. Patch Set 2: (4 comments) Did a first round, the change

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 14: Code-Review+2 LGTM,

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 13: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans

2021-08-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 ) Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans .. Patch Set 32:

[Impala-ASF-CR] IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans

2021-08-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 ) Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans .. Patch Set 25:

[Impala-ASF-CR] IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans

2021-08-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 ) Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans .. Patch Set 25:

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-08-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 9: Code-Review+2

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 9: (7 comments) This is

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-08-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 9: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 ) Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables .. Patch

[Impala-ASF-CR] IMPALA-10840: Add support for "FOR SYSTEM TIME AS OF" and "FOR SYSTEM VERSION AS OF" for Iceberg tables

2021-08-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17765 Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables ..

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-08-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 9: (5 comments) Looks

[Impala-ASF-CR] IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans

2021-08-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 ) Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans .. Patch Set 20: (8

[Impala-ASF-CR] IMPALA-8795: Turn on events processing by default

2021-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17612 ) Change subject: IMPALA-8795: Turn on events processing by default .. Patch Set 12: Code-Review+1 (4 comments) Found a few nits,

[Impala-ASF-CR] IMPALA-10808: (addendum) Abort on illegal decimal parquet schemas

2021-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17748 ) Change subject: IMPALA-10808: (addendum) Abort on illegal decimal parquet schemas .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-10741: Set engine.hive.enabled=true table property for Iceberg tables

2021-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17750 Change subject: IMPALA-10741: Set engine.hive.enabled=true table property for Iceberg tables .. IMPALA-10741: Set

[Impala-ASF-CR] IMPALA-10739: Support setting new partition spec for Iceberg tables

2021-08-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17723 ) Change subject: IMPALA-10739: Support setting new partition spec for Iceberg tables .. Patch Set 3: Code-Review+2 Great job!

[Impala-ASF-CR] IMPALA-10739: Support setting new partition spec for Iceberg tables

2021-08-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17723 ) Change subject: IMPALA-10739: Support setting new partition spec for Iceberg tables .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10739: Support setting new partition spec for Iceberg tables

2021-07-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17723 ) Change subject: IMPALA-10739: Support setting new partition spec for Iceberg tables .. Patch Set 1: Code-Review+1 (5 comments)

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

2021-07-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 ) Change subject: IMPALA-10823: Output fewer information when external frontend is used .. Patch Set 5: Thanks for the review.

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

2021-07-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 ) Change subject: IMPALA-10823: Output fewer information when external frontend is used .. Patch Set 4: (2 comments) Thanks for

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

2021-07-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Qifan Chen, Kurt Deschler, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17718 to look at the new patch set (#4). Change subject: IMPALA-10823: Output fewer information when external frontend is used

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

2021-07-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Kurt Deschler, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17718 to look at the new patch set (#3). Change subject: IMPALA-10823: Output fewer information when external frontend is used

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

2021-07-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17718 ) Change subject: IMPALA-10823: Output fewer information when external frontend is used .. Patch Set 2: (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

2021-07-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Kurt Deschler, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17718 to look at the new patch set (#2). Change subject: IMPALA-10823: Output fewer information when external frontend is used

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files

2021-07-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17719 ) Change subject: IMPALA-10820: Fix calculating default block size for parquest files .. Patch Set 2: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files

2021-07-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17719 ) Change subject: IMPALA-10820: Fix calculating default block size for parquest files .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-10823: Output fewer information when external frontend is used

2021-07-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17718 Change subject: IMPALA-10823: Output fewer information when external frontend is used .. IMPALA-10823: Output fewer information

[Impala-ASF-CR] IMPALA-10814: Fix crash on illegal Parquet file

2021-07-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17714 ) Change subject: IMPALA-10814: Fix crash on illegal Parquet file .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10814: Fix crash on illegal Parquet file

2021-07-23 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17714 to look at the new patch set (#2). Change subject: IMPALA-10814: Fix crash on illegal Parquet file

[Impala-ASF-CR] IMPALA-10814: Fix crash on illegal Parquet file

2021-07-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17714 Change subject: IMPALA-10814: Fix crash on illegal Parquet file .. IMPALA-10814: Fix crash on illegal Parquet file In

[Impala-ASF-CR] IMPALA-10815: Ignore events on non-default hive catalogs

2021-07-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17707 ) Change subject: IMPALA-10815: Ignore events on non-default hive catalogs .. Patch Set 4: Code-Review+1 (2 comments) LGTM!

[Impala-ASF-CR] IMPALA-10810: Bump json-smart from 2.3 to 2.4.7

2021-07-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17702 ) Change subject: IMPALA-10810: Bump json-smart from 2.3 to 2.4.7 .. Patch Set 2: (1 comment) Oops, thanks for noticing this. I

[Impala-ASF-CR] IMPALA-10810: Bump json-smart from 2.3 to 2.4.7

2021-07-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Laszlo Gaal, Anonymous Coward (659), Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17702 to look at the new patch set (#2). Change subject: IMPALA-10810: Bump json-smart from 2.3 to 2.4.7

[Impala-ASF-CR] IMPALA-10754: test overlap min max filters on sorted columns failed during GVO

2021-07-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17696 ) Change subject: IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO .. Patch Set 5: Code-Review+2 --

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

2021-07-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17698 ) Change subject: IMPALA-10502: Fetch events in batches (Addendum) .. IMPALA-10502: Fetch events in batches (Addendum) The

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

2021-07-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has removed a vote on this change. Change subject: IMPALA-10502: Fetch events in batches (Addendum) .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/17698 To

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

2021-07-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17698 ) Change subject: IMPALA-10502: Fetch events in batches (Addendum) .. Patch Set 2: Verified+1 Code-Review+2 LGTM! Also Verify +1

[Impala-ASF-CR] IMPALA-10810: Bump json-smart from 2.3 to 2.4.7

2021-07-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17702 Change subject: IMPALA-10810: Bump json-smart from 2.3 to 2.4.7 .. IMPALA-10810: Bump json-smart from 2.3 to 2.4.7 I noticed that

[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema

2021-07-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17701 ) Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema .. Patch Set 2: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-10627: Use standard parquet-related Iceberg table properties

2021-07-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17654 ) Change subject: IMPALA-10627: Use standard parquet-related Iceberg table properties .. Patch Set 7: Code-Review+2 Looks great!

[Impala-ASF-CR] IMPALA-10627: Use standard parquet-related Iceberg table properties

2021-07-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17654 ) Change subject: IMPALA-10627: Use standard parquet-related Iceberg table properties .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-10627: Use standard parquet-related Iceberg table properties

2021-07-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17654 ) Change subject: IMPALA-10627: Use standard parquet-related Iceberg table properties .. Patch Set 6: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error

2021-07-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17689 Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error .. IMPALA-10802:

[Impala-ASF-CR] IMPALA-10732: Use consistent DDL for specifying Iceberg partitions

2021-07-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17575 ) Change subject: IMPALA-10732: Use consistent DDL for specifying Iceberg partitions .. Patch Set 7: Code-Review+2 Carry +2 --

[Impala-ASF-CR] IMPALA-10732: Use consistent DDL for specifying Iceberg partitions

2021-07-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17575 to look at the new patch set (#7). Change subject: IMPALA-10732: Use consistent DDL for specifying Iceberg partitions

[Impala-ASF-CR] IMPALA-10626: Add support for Iceberg's Catalogs API

2021-07-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17466 ) Change subject: IMPALA-10626: Add support for Iceberg's Catalogs API .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-10626: Add support for Iceberg's Catalogs API

2021-07-14 Thread Zoltan Borok-Nagy (Code Review)
Hello wangsheng, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17466 to look at the new patch set (#6). Change subject: IMPALA-10626: Add support for Iceberg's Catalogs API

[Impala-ASF-CR] IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns

2021-07-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17635 ) Change subject: IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns .. Patch Set 9: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-10627: Use standard parquet-related Iceberg table properties

2021-07-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17654 ) Change subject: IMPALA-10627: Use standard parquet-related Iceberg table properties .. Patch Set 4: (3 comments) The change

[Impala-ASF-CR] IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

2021-07-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17678 ) Change subject: IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale .. IMPALA-7087,

[Impala-ASF-CR] IMPALA-10490: Fix illegalStateException in drop stats

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17659 ) Change subject: IMPALA-10490: Fix illegalStateException in drop stats .. Patch Set 2: Code-Review+2 LGTM! Thanks for fixing this!

[Impala-ASF-CR] IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17678 ) Change subject: IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale .. Patch Set 4: (4

[Impala-ASF-CR] IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Hello Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17678 to look at the new patch set (#6). Change subject: IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

[Impala-ASF-CR] IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17678 ) Change subject: IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale .. Patch Set 5: PS5

[Impala-ASF-CR] IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Hello Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17678 to look at the new patch set (#5). Change subject: IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

[Impala-ASF-CR] IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots.

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17658 ) Change subject: IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots. .. Patch Set 4:

[Impala-ASF-CR](asf-site) Fix wrong JIRA id and link in 4.0 release note

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17681 ) Change subject: Fix wrong JIRA id and link in 4.0 release note .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17678 ) Change subject: IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale .. Patch Set 3: (19

[Impala-ASF-CR] IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Hello Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17678 to look at the new patch set (#3). Change subject: IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

[Impala-ASF-CR] IMPALA-10732: Use consistent DDL for specifying Iceberg partitions

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17575 ) Change subject: IMPALA-10732: Use consistent DDL for specifying Iceberg partitions .. Patch Set 4: (4 comments) Thanks for the

[Impala-ASF-CR] IMPALA-10732: Use consistent DDL for specifying Iceberg partitions

2021-07-13 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17575 to look at the new patch set (#5). Change subject: IMPALA-10732: Use consistent DDL for specifying Iceberg partitions

[Impala-ASF-CR] IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

2021-07-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17678 to look at the new patch set (#2). Change subject: IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

[Impala-ASF-CR] IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale

2021-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17678 Change subject: IMPALA-7087, IMPALA-8131: Read decimals from Parquet files with different precision/scale .. IMPALA-7087,

[Impala-ASF-CR](asf-site) [DOCS] Impala 4.0 docs to be published

2021-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17677 ) Change subject: [DOCS] Impala 4.0 docs to be published .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Impala 4.0.0 Release

2021-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17676 ) Change subject: [DOCS] Impala 4.0.0 Release .. Patch Set 2: Code-Review+2 Thanks! -- To view, visit

[Impala-ASF-CR] [DOCS] Impala 4.0.0 Release

2021-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17676 ) Change subject: [DOCS] Impala 4.0.0 Release .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR](asf-site) Update download links for release 4.0.0

2021-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17669 ) Change subject: Update download links for release 4.0.0 .. Patch Set 1: Code-Review+2 LGTM! -- To view, visit

[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log

2021-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17671 ) Change subject: Add 4.0.0 Release notes and change log .. Patch Set 2: Code-Review+2 (1 comment) LGTM!

[Impala-ASF-CR] IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns

2021-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17635 ) Change subject: IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns .. Patch Set 8: Code-Review+2 (4

[Impala-ASF-CR] IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots.

2021-07-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17658 ) Change subject: IMPALA-10703: Fix crash on reading ACID table while printing SchemaPath of tuple/slots. .. Patch Set 4:

[Impala-ASF-CR] IMPALA-10766: Better selectivity for =,not distinct

2021-07-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17637 ) Change subject: IMPALA-10766: Better selectivity for =,not distinct .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10766: Better selectivity for =,not distinct

2021-07-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17637 ) Change subject: IMPALA-10766: Better selectivity for =,not distinct .. Patch Set 4: Code-Review+1 (3 comments) Found a few nits,

[Impala-ASF-CR] IMPALA-10738: Min/max filters should be enabled for partition columns

2021-07-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17568 ) Change subject: IMPALA-10738: Min/max filters should be enabled for partition columns .. Patch Set 17: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-10502: Handle CREATE/DROP events correctly

2021-07-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17308 ) Change subject: IMPALA-10502: Handle CREATE/DROP events correctly .. Patch Set 18: Code-Review+2 (4 comments) Thanks for working

[Impala-ASF-CR] IMPALA-10738: Min/max filters should be enabled for partition columns

2021-07-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17568 ) Change subject: IMPALA-10738: Min/max filters should be enabled for partition columns .. Patch Set 15: Code-Review+2 Thanks,

[Impala-ASF-CR] IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently.

2021-07-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 ) Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. .. Patch Set 5: (12 comments) Did a

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-07-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 6: (3 comments) I am

[Impala-ASF-CR] IMPALA-10738: Min/max filters should be enabled for partition columns

2021-07-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17568 ) Change subject: IMPALA-10738: Min/max filters should be enabled for partition columns .. Patch Set 14: (3 comments)

[Impala-ASF-CR] IMPALA-10738: Min/max filters should be enabled for partition columns

2021-07-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17568 ) Change subject: IMPALA-10738: Min/max filters should be enabled for partition columns .. Patch Set 14: (1 comment) I took an

[Impala-ASF-CR] IMPALA-10502: Handle CREATE/DROP events correctly

2021-07-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17308 ) Change subject: IMPALA-10502: Handle CREATE/DROP events correctly .. Patch Set 15: (25 comments) This change makes a lot of

[Impala-ASF-CR] IMPALA-10765: Allow firing INSERT events with empty results

2021-06-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17629 ) Change subject: IMPALA-10765: Allow firing INSERT events with empty results .. Patch Set 3: Code-Review+2 Thanks for fixing this.

<    7   8   9   10   11   12   13   14   15   16   >