[Impala-ASF-CR] IMPALA-12765: Balance consecutive partitions better for Iceberg tables

2024-01-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20973 ) Change subject: IMPALA-12765: Balance consecutive partitions better for Iceberg tables .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12765: Balance consecutive partitions better for Iceberg tables

2024-01-30 Thread Zoltan Borok-Nagy (Code Review)
Hello Riza Suminto, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20973 to look at the new patch set (#5). Change subject: IMPALA-12765: Balance consecutive partitions better for Iceberg tables

[Impala-ASF-CR] IMPALA-12765: Balance consecutive partitions better for Iceberg tables

2024-01-30 Thread Zoltan Borok-Nagy (Code Review)
Hello Riza Suminto, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20973 to look at the new patch set (#4). Change subject: IMPALA-12765: Balance consecutive partitions better for Iceberg tables

[Impala-ASF-CR] IMPALA-12765: Balance consecutive partitions better for Iceberg tables

2024-01-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20973 ) Change subject: IMPALA-12765: Balance consecutive partitions better for Iceberg tables .. Patch Set 3: (5 comments) Thanks for

[Impala-ASF-CR] IMPALA-12765: Balance consecutive partitions better for Iceberg tables

2024-01-30 Thread Zoltan Borok-Nagy (Code Review)
Hello Riza Suminto, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20973 to look at the new patch set (#3). Change subject: IMPALA-12765: Balance consecutive partitions better for Iceberg tables

[Impala-ASF-CR] IMPALA-12765: Balance consecutive partitions better for Iceberg tables

2024-01-29 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20973 to look at the new patch set (#2). Change subject: IMPALA-12765: Balance consecutive partitions better for Iceberg tables

[Impala-ASF-CR] IMPALA-12765: Balance consecutive partitions better for Iceberg tables

2024-01-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20973 Change subject: IMPALA-12765: Balance consecutive partitions better for Iceberg tables .. IMPALA-12765: Balance consecutive

[Impala-ASF-CR] IMPALA-12742: DELETE/UPDATE Iceberg table partitioned by DATE fails with error

2024-01-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20954 ) Change subject: IMPALA-12742: DELETE/UPDATE Iceberg table partitioned by DATE fails with error .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-12742: DELETE/UPDATE Iceberg table partitioned by DATE fails with error

2024-01-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20954 to look at the new patch set (#2). Change subject: IMPALA-12742: DELETE/UPDATE Iceberg table partitioned by DATE fails with error

[Impala-ASF-CR] IMPALA-12742: DELETE/UPDATE Iceberg table partitioned by DATE fails with error

2024-01-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20954 Change subject: IMPALA-12742: DELETE/UPDATE Iceberg table partitioned by DATE fails with error .. IMPALA-12742: DELETE/UPDATE

[Impala-ASF-CR] IMPALA-12631: Improve count star performance for parquet scans

2024-01-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20804 ) Change subject: IMPALA-12631: Improve count star performance for parquet scans .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-12631: Improve count star performance for parquet scans

2024-01-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20804 ) Change subject: IMPALA-12631: Improve count star performance for parquet scans .. Patch Set 12: Code-Review+1 (2 comments)

[Impala-ASF-CR] Addendum: IMPALA-12584: Enable strict data file access by default

2024-01-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20874 ) Change subject: Addendum: IMPALA-12584: Enable strict data file access by default .. Patch Set 11: Code-Review+2 Thanks for

[Impala-ASF-CR] Addendum: IMPALA-12584: Enable strict data file access by default

2024-01-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20874 ) Change subject: Addendum: IMPALA-12584: Enable strict data file access by default .. Patch Set 10: Code-Review+2 (5 comments)

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20903 ) Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables .. Patch Set 3: Code-Review+2 Carry +2 -- To

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20903 ) Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables .. IMPALA-12708: An UPDATE creates 2

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20903 ) Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables .. Patch Set 3: (4 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20903 to look at the new patch set (#3). Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

[Impala-ASF-CR] IMPALA-11710: Table properties are not updated in Iceberg metadata files

2024-01-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Daniel Becker, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20907 to look at the new patch set (#3). Change subject: IMPALA-11710: Table properties are not updated in Iceberg metadata files

[Impala-ASF-CR] IMPALA-11710: Table properties are not updated in Iceberg metadata files

2024-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20907 ) Change subject: IMPALA-11710: Table properties are not updated in Iceberg metadata files .. Patch Set 2: (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20903 ) Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables .. Patch Set 2: (3 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20903 to look at the new patch set (#2). Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

[Impala-ASF-CR] IMPALA-11710: Table properties are not updated in Iceberg metadata files

2024-01-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20907 ) Change subject: IMPALA-11710: Table properties are not updated in Iceberg metadata files .. Patch Set 2: (2 comments) Thanks

[Impala-ASF-CR] IMPALA-11710: Table properties are not updated in Iceberg metadata files

2024-01-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20907 to look at the new patch set (#2). Change subject: IMPALA-11710: Table properties are not updated in Iceberg metadata files

[Impala-ASF-CR] IMPALA-11710: Table properties are not updated in Iceberg metadata files

2024-01-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20907 Change subject: IMPALA-11710: Table properties are not updated in Iceberg metadata files .. IMPALA-11710: Table properties are not

[Impala-ASF-CR] Addendum: IMPALA-12584: Enable strict data file access by default

2024-01-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20874 ) Change subject: Addendum: IMPALA-12584: Enable strict data file access by default .. Patch Set 7: Code-Review+2 Thanks for

[Impala-ASF-CR] Addendum: IMPALA-12584: Enable strict data file access by default

2024-01-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20874 ) Change subject: Addendum: IMPALA-12584: Enable strict data file access by default .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20903 Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables .. IMPALA-12708: An UPDATE creates 2 new

[Impala-ASF-CR] IMPALA-12665: Adjust complete micro batch length to new scratch batch ->capacity after ScratchTupleBatch::Reset

2024-01-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20834 ) Change subject: IMPALA-12665: Adjust complete_micro_batch_ length to new scratch_batch_->capacity after ScratchTupleBatch::Reset ..

[Impala-ASF-CR] IMPALA-12665: Adjust complete micro batch length to new scratch batch ->capacity after ScratchTupleBatch::Reset

2024-01-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20834 ) Change subject: IMPALA-12665: Adjust complete_micro_batch_ length to new scratch_batch_->capacity after ScratchTupleBatch::Reset ..

[Impala-ASF-CR] IMPALA-12706: Fix nested struct querying for Iceberg metadata tables

2024-01-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20883 ) Change subject: IMPALA-12706: Fix nested struct querying for Iceberg metadata tables .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] Addendum: IMPALA-12584: Enable strict data file access by default

2024-01-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20874 ) Change subject: Addendum: IMPALA-12584: Enable strict data file access by default .. Patch Set 4: (1 comment)

[Impala-ASF-CR] Addendum: IMPALA-12584: Enable strict data file access by default

2024-01-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has removed a vote on this change. Change subject: Addendum: IMPALA-12584: Enable strict data file access by default .. Removed Code-Review+2 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] Addendum: IMPALA-12584: Enable strict data file access by default

2024-01-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20874 ) Change subject: Addendum: IMPALA-12584: Enable strict data file access by default .. Patch Set 3: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-12443: Add catalog timeline for all DDL profiles

2024-01-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20491 ) Change subject: IMPALA-12443: Add catalog timeline for all DDL profiles .. Patch Set 13: Code-Review+2 (4 comments) Great work!

[Impala-ASF-CR] IMPALA-12673: Table migration fails if partition contains '/'

2024-01-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20845 ) Change subject: IMPALA-12673: Table migration fails if partition contains '/' .. Patch Set 1: Code-Review+2 LGTM! -- To view,

[Impala-ASF-CR] IMPALA-12605: Fix ALTER TABLE SET PARTITION SPEC field id distribution

2024-01-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20823 ) Change subject: IMPALA-12605: Fix ALTER TABLE SET PARTITION SPEC field id distribution .. Patch Set 4: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-12605: Fix ALTER TABLE SET PARTITION SPEC field id distribution

2024-01-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20823 ) Change subject: IMPALA-12605: Fix ALTER TABLE SET PARTITION SPEC field id distribution .. Patch Set 3: Code-Review+1 (3

[Impala-ASF-CR] IMPALA-12658: UPDATE Iceberg table FROM view throws IllegalStateException

2024-01-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20825 ) Change subject: IMPALA-12658: UPDATE Iceberg table FROM view throws IllegalStateException .. Patch Set 2: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-12658: UPDATE Iceberg table FROM view throws IllegalStateException

2024-01-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20825 to look at the new patch set (#2). Change subject: IMPALA-12658: UPDATE Iceberg table FROM view throws IllegalStateException

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2024-01-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20818 ) Change subject: IMPALA-12653: Update documentation about the UPDATE statement .. IMPALA-12653: Update documentation about

[Impala-ASF-CR] IMPALA-12443: Add catalog timeline for all DDL profiles

2023-12-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20491 ) Change subject: IMPALA-12443: Add catalog timeline for all DDL profiles .. Patch Set 12: (13 comments) Great work, Quanlong!

[Impala-ASF-CR] IMPALA-12463: Batch non-consecutive table events in the event processor

2023-12-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20533 ) Change subject: IMPALA-12463: Batch non-consecutive table events in the event processor .. Patch Set 8: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-12661: Fix ASAN heap-use-after-free in IcebergMetadataScanNode

2023-12-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20829 ) Change subject: IMPALA-12661: Fix ASAN heap-use-after-free in IcebergMetadataScanNode .. Patch Set 1: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-12605: Fix ALTER TABLE SET PARTITION SPEC field id distribution

2023-12-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20823 ) Change subject: IMPALA-12605: Fix ALTER TABLE SET PARTITION SPEC field id distribution .. Patch Set 2: (3 comments) Nice

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20818 ) Change subject: IMPALA-12653: Update documentation about the UPDATE statement .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20818 to look at the new patch set (#6). Change subject: IMPALA-12653: Update documentation about the UPDATE statement

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20818 to look at the new patch set (#5). Change subject: IMPALA-12653: Update documentation about the UPDATE statement

[Impala-ASF-CR] IMPALA-12658: UPDATE Iceberg table FROM view throws IllegalStateException

2023-12-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20825 Change subject: IMPALA-12658: UPDATE Iceberg table FROM view throws IllegalStateException .. IMPALA-12658: UPDATE Iceberg table

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20818 ) Change subject: IMPALA-12653: Update documentation about the UPDATE statement .. Patch Set 4: (3 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20818 to look at the new patch set (#4). Change subject: IMPALA-12653: Update documentation about the UPDATE statement

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20818 to look at the new patch set (#3). Change subject: IMPALA-12653: Update documentation about the UPDATE statement

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20818 to look at the new patch set (#2). Change subject: IMPALA-12653: Update documentation about the UPDATE statement

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20818 Change subject: IMPALA-12653: Update documentation about the UPDATE statement .. IMPALA-12653: Update documentation about the

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 12: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-12650: Skip some queries in test create unicode table on non-HFDS envs

2023-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20813 ) Change subject: IMPALA-12650: Skip some queries in test_create_unicode_table on non-HFDS envs .. Patch Set 1: Code-Review+2

[Impala-ASF-CR] IMPALA-12628: iceberg negative test fail in non-HDFS environments

2023-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20812 ) Change subject: IMPALA-12628: iceberg negative test fail in non-HDFS environments .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12628: iceberg negative test fail in non-HDFS environments

2023-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20812 ) Change subject: IMPALA-12628: iceberg negative test fail in non-HDFS environments .. IMPALA-12628: iceberg negative test

[Impala-ASF-CR] IMPALA-12628: iceberg negative test fail in non-HDFS environments

2023-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20812 Change subject: IMPALA-12628: iceberg negative test fail in non-HDFS environments .. IMPALA-12628: iceberg negative test fail in

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 8: (3 comments) I only had one

[Impala-ASF-CR] IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns

2023-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20759 ) Change subject: IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns .. Patch Set 6: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-12500: Reduce flakyness of test global exchange counters

2023-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20811 ) Change subject: IMPALA-12500: Reduce flakyness of test_global_exchange_counters .. Patch Set 1: Code-Review+2 LGTM! -- To view,

[Impala-ASF-CR] IMPALA-12606: Sporadic failures around query test.test queries.TestQueries.test intersect

2023-12-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20793 to look at the new patch set (#6). Change subject: IMPALA-12606: Sporadic failures around query_test.test_queries.TestQueries.test_intersect

[Impala-ASF-CR] IMPALA-12584: Add backend config to restrict data file locations for Iceberg tables

2023-12-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20786 ) Change subject: IMPALA-12584: Add backend config to restrict data file locations for Iceberg tables .. Patch Set 5: Code-Review+2

[Impala-ASF-CR] IMPALA-12606: Sporadic failures around query test.test queries.TestQueries.test intersect

2023-12-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20793 ) Change subject: IMPALA-12606: Sporadic failures around query_test.test_queries.TestQueries.test_intersect .. Patch Set 5:

[Impala-ASF-CR] IMPALA-12606: Sporadic failures around query test.test queries.TestQueries.test intersect

2023-12-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20793 to look at the new patch set (#5). Change subject: IMPALA-12606: Sporadic failures around query_test.test_queries.TestQueries.test_intersect

[Impala-ASF-CR] IMPALA-12606: Sporadic failures around query test.test queries.TestQueries.test intersect

2023-12-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20793 ) Change subject: IMPALA-12606: Sporadic failures around query_test.test_queries.TestQueries.test_intersect .. Patch Set 4: (1

[Impala-ASF-CR] IMPALA-12606: Sporadic failures around query test.test queries.TestQueries.test intersect

2023-12-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20793 to look at the new patch set (#4). Change subject: IMPALA-12606: Sporadic failures around query_test.test_queries.TestQueries.test_intersect

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20760 ) Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables. .. Patch Set 12: (8 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-15 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#12). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 8: (12 comments) Left a few

[Impala-ASF-CR] IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns

2023-12-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20759 ) Change subject: IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns .. Patch Set 5: Code-Review+1 (3

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20760 ) Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables. .. Patch Set 6: (1 comment) Thanks for the review,

[Impala-ASF-CR] IMPALA-12629: Fix Iceberg V2 tests in non-HDFS environment

2023-12-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20803 Change subject: IMPALA-12629: Fix Iceberg V2 tests in non-HDFS environment .. IMPALA-12629: Fix Iceberg V2 tests in non-HDFS

[Impala-ASF-CR] IMPALA-12606: Sporadic failures around query test.test queries.TestQueries.test intersect

2023-12-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20793 to look at the new patch set (#2). Change subject: IMPALA-12606: Sporadic failures around query_test.test_queries.TestQueries.test_intersect

[Impala-ASF-CR] IMPALA-12606: Sporadic failures around query test.test queries.TestQueries.test intersect

2023-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20793 Change subject: IMPALA-12606: Sporadic failures around query_test.test_queries.TestQueries.test_intersect .. IMPALA-12606:

[Impala-ASF-CR] IMPALA-12584: Add backend config to restrict data file locations for Iceberg tables

2023-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20786 ) Change subject: IMPALA-12584: Add backend config to restrict data file locations for Iceberg tables .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20760 ) Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables. .. Patch Set 11: (5 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-13 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#11). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12443: Add catalog timeline for all ddl profiles

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20491 ) Change subject: IMPALA-12443: Add catalog timeline for all ddl profiles .. Patch Set 9: (2 comments) Thanks for working on this,

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#10). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12589: Ignore FbFileDesc.absolutePath() if it is null/empty

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20769 ) Change subject: IMPALA-12589: Ignore FbFileDesc.absolutePath() if it is null/empty .. Patch Set 6: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-12589: Ignore FbFileDesc.absolutePath() if it is null/empty

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20769 ) Change subject: IMPALA-12589: Ignore FbFileDesc.absolutePath() if it is null/empty .. Patch Set 5: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20760 ) Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables. .. Patch Set 8: (19 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#9). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#8). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20760 ) Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables. .. Patch Set 7: (1 comment) PS7 is a rebase (apart

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#7). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20760 ) Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables. .. Patch Set 6: (21 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#6). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 4: (2 comments) The code LGTM!

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20760 ) Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables. .. Patch Set 5: (26 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#5). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#4). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 10: (15 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, Daniel Becker, Gabor Kaszab, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20677 to look at the new patch set (#10). Change subject: IMPALA-12313: (part 2) Limited UPDATE support

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#3). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns

2023-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20759 ) Change subject: IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns .. Patch Set 2: (7 comments) Left some

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 1: (17 comments) Left a few

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#2). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

<    1   2   3   4   5   6   7   8   9   10   >