[Impala-ASF-CR] IMPALA-11539: Mitigate intra-node skew of file scans with MT DOP

2022-09-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Gergely Fürnstáhl, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18929 to look at the new patch set (#6). Change subject: IMPALA-11539: Mitigate intra-node skew of file scans with MT_DOP

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 10: (3 comments) Thanks for th

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-31 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#11). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 posit

[Impala-ASF-CR] IMPALA-11539: Mitigate intra-node skew of file scans with MT DOP

2022-08-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18929 ) Change subject: IMPALA-11539: Mitigate intra-node skew of file scans with MT_DOP .. Patch Set 5: Code-Review+1 Carry +1 from Csaba

[Impala-ASF-CR] IMPALA-11539: Mitigate intra-node skew of file scans with MT DOP

2022-08-31 Thread Zoltan Borok-Nagy (Code Review)
Hello Gergely Fürnstáhl, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18929 to look at the new patch set (#5). Change subject: IMPALA-11539: Mitigate intra-node skew of file scans with MT_DOP

[Impala-ASF-CR] IMPALA-11539: Mitigate intra-node skew of file scans with MT DOP

2022-08-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18929 ) Change subject: IMPALA-11539: Mitigate intra-node skew of file scans with MT_DOP .. Patch Set 3: (14 comments) Thanks for the com

[Impala-ASF-CR] IMPALA-11539: Mitigate intra-node skew of file scans with MT DOP

2022-08-31 Thread Zoltan Borok-Nagy (Code Review)
Hello Gergely Fürnstáhl, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18929 to look at the new patch set (#4). Change subject: IMPALA-11539: Mitigate intra-node skew of file scans with MT_DOP

[Impala-ASF-CR] IMPALA-11543: Print exception message even if throwable to stack trace id fails

2022-08-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18930 ) Change subject: IMPALA-11543: Print exception message even if throwable_to_stack_trace_id fails .. Patch Set 2: Code-Review+1 --

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 10: (6 comments) Thanks for th

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#10). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 posit

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 9: PS9 is a rebase + ORC tests.

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#9). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 positi

[Impala-ASF-CR] IMPALA-11507: Use absolute path when Iceberg data files outside of the table location

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18894 ) Change subject: IMPALA-11507: Use absolute_path when Iceberg data files outside of the table location .. Patch Set 6: (4 comments

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 8: Thanks everyone for the revi

[Impala-ASF-CR] IMPALA-11539: Mitigate intra-node skew of HDFS scans with MT DOP

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18929 to look at the new patch set (#3). Change subject: IMPALA-11539: Mitigate intra-node skew of HDFS scans with MT_DOP ...

[Impala-ASF-CR] IMPALA-11539: Mitigate intra-node skew of HDFS scans with MT DOP

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18929 Change subject: IMPALA-11539: Mitigate intra-node skew of HDFS scans with MT_DOP .. IMPALA-11539: Mitigate intra-node skew of HDFS s

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#8). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 positi

[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 ) Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. Patch Set 5: Code-Review+2 LGTM! -- To view, visit

[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables

2022-08-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 ) Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. Patch Set 3: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 ) Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. Patch Set 2: (3 comments) Looks good! http://gerri

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 7: PS7 is only a rebase. -- T

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#7). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 positi

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 5: (21 comments) Thanks for th

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#6). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 positi

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 4: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 5: (14 comments) Thanks for th

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#5). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 positi

[Impala-ASF-CR](branch-4.1.1) IMPALA-11346: Migrated partitioned Iceberg tables might return ERROR when WHERE condition is used on partition column

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18887 ) Change subject: IMPALA-11346: Migrated partitioned Iceberg tables might return ERROR when WHERE condition is used on partition column ..

[Impala-ASF-CR](branch-4.1.1) IMPALA-9410: Support resolving ORC file columns by names

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18906 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. Patch Set 1: Code-Review+2 Thanks for backporting this

[Impala-ASF-CR](branch-4.1.1) IMPALA-11344: Missing slots in all cases should be allowed to be read

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18907 ) Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR](branch-4.1.1) IMPALA-11346: Migrated partitioned Iceberg tables might return ERROR when WHERE condition is used on partition column

2022-08-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18887 ) Change subject: IMPALA-11346: Migrated partitioned Iceberg tables might return ERROR when WHERE condition is used on partition column ..

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#4). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 positi

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18854 ) Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0 .. IMPALA-11500:

[Impala-ASF-CR] WIP: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#2). Change subject: WIP: IMPALA-11484: Create SCAN plan for Iceberg V2 p

[Impala-ASF-CR] [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 ) Change subject: [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0 .. Patch Set 1: (2 comm

[Impala-ASF-CR](asf-site) Update 4.1.0 release notes with more items

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18845 ) Change subject: Update 4.1.0 release notes with more items .. Patch Set 1: Code-Review+2 Thanks for adding these items! I checked

[Impala-ASF-CR] IMPALA-10800: Tidy up the be/src/exec directory

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18815 ) Change subject: IMPALA-10800: Tidy up the be/src/exec directory .. Patch Set 3: Code-Review+2 Thanks for working on this change!

[Impala-ASF-CR] WIP: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#3). Change subject: WIP: IMPALA-11484: Create SCAN plan for Iceberg V2 p

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 ) Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0 .. Patch Set 3: Code-Revi

[Impala-ASF-CR] WIP: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18847 Change subject: WIP: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. WIP: IMPALA-11484: Create SCAN plan fo

[Impala-ASF-CR] IMPALA-11398: Ignore Flake8 rule E126

2022-08-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18836 Change subject: IMPALA-11398: Ignore Flake8 rule E126 .. IMPALA-11398: Ignore Flake8 rule E126 In Impala we use 2 spaces for indent

[Impala-ASF-CR] IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg tbl (col list)

2022-08-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18790 ) Change subject: IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg_tbl (col_list) .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#10). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 10: (9 comments) Thanks for the

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#9). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11481: Make test runtime profile aggregate slower to avoid flakyness

2022-08-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18825 ) Change subject: IMPALA-11481: Make test_runtime_profile_aggregate slower to avoid flakyness .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 6: Code-Review+1 (1 comment) On

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 8: Code-Review+1 PS8 is only a re

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#8). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg tbl (col list)

2022-08-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18790 ) Change subject: IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg_tbl (col_list) .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-11408: Fill missing partition columns with NULL when INSERT INTO iceberg tbl (col list)

2022-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18790 ) Change subject: IMPALA-11408: Fill missing partition columns with NULL when INSERT INTO iceberg_tbl (col_list) .. Patch Set 2: (1

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 5: (2 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 6: (2 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#7). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-10453: Support file pruning via runtime filters on Iceberg

2022-08-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 ) Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg .. Patch Set 12: (2 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 5: (13 comments) Thanks for the

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#5). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables

2022-07-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18735 ) Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables .. IMPALA

[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables

2022-07-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18735 ) Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables .. Patch Set 4: C

[Impala-ASF-CR] IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables

2022-07-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18639 ) Change subject: IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables .. Patch Set 16: Code-Review+2 (1 comme

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-07-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#4). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 5: Code-Review+1 Nice work! --

[Impala-ASF-CR] IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables

2022-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18639 ) Change subject: IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables .. Patch Set 14: Code-Review+1 (1 comme

[Impala-ASF-CR] IMPALA-11287: [DOCS] Implement cloning between Iceberg tables

2022-07-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18706 ) Change subject: IMPALA-11287: [DOCS] Implement cloning between Iceberg tables .. Patch Set 1: Code-Review+2 Thanks for writing the

[Impala-ASF-CR] IMPALA-11287: [DOCS] Implement cloning between Iceberg tables

2022-07-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18706 ) Change subject: IMPALA-11287: [DOCS] Implement cloning between Iceberg tables .. IMPALA-11287: [DOCS] Implement cloning bet

[Impala-ASF-CR] IMPALA-11414: Off-by-one error in Parquet late materialization

2022-07-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18700 ) Change subject: IMPALA-11414: Off-by-one error in Parquet late materialization .. Patch Set 2: Thanks for the review! -- To view

[Impala-ASF-CR] IMPALA-11419: Incremental build is broken

2022-07-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18708 ) Change subject: IMPALA-11419: Incremental build is broken .. Patch Set 2: Code-Review+2 (2 comments) Carry +2 http://gerrit.clou

[Impala-ASF-CR] IMPALA-11419: Incremental build is broken

2022-07-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Laszlo Gaal (Cloudera), Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18708 to look at the new patch set (#2). Change subject: IMPALA-11419: Incremental build is broken

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-07-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#3). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables

2022-07-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18639 ) Change subject: IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables .. Patch Set 12: (6 comments) Left a f

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

2022-07-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18658 ) Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables .. IMPALA-11287 (part 2): Implement

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

2022-07-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 ) Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables .. Patch Set 9: Code-Review+2 Thanks! LGTM!

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

2022-07-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 ) Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables .. Patch Set 7: Code-Review+2 Thanks for im

[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated

2022-07-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 ) Change subject: IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated .. Patch Set 3: Code-Review+2 Seem

[Impala-ASF-CR] IMPALA-11419: Incremental build is broken

2022-07-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18708 Change subject: IMPALA-11419: Incremental build is broken .. IMPALA-11419: Incremental build is broken IMPALA-11384 broke increment

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-07-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 2: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-11414: Off-by-one error in Parquet late materialization

2022-07-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18700 to look at the new patch set (#2). Change subject: IMPALA-11414: Off-by-one error in Parquet late materialization ..

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

2022-07-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read .. Patch Set 16: (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions

2022-07-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 ) Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions .. Patch Set 11: Code-Review+2 Thank y

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

2022-07-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read .. Patch Set 16: Code-Review+1 Thanks for f

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-07-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18704 Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. IMPALA-11350: Add virtual column FILE__POSITI

[Impala-ASF-CR] IMPALA-11414: Off-by-one error in Parquet late materialization

2022-07-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18700 Change subject: IMPALA-11414: Off-by-one error in Parquet late materialization .. IMPALA-11414: Off-by-one error in Parquet late mat

[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated

2022-07-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 ) Change subject: IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated .. Patch Set 1: Code-Review+2 LGTM

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

2022-07-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read .. Patch Set 12: (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions

2022-07-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 ) Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions .. Patch Set 10: Code-Review+1 (4 comm

[Impala-ASF-CR] IMPALA-11331: Handle concurrent Iceberg INSERT OVERWRITEs

2022-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18648 ) Change subject: IMPALA-11331: Handle concurrent Iceberg INSERT OVERWRITEs .. Patch Set 3: Code-Review+2 (1 comment) One small nit

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

2022-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 ) Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables .. Patch Set 4: (4 comments) Thank you for

[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions

2022-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 ) Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions .. Patch Set 8: (6 comments) Found a

[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone

2022-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 ) Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone .. Patch Set 5: Code-Revie

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set 9:

[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone

2022-06-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 ) Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone .. Patch Set 4: (1 commen

[Impala-ASF-CR] IMPALA-11391: Fixed race condition in test drop managed kudu table

2022-06-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18667 ) Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table .. Patch Set 2: Code-Review+2 Thanks for fixin

[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone

2022-06-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 ) Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone .. Patch Set 1: (2 commen

[Impala-ASF-CR] IMPALA-11403: Fix cmake escaping for sed regex in common/thrift

2022-06-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18678 ) Change subject: IMPALA-11403: Fix cmake escaping for sed regex in common/thrift .. Patch Set 1: Code-Review+2 LGTM! -- To view,

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set 9:

[Impala-ASF-CR] IMPALA-11279: Optimize plain count(*) queries for Iceberg tables

2022-06-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18574 ) Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables .. Patch Set 15: Code-Review+2 Great work! Thanks

[Impala-ASF-CR] IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases

2022-06-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18649 ) Change subject: IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases .. Patch Set 1: (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs

2022-06-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18648 ) Change subject: IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs .. Patch Set 1: (9 comments) Found a couple of nits, bu

[Impala-ASF-CR] IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases

2022-06-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18649 ) Change subject: IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases .. Patch Set 1: (2 comments) Thanks for

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set 5:

<    4   5   6   7   8   9   10   11   12   13   >