[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. IMPALA-3816: Codegen perf critical loops in Sorte

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 14: Verified+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 14: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 14: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-09 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. IMPALA-3816: Codegen perf critical loops in Sorter This fix added th

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 13: Code-Review+2 (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 13: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-05 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 13: One change was made in SortPlanNode::Codegen() to che

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-05 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. IMPALA-3816: Codegen perf critical loops in Sorter This fix added th

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 12: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-04 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. IMPALA-3816: Codegen perf critical loops in Sorter This fix added th

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 11: Verified-1 Build failed: https://jenkins.i

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 11: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 11: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 10: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-03 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. IMPALA-3816: Codegen perf critical loops in Sorter This fix added th

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-03 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/1662

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 9: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-02 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/16621

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-02 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. IMPALA-3816: Codegen perf critical loops in Sorter This fix added the

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-10-27 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/16621

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-10-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/16

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-10-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-10-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/16

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 8: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-10-26 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. IMPALA-3816: Codegen perf critical loops in Sorter This fix added the

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-26 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. Patch Set 7: (8 comments) Thanks a lot Csaba and Daniel! On the co

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. Patch Set 7: (5 comments) Great work! Aside from the nits, I won

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. Patch Set 7: Code-Review+1 (3 comments) lgtm, only nits http:

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. Patch Set 7: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. Patch Set 6: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. IMPALA-3816 Codegen perf critical loops in Sorter This fix added the f

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. IMPALA-3816 Codegen perf critical loops in Sorter This fix added the f

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. Patch Set 4: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. Patch Set 3: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. IMPALA-3816 Codegen perf critical loops in Sorter This fix added the f

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. IMPALA-3816 Codegen perf critical loops in Sorter This fix added the f

[Impala-ASF-CR] IMPALA-3816 Codegen perf critical loops in Sorter

2020-10-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816 Codegen perf critical loops in Sorter .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:808