[native-toolchain-CR] Update cmake to 3.14.3

2019-05-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13286 To

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Update cmake to 3.14.3 This updates to the latest cmake, which includes a few

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-14 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 2: Code-Review+2 The last patch set passed our internal automated build. The two

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: I don't think that's right. Looking at the CMakeLists.txt file, it has:

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: The cmake tweak symbol should be KWSYSPE_USE_SELECT instead of

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Todd Lipcon (Code Review)
Hello Laszlo Gaal, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13286 to look at the new patch set (#2). Change subject: Update cmake to 3.14.3 .. Update cmake to 3.14.3

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: Oh, looks like maybe it's a bug in the CMakeLists.txt. the if() statement uses

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: For those watching at home, it looks like this hit a build failure when

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13286 To

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13286 to review the following change. Change subject: Update cmake to 3.14.3 .. Update cmake to 3.14.3 This updates to