[Impala-ASF-CR] IMPALA-7039: Ignore the port in HBase planner tests

2018-05-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10459 Change subject: IMPALA-7039: Ignore the port in HBase planner tests .. IMPALA-7039: Ignore the port in HBase planner tests Before t

[Impala-ASF-CR] IMPALA-7019: Schedule EC as remote & disable failed tests

2018-05-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 ) Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests .. Patch Set 5: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-05-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/6023/15/

[Impala-ASF-CR] IMPALA-7079: Disable the multiple blocks test in erasure coding build

2018-05-25 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10521 Change subject: IMPALA-7079: Disable the multiple blocks test in erasure coding build .. IMPALA-7079: Disable the multiple blocks t

[Impala-ASF-CR] IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10599 Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py .. IMPALA-6642 (Part 1): Fix the log directory fo

[Impala-ASF-CR] IMPALA-7102: Disable support of erasure coding by default

2018-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10646 Change subject: IMPALA-7102: Disable support of erasure coding by default .. IMPALA-7102: Disable support of erasure coding by defau

[Impala-ASF-CR] IMPALA-7149: Skip q7 in test mem usage scaling in erasure coding build

2018-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10647 Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build .. IMPALA-7149: Skip q7 in test_mem_usage_sc

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: I already let Anuj know offline that it's ok to remove th

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 15: Also, I agree with Tim that it's a good idea to add this

[Impala-ASF-CR] IMPALA-6642 (Part 2): Add timestamps to start-impala-cluster.py

2018-06-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10780 Change subject: IMPALA-6642 (Part 2): Add timestamps to start-impala-cluster.py .. IMPALA-6642 (Part 2): Add timestamps to start-imp

[Impala-ASF-CR] IMPALA-6642 (Part 2): Add timestamps to start-impala-cluster.py

2018-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): Add timestamps to start-impala-cluster.py .. Patch Set 1: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py

2018-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. IMPALA-6642 (Part 2): clean up start-impala-cluster.py We

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7149: Disable some tests in the EC build

2018-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10804 Change subject: IMPALA-7149: Disable some tests in the EC build .. IMPALA-7149: Disable some tests in the EC build We temporarily d

[Impala-ASF-CR] IMPALA-7102: Disable support of erasure coding by default

2018-06-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102: Disable support of erasure coding by default .. Patch Set 1: (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7102(Part 1): Disable reading of erasure coding by default

2018-06-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102(Part 1): Disable reading of erasure coding by default .. IMPALA-7102(Part 1): Disable reading of erasure

[Impala-ASF-CR] IMPALA-7102 (Part 1): Disable reading of erasure coding by default

2018-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102 (Part 1): Disable reading of erasure coding by default .. IMPALA-7102 (Part 1): Disable reading of erasu

[Impala-ASF-CR] IMPALA-7102 (Part 1): Disable reading of erasure coding by default

2018-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102 (Part 1): Disable reading of erasure coding by default .. Patch Set 4: Code-Review+2 Fixed a typo in

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/6023/20/

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7236: Fix the parsing of ALLOW ERASURE CODED FILES

2018-07-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10857 ) Change subject: IMPALA-7236: Fix the parsing of ALLOW_ERASURE_CODED_FILES .. Patch Set 1: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test

2018-07-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10859 Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test .. IMPALA-7202: Add width_bucket() to the decimal fuzz test

[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test

2018-07-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 ) Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test .. Patch Set 1: Yeah, those should probably be merged bef

[Impala-ASF-CR] IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate

2018-07-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10882 ) Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate .. Patch Set 3: (2 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-7260: Fix decimal binary predicates

2018-07-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10888 Change subject: IMPALA-7260: Fix decimal binary predicates .. IMPALA-7260: Fix decimal binary predicates When casting the inputs to

[Impala-ASF-CR] IMPALA-7260: Fix decimal binary predicates

2018-07-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10888 ) Change subject: IMPALA-7260: Fix decimal binary predicates .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10888

[Impala-ASF-CR] IMPALA-7260: Fix decimal binary predicates

2018-07-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10888 ) Change subject: IMPALA-7260: Fix decimal binary predicates .. IMPALA-7260: Fix decimal binary predicates When casting the inputs to

[Impala-ASF-CR] IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate

2018-07-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10882 ) Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate .. Patch Set 3: (2 comments) http://gerrit.c

[Impala-ASF-CR] PREVIEW: IMPALA-7211: Fix the between predicate for decimals

2018-07-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10898 Change subject: PREVIEW: IMPALA-7211: Fix the between predicate for decimals .. PREVIEW: IMPALA-7211: Fix the between predicate for

[Impala-ASF-CR] IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate

2018-07-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10882 ) Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate .. Patch Set 4: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-7260: Fix decimal binary predicates

2018-07-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10888 ) Change subject: IMPALA-7260: Fix decimal binary predicates .. IMPALA-7260: Fix decimal binary predicates When casting the inputs to

[Impala-ASF-CR] PREVIEW: IMPALA-7211: Fix the between predicate for decimals

2018-07-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10898 ) Change subject: PREVIEW: IMPALA-7211: Fix the between predicate for decimals .. Patch Set 1: (3 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7211: Fix the between predicate for decimals

2018-07-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10898 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. IMPALA-7211: Fix the between predicate for decimals Before th

[Impala-ASF-CR] IMPALA-2422: Fix escaping in the LIKE clause

2018-07-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10910 Change subject: IMPALA-2422: Fix escaping in the LIKE clause .. IMPALA-2422: Fix escaping in the LIKE clause There are two stages t

[Impala-ASF-CR] IMPALA-7211: Fix the between predicate for decimals

2018-07-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10898 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-7211: Fix the between predicate for decimals

2018-07-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10898 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. IMPALA-7211: Fix the between predicate for decimals Before th

[Impala-ASF-CR] IMPALA-7211: Fix the between predicate for decimals

2018-07-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10898 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. Patch Set 3: Code-Review+2 Rebased. Forwarding the +2 --

[Impala-ASF-CR] IMPALA-7211: Fix the between predicate for decimals

2018-07-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10898 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. IMPALA-7211: Fix the between predicate for decimals Before th

[Impala-ASF-CR] IMPALA-2422: Fix escaping in the LIKE clause

2018-07-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10910 ) Change subject: IMPALA-2422: Fix escaping in the LIKE clause .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/109

[Impala-ASF-CR] IMPALA-2422: Fix escaping in the LIKE clause

2018-07-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10910 ) Change subject: IMPALA-2422: Fix escaping in the LIKE clause .. IMPALA-2422: Fix escaping in the LIKE clause There are two stages to

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 3: This is on top of the Decimal addition patch. I'm waiting

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8309/4/be/src/exp

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. IMPALA-5019: Decimal V2 addition In this patch, we implement the new decimal retu

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 5: Patch 5 is a rebase. -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 5: Code-Review+1 Carrying the +1 from Tim -- To view, visit http://

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 4: Code-Review-1 The current plan is to go in a c

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8309/4/be/src/exp

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8309/4/be/src/exp

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-11-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8309/4/be/src/exp

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-11-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 9: (20 comments) http://gerrit.cloudera.org:8080/#/c/6023/9/

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-11-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6023/9/be

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-11-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. IMPALA-4964: Fix Decimal modulo overflow The modulo operation between two

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 3: Code-Review+2 Looks good! -- To view, visit

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8404/2/be/s

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. IMPALA-5017: Error on decimal overflow Before this patch, decimal operation

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. IMPALA-5017: Error on decimal overflow Before this patch, decimal operation

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8404/3/be/s

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8404/4//COM

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-12-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. IMPALA-5017: Error on decimal overflow Before this patch, decimal operation

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-12-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. Patch Set 5: Code-Review+2 Made a small adjustment to test_hs2.py. Forwar

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8774 Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. IMPALA-5014: Part 1: Round when casting string to decima

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 17: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6292: Fix incorrect DCHECK in decimal subtraction

2017-12-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8796 Change subject: IMPALA-6292: Fix incorrect DCHECK in decimal subtraction .. IMPALA-6292: Fix incorrect DCHECK in decimal subtraction

[Impala-ASF-CR] IMPALA-5191: Behavior of column aliases should be more standard conforming

2017-12-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Behavior of column aliases should be more standard conforming .. Patch Set 3: (7 comments) http://ge

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. IMPALA-5014: Part 1: Round when casting string to decimal

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 1: (11 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/88

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-12-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has abandoned this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Abandoned We decided that rounding a double should return a double (

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 5: Code-Review+1 Looks good to me. Alex, maybe you can

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2017-12-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/880

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8833 Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8836 Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. IMPALA-6284: Mark the intermediate decimal avg str

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: I'm not really sure what a new test

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 1: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. IMPALA-6284: Mark the intermediate decimal avg stru

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo o

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/8833/1/b

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. IMPALA-5014: Part 1: Round when casting string to decimal

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/8833/1/b

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. IMPALA-6284: Mark the intermediate decimal avg stru

[Impala-ASF-CR] IMPALA-6284: Mark the intermediate decimal avg struct as packed

2017-12-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8836 ) Change subject: IMPALA-6284: Mark the intermediate decimal avg struct as packed .. Patch Set 3: Code-Review+2 Fixed the expected si

[Impala-ASF-CR] IMPALA-6231: Implement decimal v2 fuzz test

2017-12-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8898 Change subject: IMPALA-6231: Implement decimal_v2 fuzz test .. IMPALA-6231: Implement decimal_v2 fuzz test Implement a test that gen

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8833/2/b

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo o

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo o

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 1: It might be worth thinking about how to address the prob

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: I agree that it's probably best to unblock first. Making

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 3: (2 comments) Thanks for the review, Zach

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. IMPALA-5014: Part 1: Round when casting string to decimal

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 4: Code-Review+2 Fixed the issue with the te

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8833/4/b

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo o

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 5: Code-Review+2 Made a minor change to overflow benchmark. F

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. IMPALA-6300: Fix decimal modulo overflow In order to compute the modulo o

[Impala-ASF-CR] IMPALA-6300: Fix decimal modulo overflow

2017-12-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8833 ) Change subject: IMPALA-6300: Fix decimal modulo overflow .. Patch Set 6: Code-Review+2 Rebased and resolved conflicts. Forwarding t

<    1   2   3   >