[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 3: (3 comments) couple of sm

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 13: carry alex's +2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#14). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: noticed a discrepancy in the s3 ranges from run-to-run for p

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#15). Change subject: IMPALA-4993: extend dictionary filtering to collections .

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: clang-tidy on gvo found an issue. latest patch

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: thanks for catching this! looking into it. -

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 4: (5 comments) http://gerri

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-15 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#16). Change subject: IMPALA-4993: extend dictionary filtering to collections .

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: (3 comments) update fixes the bug tim spotted

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 6: (4 comments) http://gerri

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-17 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#17). Change subject: IMPALA-4993: extend dictionary filtering to collections .

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 16: Added a regression test and new data set. I f

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-17 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#18). Change subject: IMPALA-4993: extend dictionary filtering to collections .

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-17 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#5). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ...

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-17 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#6). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ...

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 1: (1 comment) missing test file? http://ge

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 18: (2 comments) after a couple glitches with loa

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-18 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#19). Change subject: IMPALA-4993: extend dictionary filtering to collections .

[Impala-ASF-CR] IMPALA-6092: turn off flaky test temporarily.

2018-01-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9080 Change subject: IMPALA-6092: turn off flaky test temporarily. .. IMPALA-6092: turn off flaky test temporarily. The reason for the flake

[Impala-ASF-CR] IMPALA-6092: turn off flaky test temporarily.

2018-01-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9080 ) Change subject: IMPALA-6092: turn off flaky test temporarily. .. Patch Set 1: The fix for IMPALA-6215 is intended to address this. Shou

[Impala-ASF-CR] IMPALA-6092: turn off flaky test temporarily.

2018-01-19 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9080 to look at the new patch set (#2). Change subject: IMPALA-6092: turn off flaky test temporarily.

[Impala-ASF-CR] IMPALA-6092: turn off flaky test temporarily.

2018-01-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9080 ) Change subject: IMPALA-6092: turn off flaky test temporarily. .. Patch Set 1: yes, that's less extreme than the current patch. lets see

[Impala-ASF-CR] IMPALA-6092: run flaky test serially (temporary).

2018-01-19 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9080 to look at the new patch set (#3). Change subject: IMPALA-6092: run flaky test serially (temporary). .

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9089 Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215: Removes race when using LibCache. LibCache's api to provi

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215: Removes race when using LibCache. LibCache's api to provid

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-21 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#7). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ...

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 7: (6 comments) in addition to the comments, de

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-22 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#8). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ...

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 2: (2 comments) Absolutely agree that lib-cache api is bit

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-23 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#3). Change subject: IMPALA-6215: Removes race when using LibCache. ..

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 8: Code-Review+1 carry +1 from dimitris -- To

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 3: (1 comment) jira for further cleanup: IMPALA-6439 http

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-24 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#4). Change subject: IMPALA-6215: Removes race when using LibCache. ..

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9133 Change subject: IMPALA-3562: support column restriction for compute stats .. IMPALA-3562: support column restriction for compute stats T

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. IMPALA-3562: support column restriction for compute stats Th

[Impala-ASF-CR] IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9113 ) Change subject: IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE .. Patch Set 1: (5 comments) looks good, just a couple of

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 4: Code-Review+1 carry the +1 from Bikram. any takers to +

[Impala-ASF-CR] IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9113 ) Change subject: IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE .. Patch Set 2: Code-Review+1 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/9089/4

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#5). Change subject: IMPALA-6215: Removes race when using LibCache. ..

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9089/5/

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 5: next change replaces the explicitly managed opaque cache

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#6). Change subject: IMPALA-6215: Removes race when using LibCache. ...

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/9089/6

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#7). Change subject: IMPALA-6215: Removes race when using LibCache. ...

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9089/7/

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#8). Change subject: IMPALA-6215: Removes race when using LibCache. ...

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 8: clang tidy found an issue.. update fixes it and what see

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-29 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#9). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-30 Thread Vuk Ercegovac (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9133 to look at the new patch set (#3). Change subject: IMPALA-3562: support column restriction for compute stats .. IMPALA-

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-30 Thread Vuk Ercegovac (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9133 to look at the new patch set (#4). Change subject: IMPALA-3562: support column restriction for compute stats .. IMPALA-

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9139 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 1: (6 comments) looks good. mostly nit comments an

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 8: (1 comment) latest change includes formattin

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-30 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#9). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 4: Looks like this failed due to: https://issue

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9139 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 8: (9 comments) thanks for the changes-- its

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 4: rebased with fixed conflicts. -- To view, v

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-31 Thread Vuk Ercegovac (Code Review)
Hello Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9133 to look at the new patch set (#5). Change subject: IMPALA-3562: support column restriction for compute stats

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9139 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-31 Thread Vuk Ercegovac (Code Review)
Hello Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9133 to look at the new patch set (#6). Change subject: IMPALA-3562: support column restriction for compute stats

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 6: latest patch fixes a failure in gvo. would an

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 9: (15 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 5: (3 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 7: Code-Review+1 (1 comment) htt

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 10: (10 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: decided to assert that all plans should be the same on all f

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has abandoned this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/8890 To unsubscribe, vi

[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9244 Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Revert "IMPALA-6215: Removes race when using LibCache." This

[Impala-ASF-CR] Revert "IMPALA-6215: Removes race when using LibCache."

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9244 ) Change subject: Revert "IMPALA-6215: Removes race when using LibCache." .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9232 ) Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. Patch Set 1: quick comment here... is there any

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9251 Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. IMPALA-4475: part 1, reduce size of TExecQueryFInstance

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-02-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9251 ) Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. Patch Set 1: yes, that's what the Compact protocol in

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 12: (10 comments) couple of proposals for si

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 13: Code-Review+1 (2 comments) minor comment

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-02-12 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#10). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ...

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-02-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 9: (14 comments) main changes: (1) minimized ch

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/8958/3

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9195/3

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 4: Code-Review+1 (5 comments) thanks for the refactor and d

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9195/8

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-02-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 9: Code-Review+1 lgtm. would anyone with more experience w

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-02-19 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Dimitris Tsirogiannis, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#11). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls ...

[Impala-ASF-CR] IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh

2018-03-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9497 Change subject: IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh .. IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefres

[Impala-ASF-CR] IMPALA-6602: fixes flaky expiration test

2018-03-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9538 Change subject: IMPALA-6602: fixes flaky expiration test .. IMPALA-6602: fixes flaky expiration test The test_query_expiration test assu

[Impala-ASF-CR] IMPALA-6602: fixes flaky expiration test

2018-03-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9538 ) Change subject: IMPALA-6602: fixes flaky expiration test .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9538/1/tests

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-03-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-03-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6602: fixes flaky expiration test

2018-03-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9538 ) Change subject: IMPALA-6602: fixes flaky expiration test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9538/1/tests/

[Impala-ASF-CR] IMPALA-6602: fixes flaky expiration test

2018-03-07 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9538 to look at the new patch set (#2). Change subject: IMPALA-6602: fixes flaky expiration test .. IMPALA-6602: fixes f

<    1   2   3   4   5   6   7   8   9   >