[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#9). Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. IMPALA-3902: Scheduler improvements for running multiple frag

Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson
Huh, the GVO failed when the same job passed just fine when run manually. Looks possibly like the machine had trouble, but looking into it. On 19 September 2016 at 19:43, Internal Jenkins (Code Review) < ger...@cloudera.org> wrote: > Internal Jenkins has posted comments on this change. > > Change

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#8). Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. IMPALA-3902: Scheduler improvements for running multiple frag

[Impala-ASF-CR] IMPALA-889: Add support for ISO-SQL trim()

2016-09-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/4474/1//COMMIT_MSG Commit Message: Line 10: Form #1: Im

[Impala-ASF-CR] IMPALA-889: Add support for ISO-SQL trim()

2016-09-19 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/4474 Change subject: IMPALA-889: Add support for ISO-SQL trim() .. IMPALA-889: Add support for ISO-SQL trim() Add support for an ISO-SQL compli

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 5: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/2

[Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config file path to make extra spaces visible.

2016-09-19 Thread Anonymous Coward (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4309 to look at the new patch set (#5). Change subject: IMPALA-4028: Improve message for improper Sentry config file path to make extra spaces visible. .

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4390/3/be/src/codegen/llvm-codegen.cc Fi

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. IMPALA-4008: Don't bake ExprContext pointers into IR code To allow genearated code to be shared across mu

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#5). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. IMPALA-4026: Implement double-buffering for BlockingQueue With recent changes to improve the parquet scan

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/4350/4/be/src/util/blocking-queue.h File

Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Matthew Jacobs
Yup, sure thing On Mon, Sep 19, 2016 at 4:54 PM, Henry Robinson wrote: > Sounds good - if it's ok by you, will do in a separate commit since the > first one is well into GVO-land... > > On 19 September 2016 at 16:19, Matthew Jacobs (Code Review) > wrote: >> >> Matthew Jacobs has posted comments

Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson
Sounds good - if it's ok by you, will do in a separate commit since the first one is well into GVO-land... On 19 September 2016 at 16:19, Matthew Jacobs (Code Review) < ger...@cloudera.org> wrote: > Matthew Jacobs has posted comments on this change. > > Change subject: IMPALA-4160: Remove Llama s

[Impala-ASF-CR] IMPALA-1616: Improve the Memory Limit Exceeded error report

2016-09-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4335 To unsubscribe,

[Impala-ASF-CR] IMPALA-1616: Improve the Memory Limit Exceeded error report

2016-09-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report .. IMPALA-1616: Improve the Memory Limit Exceeded error report The error report has been

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 5: (3 comments) a few more small things to remove http://gerrit.cloudera.org:8080/#/c/4445/5/testdata/cluster/

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4390/3/be/src/exec/partitioned-aggrega

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 5: (2 comments) It seems regardless of database, Kudu tables live in the same Kudu namespace. In order to

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4390/3/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname .. Patch Set 2: See comments on your other patch - I think you can make the changes requested her

[Impala-ASF-CR] IMPALA-4057:fix webserver interface with 127.0.0.1 when start impala process

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4057:fix webserver_interface with 127.0.0.1 when start impala process .. Patch Set 1: (6 comments) Sorry for the delay - looks pretty good, just a few

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/query-schedule.cc File be/src/sche

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4445 to look at the new patch set (#5). Change subject: IMPALA-4160: Remove Llama support. .. IMPALA

[Impala-ASF-CR] IMPALA-4028: Trim sentry config file path spaces while impala start.

2016-09-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4028: Trim sentry config file path spaces while impala start. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4309/4//COMMIT_MSG Commit Mes

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#7). Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. IMPALA-3902: Scheduler improvements for running multiple frag

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/query-schedule.cc

[Impala-ASF-CR] IMPALA-4053: Address follow up comments for IMPALA-3610

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4053: Address follow up comments for IMPALA-3610 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4306/2/be/src/runtime/coordinator.cc Fi

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4445 to look at the new patch set (#4). Change subject: IMPALA-4160: Remove Llama support. .. IMPALA-4160: Remove Llam

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4445/3/be/src/scheduling/request-pool-service.cc File be/src

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/4414/1/testdata/bin/generate-sc

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4445/3/be/src/scheduling/request-pool-service.

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/4445/1//COMMIT_MSG Commit Message: Line 7: Remove Llama s

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4160: Remove Llama support. .. IMPALA-4160: Remove Llama support. Alas, poor Llama! I knew him, Impala: a system of infinite jest, of most excellent fancy:

[Impala-ASF-CR] IMPALA-4610: Remove Llama support.

2016-09-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4610: Remove Llama support. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4445/1//COMMIT_MSG Commit Message: Line 7: Remove Llama sup

[Impala-ASF-CR] IMPALA-4028: Trim sentry config file path spaces while impala start.

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4028: Trim sentry config file path spaces while impala start. .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4309 To un

[Impala-ASF-CR] IMPALA-4610: Remove Llama support.

2016-09-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4610: Remove Llama support. .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/4445/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4610: R

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-19 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#10). Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION Just like Hive, Imp

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-19 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#10). Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION Just like Hive, Imp

[Impala-ASF-CR] IMPALA-4610: Remove Llama support.

2016-09-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4610: Remove Llama support. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4445/2//COMMIT_MSG Commit Message: PS2, Line 7: 4610 Wro

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File be/src/exprs/exp

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File be/src/exprs

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 1: This depends on https://gerrit.cloudera.org/#/c/3873/ (I based it on that to avoid a

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4448 Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. IMPALA-4023: don't attach buffered tuple streams to batche

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File be/src/exprs/exp

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#6). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment i

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-19 Thread Tim Armstrong (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3873 to look at the new patch set (#18). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 18: Code-Review+1 Carry +_1 -- To view, visit http://gerrit.cloudera.org:8080/3873 To unsu

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 17: (6 comments) http://gerrit.cloudera.org:8080/#/c/3873/14/be/src/exec/partitioned-hash-j

[Impala-ASF-CR] IMPALA-4610: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4610: Remove Llama support. .. Patch Set 1: (4 comments) Matt's going to weigh in on what parts of the memory estimation path we can remove, depending

[Impala-ASF-CR] IMPALA-4610: Remove Llama support.

2016-09-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4610: Remove Llama support. .. IMPALA-4610: Remove Llama support. Alas, poor Llama! I knew him, Impala: a system of infinite jest, of most excellent fancy:

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File be/src/exprs

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File be/src/exprs/exp

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File be/src/exprs

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File be/src/exprs/exp

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 4: (8 comments) I'm ok with this option if it generally provides better perf and avoids

[Impala-ASF-CR] IMPALA-4053: Address follow up comments for IMPALA-3610

2016-09-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4053: Address follow up comments for IMPALA-3610 .. Patch Set 2: (1 comment) let's put this on hold until mostafa verifies that the general approach f

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (2 comments) No problems, just wanted to make sure that this patch made it it. http://gerrit.clou

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread segelyang (Code Review)
segelyang has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: I had a holiday last week and am sorry for late. I have uploaded a new patch. Please help to review.

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread segelyang (Code Review)
segelyang has uploaded a new patch set (#3). Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. IMPALA-3308: Get expr-test passing on PPC64LE When using gcc 5+ (which introduced a new library ABI that includes new