Alex Behm has posted comments on this change.
Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
..
Patch Set 3:
Great, thanks! I'll get this merged for you.
--
To view, visit http://gerrit.clouder
Yuanhao Luo has posted comments on this change.
Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
..
Patch Set 3:
Yes, I have walk around other planner tests in this file(but not other files),
and
Alex Behm has posted comments on this change.
Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
..
Patch Set 4: Code-Review+2
rebased
--
To view, visit http://gerrit.cloudera.org:8080/4753
To unsu
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4767
Change subject: IMPALA-4285: Fix Parquet scanner with MT_DOP > 0 and no
materialized slots.
..
IMPALA-4285: Fix Parquet scanner with MT_DOP
Alex Behm has posted comments on this change.
Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
..
Patch Set 3: Code-Review+2
Did you check whether the expected output of other planner tests changed
Yuanhao Luo has uploaded a new patch set (#3).
Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
..
IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
StmtRewrite lost parentheses of Comp
Yuanhao Luo has posted comments on this change.
Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
..
Patch Set 3:
Thank you for your patience.
--
To view, visit http://gerrit.cloudera.org:8080/475
Alex Behm has posted comments on this change.
Change subject: IMPALA-2521: Add clustered hint to insert statements
..
Patch Set 5:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/4745/5/fe/src/main/java/org/apache/impala/anal
Alex Behm has posted comments on this change.
Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
..
Patch Set 2:
(3 comments)
Thanks for adding the test. Almost good to be merged.
http://gerrit.clo
Alex Behm has posted comments on this change.
Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4732
To unsubscribe, visit ht
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3739: Enable stress tests on Kudu
..
Patch Set 9: Verified-1
Build failed:
http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4269: Codegen merging exchange node
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4759
To unsubscribe, visit http://ger
Lars Volker has uploaded a new patch set (#5).
Change subject: IMPALA-2521: Add clustered hint to insert statements
..
IMPALA-2521: Add clustered hint to insert statements
This change introduces a clustered/noclustered hint for
Lars Volker has posted comments on this change.
Change subject: IMPALA-2521: Add clustered hint to insert statements
..
Patch Set 4:
(8 comments)
> (8 comments)
>
> Nice! Current PS looks good to me. Do you intent to add Ku
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4269: Codegen merging exchange node
..
IMPALA-4269: Codegen merging exchange node
This change enables codegen for the tuple row comparator
use
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-3739: Enable stress tests on Kudu
..
Patch Set 9: Code-Review+2
Rebase and carry MJ's +2.
--
To view, visit http://gerrit.cloudera.org:8080/4327
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables
..
Patch Set 12: Code-Review+1
Fixed some test loading issues and modified the dropTable()
Hello Michael Brown, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4414
to look at the new patch set (#12).
Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables
.
Yuanhao Luo has uploaded a new patch set (#2).
Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
..
IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
StmtRewrite lost parentheses of Comp
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3420: use gold by default
..
IMPALA-3420: use gold by default
Also pass the flag that enables ld.gold directly to the
compiler. This is unders
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3420: use gold by default
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4751
To unsubscribe, visit http://gerrit.cloude
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-1169: Admission control info on the queries debug webpage
..
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/4756/1//COMMIT_MSG
Co
Thomas Tauber-Marshall has uploaded a new patch set (#2).
Change subject: IMPALA-1169: Admission control info on the queries debug webpage
..
IMPALA-1169: Admission control info on the queries debug webpage
Previously, the /quer
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.
..
Patch Set 6:
Build failed:
http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-me
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3676,4321: Use clang as a static analysis tool
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4758/1/be/src/util/aligned-new.h
File be/s
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4023: don't attach buffered tuple streams to batches
..
Patch Set 8:
(2 comments)
Yeah, I was thinking we could always attach resources to make it unambiguou
Michael Ho has uploaded a new patch set (#3).
Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function
..
IMPALA-4120: Incorrect results with LEAD() analytic function
This change fixes a memory management pro
Michael Ho has posted comments on this change.
Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function
..
Patch Set 2:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/4740/2/be/src/exec/analytic-eval-node
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3676,4321: Use clang as a static analysis tool
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt
File be/CMakeLis
Alex Behm has posted comments on this change.
Change subject: IMPALA-3725 Support Kudu UPSERT in Impala
..
Patch Set 8:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/4047/8/fe/src/main/java/org/apache/impala/analysis/Insert
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
..
IMPALA-4230: ASF policy issues from 2.7.0 rc3.
In our IPMC vote to release 2.7.0 rc3, Justing Mclea
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http:/
Jim Apple has uploaded a new patch set (#3).
Change subject: IMPALA-3676,4321: Use clang as a static analysis tool
..
IMPALA-3676,4321: Use clang as a static analysis tool
This patch adds a script to run clang-tidy over the whol
Alex Behm has uploaded a new patch set (#4).
Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting
classes.
..
IMPALA-4309: Introduce Expr rewrite phase and supporting classes.
Introduces a new phase for rewr
Alex Behm has posted comments on this change.
Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting
classes.
..
Patch Set 2:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/4746/2/fe/src/main/java/org/apac
Jim Apple has posted comments on this change.
Change subject: IMPALA-3676,4321: Use clang as a static analysis tool
..
Patch Set 3:
(23 comments)
http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt
File be/CMakeLists.
Alex Behm has posted comments on this change.
Change subject: IMPALA-2521: Add clustered hint to insert statements
..
Patch Set 4:
(8 comments)
Nice! Current PS looks good to me. Do you intent to add Kudu support in a
separat
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for
fragments with Kudu scan node
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.clouder
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.
..
Patch Set 6:
Build failed:
http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-me
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4047
to look at the new patch set (#8).
Change subject: IMPALA-3725 Support Kudu UPSERT in Impala
..
IMPALA-3725 Suppo
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-3725 Support Kudu UPSERT in Impala
..
Patch Set 8:
(16 comments)
http://gerrit.cloudera.org:8080/#/c/4047/7//COMMIT_MSG
Commit Message:
Line 18
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for
fragments with Kudu scan node
..
IMPALA-3920: TotalStorageWaitTime counter not populated
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting
classes.
..
Patch Set 2:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/4746/2/fe/src/main/ja
Alex Behm has posted comments on this change.
Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting
classes.
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4746/2/fe/src/main/java/org/apac
Alex Behm has uploaded a new patch set (#3).
Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting
classes.
..
IMPALA-4309: Introduce Expr rewrite phase and supporting classes.
Introduces a new phase for rewr
Alex Behm has posted comments on this change.
Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.cc
File be/src/
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.cc
File be
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4269: Codegen merging exchange node
..
Patch Set 1: Code-Review+2
Change is a straightforward application of an existing pattern and I'm
confident we hav
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.
..
Patch Set 6: Verified-1
Build failed:
http://sandbox.jenkins.cloudera.com/job/impala-external-gerri
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4759
Change subject: IMPALA-4269: Codegen merging exchange node
..
IMPALA-4269: Codegen merging exchange node
This change enables codegen for th
Todd Lipcon has posted comments on this change.
Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.cc
File be/sr
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function
..
Patch Set 2:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/4740/2/be/src/exec/analytic-eval-
Alex Behm has posted comments on this change.
Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements
..
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.c
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3676,4321: Use clang as a static analysis tool
..
Patch Set 1:
(23 comments)
http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt
File be/CMakeLi
Matthew Jacobs has uploaded a new patch set (#4).
Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements
..
IMPALA-4134,IMPALA-3704: Kudu INSERT improvements
1.) IMPALA-4134: Use Kudu AUTO FLUSH
Improves performance o
Lars Volker has uploaded a new patch set (#4).
Change subject: IMPALA-2521: Add clustered hint to insert statements
..
IMPALA-2521: Add clustered hint to insert statements
This change introduces a clustered/noclustered hint for
Lars Volker has posted comments on this change.
Change subject: IMPALA-2521: Add clustered hint to insert statements
..
Patch Set 4:
(24 comments)
Thanks for the comments, please see PS4. As pointed out in one of the replies I
Lars Volker has uploaded a new patch set (#3).
Change subject: IMPALA-2521: Add clustered hint to insert statements
..
IMPALA-2521: Add clustered hint to insert statements
This change introduces a clustered/noclustered hint for
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4728/2/be/src/exec/kudu-table-sink.cc
File be
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4732
To unsubscribe, vis
Michael Ho has posted comments on this change.
Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4755
To unsubscribe, visi
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4728/2/be/src/exec/kudu-table-sink.cc
File b
Michael Ho has posted comments on this change.
Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4740/1/be/src/exprs/agg-fn-evaluator.h
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function
..
IMPALA-4120: Incorrect results with LEAD() analytic function
This change fixes a memory management pro
Alex Behm has posted comments on this change.
Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4732/4/fe/src/main/java/org/apache/impala/an
Michael Ho has posted comments on this change.
Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4740/1//COMMIT_MSG
Commit Message:
P
Alex Behm has uploaded a new patch set (#5).
Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.
..
IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.
AnayticExpr.analyze() replaces the original FIRST/LAST
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-3676,4321: Use clang as a static analysis tool
..
IMPALA-3676,4321: Use clang as a static analysis tool
This patch adds a script to run clang-tidy over the whol
Jim Apple has posted comments on this change.
Change subject: IMPALA-3420: use gold by default
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4751
To unsubscribe, visit http://gerrit.cloudera.o
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3420: use gold by default
..
Patch Set 2:
I've been implicitly testing this locally with release, distcc and ninja, etc
just with my normal workflow. UPd
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-3420: use gold by default
..
IMPALA-3420: use gold by default
Also pass the flag that enables ld.gold directly to the
compiler. This is understood by both g
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.
..
Patch Set 4:
(2 comments)
I think this makes sense. I mention an alternative inline, I'm OK either wa
Jim Apple has posted comments on this change.
Change subject: IMPALA-3676,4321: Use clang as a static analysis tool
..
Patch Set 1:
(44 comments)
http://gerrit.cloudera.org:8080/#/c/4758/1//COMMIT_MSG
Commit Message:
Line 18:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting
classes.
..
Patch Set 2:
(5 comments)
The overall approach looks sane - had a few high-level questions
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4758
Change subject: IMPALA-3676: Use clang as a static analysis tool
..
IMPALA-3676: Use clang as a static analysis tool
This patch adds a scrip
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-1654: General partition exprs in DDL operations.
..
Patch Set 18: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3942
To unsubscribe,
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after
load
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4617/5/tests/custom_c
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-1169: Admission control info on the debug webpage
..
Patch Set 1:
(7 comments)
Nice! This will be useful to a lot of people.
http://gerrit.cloudera.org
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4617
to look at the new patch set (#6).
Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after
load
.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
..
Patch Set 6: Verified-1
Build failed:
http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify
Alex Behm has posted comments on this change.
Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4728/2/be/src/exec/kudu-table-sink.cc
File be/src
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4023: don't attach buffered tuple streams to batches
..
Patch Set 8:
Another way of looking at it is that ignoring flush_resources is a resource
manageme
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4023: don't attach buffered tuple streams to batches
..
Patch Set 8:
Not really - flush_resources without need_to_return implies 2a, whereas
flush_resour
Jim Apple has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
..
Patch Set 6: Code-Review+2
rebase, carry Tim's +2
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsub
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4023: don't attach buffered tuple streams to batches
..
Patch Set 8:
It's not clear to me how this is really any different from needs-to-return.
Don't they
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3739: Enable stress tests on Kudu
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4327
To unsubscribe, visit http://gerr
Thomas Tauber-Marshall has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4756
Change subject: IMPALA-1169: Admission control info on the debug webpage
..
IMPALA-1169: Admission control info on the debug web
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after
load
..
Patch Set 5:
You're right, of course, I was confused. Ignore my previous comment.
--
To
Alex Behm has posted comments on this change.
Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4755
To unsubscribe, visit
Alex Behm has posted comments on this change.
Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
..
Patch Set 1:
(1 comment)
Thanks for finding and fixing this! Let me know if you have trouble with
Hello Michael Ho,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4755
to review the following change.
Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test
..
IMPALA-415
Yuanhao Luo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4753
Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate
..
IMPALA-4325: StmtRewrite lost parentheses of CompoundPred
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4651
To unsubscribe, vis
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()
..
IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()
This patch is mostly mechanical mo
94 matches
Mail list logo
