[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. IMPALA-3771: Expose kudu client timeout and set default The Kudu client timeout was too lo

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4849 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-4435: Fix in-predicate-benchmark link error in release mode

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4964 Change subject: IMPALA-4435: Fix in-predicate-benchmark link error in release mode .. IMPALA-4435: Fix in-predicate-benchmark link erro

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4391: fix dropped statuses in scanners .. IMPALA-4391: fix dropped statuses in scanners As far as I'm aware we haven't seen any failures relat

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4391: fix dropped statuses in scanners .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4938 To unsubscribe, visit http://

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 4: Please take another quick look at expr-test.cc I needed to do an interesting fix because so

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-04 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4877 to look at the new patch set (#4). Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725 Support Kudu UPSERT in Impala This patch introduces a new query statement, UPSERT, for Kudu

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 19: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit http://ger

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/i

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4849 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Matthew Jacobs (Code Review)
Hello Lars Volker, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4849 to look at the new patch set (#6). Change subject: IMPALA-3771: Expose kudu client timeout and set default

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4849/5/testdata/workloads/functional-qu

[Impala-ASF-CR] IMPALA-3586: Clean up union-node.h/cc to enable improvements.

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3586: Clean up union-node.h/cc to enable improvements. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4817 To unsubscrib

[Impala-ASF-CR] IMPALA-3586: Clean up union-node.h/cc to enable improvements.

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3586: Clean up union-node.h/cc to enable improvements. .. IMPALA-3586: Clean up union-node.h/cc to enable improvements. This patch does not ad

[Impala-ASF-CR] IMPALA-4303: Do not reset() qualifier of union operands.

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4963 Change subject: IMPALA-4303: Do not reset() qualifier of union operands. .. IMPALA-4303: Do not reset() qualifier of union operands. The bug

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3882: Simplify some query exec state locking .. Patch Set 4: (3 comments) I did an initial pass over it. I'm still struggling with reasoning about wheth

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4849/5/testdata/workloads/functional-query/q

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4391: fix dropped statuses in scanners .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4938 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-04 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4938 to look at the new patch set (#2). Change subject: IMPALA-4391: fix dropped statuses in scanners .. IMPAL

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4391: fix dropped statuses in scanners .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4938 To unsubscribe, visit http://gerr

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4941 To unsubscri

[Impala-ASF-CR] IMPALA-4302,IMPALA-2379: constant expr arg fixes

2016-11-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4302,IMPALA-2379: constant expr arg fixes .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4838 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/impala/

[Impala-ASF-CR] IMPALA-4174: Refine PK/FK detection in JoinNode.getJoinCardinality().

2016-11-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4174: Refine PK/FK detection in JoinNode.getJoinCardinality(). .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4925 T

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4941 to look at the new patch set (#4). Change subject: IMPALA-4266: Java udf returning string can give incorrect results ...

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4941/3/tests/test-hive-udfs/

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/494

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add "Effective Coding Practices" doc to site .. Patch Set 2: I can see it being a blog post. Mainly I didn't think it fit on the wiki since it should be a stati

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

2016-11-04 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Add "Effective Coding Practices" doc to site .. Patch Set 2: Would this make more sense as a blog post, rather than a top level document? If it's a top level docu

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 3: Code-Review+1 (2 comments) Thanks! http://gerrit.cloudera.org:8080/#/c/4941/3/te

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/impala/

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4941/1/be/src/exprs/hive-udf-

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4941 to look at the new patch set (#3). Change subject: IMPALA-4266: Java udf returning string can give incorrect results ..

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/impala/

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: Add "Effective Coding Practices" doc to site .. Add "Effective Coding Practices" doc to site This is a useful document that had floated around internally at Cloude

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 8: i'll pick this up once it has an overall +1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/

[Impala-ASF-CR] IMPALA-4302,IMPALA-2379: constant expr arg fixes

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4302,IMPALA-2379: constant expr arg fixes .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/4838/4//COMMIT_MSG Commit Message: Line 18:

[Impala-ASF-CR] IMPALA-4302,IMPALA-2379: constant expr arg fixes

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-4302,IMPALA-2379: constant expr arg fixes .. IMPALA-4302,IMPALA-2379: constant expr arg fixes This patch fixes two issues around handling of constant expr a

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add "Effective Coding Practices" doc to site .. Patch Set 1: Can you word-wrap the file so it's possible to review? Thanks! -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4941/1/be/src/exprs/hive-udf-call

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4849/5/be/src/exec/kudu-table-sink.h F

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/impala/

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4961 Change subject: Add "Effective Coding Practices" doc to site .. Add "Effective Coding Practices" doc to site This is a useful document t

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join.

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4960 Change subject: IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join. .. IMPALA-3167: Fix assignment of W

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. Patch Set 4: Code-Review+2 Looks good to me. -- To view, visit http:/

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#18). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725 Support Kudu UPSERT in Impala This patch introduces a new query statement, UPSERT, for Kudu tabl

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4941 to look at the new patch set (#2). Change subject: IMPALA-4266: Java udf returning string can give incorrect results ..

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4941/1/be/src/exprs/hive-udf

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 17: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit http://ger

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) An additional high-level comment http://gerrit.cloudera.org:8080/#/c/4914

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4856 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for non-c

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (11 comments) Some high-level comments before digging in deeper. http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#4). Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. IMPALA-4338: test infra data migrator: include tables' primary keys in Postgr

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. Patch Set 4: (3 comments) Thanks for the review. Please see patch set 4.

[Impala-ASF-CR] IMPALA-4302,IMPALA-2379: constant expr arg fixes

2016-11-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4302,IMPALA-2379: constant expr arg fixes .. Patch Set 4: (11 comments) Looks good. I think just comments about comments. http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: First pass on the review to make sure it's going in the right direction. I also wonder a

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4835 To unsubscribe

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer Change-Id: I52e1b1354e9e

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 12: Rebased. Had to make some fixes to the UDF tests because of logical conflicts

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded a new change for review. http://gerrit.cloudera.org:8080/4914 Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. IMPALA-4172: Switch to BlockLocation methods for disk IDs Thi

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions This change enables codegen f

[Impala-ASF-CR] IMPALA-3586: Clean up union-node.h/cc to enable improvements.

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3586: Clean up union-node.h/cc to enable improvements. .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4817 To unsubs

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 7: Thanks for the review, Taras. This *does* need GVO, which I'll make sure

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: > There is no point in sending it through GVO. Just submit it directly I agree. As a non-c

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4936 To unsubscribe, visit http:/

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required This patch now requires users of the Leopard

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 4: > There is no point in sending it through GVO. Just submit it > directly Only committers can

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/487

[Impala-ASF-CR] IMPALA-4260: Alter table add column drops all the column stats

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4260: Alter table add column drops all the column stats .. Patch Set 2: Code-Review+2 carrying dimitris' +2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: There is no point in sending it through GVO. Just submit it directly -- To view, visi

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4951/2/t

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 7: Code-Review+1 (1 comment) Thanks for the review. I made the rename and

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Michael Brown (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4873 to look at the new patch set (#7). Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model ..

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 6: Code-Review+1 rebase -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: Thanks! Do you mind submitting this in the Gerrit WebUI since 1. GVO won't touch paths aff

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 8: (3 comments) Couple of naming questions, otherwise looks good. http://ger

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4936 To unsubscribe, v

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4849/5/be/src/exec/kudu-table

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4873/5/tests/compar

[Impala-ASF-CR] IMPALA-4421: Send custom cluster & process failure test results to logs/

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4421: Send custom cluster & process failure test results to logs/ .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4918 T

[Impala-ASF-CR] IMPALA-4421: Send custom cluster & process failure test results to logs/

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4421: Send custom cluster & process failure test results to logs/ .. IMPALA-4421: Send custom cluster & process failure test results to logs/

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 8: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-exte

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. Patch Set 2: Note this patched is based on https://gerrit.cloudera.org/#/c/

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4951 Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. IMPALA-4338: test infra data migrat

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 5: (12 comments) Nice cleanup http://gerrit.cloudera.org:8080/#/c/4867/5/be/src/

[Impala-ASF-CR] IMPALA-4406: Add cryptography export control notice

2016-11-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4406: Add cryptography export control notice .. Patch Set 3: Code-Review+2 Verified+1 (2 comments) Carry +2. No code changes, so verifying and submittin

[Impala-ASF-CR] IMPALA-4406: Add cryptography export control notice

2016-11-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has submitted this change and it was merged. Change subject: IMPALA-4406: Add cryptography export control notice .. IMPALA-4406: Add cryptography export control notice The ASF guidelines on crypto requires project

[Impala-ASF-CR] IMPALA-4406: Add cryptography export control notice

2016-11-04 Thread Sailesh Mukil (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4940 to look at the new patch set (#3). Change subject: IMPALA-4406: Add cryptography export control notice .. IMPALA-4406:

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4391: fix dropped statuses in scanners .. Patch Set 1: Code-Review+1 Thanks for fixing this! -- To view, visit http://gerrit.cloudera.org:8080/4938 To uns

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4048: Misc. improvements to /sessions .. IMPALA-4048: Misc. improvements to /sessions * Make table searchable and sortable * Fix 'last accessed time' being

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4880/2/be/src/service/impala-http-handler.cc File

  1   2   >