[Impala-ASF-CR] IMPALA-4437: hit DCHECK in buffered-block-mgr-test

2016-11-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4437: hit DCHECK in buffered-block-mgr-test .. Patch Set 1: Code-Review+2 Ignore that comment - I was looking at an old version of the code that didn't

[Impala-ASF-CR] IMPALA-4437: hit DCHECK in buffered-block-mgr-test

2016-11-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4437: hit DCHECK in buffered-block-mgr-test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4973/1/be/src/runtime/disk-io-mgr.cc File be

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-11-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#3). Change subject: IMPALA-4014: Introduce query-wide execution state. .. IMPALA-4014: Introduce query-wide execution state. This introduces a global structure to coordinate execut

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-11-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4418/2/be/src/runtime/coordinator.cc File

[Impala-ASF-CR] IMPALA-4437: hit DCHECK in buffered-block-mgr-test

2016-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4973 Change subject: IMPALA-4437: hit DCHECK in buffered-block-mgr-test .. IMPALA-4437: hit DCHECK in buffered-block-mgr-test The issue was i

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-11-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 2: (27 comments) Regarding tests: I ran a bunch of queries locally, and basic cases work, but

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-11-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#2). Change subject: IMPALA-4014: Introduce query-wide execution state. .. IMPALA-4014: Introduce query-wide execution state. This introduces a global structure to coordinate execut

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-06 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#3). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. There

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2016-11-06 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#2). Change subject: Initial commit of the blog section of the Impala ASF website. .. Initial commit of the blog section of the Impala ASF website. Note: a sample version of the site is

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2016-11-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 1: (18 comments) http://gerrit.cloudera.org:8080/#/c/4944/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-06 Thread Anonymous Coward (Code Review)
davy...@163.com has uploaded a new patch set (#2). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. T

[Impala-ASF-CR] Add -build shared libs for default build for speed.

2016-11-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Add -build_shared_libs for default build for speed. .. Patch Set 1: Code-Review+1 I use this, too, and it works well. -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 1: (6 comments) Thank you for working on this. Please make sure your ch

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 7: S3 private build failed b/c of stale testdata snapshot. I will rebase next and try again.

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4863/7/tests/query_test/test_insert_behav

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-06 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4863 to look at the new patch set (#9). Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. IMP

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-06 Thread Anonymous Coward (Code Review)
davy...@163.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/4971 Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log contr

[Impala-ASF-CR] Preview: IMPALA-4363: Add timestamp validation

2016-11-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Preview: IMPALA-4363: Add timestamp validation .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4968/1/be/src/exec/parquet-column-readers.cc File