[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (3 comments) Looks pretty good, will continue tomorrow. http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5026/1/fe/src/main/java/org/ap

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5026/1/fe/src/main/cup/sql-pa

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for Kudu-sp

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (4 comments) Responding to comments. http://gerrit.cloudera.org:8080/#/c/5026/1/fe/src/ma

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 10: Code-Review+1 Carrying +1 from Alex. Dan, can you please do a +2 re

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4867 to look at the new patch set (#10). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/4867/9/be/src/serv

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (25 comments) Still need to address the parser changes wrt the use of DEFAULT

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for Kudu-sp

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-09 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 6: I have added static method GetAuditEventLogFilePrefix in class Impala

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-09 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#6). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. There

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5022 To unsu

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 9: Code-Review+1 (5 comments) +2 for FE, +1 for BE after the minor renames http:

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. Patch Set 2: > I think the various sizeof(max_alignt_t) in mem-pool.[h,cc] also > need up

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-09 Thread Jim Apple (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5022 to look at the new patch set (#2). Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#9). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix "IMPAL

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/4867/8/be/src/util

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (29 comments) http://gerrit.cloudera.org:8080/#/c/5026/1/common/thrift/CatalogObjects.thri

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. Patch Set 1: I think the various sizeof(max_alignt_t) in mem-pool.[h,cc] also need updatin

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: No e2e tests with inserts yet as there seems to be an issue with Kudu wrt hand

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5026 Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column op

[Impala-ASF-CR] Run MT DOP tests on all file formats.

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5025 Change subject: Run MT_DOP tests on all file formats. .. Run MT_DOP tests on all file formats. Change-Id: I28d5bcc48bbe32fb970b41daa91909606

[Impala-ASF-CR] IMPALA-4456: Change query exec state lock to a reader-writer lock

2016-11-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4456: Change query_exec_state_lock_ to a reader-writer lock .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5021/2//COMMIT_MSG Commit M

[Impala-ASF-CR] IMPALA-4456: Change query exec state lock to a reader-writer lock

2016-11-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-4456: Change query_exec_state_lock_ to a reader-writer lock .. IMPALA-4456: Change query_exec_state_lock_ to a reader-writer lock This patch includes a por

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 20: An exhaustive run passed, minus an independent issue with loading HBase widetable_500. --

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5022 To unsu

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-09 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5022 Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. IMPALA-4455: MemPoolTest.TryAllocateAligned failur

[Impala-ASF-CR] IMPALA-4456: Change query exec state lock to a reader-writer lock

2016-11-09 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4456: Change query_exec_state_lock_ to a reader-writer lock .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5021/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4456: Change query exec state lock to a reader-writer lock

2016-11-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-4456: Change query_exec_state_lock_ to a reader-writer lock .. IMPALA-4456: Change query_exec_state_lock_ to a reader-writer lock This patch includes a por

[Impala-ASF-CR] Change query exec state lock to a reader-writer lock

2016-11-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5021 Change subject: Change query_exec_state_lock_ to a reader-writer lock .. Change query_exec_state_lock_ to a reader-writer lock This patc

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/4867/8/be/src/util/backend-co

[Impala-ASF-CR] IMPALA-4433: Fix undefined NDV calculations

2016-11-09 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-4433: Fix undefined NDV calculations .. Abandoned Doesn't bring consensus to all the platforms on the NDV of timestamp_col. Let's bring the discussion back to IMPALA-

[Impala-ASF-CR] IMPALA-4433: Fix undefined NDV calculations

2016-11-09 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-4433: Fix undefined NDV calculations .. Patch Set 2: Tested this patch on my Ubuntu server. The stats mismatching cases are gone. Thanks Jim ;) -- To view,

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 12: Code-Review+1 Rebased, carry +1 from Alex. -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-09 Thread Lars Volker (Code Review)
Hello Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4863 to look at the new patch set (#12). Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input ...

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-09 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 5: (9 comments) logging.cc Line 58: I can't use it by include impala-se

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-09 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#5). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. There

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#8). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix "IMPAL

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/catal

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 4: (2 comments) Please address the questions in my previous comments a

[Impala-ASF-CR] Preview: IMPALA-4363: Add timestamp validation

2016-11-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Preview: IMPALA-4363: Add timestamp validation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/2/common/thrift/generate_error_codes.py File c

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4877 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. IMPALA-1286: Extract common conjuncts from disjunctions. Adds a new ExprRewriteRule to ex

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-11-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 4: (34 comments) http://gerrit.cloudera.org:8080/#/c/4715/4//COMMIT_MSG Commit Message: PS4,