[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5093/5/tests/stress/concurrent_select.py

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5093/4//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: Code-Review+1 Change looks good to me. As discussed, I think there is still one remaining

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: BTW this passed a private jenkins run -- To view, visit

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: (3 comments) Alex, per our conversation about other cases- are you OK with

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-13 Thread Taras Bobrovytsky (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5093 to look at the new patch set (#5). Change subject: IMPALA-4467: Add support for DML statements in stress test ..

[Impala-ASF-CR] IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1"

2016-12-13 Thread hewenting (Code Review)
hewenting has posted comments on this change. Change subject: IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1" .. Patch Set 1: Why do this patch cannot be merged? -- To view, visit

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-13 Thread Taras Bobrovytsky (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5093 to look at the new patch set (#5). Change subject: IMPALA-4467: Add support for DML statements in stress test ..

[Impala-ASF-CR] IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

2016-12-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally. .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5493/2/be/src/exec/kudu-scanner.cc File

[Impala-ASF-CR] Clarify synchronization policy for 'done ' in KuduScanNode

2016-12-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5494 Change subject: Clarify synchronization policy for 'done_' in KuduScanNode .. Clarify synchronization policy for 'done_' in KuduScanNode

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

2016-12-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally. .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

2016-12-13 Thread David Knupp (Code Review)
Hello Michael Brown, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5446 to look at the new patch set (#3). Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. Patch Set 6: Code-Review+2 Carry John's +2 after rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4636: Add support for SLES12 for Kudu integration

2016-12-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4636: Add support for SLES12 for Kudu integration .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5463 To unsubscribe,

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 1: > Uploaded patch set 1. Ran the core test suite and it passed. Unable to run stress testing yet

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5491 Change subject: IMPALA-3977: TransmitData() should not block .. IMPALA-3977: TransmitData() should not block TransmitData() calls

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 13: Code-Review+1 (1 comment)

[Impala-ASF-CR](asf-site) Change git links from GitHub to the official Apache repo.

2016-12-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Change git links from GitHub to the official Apache repo. .. Patch Set 1: > I think that sounds good, it seems we should be making it as easy > as possible for

[Impala-ASF-CR] IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements

2016-12-13 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#2). Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements .. IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements - Generate INSERT

[Impala-ASF-CR] IMPALA-4636: Add support for SLES12 for Kudu integration

2016-12-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4636: Add support for SLES12 for Kudu integration .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5463 To

[Impala-ASF-CR] IMPALA-4642: Return to the newer Kudu toolchain build.

2016-12-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: IMPALA-4642: Return to the newer Kudu toolchain build. .. IMPALA-4642: Return to the newer Kudu toolchain build. This reverts commit

[Impala-ASF-CR] IMPALA-4642: Return to the newer Kudu toolchain build.

2016-12-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4642: Return to the newer Kudu toolchain build. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5487 To unsubscribe,