[Impala-ASF-CR] IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable .. IMPALA-4008: Don't bake fields into generated IR functions of

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5039: Fix variability in parquet dictionary filtering test

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6301 To

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-03-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section

2017-03-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3405: [DOCS] Pare down upgrading section .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6008 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

2017-03-10 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6352/1/docs/impala.ditamap File

[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section

2017-03-10 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-3405: [DOCS] Pare down upgrading section .. Patch Set 4: Code-Review+1 (1 comment) Builds cleanly, looks good, except for one small typo described below.

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

2017-03-10 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links .. Patch Set 1: (23 comments) Most of the issues were caused with inconsistencies in the

[Impala-ASF-CR] IMPALA-4996: Single-threaded KuduScanNode

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4996: Single-threaded KuduScanNode .. Patch Set 2: (5 comments) I started reviewing this and realized there are maybe some more changes you're still

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

2017-03-10 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6352 Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references .. IMPALA-3402: [DOCS] Remove more stray CDH references A number of

[Impala-ASF-CR] MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev=

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev= .. MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev= For history and tracking

[Impala-ASF-CR] MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev=

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev= .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/69/ -- To

[Impala-ASF-CR] MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev=

2017-03-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev= .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6349 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section

2017-03-10 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#4). Change subject: IMPALA-3405: [DOCS] Pare down upgrading section .. IMPALA-3405: [DOCS] Pare down upgrading section Physically remove the CM upgrading instructions and the yum,

[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section

2017-03-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3405: [DOCS] Pare down upgrading section .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6008/3/docs/topics/impala_upgrading.xml File

[Impala-ASF-CR] MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev=

2017-03-10 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev= .. Patch Set 1: Code-Review+1 Clean build. -- To view, visit http://gerrit.cloudera.org:8080/6349 To

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4996: Single-threaded KuduScanNode

2017-03-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-4996: Single-threaded KuduScanNode .. Patch Set 2: I had to rebase due to a different branch. This upload contains no new changes. -- To view, visit

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5039: Fix variability in parquet dictionary filtering test

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6005 To

[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info .. IMPALA-3403: [DOCS] Pare back irrelevant installation info Take out the path A /

[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section

2017-03-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3405: [DOCS] Pare down upgrading section .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6008/3/docs/topics/impala_upgrading.xml File

[Impala-ASF-CR] IMPALA-5039: Fix variability in parquet dictionary filtering test

2017-03-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6301/3//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5039: Fix variability in parquet dictionary filtering test

2017-03-10 Thread Joe McDonnell (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6301 to look at the new patch set (#4). Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test

[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section

2017-03-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3405: [DOCS] Pare down upgrading section .. Patch Set 3: (5 comments) I think this info is now a reasonable compromise between removing vendor-specific

[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section

2017-03-10 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#3). Change subject: IMPALA-3405: [DOCS] Pare down upgrading section .. IMPALA-3405: [DOCS] Pare down upgrading section Physically remove the CM upgrading instructions and the yum,

[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/68/ --

[Impala-ASF-CR] MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev=

2017-03-10 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6349 Change subject: MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev= .. MPALA-3402: [DOCS] Remove CDH- JIRA numbers from rev= For

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6328

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6328/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6328 to look at the new patch set (#2). Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

[Impala-ASF-CR] IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable

2017-03-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable .. Patch Set 3: Code-Review+2 Carry Tim's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable

2017-03-10 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6263 to look at the new patch set (#3). Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

2017-03-10 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6345 Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links .. IMPALA-4643: [DOCS] Phase 2 of genericizing

[Impala-ASF-CR] IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable

2017-03-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable .. Patch Set 2: (2 comments) Yes, I did a private run with legacy join and agg before

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6344 Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and

[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info

2017-03-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6005 To unsubscribe,

[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info

2017-03-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6005 To unsubscribe,

[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info

2017-03-10 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info .. Patch Set 3: Jim, should I turn Laurel's +1 into my +2 or do you want to doublecheck the wording

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: > Even better - because the partition function definition would be a > template (and therefore

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: Even better - because the partition function definition would be a template (and therefore

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (2 comments)

[native-toolchain-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-10 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has submitted this change and it was merged. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. IMPALA-4846: Upgrade Snappy to 1.1.4 Snappy 1.1.4 (released Jan 25th, 2017) claims significant performance

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 14: (10 comments)

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6328/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5039: Fix variability in parquet dictionary filtering test

2017-03-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test .. Patch Set 3: nice! -- To view, visit http://gerrit.cloudera.org:8080/6301 To

[Impala-ASF-CR] IMPALA-5039: Fix variability in parquet dictionary filtering test

2017-03-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6301/3//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer

2017-03-10 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#3). Change subject: IMPALA-3079: Fix sequence file writer .. IMPALA-3079: Fix sequence file writer Before the fix, sequence file writer produced corrupt files in some cases. Steps to

[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer

2017-03-10 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3079: Fix sequence file writer .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/6107/1/be/src/exec/read-write-util-test.cc File

[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer

2017-03-10 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#2). Change subject: IMPALA-3079: Fix sequence file writer .. IMPALA-3079: Fix sequence file writer Before the fix, sequence file writer produced corrupt files in some cases. Steps to

[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer

2017-03-10 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#2). Change subject: IMPALA-3079: Fix sequence file writer .. IMPALA-3079: Fix sequence file writer Before the fix, sequence file writer produced corrupt files in some cases. Steps to

[native-toolchain-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-10 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: Code-Review+1 Verified by a complete build -- To view, visit http://gerrit.cloudera.org:8080/6336 To