[Impala-ASF-CR] IMPALA-5120: Default to partitioned join when stats are missing

2017-05-08 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5120: Default to partitioned join when stats are missing .. Patch Set 2: Code-Review+2 Carrying forward -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5120: Default to partitioned join when stats are missing

2017-05-08 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6803 to look at the new patch set (#2). Change subject: IMPALA-5120: Default to partitioned join when stats are missing .

[Impala-ASF-CR] IMPALA-5120: Default to partitioned join when stats are missing

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5120: Default to partitioned join when stats are missing .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/540

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/6478/4/be/src/runtime/disk-io-mgr.cc File be/src/runti

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6563 to look at the new patch set (#9). Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types ...

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types .. Patch Set 8: (2 comments) Thanks for the review. I addressed your

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6819 Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. IMPALA-5245: fix ASAN buffer-allocator-test * Use the allocator_may_retur

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 1: (1 comment) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/6819/1/be/src/runtime/bufferpoo

[Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes

2017-05-08 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5207,IMPALA-5214: distcc fixes .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/6655/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes

2017-05-08 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6655 to look at the new patch set (#3). Change subject: IMPALA-5207,IMPALA-5214: distcc fixes .. IMPALA-5207,I

[Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5207,IMPALA-5214: distcc fixes .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6655/2//COMMIT_MSG Commit Message: Line 9: enable_distcc

[Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5207,IMPALA-5214: distcc fixes .. Patch Set 3: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/6655 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6535 To unsubscribe, visit http://gerrit.

Re: [Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-08 Thread Dimitris Tsirogiannis
I believe it sends the wrong message and is probably confusing to throw an error when someone writes a CREATE TABLE with an empty SORT BY() but allow the same clause in an ALTER. No doubt the users can read the documentation and figure it out but its an extra step. Also, as Marcel mentions, scripti

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5483/7/be/src/exprs/scalar-expr-evaluator.h File b

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-05-08 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5538 to look at the new patch set (#11). Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs ..

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. Patch Set 11: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/541/ -- To vi

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. Patch Set 11: Code-Review+2 Fixed JDBC test failure. -- To view, visit http://gerrit.cloudera.org:8080/55

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6563 to look at the new patch set (#10). Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types ..

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6819/1/be/src/runtime/bufferpool/system-allocator.cc

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. IMPALA-5245: fix ASAN buffer-allocator-test * Use the allocator_may_return_null=1 ASAN option so that the allocation

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: Looks good. One last question - how did you test? -- To view, visit http://gerrit.cloudera.org:8080/681

[Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes

2017-05-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5207,IMPALA-5214: distcc fixes .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6655/3/bin/distcc/distcc_env.sh File bin/di

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6817 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 1: Update testdata/data/README to describe those two new files? -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: I ran buffer-allocator-test locally with an ASAN build. I was able to reproduce the problem before t

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6819 To unsubscribe, visit http://gerrit

[Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5207,IMPALA-5214: distcc fixes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6655/3/bin/distcc/distcc_env.sh File bin/distcc/distcc_env

[Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5207,IMPALA-5214: distcc fixes .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/543/ -- To view, visit http

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 20: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6495 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6817/1/testdata/workloads/functional-query/que

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6626/7/be/src/common/init.cc File be/src/common/init.cc:

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-05-08 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6626 to look at the new patch set (#8). Change subject: IMPALA-5220: memory maintenance cleanup .. IMPALA-5220: memory

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-05-08 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6626 to look at the new patch set (#9). Change subject: IMPALA-5220: memory maintenance cleanup .. IMPALA-5220: memory

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6817/1/tests/query_test/test_scanners.py File tes

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Marcel Kornacker (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6535 to look at the new patch set (#13). Change subject: IMPALA-2550: Switch to per-query exec rpc .. IMPALA-2550: Switch t

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 13: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6535 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 13: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/544/ -- To view, visit

[Impala-ASF-CR] IMPALA-5120: Default to partitioned join when stats are missing

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5120: Default to partitioned join when stats are missing .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6803 To uns

[Impala-ASF-CR] IMPALA-5120: Default to partitioned join when stats are missing

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5120: Default to partitioned join when stats are missing .. IMPALA-5120: Default to partitioned join when stats are missing Previously, w

[Impala-ASF-CR] IMPALA-5166: clean up BufferPool counters

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5166: clean up BufferPool counters .. IMPALA-5166: clean up BufferPool counters Misc changes to improve usability of the profiles. * Separate out detailed

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6817/1/tests/query_test/test_scanners.py File t

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 7533364 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6797 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 7533364 .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/545/ -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6817 to look at the new patch set (#2). Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. IMPALA-5287: Te

[Impala-ASF-CR] IMPALA-5169: Add support for async pins in buffer pool

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-5169: Add support for async pins in buffer pool .. IMPALA-5169: Add support for async pins in buffer pool Makes Pin() do async reads behind-the-scenes, inst

[Impala-ASF-CR] IMPALA-5169: Add support for async pins in buffer pool

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5169: Add support for async pins in buffer pool .. Patch Set 7: Rebased -- To view, visit http://gerrit.cloudera.org:8080/6612 To unsubscribe, visit htt

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 2: (1 comment) Thanks for the review comments and the good suggestions. Please see PS 3. http://ger

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6817 to look at the new patch set (#3). Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. IMPALA-5287: Te

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6817/3/testdata/data/README File testdata/data

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6817/1/tests/query_test/test_scanners.py File tes

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. IMPALA-5197: Erroneous corrupted Parquet file message The Parquet file column reader may fail in the middle o

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (36 comments) http://gerrit.cloudera.org:8080/#/c/6812/1//COMMIT_MSG Commit Message: PS1, Line 10: sta

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5715/7/be/src/kudu/util/compression/co

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 9: (45 comments) first half http://gerrit.cloudera.org:8080/#/c/5483/7/be/src/exec/exec-node.h Fi

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6817 to look at the new patch set (#4). Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. IMPALA-5287: Te

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 3: (5 comments) Thanks for the comments. Please see PS4. http://gerrit.cloudera.org:8080/#/c/6817/3

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. Patch Set 3: PS3 added a new assert in test_failpoints.py and removed the new test in test_scanners.py. -

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5538 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. IMPALA-5184: build fe against both Hive 1 & 2 APIs This adds a compatibility shim layer wi

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6787/3/tests/failure/test_failpoints.py File

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6812/1//COMMIT_MSG Commit Message: PS1, Line 10: st

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6817/3/testdata/datasets/function

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/546/ -- To view, visi

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. IMPALA-5197: Erroneous corrupted Parquet file message The Parquet file column reader may fail in the middle o

[Impala-ASF-CR] IMPALA-5239: transfer reservations between trackers

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5239: transfer reservations between trackers .. IMPALA-5239: transfer reservations between trackers This is a primitive needed to implement claiming and dis

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 3: (1 comment) Thanks for the reviews! http://gerrit.cloudera.org:8080/#/c/6817/3/testdata/datasets

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/547/ -- To view,

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/6526/6/be/src/exec/kudu-scanner.

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-05-08 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5715 to look at the new patch set (#9). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. IM

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-05-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 8: (2 comments) PS8 is just a rebase. PS9 includes the review responses. http://gerrit.c

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6563 to look at the new patch set (#11). Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types ..

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/656

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. Patch Set 4: Code-Review+1 (1 comment) Thanks for trying alternate testing routes. I'm ok with these change

[Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5207,IMPALA-5214: distcc fixes .. IMPALA-5207,IMPALA-5214: distcc fixes enable_distcc should reset IMPALA_DISTCC_ENABLED, otherwise disab

[Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5207,IMPALA-5214: distcc fixes .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6655 To unsubscribe, visit http://ger

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6

[Impala-ASF-CR] IMPALA-5158: Part 1: include untracked memory in MemTracker dumps

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6820 Change subject: IMPALA-5158: Part 1: include untracked memory in MemTracker dumps .. IMPALA-5158: Part 1: include untracked memory in Me

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/656

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Lars Volker (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6563 to look at the new patch set (#12). Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types ..

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types .. Patch Set 11: Thanks for having a look. -- To view, visit http:/

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#7). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP Adds Impala support for TIMESTAMP t

Re: [Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-08 Thread Lars Volker
On Mon, May 8, 2017 at 11:41 PM, Marcel Kornacker wrote: > > > On Mon, May 8, 2017 at 9:50 AM, Dimitris Tsirogiannis < > dtsirogian...@cloudera.com> wrote: > >> I believe it sends the wrong message and is probably confusing to throw >> an error when someone writes a CREATE TABLE with an empty SOR

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 13: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/544/ -- To v

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5715/7/be/src/kudu/util/status.h File b

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 7533364 .. Patch Set 2: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/545/ -- To view, visit htt

Re: [Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-08 Thread Dimitris Tsirogiannis
The other alternative would be to populate it with the partitioning columns, if any. Thoughts? Dimitris On Mon, May 8, 2017 at 4:02 PM, Lars Volker wrote: > > On Mon, May 8, 2017 at 11:41 PM, Marcel Kornacker > wrote: > >> >> >> On Mon, May 8, 2017 at 9:50 AM, Dimitris Tsirogiannis < >> dtsiro

Re: [Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-08 Thread Lars Volker
On Tue, May 9, 2017 at 1:24 AM, Dimitris Tsirogiannis < dtsirogian...@cloudera.com> wrote: > The other alternative would be to populate it with the partitioning > columns, if any. Thoughts? > > Adding the partitioning columns to the sort by list is not supported. They can be added to the pre-inser

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-05-08 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5715 to look at the new patch set (#10). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. I

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-05-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5715/7/be/src/kudu/util/status.h File

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-08 Thread Lars Volker (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6495 to look at the new patch set (#21). Change subject: IMPALA-4166: Add SORT BY sql clause .. IMPALA-4166: Ad

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 21: Rebased, added support for CREATE TABLE SORT BY() with empty sort by list. Will need to rebase again though,

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6787 To unsubscribe, visit htt

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 9: (10 comments) Still trying to come to grips with it all but did an initial pass over the query ex

Re: [Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-08 Thread Dimitris Tsirogiannis
If you don't populate it for CREATE TABLE SORT BY() then I think you should remove it altogether. Dimitris On Mon, May 8, 2017 at 4:33 PM, Lars Volker wrote: > > > On Tue, May 9, 2017 at 1:24 AM, Dimitris Tsirogiannis < > dtsirogian...@cloudera.com> wrote: > >> The other alternative would be to

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6535 to look at the new patch set (#14). Change subject: IMPALA-2550: Switch to per-query exec rpc ..

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 14: Code-Review+2 fixing some 'unused results' warnings. -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 14: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/549/ -- To view, visit

  1   2   >