[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8212 ) Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8212 ) Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. Patch Set 3: Code-Review+2 (1 comment) Carrying +2.

[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-04 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8212 to look at the new patch set (#3). Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. IMPALA-6016:

Re: [Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread Alexander Behm
Great work, John! Thanks for your continued effort to get this important change merged. Much appreciated. On Wed, Oct 4, 2017 at 7:26 PM, Impala Public Jenkins (Code Review) < ger...@cloudera.org> wrote: > Impala Public Jenkins *merged* this change. > > View Change

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 14: Verified+1 > Thanks! Also thanks

[Impala-ASF-CR] IMPALA-5990: Part 1: JNI-based LZ4 de/compression

2017-10-04 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. ( http://gerrit.cloudera.org:8080/8150 ) Change subject: IMPALA-5990: Part 1: JNI-based LZ4 de/compression .. Abandoned Putting this on hold as it's not clear we will proceed with this

[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8212 ) Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 4: Yeah, the profile is:

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 15: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. IMPALA-5908: Allow SET to unset modified

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-04 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 4: Did you the test the case

[Impala-ASF-CR] IMPALA-5988: optimise MemPool::TryAllocate()

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8145 ) Change subject: IMPALA-5988: optimise MemPool::TryAllocate() .. IMPALA-5988: optimise MemPool::TryAllocate() Testing:

[Impala-ASF-CR] IMPALA-5988: optimise MemPool::TryAllocate()

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8145 ) Change subject: IMPALA-5988: optimise MemPool::TryAllocate() .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching

2017-10-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 ) Change subject: IMPALA-4623: [DOCS] Document file handle caching .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. IMPALA-5394: Change

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 13: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-04 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8212 to look at the new patch set (#2). Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. IMPALA-6016:

[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8212 ) Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-04 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-10-04 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8056 ) Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 2: (2 comments) Updated

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-04 Thread Vuk Ercegovac (Code Review)
Hello Philip Zeyliger, Balazs Jeszenszky, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8202 to look at the new patch set (#2). Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received.

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

2017-10-04 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8215 Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. IMPALA-5142 EventSequence displays negative elapsed time.

[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool

2017-10-04 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8003 ) Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool

2017-10-04 Thread John Russell (Code Review)
Hello Tim Armstrong, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8003 to look at the new patch set (#5). Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException thrown by aggregate function.

2017-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682 Fix IllegalStateException thrown by aggregate function. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8212 ) Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 4: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-04 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8147 to look at the new patch set (#4). Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 13: Thanks! Also thanks to you and

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 ) Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. Patch Set 3: Code-Review+1 Looks good.

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException issue

2017-10-04 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682 Fix IllegalStateException issue .. Patch Set 1: (2 comments) > Zoram, let's try to move this forward. We

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException thrown by aggregate function.

2017-10-04 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dimitris Tsirogiannis, anujphadke, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8143 to look at the new patch set (#2). Change subject: IMPALA-4682 Fix IllegalStateException thrown by aggregate function.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 15: Code-Review+2 Let me retry -- To view,

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 14: The build error seems to be: > 19:44:25 ]

[Impala-ASF-CR] Remove dead code parallel-executor*

2017-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8206 ) Change subject: Remove dead code parallel-executor* .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6016: Fix logging in TableLoadingMgr class

2017-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8212 Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class .. IMPALA-6016: Fix logging in TableLoadingMgr class This

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 13: Build started:

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 12: Code-Review+2 > It looks like it

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 13: Code-Review+2 Rebase, Carry +2.

[Impala-ASF-CR] IMPALA-5988: optimise MemPool::TryAllocate()

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8145 ) Change subject: IMPALA-5988: optimise MemPool::TryAllocate() .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5988: optimise MemPool::TryAllocate()

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8145 ) Change subject: IMPALA-5988: optimise MemPool::TryAllocate() .. Patch Set 4: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-5988: optimise MemPool::TryAllocate()

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8145 ) Change subject: IMPALA-5988: optimise MemPool::TryAllocate() .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 7: Code-Review+1 Carry +1 -- To

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-10-04 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8085 to look at the new patch set (#7). Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables. (wip)

2017-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211 ) Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. (wip) .. Patch Set 1: Hi Tim, As you suggested, I'm sharing

[Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables. (wip)

2017-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8211 Change subject: IMPALA-5243: Speed up code gen for wide Avro tables. (wip) .. IMPALA-5243: Speed up code gen for wide Avro tables.

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8056 ) Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet .. Patch Set 8: Code-Review+2 (1 comment) Looks

[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8003 ) Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. Patch Set 4: (18 comments)

[Impala-ASF-CR] IMPALA-5988: optimise MemPool::TryAllocate()

2017-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8145 ) Change subject: IMPALA-5988: optimise MemPool::TryAllocate() .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Bump Kudu version to bec2a24

2017-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8207 ) Change subject: Bump Kudu version to bec2a24 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8207 To

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-10-04 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 12: Tim, Please remove all the

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 ) Change subject: IMPALA-6012: workaround - downgrade hive temporarily .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8205 ) Change subject: IMPALA-6012: workaround - downgrade hive temporarily .. IMPALA-6012: workaround - downgrade hive temporarily

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 ) Change subject: IMPALA-6012: workaround - downgrade hive temporarily .. Patch Set 2: I carried the verification since it was only a

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 ) Change subject: IMPALA-6012: workaround - downgrade hive temporarily .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 14: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5988: optimise MemPool::TryAllocate()

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8145 ) Change subject: IMPALA-5988: optimise MemPool::TryAllocate() .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5988: optimise MemPool::TryAllocate()

2017-10-04 Thread Tim Armstrong (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8145 to look at the new patch set (#4). Change subject: IMPALA-5988: optimise MemPool::TryAllocate() ..

[Impala-ASF-CR] IMPALA-5844: use a MemPool for expr result allocations

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8025 ) Change subject: IMPALA-5844: use a MemPool for expr result allocations .. Patch Set 15: Code-Review+2 PS13 was the rebase (required to

[Impala-ASF-CR] IMPALA-5844: use a MemPool for expr result allocations

2017-10-04 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8025 to look at the new patch set (#14). Change subject: IMPALA-5844: use a MemPool for expr result allocations

[Impala-ASF-CR] IMPALA-5844: use a MemPool for expr result allocations

2017-10-04 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8025 to look at the new patch set (#15). Change subject: IMPALA-5844: use a MemPool for expr result allocations

[Impala-ASF-CR] IMPALA-5844: use a MemPool for expr result allocations

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8025 ) Change subject: IMPALA-5844: use a MemPool for expr result allocations .. Patch Set 12: (6 comments) Rebase, then addressed comments.

[Impala-ASF-CR] IMPALA-5844: use a MemPool for expr result allocations

2017-10-04 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8025 to look at the new patch set (#13). Change subject: IMPALA-5844: use a MemPool for expr result allocations

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax

2017-10-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8191 ) Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Bump Kudu version to bec2a24

2017-10-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8207 Change subject: Bump Kudu version to bec2a24 .. Bump Kudu version to bec2a24 Change-Id:

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-10-04 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 ) Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 12: It looks like it passed

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException issue

2017-10-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682 Fix IllegalStateException issue .. Patch Set 1: Zoram, let's try to move this forward. We don't

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-10-04 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Matthew Jacobs, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7822 to look at the new patch set (#4). Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-10-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/7564 ) Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 8: (3 comments) Thanks!

[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax

2017-10-04 Thread John Russell (Code Review)
Hello Greg Rahn, Thomas Tauber-Marshall, Ambreen Kazi, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8191 to look at the new patch set (#3). Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax

[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax

2017-10-04 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8191 ) Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 1: (2 comments) It does

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 ) Change subject: IMPALA-6012: workaround - downgrade hive temporarily .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

2017-10-04 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, Dimitris Tsirogiannis, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8205 to look at the new patch set (#2). Change subject: IMPALA-6012: workaround - downgrade hive temporarily

[Impala-ASF-CR] Remove dead code parallel-executor*

2017-10-04 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8206 Change subject: Remove dead code parallel-executor* .. Remove dead code parallel-executor* Change-Id:

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 1: What process is

[Impala-ASF-CR] IMPALA-5988: optimise MemPool::TryAllocate()

2017-10-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8145 ) Change subject: IMPALA-5988: optimise MemPool::TryAllocate() .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-10-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 5: Code-Review+1 (1 comment) Please get have Michael

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 14: Build started:

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-04 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 1: I think the bug

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

2017-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 ) Change subject: IMPALA-6012: workaround - downgrade hive temporarily .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-10-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 ) Change subject: IMPALA-6012: workaround - downgrade hive temporarily .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 ) Change subject: IMPALA-6012: workaround - downgrade hive temporarily .. Patch Set 1: Code-Review-2 Running tests but don't want to

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8205 Change subject: IMPALA-6012: workaround - downgrade hive temporarily .. IMPALA-6012: workaround - downgrade hive temporarily To unblock

[Impala-ASF-CR] IMPALA-5844: use a MemPool for expr result allocations

2017-10-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8025 ) Change subject: IMPALA-5844: use a MemPool for expr result allocations .. Patch Set 12: Code-Review+2 (5 comments)

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-04 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#11). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 10: The fe/ files should not be in the

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 9: (4 comments)

  1   2   >