[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-10-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 18: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. IMPALA-5307: Part 2: copy out strings in

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-31 Thread Pranay Singh (Code Review)
Hello Joe McDonnell, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8034 to look at the new patch set (#14). Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-31 Thread Pranay Singh (Code Review)
Hello Joe McDonnell, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8034 to look at the new patch set (#13). Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-31 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 12: (5 comments)

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-10-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8436 Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. IMPALA-6054: Parquet dictionary

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 18: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 17: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 18: Build started:

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 8: My +1 was for the backend, I can upgrade to a +2 for

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 8: Code-Review+1 (5 comments)

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 7: Code-Review+1 Looks good to

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-31 Thread Kim Jin Chul (Code Review)
Hello Greg Rahn, Jim Apple, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8311 to look at the new patch set (#6). Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

2017-10-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 4: Do you have time to look at this Joe? I

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-10-31 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8424 to look at the new patch set (#4). Change subject: IMPALA-4835 (prep only): create io subfolder and namespace

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: Hi Dan, This is a draft of the change to let query

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8434 Change subject: IMPALA-5564: Release lock during planning. (wip) .. IMPALA-5564: Release lock during planning. (wip) ** I'm looking

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 8: I need to take another look at this - sorry for the

[Impala-ASF-CR] Correct log line in start-impala-cluster.py.

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8432 Change subject: Correct log line in start-impala-cluster.py. .. Correct log line in start-impala-cluster.py. Updated logging in

[Impala-ASF-CR] Install OpenJDK-dbg for development environments.

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8431 Change subject: Install OpenJDK-dbg for development environments. .. Install OpenJDK-dbg for development environments. Updates the

[Impala-ASF-CR] IMPALA-6127: Fix timeout in TestRuntimeFilter.test wait time

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8427 ) Change subject: IMPALA-6127: Fix timeout in TestRuntimeFilter.test_wait_time .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6127: Fix timeout in TestRuntimeFilter.test wait time

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8427 ) Change subject: IMPALA-6127: Fix timeout in TestRuntimeFilter.test_wait_time .. IMPALA-6127: Fix timeout in

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-10-31 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8430 Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. IMPALA-6136: Part 1: Query duration should not

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-10-31 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8172 to look at the new patch set (#9). Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8421 ) Change subject: IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue .. IMPALA-5638: [DOCS] Add known issue

[Impala-ASF-CR] IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8421 ) Change subject: IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 3: I am running into MAPREDUCE-6441 with this patch precisely

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6080: clean up table descriptor handling

2017-10-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8330 ) Change subject: IMPALA-6080: clean up table descriptor handling .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8421 ) Change subject: IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 3: > Patch Set 3: > > I'm still testing this change.

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-10-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 6: (37 comments) Next batch.

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: > Dan, did you want to have a look or

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: Dan, did you want to have a look or

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 19: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Vuk Ercegovac (Code Review)
Hello Juan Yu, Michael Brown, Philip Zeyliger, Balazs Jeszenszky, Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8202 to look at the new patch set (#19). Change subject: IMPALA-4704: Turns on client connections

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 18: (2 comments)

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 18: Code-Review+1 (3 comments) I'm

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 3: I'm still testing this change. With this change we seem to

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8426 to look at the new patch set (#3). Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 ..

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 3: I'll do another pass with fresh eyes. I didn't have any

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

2017-10-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 3: Tim, do you want a second pair of eyes on this? If not, could you

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-10-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 8: (3 comments) Michael, can you do the +2 for this

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 1: (4 comments) No serious concerns, nice

[Impala-ASF-CR] IMPALA-6127: Fix timeout in TestRuntimeFilter.test wait time

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8427 ) Change subject: IMPALA-6127: Fix timeout in TestRuntimeFilter.test_wait_time .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 3: This touches a lot of lines but is just

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 8: This is a follow-on to the last patch you

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue

2017-10-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7388 ) Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. Patch Set 3: (1 comment) Sorry, just saw this today.

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Vuk Ercegovac (Code Review)
Hello Michael Brown, Philip Zeyliger, Balazs Jeszenszky, Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8202 to look at the new patch set (#18). Change subject: IMPALA-4704: Turns on client connections when

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 17: (7 comments)

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 1: (1 comment) Most of this looks

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 5: Code-Review+2 Thanks for the

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8412 to look at the new patch set (#4). Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 3: Looks like I found the real bug.

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-10-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8428 Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. IMPALA-6134: Update code base to use

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8412 to look at the new patch set (#3). Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 2: Code-Review+1 I'm ok with this to

[Impala-ASF-CR] IMPALA-6127: Fix timeout in TestRuntimeFilter.test wait time

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8427 ) Change subject: IMPALA-6127: Fix timeout in TestRuntimeFilter.test_wait_time .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 17: (7 comments)

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 2: I wonder if the bug is elsewhere

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8426 to look at the new patch set (#2). Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 ..

[Impala-ASF-CR] IMPALA-6127: Fix timeout in TestRuntimeFilter.test wait time

2017-10-31 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8427 Change subject: IMPALA-6127: Fix timeout in TestRuntimeFilter.test_wait_time .. IMPALA-6127: Fix timeout in

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Vuk Ercegovac (Code Review)
Hello Michael Brown, Philip Zeyliger, Balazs Jeszenszky, Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8202 to look at the new patch set (#17). Change subject: IMPALA-4704: Turns on client connections when

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 16: (9 comments)