[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8398/

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8398/

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8398/

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-11-14 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Abandoned It's sad but I couldn't make this change work reliably. Data loading fre

[Impala-ASF-CR] IMPALA-6183: Fix Decimal to Double conversion

2017-11-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8547 ) Change subject: IMPALA-6183: Fix Decimal to Double conversion .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 4: (24 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-11-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 24: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 14: Code-Review+1 (1 comment) I'm happy with this change. Nice

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 4: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] Remove unused/defunct Maven repositories.

2017-11-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8497 ) Change subject: Remove unused/defunct Maven repositories. .. Patch Set 1: Code-Review+2 Nice, thanks -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 3: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables

2017-11-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8506 ) Change subject: IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables .. Patch Set 1: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 13: (7 comments) Looks pretty good to me http://gerrit.clouder

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: Code-Review+1 (4 comments) I'm happy with the FE chan

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/846

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 3: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/846

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/84

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8322 ) Change subject: IMPALA-1422: support a constant on LHS of IN predicates. .. Patch Set 6: (12 comments) Some high-level comments before I d

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/84

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 11: (7 comments) http://gerrit.cloudera.org:8080/#/c/7793/9//CO

[Impala-ASF-CR] Correct log line in start-impala-cluster.py.

2017-11-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8432 ) Change subject: Correct log line in start-impala-cluster.py. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] Correct log line in start-impala-cluster.py.

2017-11-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8432 ) Change subject: Correct log line in start-impala-cluster.py. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8432/1/bin/st

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 9: (14 comments) http://gerrit.cloudera.org:8080/#/c/7793/9//CO

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 3: (62 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 3: I am running into MAPREDUCE-6441 with this patch precisely

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 19: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 16: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 18: Code-Review+1 (3 comments) I'm

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 3: I'm still testing this change. With this change we seem to

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8426/2//CO

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8426 to look at the new patch set (#3). Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. IMPALA

[Impala-ASF-CR] IMPALA-6127: Fix timeout in TestRuntimeFilter.test wait time

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8427 ) Change subject: IMPALA-6127: Fix timeout in TestRuntimeFilter.test_wait_time .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 17: (7 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8426/1/fe/

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-31 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8426 to look at the new patch set (#2). Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. IMPALA

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 ) Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. Patch Set 1: (1 comment) Don't have many data points regarding the effe

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 16: (9 comments) Nice, this looks m

[Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min=3

2017-10-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8426 Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 .. IMPALA-3887: Use dfs.namenode.replication.min=3 Changes the HDFS and HBas

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 ) Change subject: IMPALA-6124: Fix alter table ddl updates and test .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8411/4/t

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 ) Change subject: IMPALA-6124: Fix alter table ddl updates and test .. Patch Set 6: Code-Review+1 (1 comment) Lgtm. Bharath, please do the +

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8410 ) Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating .. Patch Set 3: Code-Review+2 Seems fine, std::str

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 15: (8 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 2: (1 comment) Thanks for the explanatio

[Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test

2017-10-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6124: Make assertion in ddl update test resilient to long runtime

2017-10-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 ) Change subject: IMPALA-6124: Make assertion in ddl update test resilient to long runtime .. Patch Set 1: Code-Review+2 lgtm once you compl

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8410 ) Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating .. Patch Set 1: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6123: Fix column order of a query test in test inline view limit

2017-10-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8409 ) Change subject: IMPALA-6123: Fix column order of a query test in test_inline_view_limit .. Patch Set 2: Any idea how this test succeeded i

[Impala-ASF-CR] IMPALA-6123: Fix column order of a query test in test inline view limit

2017-10-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8409 ) Change subject: IMPALA-6123: Fix column order of a query test in test_inline_view_limit .. Patch Set 2: Actually nvm, I see it only fails

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-10-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/839

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-10-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7564 ) Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 13: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-10-26 Thread Alex Behm (Code Review)
Alex Behm has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7564 ) Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. IMPALA-3548: Prune runtime filters based on

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-10-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7564 ) Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 12: Code-Review+2 (1 comment) http://ger

[Impala-ASF-CR] DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics

2017-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7354 ) Change subject: DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics .. Patch Set 3: Lars, if this patch is not actively being worked

[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue

2017-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7388 ) Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. Patch Set 2: Documenting this seems kinda important. Adding Saile

[Impala-ASF-CR] IMPALA-6004: Fix test row filters failure on ASAN

2017-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8358 ) Change subject: IMPALA-6004: Fix test_row_filters failure on ASAN .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] Prereqs for load test system testing

2017-10-24 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. ( http://gerrit.cloudera.org:8080/5851 ) Change subject: Prereqs for load test system testing .. Abandoned Abandoning to reflect that this is not actively being worked on. -- To view, visit

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7564 ) Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 11: (13 comments) Looks good, final comm

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 4: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 3: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 3: (4 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8350 ) Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 12: (10 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6004: Fix test row filters failure on ASAN

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8358 ) Change subject: IMPALA-6004: Fix test_row_filters failure on ASAN .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8358/1/t

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 1: (2 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls.

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 ) Change subject: IMPALA-4524: Batch ALTER TABLE...ADD PARTITION calls. .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 2: Code-Review+1 Thanks for adding the logging. Let's MikeB do th

[Impala-ASF-CR] IMPALA-6070: Parallel compute table stats.py

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 ) Change subject: IMPALA-6070: Parallel compute_table_stats.py .. Patch Set 1: (2 comments) Nice http://gerrit.cloudera.org:8080/#/c/8354/1

[Impala-ASF-CR] IMPALA-6068: Fix dataload for complextypes fileformat

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8350 ) Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8350

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 8: Code-Review+1 (1 comment) Dimitris should +2 http://ge

[Impala-ASF-CR] IMPALA-6070: Parallel data load.

2017-10-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8320 ) Change subject: IMPALA-6070: Parallel data load. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8320 To u

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/8235/7

[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8336 ) Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. Patch Set 4: Code-Review+2 Thanks! -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8336 ) Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/83

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 4: (3 comments) Nice cleanup! I don't have much to sa

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 1: (4 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-4918: Support getting column comments via HS2

2017-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8315 ) Change subject: IMPALA-4918: Support getting column comments via HS2 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8336 ) Change subject: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8336/1//COMMIT

[Impala-ASF-CR] IMPALA-6073: Fail on misconfigured CLASSPATH.

2017-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8327 ) Change subject: IMPALA-6073: Fail on misconfigured CLASSPATH. .. Patch Set 1: (3 comments) Thanks for fixing, lgtm, only minor nits http:

[Impala-ASF-CR] IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

2017-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 ) Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION. .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6070: Parallel data load.

2017-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8320 ) Change subject: IMPALA-6070: Parallel data load. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8320/1/testdata/bin/run-h

[Impala-ASF-CR] IMPALA-6070: Parallel data load.

2017-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8320 ) Change subject: IMPALA-6070: Parallel data load. .. Patch Set 1: (2 comments) Changes like these tend to be slow and painful to test, so I

[Impala-ASF-CR] IMPALA-5976: Remove equivalent class computation in FE

2017-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalent class computation in FE .. Patch Set 1: (47 comments) Very nice. First wave of comments. I

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-10-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7564 ) Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 10: (27 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 6: (15 comments) http://gerrit.cloudera.org:8080/#/c/8235/

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 15: Csaba, are those failing tests specifical

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 14: Code-Review+1 * The patch covers wh

[Impala-ASF-CR] IMPALA-4682: Remove Preconditions check from analyzeAggregation().

2017-10-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682: Remove Preconditions check from analyzeAggregation(). .. Patch Set 4: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] Download toolchain in parallel.

2017-10-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8237 ) Change subject: Download toolchain in parallel. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8237 To un

[Impala-ASF-CR] IMPALA-6011: Remove use of Guava Hasher.

2017-10-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 ) Change subject: IMPALA-6011: Remove use of Guava Hasher. .. Patch Set 2: Afaik these hashes are stored in Navigator and used for finding ex

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-10-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7353 ) Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. Patch Set 4: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS

2017-10-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7999 ) Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. Patch Set 5: Code-Review+2 I'm still working with Bharath

[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS

2017-10-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7999 ) Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS

2017-10-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7999 ) Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS

2017-10-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7999 ) Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6021: Revert "IMPALA-6009: Upgrade Guava to 14.0.1"

2017-10-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8225 ) Change subject: IMPALA-6021: Revert "IMPALA-6009: Upgrade Guava to 14.0.1" .. Patch Set 1: Code-Review+2 Lesson learned: Other components s

  1   2   3   4   5   6   7   8   9   10   >