[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. IMPALA-2890: Support ALTER TABLE statements for Kudu tables With this commit, we add

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 1: (1 comment) Forgotten comment and some minor test fixes.

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. IMPALA-2890: Support ALTER TABLE statements for Kudu tables With this commit, we add

[Impala-ASF-CR] IMPALA-4440: lineage timestamps can go backwards across daylight savings transitions

2016-11-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4440: lineage timestamps can go backwards across daylight savings transitions .. Patch Set 1: Code-Review+2 (3 comments) Looks good to me and

[Impala-ASF-CR] IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.

2016-11-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. .. Patch Set 2: Code-Review+2 (4 comments) I think this a small change so I am giving it a

[Impala-ASF-CR] Fix typo in DDL statement for loading Kudu table in stress test

2016-11-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5158 Change subject: Fix typo in DDL statement for loading Kudu table in stress test .. Fix typo in DDL statement for loading Kudu

[Impala-ASF-CR] IMPALA-4514: Fix broken exhaustive builds caused by non-nullable columns

2016-11-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5157 Change subject: IMPALA-4514: Fix broken exhaustive builds caused by non-nullable columns .. IMPALA-4514: Fix broken exhaustive

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5151 Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. IMPALA-4283: Ensure Kudu-specific lineage and

[Impala-ASF-CR] IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.

2016-11-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. .. Patch Set 1: (7 comments) Thanks for doing this. Nice! IMPALA-3726 is checked in, so

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5136 Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. IMPALA-2890: Support ALTER TABLE statements for

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 8: Code-Review+2 Minor test fix and rebase. Carry Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5026 to look at the new patch set (#8). Change subject: IMPALA-3726: Add support for Kudu-specific column options

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 7: Code-Review+2 (2 comments) Rebase and fixing tests, carry Alex's +2

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5026 to look at the new patch set (#7). Change subject: IMPALA-3726: Add support for Kudu-specific column options ..

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0.

2016-11-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity/-0. .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-4479: Use correct isSet() thrift function when evaluating constant bool exprs.

2016-11-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4479: Use correct isSet() thrift function when evaluating constant bool exprs. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 5: Modifications to the parser to handle the DEFAULT keyword. -- To view, visit

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for

[Impala-ASF-CR] IMPALA-4372: 'Describe formatted' returns types in upper case

2016-11-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4000: Disable Sentry column-level privileges for Kudu

2016-11-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4000: Disable Sentry column-level privileges for Kudu .. Patch Set 1: I don't think disabling column-level privileges is the desired behavior.

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (25 comments) Still need to address the parser changes wrt the use of DEFAULT

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5026 Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column

[Impala-ASF-CR] Fix TPCH and TPCDS Kudu loading templates

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Fix TPCH and TPCDS Kudu loading templates .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/4939 To unsubscribe,

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 8: Code-Review+2 Fix test issue. Rebase and carry Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4856 to look at the new patch set (#7). Change subject: IMPALA-3724: Support Kudu non-covering range partitions

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 7: Code-Review+2 Fix minor data loading issue and rebase. Carry Alex's +2 -- To

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 3: (19 comments)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-31 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 2: (1 comment) Just flushing out one comment. Working on the rest of the comments.

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4384: NPE when cols list has trailing comma .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4869 To unsubscribe,

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 19: Code-Review+1 (8 comments) Minor fixes in the

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-10-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. Patch Set 2: Code-Review+2 (1 comment) Carry MJ's +2

[Impala-ASF-CR] IMPALA-4336: Cast exprs after unnesting union operands.

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4336: Cast exprs after unnesting union operands. .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4379: Throw if Kudu table created with var/char

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4379: Throw if Kudu table created with var/char .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4857/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/4856 Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range

[Impala-ASF-CR] IMPALA-4336: Cast exprs after unnesting union operands.

2016-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4336: Cast exprs after unnesting union operands. .. Patch Set 1: (8 comments) Flushing some initial comments. Still need to wrap my head around

[Impala-ASF-CR] IMPALA-4260: Alter table add column drops all the column stats

2016-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4260: Alter table add column drops all the column stats .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 10: Code-Review+2 Fix data loading for Kudu tables and rebase. Carry MJ's +2. -- To view, visit

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, Matthew Jacobs, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4327 to look at the new patch set (#10). Change subject: IMPALA-3739: Enable stress tests on Kudu

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (13 comments) Flushing out some comments. Haven't looked at tests

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 9: Code-Review+2 Rebase and carry MJ's +2. -- To view, visit

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4414 to look at the new patch set (#11). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4327 to look at the new patch set (#8). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739:

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4414 to look at the new patch set (#10). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 9: Code-Review+1 (9 comments) Carry mikeb's +1 for python tests.

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: Code-Review+1 (2 comments) Carry Michael's +1

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#9). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 5: (4 comments) A few minor clarifications.

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 7: (63 comments) Still a few minor asks to go through (e.g. add JIRA

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#8). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 5: (41 comments) http://gerrit.cloudera.org:8080/#/c/4414/5//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 3: (23 comments)

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 5: (13 comments) http://gerrit.cloudera.org:8080/#/c/4047/5/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (14 comments) Very nice! Minor nits in the code,

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 1: (94 comments) http://gerrit.cloudera.org:8080/#/c/4414/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 13: (15 comments)

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 4: (3 comments) Thanks for calling these out mikeb.

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4420/2/bin/impala-config.sh

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Bump Kudu version to 1.0-RC1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4420 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4327/3/testdata/bin/load-tpc-kudu.py File

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and

<    1   2   3   4   5