[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options

2017-10-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. ( http://gerrit.cloudera.org:8080/8401 ) Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. Patch Set 2: (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads

2017-09-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4671: Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 1: Why not make a separate implementation of a service pool, rather than

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7866 To unsubscribe

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-02 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 (Prerequisite knowledge: Imp

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-02 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7866 to look at the new patch set (#5). Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 ...

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 4: Code-Review+2 Carry +2 w/rebase. -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7866/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-08-31 Thread Henry Robinson (Code Review)
Hello Bharath Vissapragada, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7866 to look at the new patch set (#3). Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 ..

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-08-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 1: (1 comment) An update: I discovered that it is *not* backwards compatible to use th

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-08-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7866/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] CDH-58701: Check for existence of sync file range()

2017-08-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: CDH-58701: Check for existence of sync_file_range() .. Patch Set 1: Code-Review+2 did you manage to build this on Centos or rhel 5.5? -- To view, visit http:/

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-08-30 Thread Henry Robinson (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7866 to look at the new patch set (#2). Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .

[Impala-ASF-CR] IMPALA-5816: xfail wildcard TLS cert tests

2017-08-30 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7908 Change subject: IMPALA-5816: xfail wildcard TLS cert tests .. IMPALA-5816: xfail wildcard TLS cert tests Wildcard support is not unifor

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-30 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 Thrift commit taken from:

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-30 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. Patch Set 5: Code-Review+2 Verified+1 Verified by a toolchain build. -- To view, visit http://

[Impala-ASF-CR] KUDU-2041: Fix negotiation deadlock

2017-08-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: KUDU-2041: Fix negotiation deadlock .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7742 To unsubscribe, visit http://gerrit.cl

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. Patch Set 4: (1 comment) Also fix a bug in how the options are checked after setting. http://g

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-29 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7859 to look at the new patch set (#5). Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 ..

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7859/4/source/thrift/thrift-0.9.0-

[Impala-ASF-CR] KUDU-2065: Support cancellation for outbound RPC call

2017-08-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: KUDU-2065: Support cancellation for outbound RPC call .. Patch Set 1: Wasn't there an outstanding bug with cancellation that was found in Kudu? Does that affec

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7866 Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0

[Impala-ASF-CR] IMPALA-467: enable disabled metric verification

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-467: enable disabled metric verification .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7827 To unsubscribe, visit http

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 Thrift commit taken from: https://gi

[Impala-ASF-CR] IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5853: GetResultSetMetadata() invalid query id error message is confusing .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7760/2/be/src/runtime/exec-

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7760/3/be/src/scheduling/sc

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 Thrift commit taken from: https://gi

[native-toolchain-CR] IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7859 Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 .. IMPALA-5849: Disable compile-time checks for OpenSSL > 1

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7760/2/be/src/runtime/exec-

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7760/3/be/src/scheduling/sc

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 7: I wonder if you could write a test in thrift-server-test, that did somethin

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 17: Code-Review+2 Forgot to add necessary changes to logging.cc to patch. -- To view, visit htt

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-25 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5719 to look at the new patch set (#17). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .

[Impala-ASF-CR] IMPALA-4856: Include KRPC services in plan fragment's destinations

2017-08-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7760/2/be/src/runtime/exec

[Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries

2017-08-24 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7818 Change subject: IMPALA-5846: Fix output path for kudu libraries .. IMPALA-5846: Fix output path for kudu libraries Prior to this patch,

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/5719/14/be/src/kudu/rpc/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-24 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5719 to look at the new patch set (#15). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. Patch Set 1: The previous commit was merged - it will need a new change ID. -- To view, visi

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/runtime/coordinator-backe

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7711 to look at the new patch set (#6). Change subject: IMPALA-5811: Add 'backends' tab to query details pages ...

[Impala-ASF-CR] IMPALA-5775: (Addendum) Make SSL cluster actually come up in test client ssl.py

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in test_client_ssl.py .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7711/4/tests/webserver/test_web_pages.py

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7711 to look at the new patch set (#5). Change subject: IMPALA-5811: Add 'backends' tab to query details pages ...

[Impala-ASF-CR] Hide some deprecated flags

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Hide some deprecated flags .. Patch Set 2: Thanks - is there any more information you need before you can give a +2? -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] Hide some deprecated flags

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Hide some deprecated flags .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7786/1//COMMIT_MSG Commit Message: Line 7: Hide some deprecated fl

[Impala-ASF-CR] Hide some deprecated flags

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: Hide some deprecated flags .. Hide some deprecated flags Hidden flags do not show up in /varz or --help. Change-Id: I948b46cd6853f1d8ebaaadaba7b801dca886c7ad ---

[Impala-ASF-CR] Hide some deprecated flags

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7786 Change subject: Hide some deprecated flags .. Hide some deprecated flags Change-Id: I948b46cd6853f1d8ebaaadaba7b801dca886c7ad --- M be/

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 3: (4 comments) just passing through. http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 3: (2 comments) Added a test, thanks for the suggestion! http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7711 to look at the new patch set (#4). Change subject: IMPALA-5811: Add 'backends' tab to query details pages ..

[Impala-ASF-CR] IMPALA-5825: Catch exceptions thrown by TSSLSocketFactory c'tor

2017-08-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7768 Change subject: IMPALA-5825: Catch exceptions thrown by TSSLSocketFactory c'tor .. IMPALA-5825: Catch exceptions thrown by TSSLSocketFac

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 5: Hi John - anything I can do to help with this one? Let me know if you need

[Impala-ASF-CR] Cherry-pick constant renaming for be/src/kudu from Kudu commit e719b

2017-08-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Cherry-pick constant renaming for be/src/kudu from Kudu commit e719b .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7740 To u

[Impala-ASF-CR] tidy: enable rule for constant naming

2017-08-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: tidy: enable rule for constant naming .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7740/2//COMMIT_MSG Commit Message: PS2, Line 7: tidy: en

[Impala-ASF-CR] tidy: enable rule for constant naming

2017-08-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: tidy: enable rule for constant naming .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7740/2//COMMIT_MSG Commit Message: PS2, Line 7: tidy: en

[Impala-ASF-CR] tidy: enable rule for constant naming

2017-08-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: tidy: enable rule for constant naming .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7740/1//COMMIT_MSG Commit Message: Line 7: tidy: enable

[Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c

2017-08-20 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c .. IMPALA-5800: [Addendum] Fix bad import of squeasel.c The previous commit for IMPALA-5800 imported a slight

[Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c

2017-08-20 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7752 Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c .. IMPALA-5800: [Addendum] Fix bad import of squeasel.c The previo

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-20 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. IMPALA-5108: idle_session_timeout kicks in later than expected Fix: The issue was cau

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7709 To unsubscr

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-18 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5719 to look at the new patch set (#14). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .

[Impala-ASF-CR] IMPALA-5775: (Addendum) Make SSL cluster actually come up in test client ssl.py

2017-08-18 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7732 Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in test_client_ssl.py .. IMPALA-5775: (Addendum) Make SSL clu

[Impala-ASF-CR] IMPALA-5108:idle session timeout kicks in later than expected

2017-08-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected .. Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/7709/2//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5108:idle session timeout kicks in later than expected

2017-08-18 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7712 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7711/1/be/src/runtime/coordinator-backe

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-18 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. IMPALA-5811: Add 'backends' tab to query details pages Add a 'backends' tab to query details pages which

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 2: That's deliberate - preserve the last seen set of states. I could change something to ad

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. IMPALA-5811: Add 'backends' tab to query details pages Add a 'backends' tab to query details pages which

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 1: Presumably the query was a DDL statement, so there was no coordinator. Thanks for the re

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7673/1/be/src/testutil/in-process-servers.c

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. IMPALA-4786: Clean up how ImpalaServers are created ImpalaServer had to be created via an awkward CreateImp

[Impala-ASF-CR] IMPALA-5108:idle session timeout kicks in later than expected

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7712/1//COMMIT_MSG Commit Message

[Impala-ASF-CR] (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode .. Patch Set 2: Thanks for the review, btw - I'm working on some ergonomic improvements before r

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7711 Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. IMPALA-5811: Add 'backends' tab to query details pages Add a

[Impala-ASF-CR] IMPALA-5108:idle session timeout kicks in later than expected

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7709/1/be/src/service/impala-ser

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-17 Thread Henry Robinson (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5719 to look at the new patch set (#13). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. IMPALA-4669:

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/5719/12//COMMIT_MSG Commit Message: PS12,

[Impala-ASF-CR] Propagate HAVE PIPE2 compile time value to files that use it

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Propagate HAVE_PIPE2 compile time value to files that use it .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7705 To unsubscrib

[Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations

2017-08-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations .. Patch Set 6: FWIW (and this is veering away from an Apache discussion), I thought end-u

[Impala-ASF-CR] IMPALA-2615: support [[nodiscard]] on Status

2017-08-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2615: support [[nodiscard]] on Status .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/7253/14/be/src/runtime/exec-env.cc File be/src/ru

[Impala-ASF-CR] IMPALA-5749: coordinator race hits DCHECK 'num remaining backends > 0'

2017-08-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5749: coordinator race hits DCHECK 'num_remaining_backends_ > 0' .. Patch Set 3: Code-Review+1 (3 comments) Thanks - this seems a lot better to me. Did

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 12: This patch builds on all platforms we test on here at Cloudera. -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-08-16 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#12). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. IMPALA-4669: [KRPC] Add kudu_rpc library to build Import FindKRPC.cmake from Apache Kudu. One minor linking

[Impala-ASF-CR] IMPALA-5800: Configure Squeasel's cipher suite and TLS version

2017-08-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version .. Patch Set 3: Code-Review+2 I feel pretty ok giving this a +2 myself, as the Impala-side change

[Impala-ASF-CR] IMPALA-5800: Configure Squeasel's cipher suite and TLS version

2017-08-16 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version .. IMPALA-5800: Configure Squeasel's cipher suite and TLS version * Import Squeasel as of https:/

[Impala-ASF-CR] IMPALA-5800: Configure Squeasel's cipher suite and TLS version

2017-08-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7679/1//COMMIT_MSG Commit Messa

[Impala-ASF-CR] IMPALA-5800: Configure Squeasel's cipher suite and TLS version

2017-08-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7679/2/be/src/thirdparty/squease

[Impala-ASF-CR] IMPALA-5800: Configure Squeasel's cipher suite and TLS version

2017-08-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7679/1/be/src/util/webserver-tes

[Impala-ASF-CR] IMPALA-5800: Configure Squeasel's cipher suite and TLS version

2017-08-15 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version .. IMPALA-5800: Configure Squeasel's cipher suite and TLS version * Import Squeasel from https://

[Impala-ASF-CR] IMPALA-5800: Configure Squeasel's cipher suite and TLS version

2017-08-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7679/1//COMMIT_MSG Commit Messa

[Impala-ASF-CR] IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2

2017-08-15 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7675 to look at the new patch set (#3). Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 .. IMP

[Impala-ASF-CR] IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2

2017-08-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7675/2/shell/TSSLSocketWithWildcardSA

[Impala-ASF-CR] IMPALA-5800: Configure Squeasel's cipher suite and TLS version

2017-08-15 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7679 Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version .. IMPALA-5800: Configure Squeasel's cipher suite and TLS

[Impala-ASF-CR] IMPALA-5109: Increase range of backend latency histogram

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7676 Change subject: IMPALA-5109: Increase range of backend latency histogram .. IMPALA-5109: Increase range of backend latency histogram Ti

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. Patch Set 6: Code-Review+2 Fix a couple of clang-tidy warnings. -- To view, visit http:/

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7606 to look at the new patch set (#6). Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers ...

[Impala-ASF-CR] IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2

2017-08-14 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7675 to look at the new patch set (#2). Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 .. IMP

[Impala-ASF-CR] IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7675/1/tests/custom_cluster/test_clien

[Impala-ASF-CR] IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7675 Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 .. IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2 Th

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-14 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7606 to look at the new patch set (#5). Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers ..

  1   2   3   4   5   6   7   8   9   10   >