Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7711/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: Line 556: value->AddMember("num_instances", fragments_.size(), document->GetAllocator()); > I think we should include some form of total_ranges_complete_ in this page. I couldn't find a very easy way to plumb it through. Perhaps we could leave that to a follow-on patch? PS1, Line 569: status_ > use GetStatus()? It takes the BackendState::lock_ Done http://gerrit.cloudera.org:8080/#/c/7711/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: PS1, Line 710: request_state > UNLIKELY(request_state.get()...) ? I think UNLIKELY() is best used when we have branches whose mispredictions are expensive. That's not really the case here. http://gerrit.cloudera.org:8080/#/c/7711/1/www/query_backends.tmpl File www/query_backends.tmpl: Line 57: > Does it make sense to add a checkbox to show only backends with unfinished The table can be sorted so that unfinished backends can be sorted to the top. -- To view, visit http://gerrit.cloudera.org:8080/7711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5b3b0fb8f4188da56da593199f41ce6fab99767 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
