[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4867 To u

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 12: Code-Review+2 Carrying +2. Attempting to GVO. -- To view, visit h

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 11: Code-Review+2 +2 for FE. You can carry Dan's +2. -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-10 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4867 to look at the new patch set (#11). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable ..

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/4867/10//COMMIT_M

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/4867/10/common/thrift/Backend

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/4867/10/common/thrift/Ba

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 10: Code-Review+2 (2 comments) Please hold off on committing until the blocker br

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 10: Code-Review+1 Carrying +1 from Alex. Dan, can you please do a +2 re

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4867 to look at the new patch set (#10). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/4867/9/be/src/serv

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 9: Code-Review+1 (5 comments) +2 for FE, +1 for BE after the minor renames http:

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#9). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix "IMPAL

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/4867/8/be/src/util

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/4867/8/be/src/util/backend-co

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#8). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix "IMPAL

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/catal

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/catalog/catalog.

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/catalog/catalog.

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/cata

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/catalog/catalog

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#7). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix "IMPAL

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#6). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix "IMPAL

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 5: (15 comments) I've taken over this. Please check the next PS. http

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 5: (12 comments) Nice cleanup http://gerrit.cloudera.org:8080/#/c/4867/5/be/src/

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 5: (1 comment) agreed w/ bharath. Types.thrift is not good place for tbacken

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 5: Alex, I think we need to find a better place to add TBackendConfig.

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/4867

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/4867/4//COMMIT_MSG Comm

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new patch set (#5). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix "IMPALA-2648

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 4: (10 comments) Looks pretty good. Just a bunch of small changes. I c

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new patch set (#4). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix "IMPALA-2648

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 2: (16 comments) http://gerrit.cloudera.org:8080/#/c/4867/2//COMMIT_MSG Comm

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new patch set (#3). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix "IMPALA-2648

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-11-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 2: (16 comments) http://gerrit.cloudera.org:8080/#/c/4867/2//COMMIT_MS

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-11-02 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new patch set (#2). Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. IMPALA-3552: make incremental stats max serialized size configurable The fix fox "IMPALA-

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-28 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4867/1/be/src/catalog/ca

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4867/1/be/src/cata

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4867/1/be/src/catalog/ca

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4867/1/be/src/cata

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4867/1/be/src/catalog/catalog

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (4 comments) Haven't gone through the whole patch, but I put some d

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: I still have two questions on the fix.

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has abandoned this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Abandoned after the 1st review, major change was made for the fix. hence, a new review started

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-27 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new change for review. http://gerrit.cloudera.org:8080/4867 Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. IMPALA-3552: make incremental stats max seriali

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: @Yonghyun I had a chat with Alex on the best way to move forward. He

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4772/1/fe/src/main/java/o

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4772/1/fe/src/main/java/org/ap

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4772/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: actually this can this be checked when we load the table, and this should be e

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: Yonghyun, one minor comment on the code review the process. You don

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4772/1/be/src/catalog/catalog

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/4772/1/be/src/catalog/ca

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4772/1/fe/src/main/java/org/ap

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/4772/1/be/src/catalog/catalog

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: local tests as well as jenkins are passing. http://sandbox.jenkins.cloude

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new change for review. http://gerrit.cloudera.org:8080/4772 Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. IMPALA-3552: make incremental stats max seriali