[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 7: (3 comments) I kept on pulling at the error propagation

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/8414/4/b

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8414/4/

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8414/4/

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8414/4/

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/8414/4/be

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (3 comments) Testing found one subtle bug. http://gerr

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#7). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. IMPALA-4835: Par

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#6). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. IMPALA-4835: Par

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#5). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. IMPALA-4835: Par

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-03 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8414/4/b

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. IMPALA-4835: Part 1: simplify I/O mgr mem mgmt In preparation for switc