[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6328

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dry

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dry

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6328 T

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6328/1//COMMIT_MSG Commi

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6328 to look at the new patch set (#2). Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6328/1//COMMIT_MSG Com

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: My proposal is to keep the signature as it is, but initialize the status pa

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: Just to make it a matter of record: GetBytes's call signature is mirrored

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: Since we expect no performance penalty and consumers shouldn't rely on statu

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: Code-Review+2 I spoke to Joe offline and he mentioned that changing the re

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6328/1/be/src/exec/parque

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6328/1/be/src/exec/parque

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6328/1/be/src/exec/parquet-

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6328/1/be/src/exec/parque

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6328/1//COMMIT_MSG Commit M

[Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()

2017-03-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6328 Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader() .. IMPALA-5055: Fix DCHECK in parquet-column-reade