[PR] IoTConsensus Transit Snapshot Rate Limiter [iotdb]

2024-04-16 Thread via GitHub
BUAAserein opened a new pull request, #12348: URL: https://github.com/apache/iotdb/pull/12348 ## Description Provides a IoT rate limiter for region migration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] Pipe: timely reload file list according to compaction [iotdb]

2024-04-16 Thread via GitHub
DanielWang2035 opened a new pull request, #12349: URL: https://github.com/apache/iotdb/pull/12349 This PR: - added a listener for pipe to listen to compactions and record source/target files - added a timed job to refresh realtime extractors' pending queue according to compactions

Re: [PR] Pipe: Fixed the bug that mod file may not close in async transferring [iotdb]

2024-04-16 Thread via GitHub
SteveYurongSu commented on code in PR #12347: URL: https://github.com/apache/iotdb/pull/12347#discussion_r1566831362 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/async/handler/PipeTransferTsFileInsertionEventHandler.java: ## @@ -103,6 +

Re: [PR] Implementation of device TTL [iotdb]

2024-04-16 Thread via GitHub
shuwenwei commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1566836737 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + * Licen

Re: [PR] Implementation of device TTL [iotdb]

2024-04-16 Thread via GitHub
shuwenwei commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1566840398 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + * Licen

Re: [PR] Implementation of device TTL [iotdb]

2024-04-16 Thread via GitHub
shuwenwei commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1566844267 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + * Licen

Re: [PR] Compaction rate limit [iotdb]

2024-04-16 Thread via GitHub
jt2594838 commented on code in PR #12312: URL: https://github.com/apache/iotdb/pull/12312#discussion_r1566874193 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java: ## @@ -1117,6 +1129,35 @@ private void loadCompactionHotModifiedProps(Properties

Re: [PR] Compaction rate limit [iotdb]

2024-04-16 Thread via GitHub
jt2594838 commented on code in PR #12312: URL: https://github.com/apache/iotdb/pull/12312#discussion_r1566883537 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/io/CompactionTsFileOutput.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to

Re: [PR] Compaction rate limit [iotdb]

2024-04-16 Thread via GitHub
jt2594838 commented on code in PR #12312: URL: https://github.com/apache/iotdb/pull/12312#discussion_r1566883537 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/io/CompactionTsFileOutput.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to

Re: [PR] Compaction rate limit [iotdb]

2024-04-16 Thread via GitHub
jt2594838 commented on code in PR #12312: URL: https://github.com/apache/iotdb/pull/12312#discussion_r1566891500 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionTaskManager.java: ## @@ -84,17 +84,19 @@ public class

Re: [PR] Compaction rate limit [iotdb]

2024-04-16 Thread via GitHub
jt2594838 commented on code in PR #12312: URL: https://github.com/apache/iotdb/pull/12312#discussion_r1566891500 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionTaskManager.java: ## @@ -84,17 +84,19 @@ public class

Re: [PR] Compaction rate limit [iotdb]

2024-04-16 Thread via GitHub
shuwenwei commented on code in PR #12312: URL: https://github.com/apache/iotdb/pull/12312#discussion_r1566912069 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionTaskManager.java: ## @@ -84,17 +84,19 @@ public class

Re: [PR] Fix auto leader balance for Ratis protocol judgement bug [iotdb]

2024-04-16 Thread via GitHub
OneSizeFitsQuorum merged PR #12350: URL: https://github.com/apache/iotdb/pull/12350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Fix auto leader balance for Ratis protocol judgement bug [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12350: URL: https://github.com/apache/iotdb/pull/12350#issuecomment-2058484278 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2058519193 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Print progress in log during transmitting snapshot for region migration [iotdb]

2024-04-16 Thread via GitHub
OneSizeFitsQuorum merged PR #12346: URL: https://github.com/apache/iotdb/pull/12346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2058709131 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Optimize priority map lock structure [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12351: URL: https://github.com/apache/iotdb/pull/12351#issuecomment-2058734919 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Update Link of IoTDB Introduction.md [iotdb]

2024-04-16 Thread via GitHub
Beyyes merged PR #12323: URL: https://github.com/apache/iotdb/pull/12323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apach

Re: [PR] Optimize priority map lock structure [iotdb]

2024-04-16 Thread via GitHub
codecov[bot] commented on PR #12351: URL: https://github.com/apache/iotdb/pull/12351#issuecomment-2058815151 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12351?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[PR] Update README_ZH.md [iotdb]

2024-04-16 Thread via GitHub
SihanLiu2024 opened a new pull request, #12352: URL: https://github.com/apache/iotdb/pull/12352 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ]

Re: [PR] Update README_ZH.md [iotdb]

2024-04-16 Thread via GitHub
Beyyes merged PR #12352: URL: https://github.com/apache/iotdb/pull/12352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apach

Re: [PR] IoTConsensus Transit Snapshot Rate Limiter [iotdb]

2024-04-16 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #12348: URL: https://github.com/apache/iotdb/pull/12348#discussion_r1567285875 ## iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/snapshot/IoTConsensusRateLimiter.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[PR] [Table Model] Implement table insert via tree model insertion [iotdb]

2024-04-16 Thread via GitHub
MarcosZyk opened a new pull request, #12353: URL: https://github.com/apache/iotdb/pull/12353 ## Description Table model cli ``` IoTDB> use db_1 Msg: The statement is executed successfully. IoTDB> insert into t_3(Time, region, code, type, price, s_1, s_2) values(1, beij

Re: [I] How To backup/restore cluster [iotdb]

2024-04-16 Thread via GitHub
github-actions[bot] commented on issue #12354: URL: https://github.com/apache/iotdb/issues/12354#issuecomment-2059107035 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To re

Re: [PR] IoTConsensus Transit Snapshot Rate Limiter [iotdb]

2024-04-16 Thread via GitHub
BUAAserein commented on code in PR #12348: URL: https://github.com/apache/iotdb/pull/12348#discussion_r1567413425 ## iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/snapshot/IoTConsensusRateLimiter.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Softwa

[PR] PipeConsensus: initialize thrift service [iotdb]

2024-04-16 Thread via GitHub
Pengzna opened a new pull request, #12355: URL: https://github.com/apache/iotdb/pull/12355 wip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: revie

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2059258535 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2059350903 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2059378628 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

[PR] Load: Add WritePointRateLimiter to control load writing point rate [iotdb]

2024-04-16 Thread via GitHub
MiniSho opened a new pull request, #12356: URL: https://github.com/apache/iotdb/pull/12356 ## Description LoadTsFileRateLimiter is a global singleton, and control the load writing point rate at 2 places: 1. The second phase of Two-phase Commit: After loading the tsfilePiecesNode 2.

Re: [PR] Load: Skip the file failed to load instead of stopping loading the whole directory [iotdb]

2024-04-16 Thread via GitHub
MiniSho commented on code in PR #12313: URL: https://github.com/apache/iotdb/pull/12313#discussion_r1567642374 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/load/LoadTsFileNode.java: ## @@ -103,6 +103,11 @@ public List splitByPartiti

Re: [PR] Log InsertRowsNode in WAL [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12271: URL: https://github.com/apache/iotdb/pull/12271#issuecomment-2060188506 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Optimize priority map lock structure [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12351: URL: https://github.com/apache/iotdb/pull/12351#issuecomment-2060201547 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2060234231 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] PipeConsensus: initialize thrift service & connector and receiver logic [iotdb]

2024-04-16 Thread via GitHub
SzyWilliam commented on code in PR #12355: URL: https://github.com/apache/iotdb/pull/12355#discussion_r1568144839 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/PipeConsensusAsyncConnector.java: ## @@ -0,0 +1,113 @@ +/* + * License

Re: [PR] PipeConsensus: initialize thrift service & connector and receiver logic [iotdb]

2024-04-16 Thread via GitHub
Pengzna commented on code in PR #12355: URL: https://github.com/apache/iotdb/pull/12355#discussion_r1568157024 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/PipeConsensusAsyncConnector.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed t

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2060278010 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Add docs for aggregation function max_by/min_by [iotdb-docs]

2024-04-16 Thread via GitHub
qiaojialin merged PR #183: URL: https://github.com/apache/iotdb-docs/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.

Re: [PR] Revert "Fix auto leader balance for Ratis protocol judgement bug" [iotdb]

2024-04-16 Thread via GitHub
OneSizeFitsQuorum merged PR #12358: URL: https://github.com/apache/iotdb/pull/12358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] Revert "Fix auto leader balance for Ratis protocol judgement bug" [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12358: URL: https://github.com/apache/iotdb/pull/12358#issuecomment-2060325858 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Remove lib udf links [iotdb-docs]

2024-04-16 Thread via GitHub
HTHou merged PR #220: URL: https://github.com/apache/iotdb-docs/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apach

Re: [PR] Log InsertRowsNode in WAL [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12271: URL: https://github.com/apache/iotdb/pull/12271#issuecomment-2060327253 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2060341975 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Optimize priority map lock structure [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12351: URL: https://github.com/apache/iotdb/pull/12351#issuecomment-2060427128 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] Pipe: Fixed the CPU consuming problem when configNode has nothing to sync [iotdb]

2024-04-16 Thread via GitHub
Caideyipi opened a new pull request, #12359: URL: https://github.com/apache/iotdb/pull/12359 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] Optimize priority map lock structure [iotdb]

2024-04-16 Thread via GitHub
sonarcloud[bot] commented on PR #12351: URL: https://github.com/apache/iotdb/pull/12351#issuecomment-2060494550 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo