Re: [PR] [IOTDB-3162]Split large target files in cross space compaction [iotdb]

2024-09-27 Thread via GitHub
HTHou closed pull request #6425: [IOTDB-3162]Split large target files in cross space compaction URL: https://github.com/apache/iotdb/pull/6425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] Support global-aggregation in TableModel [iotdb]

2024-09-27 Thread via GitHub
Wei-hao-Li opened a new pull request, #13651: URL: https://github.com/apache/iotdb/pull/13651 1. Now only support count, avg aggregation function; 2. ITs are not added now, we will do this work after all aggregation operator developed. https://github.com/user-attachments/assets/9d9

Re: [PR] Support Fill in Table Model [iotdb]

2024-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #13650: URL: https://github.com/apache/iotdb/pull/13650#issuecomment-2379293186 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

[PR] Support Fill in Table Model [iotdb]

2024-09-27 Thread via GitHub
JackieTien97 opened a new pull request, #13650: URL: https://github.com/apache/iotdb/pull/13650 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Product Introduction [iotdb-docs]

2024-09-27 Thread via GitHub
StefanieZhao7 commented on code in PR #369: URL: https://github.com/apache/iotdb-docs/pull/369#discussion_r1778382737 ## src/.vuepress/sidebar_timecho/V1.3.x/en.ts: ## @@ -29,7 +29,7 @@ export const enSidebar = { prefix: 'IoTDB-Introduction/', // children: 'structu

Re: [PR] Problem fixing [iotdb-docs]

2024-09-27 Thread via GitHub
HTHou merged PR #370: URL: https://github.com/apache/iotdb-docs/pull/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apach

[PR] Feature/move SBOM check into separate profile [iotdb]

2024-09-27 Thread via GitHub
chrisdutz opened a new pull request, #13649: URL: https://github.com/apache/iotdb/pull/13649 Moves the sbom check into a dedicated profile, which needs to be enabled explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778309124 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -38,82 +40,89 @@ import java.io.IOExcepti

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

2024-09-27 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1776647658 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/PipeConsensusAsyncConnector.java: ## @@ -400,13 +401,16 @@ publ

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778273748 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/ServerCommandLine.java: ## @@ -39,10 +41,10 @@ public abstract class ServerCommandLine { Opti

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778264977 ## iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh: ## @@ -19,21 +19,35 @@ # if [ "$#" -eq 1 ] && [ "$1" == "--help" ]; then -echo "The scr

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778263046 ## iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh: ## @@ -19,21 +19,35 @@ # if [ "$#" -eq 1 ] && [ "$1" == "--help" ]; then -echo "The scr

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778260047 ## iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh: ## @@ -19,21 +19,35 @@ # if [ "$#" -eq 1 ] && [ "$1" == "--help" ]; then -echo "The scr

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778252884 ## iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedureTest.java: ## @@ -29,21 +30,28 @@ import java.io.DataO

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778230749 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java: ## @@ -144,19 +145,26 @@ protected void start() throws IoTDBException {

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778229388 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -212,22 +249,54 @@ protected RemoveDataNod

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778213794 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -123,8 +132,10 @@ protected Flow executeFr

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778204427 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778188629 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Softw