[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2988/ -- To view, visit http://gerrit.c

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#12). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] subprocess: allow Call() to read both stdout and stderr

2016-08-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: subprocess: allow Call() to read both stdout and stderr .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2986/ -- To view, visit http://gerri

[kudu-CR] tool: better handling for positional arguments

2016-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: better handling for positional arguments .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4013/3/src/kudu/tools/tool_action.cc File src/kudu/t

[kudu-CR] tool: basic integration test

2016-08-18 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4058 to review the following change. Change subject: tool: basic integration test .. tool: basic integration test So far a

[kudu-CR] tool: better handling for positional arguments

2016-08-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: better handling for positional arguments .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2985/ -- To view, visit http://gerrit.clouder

[kudu-CR] tool: better handling for positional arguments

2016-08-18 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4013 to look at the new patch set (#4). Change subject: tool: better handling for positional arguments ..

[kudu-CR] tool: basic integration test

2016-08-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: basic integration test .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2987/ -- To view, visit http://gerrit.cloudera.org:8080/4058 To

[kudu-CR] subprocess: allow Call() to read both stdout and stderr

2016-08-18 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4057 to review the following change. Change subject: subprocess: allow Call() to read both stdout and stderr .. subprocess:

[kudu-CR] KUDU-1542: in some cases apply will hang.

2016-08-18 Thread song bruce zhang (Code Review)
song bruce zhang has posted comments on this change. Change subject: KUDU-1542: in some cases apply will hang. .. Patch Set 6: > > Lemme put it more clear: > > 1 the "looping forever" happened when i am using > "AUTO_FLUSH_BA

[kudu-CR] tool: better handling for positional arguments

2016-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tool: better handling for positional arguments .. Patch Set 1: > (11 comments) > > > Sure wish there was some test coverage on these tools... > > Alright,

[kudu-CR] tool: improve help output

2016-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tool: improve help output .. Patch Set 1: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/4038/1//COMMIT_MSG Commit Message: Line 9: - adds blan

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2984/ -- To view, visit http://gerrit.c

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#11). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] tool: better handling for positional arguments

2016-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: better handling for positional arguments .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4013/3/src/kudu/tools/tool_action.cc File src/kudu/

[kudu-CR] [doc] update on shared ptr/scoped refptr pros/cons

2016-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [doc] update on shared_ptr/scoped_refptr pros/cons .. [doc] update on shared_ptr/scoped_refptr pros/cons Change-Id: I46678a28a623c7b9c0835177e08a3f2393ed1

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3952/9/src/kudu/client/session-internal.cc F

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2983/ -- To view, visit http://gerrit.c

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#10). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 9: (22 comments) http://gerrit.cloudera.org:8080/#/c/3952/9/src/kudu/client/batcher.h File src/

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/4034/1/java/kudu-flume-sink/pom.xml File ja

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2982/ -- To view, visit http://gerrit.cl

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-18 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4034 to look at the new patch set (#2). Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Add AvroK

[kudu-CR] KUDU-1542: in some cases apply will hang.

2016-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1542: in some cases apply will hang. .. Patch Set 6: > Lemme put it more clear: > 1 the "looping forever" happened when i am using "AUTO_FLUSH_BACKGROUND" >

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3952/6/src/kudu/client/session-internal.cc File

[kudu-CR] Add initial release notes section for 1.0.0

2016-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add initial release notes section for 1.0.0 .. Patch Set 1: Code-Review+2 Provided you don't end up changing the name of the pbc dump mode. -- To view, visit http

[kudu-CR] tool: improve help output

2016-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: improve help output .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4038/1/src/kudu/tools/tool_action.cc File src/kudu/tools/to

[kudu-CR] Convert pbc-dump over to new tool infrastructure

2016-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Convert pbc-dump over to new tool infrastructure .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4037/1/src/kudu/tools/CMakeLists.txt File src/kud

[kudu-CR] tool: properly handle -version

2016-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: properly handle -version .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4036 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR] tool: better handling for positional arguments

2016-08-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: better handling for positional arguments .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2981/ -- To view, visit http://gerrit.clouder

[kudu-CR] tool: better handling for positional arguments

2016-08-18 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4013 to look at the new patch set (#3). Change subject: tool: better handling for positional arguments ..

[kudu-CR] [doc] update on shared ptr/scoped refptr pros/cons

2016-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [doc] update on shared_ptr/scoped_refptr pros/cons .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4050 To unsubscribe, visit http

[kudu-CR] [doc] update on shared ptr/scoped refptr pros/cons

2016-08-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4050 to look at the new patch set (#2). Change subject: [doc] update on shared_ptr/scoped_refptr pros/cons .. [doc] upda

[kudu-CR] [doc] update on shared ptr/scoped refptr pros/cons

2016-08-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [doc] update on shared_ptr/scoped_refptr pros/cons .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2980/ -- To view, visit http://gerrit.clo

[kudu-CR] [doc] update on shared ptr/scoped refptr pros/cons

2016-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [doc] update on shared_ptr/scoped_refptr pros/cons .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4050/1/docs/contributing.adoc File docs/contr

[kudu-CR](gh-pages) rm CNAME

2016-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: rm CNAME .. rm CNAME Change-Id: Ib301f94ba8bf591d7202c95c252e2ff22c68f692 Reviewed-on: http://gerrit.cloudera.org:8080/4048 Reviewed-by: Todd Lipcon Test

[kudu-CR] [doc] update on shared ptr/scoped refptr pros/cons

2016-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [doc] update on shared_ptr/scoped_refptr pros/cons .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4050/1/docs/contributing.adoc File docs/contrib

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/4034/1/java/kudu-flume-sink/pom.xml File java

[kudu-CR] [doc] update on shared ptr/scoped refptr pros/cons

2016-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4050 Change subject: [doc] update on shared_ptr/scoped_refptr pros/cons .. [doc] update on shared_ptr/scoped_refptr pros/cons Change-Id: I466

[kudu-CR] [doc] update on shared ptr/scoped refptr pros/cons

2016-08-18 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [doc] update on shared_ptr/scoped_refptr pros/cons .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2979/ -- To view, visit http://gerrit.clo

[kudu-CR](gh-pages) rm CNAME

2016-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rm CNAME .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-

[kudu-CR] [spark] Add insert-ignore, update, and delete as write options

2016-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [spark] Add insert-ignore, update, and delete as write options .. [spark] Add insert-ignore, update, and delete as write options Change-Id: I2781104c8a655

[kudu-CR] [spark] Add insert-ignore, update, and delete as write options

2016-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [spark] Add insert-ignore, update, and delete as write options .. Patch Set 2: correct, that was an out of date doc. -- To view, visit http://gerrit.cloudera.org

[kudu-CR] Predicate evaluation pushdown

2016-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 2: (15 comments) Overall I had a few style nits that were repeated throughout the patch: * Put the pointer * and refer

[kudu-CR] [spark] Add insert-ignore, update, and delete as write options

2016-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [spark] Add insert-ignore, update, and delete as write options .. Patch Set 2: Code-Review+2 Just to be clear, is this compatible? Looks like it but one of the com

[kudu-CR] Add State Message column to /tables

2016-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add State Message column to /tables .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4014 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] Add State Message column to /tables

2016-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add State Message column to /tables .. Add State Message column to /tables The state message portion of a table's metadata is displayed in the same table

[kudu-CR](gh-pages) rm CNAME

2016-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rm CNAME .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerr

[kudu-CR](gh-pages) new range partitioning features blog post

2016-08-18 Thread Dan Burkert (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4012 to look at the new patch set (#5). Change subject: new range partitioning features blog post .. new rang

[kudu-CR](gh-pages) new range partitioning features blog post

2016-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: new range partitioning features blog post .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4012/4/_posts/2016-08-18-new-range-partitioning-feature

[kudu-CR](gh-pages) rm CNAME

2016-08-18 Thread Dan Burkert (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4048 to review the following change. Change subject: rm CNAME .. rm CNAME Change-Id: Ib301f94ba8bf591d7202c95c

[kudu-CR](gh-pages) new range partitioning features blog post

2016-08-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: new range partitioning features blog post .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4012/4/_posts/2016-08-18-new-range-partitioning-featu

[kudu-CR] Convert pbc-dump over to new tool infrastructure

2016-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Convert pbc-dump over to new tool infrastructure .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/4037/1//COMMIT_MSG Commit Message: Line 7: Co

[kudu-CR](gh-pages) new range partitioning features blog post

2016-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: new range partitioning features blog post .. Patch Set 3: (18 comments) updated rendering: http://danburkert.github.io/kudu/2016/08/18/new-range-partitioning-fea

[kudu-CR](gh-pages) new range partitioning features blog post

2016-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#4). Change subject: new range partitioning features blog post .. new range partitioning features blog post Change-Id: I53504d849c2aca9ff613b11e67d1533536283931 --- A _posts/2016-08-18-n

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-08-18 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 5: (1 comment) LGTM, one nit below which you can ignore. http://gerrit.cloudera.org:8080/#